@bonesofspring/ai-rules 0.2.17 → 0.2.18
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +18 -0
- package/README.md +1 -1
- package/package.json +1 -1
- package/presets/_shared/README.md +1 -1
- package/presets/_shared/core/agent-team/agent-artifact-contracts.md +3 -0
- package/presets/_shared/core/agent-team/agent-team-orchestrator.md +4 -4
- package/presets/_shared/core/architecture/feature-delivery-workflow.md +1 -1
- package/presets/_shared/core/meta/preset-no-cross-stack-leakage.md +4 -2
- package/presets/_shared/core/review/mockup-review.md +105 -0
- package/presets/_shared/core/review/ux-design.md +97 -0
- package/presets/claude/android-kotlin/agents/README.md +2 -2
- package/presets/claude/android-kotlin/agents/build-verifier.md +6 -0
- package/presets/claude/android-kotlin/agents/feature-developer.md +6 -0
- package/presets/claude/android-kotlin/agents/mockup-reviewer.md +59 -0
- package/presets/claude/android-kotlin/agents/task-analyst.md +18 -1
- package/presets/claude/android-kotlin/agents/task-router.md +11 -2
- package/presets/claude/android-kotlin/commands/task-continue.md +6 -4
- package/presets/claude/android-kotlin/commands/task.md +2 -0
- package/presets/claude/android-kotlin/hooks/chain-team-phases.sh +26 -0
- package/presets/claude/android-kotlin/rules/README.md +2 -0
- package/presets/claude/android-kotlin/rules/architecture/feature-delivery.md +2 -0
- package/presets/claude/android-kotlin/rules/tooling-and-review/agent-team-orchestrator.md +6 -3
- package/presets/claude/android-kotlin/rules/tooling-and-review/mockup-review.md +118 -0
- package/presets/claude/android-kotlin/rules/tooling-and-review/preset-no-cross-stack-leakage.md +4 -3
- package/presets/claude/android-kotlin/rules/tooling-and-review/ux-design.md +110 -0
- package/presets/claude/android-kotlin/skills/README.md +2 -0
- package/presets/claude/android-kotlin/skills/feature-delivery/SKILL.md +3 -0
- package/presets/claude/android-kotlin/skills/mockup-review/SKILL.md +29 -0
- package/presets/claude/android-kotlin/skills/ux-design/SKILL.md +36 -0
- package/presets/claude/android-kotlin/team/fixtures/artifact-manifest.example.json +25 -0
- package/presets/claude/android-kotlin/team/fixtures/feature-with-figma-url.json +17 -0
- package/presets/claude/android-kotlin/team/fixtures/feature-with-ux-no-figma.json +17 -0
- package/presets/claude/android-kotlin/team/fixtures/mockup-review-fail-embedded-status.json +8 -0
- package/presets/claude/android-kotlin/team/fixtures/mockup-review-standalone.json +14 -0
- package/presets/claude/android-kotlin/team/fixtures/ux-design-standalone.json +15 -0
- package/presets/claude/go/MCP.md +1 -1
- package/presets/claude/go/agents/build-verifier.md +6 -0
- package/presets/claude/go/agents/task-router.md +1 -1
- package/presets/claude/go/rules/tooling-and-review/preset-no-cross-stack-leakage.md +4 -2
- package/presets/claude/ios-swift/agents/README.md +2 -2
- package/presets/claude/ios-swift/agents/build-verifier.md +6 -0
- package/presets/claude/ios-swift/agents/feature-developer.md +6 -0
- package/presets/claude/ios-swift/agents/mockup-reviewer.md +59 -0
- package/presets/claude/ios-swift/agents/task-analyst.md +18 -1
- package/presets/claude/ios-swift/agents/task-router.md +11 -2
- package/presets/claude/ios-swift/commands/task-continue.md +6 -4
- package/presets/claude/ios-swift/commands/task.md +2 -0
- package/presets/claude/ios-swift/hooks/chain-team-phases.sh +26 -0
- package/presets/claude/ios-swift/rules/README.md +4 -0
- package/presets/claude/ios-swift/rules/architecture/feature-delivery.md +2 -0
- package/presets/claude/ios-swift/rules/tooling-and-review/agent-team-orchestrator.md +6 -3
- package/presets/claude/ios-swift/rules/tooling-and-review/mockup-review.md +118 -0
- package/presets/claude/ios-swift/rules/tooling-and-review/preset-no-cross-stack-leakage.md +4 -2
- package/presets/claude/ios-swift/rules/tooling-and-review/ux-design.md +110 -0
- package/presets/claude/ios-swift/skills/README.md +2 -0
- package/presets/claude/ios-swift/skills/feature-delivery/SKILL.md +3 -0
- package/presets/claude/ios-swift/skills/mockup-review/SKILL.md +29 -0
- package/presets/claude/ios-swift/skills/ux-design/SKILL.md +36 -0
- package/presets/claude/ios-swift/team/fixtures/artifact-manifest.example.json +25 -0
- package/presets/claude/ios-swift/team/fixtures/feature-with-figma-url.json +17 -0
- package/presets/claude/ios-swift/team/fixtures/feature-with-ux-no-figma.json +17 -0
- package/presets/claude/ios-swift/team/fixtures/mockup-review-fail-embedded-status.json +8 -0
- package/presets/claude/ios-swift/team/fixtures/mockup-review-standalone.json +14 -0
- package/presets/claude/ios-swift/team/fixtures/ux-design-standalone.json +15 -0
- package/presets/claude/java/agents/build-verifier.md +7 -1
- package/presets/claude/java/agents/task-router.md +1 -1
- package/presets/claude/java/rules/tooling-and-review/preset-no-cross-stack-leakage.md +4 -2
- package/presets/claude/mcp-ts/agents/build-verifier.md +7 -1
- package/presets/claude/mcp-ts/agents/task-router.md +1 -1
- package/presets/claude/mcp-ts/rules/tooling-and-review/preset-no-cross-stack-leakage.md +4 -2
- package/presets/claude/next/agents/README.md +2 -1
- package/presets/claude/next/agents/build-verifier.md +6 -0
- package/presets/claude/next/agents/feature-developer.md +6 -0
- package/presets/claude/next/agents/mockup-reviewer.md +59 -0
- package/presets/claude/next/agents/task-analyst.md +18 -1
- package/presets/claude/next/agents/task-router.md +12 -3
- package/presets/claude/next/commands/task-continue.md +6 -4
- package/presets/claude/next/commands/task.md +2 -0
- package/presets/claude/next/hooks/chain-team-phases.sh +26 -0
- package/presets/claude/next/rules/README.md +5 -1
- package/presets/claude/next/rules/architecture/feature-delivery-workflow.md +2 -0
- package/presets/claude/next/rules/tooling-and-review/agent-team-orchestrator.md +6 -3
- package/presets/claude/next/rules/tooling-and-review/mockup-review.md +118 -0
- package/presets/claude/next/rules/tooling-and-review/preset-no-cross-stack-leakage.md +4 -2
- package/presets/claude/next/rules/tooling-and-review/ux-design.md +110 -0
- package/presets/claude/next/skills/README.md +2 -0
- package/presets/claude/next/skills/feature-delivery/SKILL.md +3 -0
- package/presets/claude/next/skills/mockup-review/SKILL.md +29 -0
- package/presets/claude/next/skills/ux-design/SKILL.md +36 -0
- package/presets/claude/next/team/fixtures/artifact-manifest.example.json +20 -2
- package/presets/claude/next/team/fixtures/feature-with-figma-url.json +17 -0
- package/presets/claude/next/team/fixtures/feature-with-ux-no-figma.json +17 -0
- package/presets/claude/next/team/fixtures/mockup-review-fail-embedded-status.json +8 -0
- package/presets/claude/next/team/fixtures/mockup-review-standalone.json +14 -0
- package/presets/claude/next/team/fixtures/ux-design-standalone.json +15 -0
- package/presets/claude/nuxt/agents/README.md +2 -1
- package/presets/claude/nuxt/agents/build-verifier.md +6 -0
- package/presets/claude/nuxt/agents/feature-developer.md +6 -0
- package/presets/claude/nuxt/agents/mockup-reviewer.md +59 -0
- package/presets/claude/nuxt/agents/task-analyst.md +18 -1
- package/presets/claude/nuxt/agents/task-router.md +12 -3
- package/presets/claude/nuxt/commands/task-continue.md +6 -4
- package/presets/claude/nuxt/commands/task.md +2 -0
- package/presets/claude/nuxt/hooks/chain-team-phases.sh +26 -0
- package/presets/claude/nuxt/rules/README.md +4 -0
- package/presets/claude/nuxt/rules/architecture/feature-delivery-workflow.md +2 -0
- package/presets/claude/nuxt/rules/tooling-and-review/agent-team-orchestrator.md +6 -3
- package/presets/claude/nuxt/rules/tooling-and-review/mockup-review.md +118 -0
- package/presets/claude/nuxt/rules/tooling-and-review/preset-no-cross-stack-leakage.md +4 -2
- package/presets/claude/nuxt/rules/tooling-and-review/ux-design.md +110 -0
- package/presets/claude/nuxt/skills/README.md +2 -0
- package/presets/claude/nuxt/skills/feature-delivery/SKILL.md +3 -0
- package/presets/claude/nuxt/skills/mockup-review/SKILL.md +29 -0
- package/presets/claude/nuxt/skills/ux-design/SKILL.md +36 -0
- package/presets/claude/nuxt/team/fixtures/artifact-manifest.example.json +20 -2
- package/presets/claude/nuxt/team/fixtures/feature-with-figma-url.json +17 -0
- package/presets/claude/nuxt/team/fixtures/feature-with-ux-no-figma.json +17 -0
- package/presets/claude/nuxt/team/fixtures/mockup-review-fail-embedded-status.json +8 -0
- package/presets/claude/nuxt/team/fixtures/mockup-review-standalone.json +14 -0
- package/presets/claude/nuxt/team/fixtures/ux-design-standalone.json +15 -0
- package/presets/claude/php-hexagonal/agents/build-verifier.md +7 -1
- package/presets/claude/php-hexagonal/agents/task-router.md +1 -1
- package/presets/claude/php-hexagonal/rules/tooling-and-review/preset-no-cross-stack-leakage.md +4 -2
- package/presets/claude/php-laravel/agents/build-verifier.md +7 -1
- package/presets/claude/php-laravel/agents/task-router.md +1 -1
- package/presets/claude/php-laravel/rules/tooling-and-review/preset-no-cross-stack-leakage.md +4 -2
- package/presets/claude/svelte/agents/README.md +2 -1
- package/presets/claude/svelte/agents/build-verifier.md +6 -0
- package/presets/claude/svelte/agents/feature-developer.md +6 -0
- package/presets/claude/svelte/agents/mockup-reviewer.md +59 -0
- package/presets/claude/svelte/agents/task-analyst.md +18 -1
- package/presets/claude/svelte/agents/task-router.md +12 -3
- package/presets/claude/svelte/commands/task-continue.md +6 -4
- package/presets/claude/svelte/commands/task.md +2 -0
- package/presets/claude/svelte/hooks/chain-team-phases.sh +26 -0
- package/presets/claude/svelte/rules/README.md +4 -0
- package/presets/claude/svelte/rules/architecture/feature-delivery-workflow.md +2 -0
- package/presets/claude/svelte/rules/tooling-and-review/agent-team-orchestrator.md +6 -3
- package/presets/claude/svelte/rules/tooling-and-review/mockup-review.md +118 -0
- package/presets/claude/svelte/rules/tooling-and-review/preset-no-cross-stack-leakage.md +4 -2
- package/presets/claude/svelte/rules/tooling-and-review/ux-design.md +110 -0
- package/presets/claude/svelte/skills/README.md +2 -0
- package/presets/claude/svelte/skills/feature-delivery/SKILL.md +3 -0
- package/presets/claude/svelte/skills/mockup-review/SKILL.md +29 -0
- package/presets/claude/svelte/skills/ux-design/SKILL.md +36 -0
- package/presets/claude/svelte/team/fixtures/artifact-manifest.example.json +20 -2
- package/presets/claude/svelte/team/fixtures/feature-with-figma-url.json +17 -0
- package/presets/claude/svelte/team/fixtures/feature-with-ux-no-figma.json +17 -0
- package/presets/claude/svelte/team/fixtures/mockup-review-fail-embedded-status.json +8 -0
- package/presets/claude/svelte/team/fixtures/mockup-review-standalone.json +14 -0
- package/presets/claude/svelte/team/fixtures/ux-design-standalone.json +15 -0
- package/presets/cursor/android-kotlin/agents/README.md +2 -2
- package/presets/cursor/android-kotlin/agents/build-verifier.md +6 -0
- package/presets/cursor/android-kotlin/agents/feature-developer.md +6 -0
- package/presets/cursor/android-kotlin/agents/mockup-reviewer.md +60 -0
- package/presets/cursor/android-kotlin/agents/task-analyst.md +18 -1
- package/presets/cursor/android-kotlin/agents/task-router.md +11 -2
- package/presets/cursor/android-kotlin/commands/task-continue.md +6 -4
- package/presets/cursor/android-kotlin/commands/task.md +2 -0
- package/presets/cursor/android-kotlin/hooks/chain-team-phases.sh +26 -0
- package/presets/cursor/android-kotlin/rules/README.md +4 -0
- package/presets/cursor/android-kotlin/rules/agent-team-orchestrator.mdc +6 -3
- package/presets/cursor/android-kotlin/rules/feature-delivery-workflow.mdc +2 -0
- package/presets/cursor/android-kotlin/rules/mockup-review.mdc +116 -0
- package/presets/cursor/android-kotlin/rules/preset-no-cross-stack-leakage.mdc +4 -3
- package/presets/cursor/android-kotlin/rules/ux-design.mdc +108 -0
- package/presets/cursor/android-kotlin/skills/README.md +2 -0
- package/presets/cursor/android-kotlin/skills/feature-delivery/SKILL.md +3 -0
- package/presets/cursor/android-kotlin/skills/mockup-review/SKILL.md +29 -0
- package/presets/cursor/android-kotlin/skills/ux-design/SKILL.md +36 -0
- package/presets/cursor/android-kotlin/team/fixtures/artifact-manifest.example.json +25 -0
- package/presets/cursor/android-kotlin/team/fixtures/feature-with-figma-url.json +17 -0
- package/presets/cursor/android-kotlin/team/fixtures/feature-with-ux-no-figma.json +17 -0
- package/presets/cursor/android-kotlin/team/fixtures/mockup-review-fail-embedded-status.json +8 -0
- package/presets/cursor/android-kotlin/team/fixtures/mockup-review-standalone.json +14 -0
- package/presets/cursor/android-kotlin/team/fixtures/ux-design-standalone.json +15 -0
- package/presets/cursor/go/MCP.md +1 -1
- package/presets/cursor/go/agents/build-verifier.md +6 -0
- package/presets/cursor/go/agents/task-router.md +1 -1
- package/presets/cursor/go/rules/preset-no-cross-stack-leakage.mdc +4 -2
- package/presets/cursor/ios-swift/agents/README.md +2 -2
- package/presets/cursor/ios-swift/agents/build-verifier.md +6 -0
- package/presets/cursor/ios-swift/agents/feature-developer.md +6 -0
- package/presets/cursor/ios-swift/agents/mockup-reviewer.md +60 -0
- package/presets/cursor/ios-swift/agents/task-analyst.md +18 -1
- package/presets/cursor/ios-swift/agents/task-router.md +11 -2
- package/presets/cursor/ios-swift/commands/task-continue.md +6 -4
- package/presets/cursor/ios-swift/commands/task.md +2 -0
- package/presets/cursor/ios-swift/hooks/chain-team-phases.sh +26 -0
- package/presets/cursor/ios-swift/rules/README.md +5 -1
- package/presets/cursor/ios-swift/rules/agent-team-orchestrator.mdc +6 -3
- package/presets/cursor/ios-swift/rules/feature-delivery-workflow.mdc +2 -0
- package/presets/cursor/ios-swift/rules/mockup-review.mdc +116 -0
- package/presets/cursor/ios-swift/rules/preset-no-cross-stack-leakage.mdc +4 -2
- package/presets/cursor/ios-swift/rules/ux-design.mdc +108 -0
- package/presets/cursor/ios-swift/skills/README.md +2 -0
- package/presets/cursor/ios-swift/skills/feature-delivery/SKILL.md +3 -0
- package/presets/cursor/ios-swift/skills/mockup-review/SKILL.md +29 -0
- package/presets/cursor/ios-swift/skills/ux-design/SKILL.md +36 -0
- package/presets/cursor/ios-swift/team/fixtures/artifact-manifest.example.json +25 -0
- package/presets/cursor/ios-swift/team/fixtures/feature-with-figma-url.json +17 -0
- package/presets/cursor/ios-swift/team/fixtures/feature-with-ux-no-figma.json +17 -0
- package/presets/cursor/ios-swift/team/fixtures/mockup-review-fail-embedded-status.json +8 -0
- package/presets/cursor/ios-swift/team/fixtures/mockup-review-standalone.json +14 -0
- package/presets/cursor/ios-swift/team/fixtures/ux-design-standalone.json +15 -0
- package/presets/cursor/java/agents/build-verifier.md +7 -1
- package/presets/cursor/java/agents/task-router.md +1 -1
- package/presets/cursor/java/rules/preset-no-cross-stack-leakage.mdc +4 -2
- package/presets/cursor/mcp-ts/agents/build-verifier.md +7 -1
- package/presets/cursor/mcp-ts/agents/task-router.md +1 -1
- package/presets/cursor/mcp-ts/rules/preset-no-cross-stack-leakage.mdc +4 -2
- package/presets/cursor/next/agents/README.md +2 -1
- package/presets/cursor/next/agents/build-verifier.md +6 -0
- package/presets/cursor/next/agents/feature-developer.md +6 -0
- package/presets/cursor/next/agents/mockup-reviewer.md +60 -0
- package/presets/cursor/next/agents/task-analyst.md +18 -1
- package/presets/cursor/next/agents/task-router.md +12 -3
- package/presets/cursor/next/commands/task-continue.md +6 -4
- package/presets/cursor/next/commands/task.md +2 -0
- package/presets/cursor/next/hooks/chain-team-phases.sh +26 -0
- package/presets/cursor/next/rules/README.md +3 -1
- package/presets/cursor/next/rules/agent-team-orchestrator.mdc +6 -3
- package/presets/cursor/next/rules/feature-delivery-workflow.mdc +2 -0
- package/presets/cursor/next/rules/mockup-review.mdc +116 -0
- package/presets/cursor/next/rules/preset-no-cross-stack-leakage.mdc +4 -2
- package/presets/cursor/next/rules/ux-design.mdc +108 -0
- package/presets/cursor/next/skills/README.md +2 -0
- package/presets/cursor/next/skills/feature-delivery/SKILL.md +3 -0
- package/presets/cursor/next/skills/mockup-review/SKILL.md +29 -0
- package/presets/cursor/next/skills/ux-design/SKILL.md +36 -0
- package/presets/cursor/next/team/fixtures/artifact-manifest.example.json +20 -2
- package/presets/cursor/next/team/fixtures/feature-with-figma-url.json +17 -0
- package/presets/cursor/next/team/fixtures/feature-with-ux-no-figma.json +17 -0
- package/presets/cursor/next/team/fixtures/mockup-review-fail-embedded-status.json +8 -0
- package/presets/cursor/next/team/fixtures/mockup-review-standalone.json +14 -0
- package/presets/cursor/next/team/fixtures/ux-design-standalone.json +15 -0
- package/presets/cursor/nuxt/agents/README.md +2 -1
- package/presets/cursor/nuxt/agents/build-verifier.md +6 -0
- package/presets/cursor/nuxt/agents/feature-developer.md +6 -0
- package/presets/cursor/nuxt/agents/mockup-reviewer.md +60 -0
- package/presets/cursor/nuxt/agents/task-analyst.md +18 -1
- package/presets/cursor/nuxt/agents/task-router.md +12 -3
- package/presets/cursor/nuxt/commands/task-continue.md +6 -4
- package/presets/cursor/nuxt/commands/task.md +2 -0
- package/presets/cursor/nuxt/hooks/chain-team-phases.sh +26 -0
- package/presets/cursor/nuxt/rules/README.md +3 -1
- package/presets/cursor/nuxt/rules/agent-team-orchestrator.mdc +6 -3
- package/presets/cursor/nuxt/rules/feature-delivery-workflow.mdc +2 -0
- package/presets/cursor/nuxt/rules/mockup-review.mdc +116 -0
- package/presets/cursor/nuxt/rules/preset-no-cross-stack-leakage.mdc +4 -2
- package/presets/cursor/nuxt/rules/ux-design.mdc +108 -0
- package/presets/cursor/nuxt/skills/README.md +2 -0
- package/presets/cursor/nuxt/skills/feature-delivery/SKILL.md +3 -0
- package/presets/cursor/nuxt/skills/mockup-review/SKILL.md +29 -0
- package/presets/cursor/nuxt/skills/ux-design/SKILL.md +36 -0
- package/presets/cursor/nuxt/team/fixtures/artifact-manifest.example.json +20 -2
- package/presets/cursor/nuxt/team/fixtures/feature-with-figma-url.json +17 -0
- package/presets/cursor/nuxt/team/fixtures/feature-with-ux-no-figma.json +17 -0
- package/presets/cursor/nuxt/team/fixtures/mockup-review-fail-embedded-status.json +8 -0
- package/presets/cursor/nuxt/team/fixtures/mockup-review-standalone.json +14 -0
- package/presets/cursor/nuxt/team/fixtures/ux-design-standalone.json +15 -0
- package/presets/cursor/php-hexagonal/agents/build-verifier.md +7 -1
- package/presets/cursor/php-hexagonal/agents/task-router.md +1 -1
- package/presets/cursor/php-hexagonal/rules/preset-no-cross-stack-leakage.mdc +4 -2
- package/presets/cursor/php-laravel/agents/build-verifier.md +7 -1
- package/presets/cursor/php-laravel/agents/task-router.md +1 -1
- package/presets/cursor/php-laravel/rules/preset-no-cross-stack-leakage.mdc +4 -2
- package/presets/cursor/svelte/agents/README.md +2 -1
- package/presets/cursor/svelte/agents/build-verifier.md +6 -0
- package/presets/cursor/svelte/agents/feature-developer.md +6 -0
- package/presets/cursor/svelte/agents/mockup-reviewer.md +60 -0
- package/presets/cursor/svelte/agents/task-analyst.md +18 -1
- package/presets/cursor/svelte/agents/task-router.md +12 -3
- package/presets/cursor/svelte/commands/task-continue.md +6 -4
- package/presets/cursor/svelte/commands/task.md +2 -0
- package/presets/cursor/svelte/hooks/chain-team-phases.sh +26 -0
- package/presets/cursor/svelte/rules/README.md +3 -1
- package/presets/cursor/svelte/rules/agent-team-orchestrator.mdc +6 -3
- package/presets/cursor/svelte/rules/feature-delivery-workflow.mdc +2 -0
- package/presets/cursor/svelte/rules/mockup-review.mdc +116 -0
- package/presets/cursor/svelte/rules/preset-no-cross-stack-leakage.mdc +4 -2
- package/presets/cursor/svelte/rules/ux-design.mdc +108 -0
- package/presets/cursor/svelte/skills/README.md +2 -0
- package/presets/cursor/svelte/skills/feature-delivery/SKILL.md +3 -0
- package/presets/cursor/svelte/skills/mockup-review/SKILL.md +29 -0
- package/presets/cursor/svelte/skills/ux-design/SKILL.md +36 -0
- package/presets/cursor/svelte/team/fixtures/artifact-manifest.example.json +20 -2
- package/presets/cursor/svelte/team/fixtures/feature-with-figma-url.json +17 -0
- package/presets/cursor/svelte/team/fixtures/feature-with-ux-no-figma.json +17 -0
- package/presets/cursor/svelte/team/fixtures/mockup-review-fail-embedded-status.json +8 -0
- package/presets/cursor/svelte/team/fixtures/mockup-review-standalone.json +14 -0
- package/presets/cursor/svelte/team/fixtures/ux-design-standalone.json +15 -0
|
@@ -0,0 +1,8 @@
|
|
|
1
|
+
{
|
|
2
|
+
"slug": "example-mockup-fail-gate",
|
|
3
|
+
"state": "awaiting_approval",
|
|
4
|
+
"currentAgent": "mockup-reviewer",
|
|
5
|
+
"awaitingHumanGate": true,
|
|
6
|
+
"retryAfterFix": null,
|
|
7
|
+
"note": "Embedded mockup FAIL: hook must NOT set retryAfterFix to feature-developer. Resume only via /task-continue."
|
|
8
|
+
}
|
|
@@ -0,0 +1,14 @@
|
|
|
1
|
+
{
|
|
2
|
+
"slug": "example-mockup-review-standalone",
|
|
3
|
+
"intent": "mockup-review",
|
|
4
|
+
"profile": "light",
|
|
5
|
+
"summary": "Standalone Figma mockup review (report-only)",
|
|
6
|
+
"steps": [
|
|
7
|
+
{ "agent": "mockup-reviewer", "label": "Figma mockup review", "model": "strong" }
|
|
8
|
+
],
|
|
9
|
+
"humanGates": [],
|
|
10
|
+
"autoChain": true,
|
|
11
|
+
"skipped": [
|
|
12
|
+
{ "agent": "feature-developer", "reason": "Standalone mockup-review is report-only" }
|
|
13
|
+
]
|
|
14
|
+
}
|
|
@@ -0,0 +1,15 @@
|
|
|
1
|
+
{
|
|
2
|
+
"slug": "example-ux-design-standalone",
|
|
3
|
+
"intent": "ux-design",
|
|
4
|
+
"profile": "light",
|
|
5
|
+
"summary": "Standalone behavioral UX design (analyst + skill ux-design; report-only; no developer)",
|
|
6
|
+
"steps": [
|
|
7
|
+
{ "agent": "task-analyst", "label": "UX design (skill ux-design)" }
|
|
8
|
+
],
|
|
9
|
+
"humanGates": [],
|
|
10
|
+
"autoChain": true,
|
|
11
|
+
"skipped": [
|
|
12
|
+
{ "agent": "feature-developer", "reason": "Standalone ux-design is report-only" },
|
|
13
|
+
{ "agent": "mockup-reviewer", "reason": "No figma.com URL; not a mockup review" }
|
|
14
|
+
]
|
|
15
|
+
}
|
|
@@ -31,7 +31,7 @@ Hard gates for the **php-hexagonal** stack (and peers):
|
|
|
31
31
|
|------|-----------|
|
|
32
32
|
| **twin-map** | `php-hexagonal` missing from `STACKS`, or Cursor↔Claude orphan/missing twins |
|
|
33
33
|
| **token-budget** | Cursor `alwaysApply` ≠ 3 or Claude session-start (excl. README) ≠ 3, or trio body sum > 140 |
|
|
34
|
-
| **leakage** | `PHP_FORBIDDEN_*` hits (Playwright/XCUITest/`lint:js`/`accessibility-reviewer` as required handoffs) |
|
|
34
|
+
| **leakage** | `PHP_FORBIDDEN_*` hits (Playwright/XCUITest/`lint:js`/`accessibility-reviewer` / `mockup-reviewer` as required handoffs) |
|
|
35
35
|
| **chain fork** | `hooks/chain-team-phases.sh` byte-identical to **next**, **ios-swift**, **go**, **java**, **mcp-ts**, or **php-laravel** (same platform) |
|
|
36
36
|
|
|
37
37
|
Also document:
|
|
@@ -44,6 +44,12 @@ Also document:
|
|
|
44
44
|
|
|
45
45
|
Document PASS/FAIL in `validation-report.md`.
|
|
46
46
|
|
|
47
|
+
|
|
48
|
+
**Forbidden mockup-reviewer:** agent file `agents/mockup-reviewer.md` or required `AGENT_HANDOFF` / pipeline handoff for `mockup-reviewer` → **FAIL** (no UI mockup reviewer).
|
|
49
|
+
|
|
50
|
+
**Forbidden ux-designer / ux-design:** agent file `agents/ux-designer.md` or required `skills/ux-design` / `rules/ux-design` / pipeline handoff stem `ux-design` → **FAIL** (no UI UX surface).
|
|
51
|
+
|
|
52
|
+
|
|
47
53
|
## Artifact contract
|
|
48
54
|
|
|
49
55
|
- **Authoritative inputs:** read `.cursor/team/tasks/<slug>/artifact-manifest.json` first; consume handoff `artifactInputIds` when supplied, otherwise consume the manifest entries for brief/decomposition, implementation evidence, pipeline scope, and changed files.
|
|
@@ -31,7 +31,7 @@ You are a task router for a **PHP hexagonal backend** agent team. You **do not**
|
|
|
31
31
|
| `spike` | «исследуй» (investigate), «spike», proof of concept | task-analyst → solution-architect | <!-- i18n-keep: E4 -->
|
|
32
32
|
| `retro` | «ретро» (retro), «postmortem» | (orchestrator → `/technical-retro`) | <!-- i18n-keep: E4 -->
|
|
33
33
|
|
|
34
|
-
**Never schedule** Playwright (`playwright-test-*`), XCUITest (`xcuitest-test-*`), or `accessibility-reviewer`. Put them in `skipped` with reason «PHP backend uses integration-test trio».
|
|
34
|
+
**Never schedule** Playwright (`playwright-test-*`), XCUITest (`xcuitest-test-*`), or `accessibility-reviewer` / `mockup-reviewer`. Put them in `skipped` with reason «PHP backend uses integration-test trio».
|
|
35
35
|
|
|
36
36
|
## Pipeline profiles
|
|
37
37
|
|
|
@@ -70,7 +70,8 @@ Shared backend-stack bans (`go`, `java`, `php-hexagonal`, and `php-laravel`):
|
|
|
70
70
|
- `playwright-test-`, `playwright-e2e`, `user-playwright`, `app/__tests__/e2e`
|
|
71
71
|
- Positive yarn recipes `lint:js` / `lint:css`
|
|
72
72
|
- `xcuitest-test-`, `instrumentation-test-`, `xcodebuild`, `SwiftLint` as required handoffs
|
|
73
|
-
- Agent
|
|
73
|
+
- Agent files `accessibility-reviewer`, `mockup-reviewer`, `ux-designer` (no UI surface)
|
|
74
|
+
- Required `skills/ux-design`, required `rules/ux-design`, or required pipeline handoff stem `ux-design`
|
|
74
75
|
|
|
75
76
|
Required instead: `integration-test-*`; build-verifier / `post-change-test` plus stack tooling — `go-tooling` (`go test`, `go vet`), `java-tooling` (`mvn test` / `./gradlew test`), or `php-tooling` (`php artisan test` / `composer test` / `vendor/bin/phpunit`).
|
|
76
77
|
|
|
@@ -82,7 +83,8 @@ Same UI/mobile bans as backend stacks, plus:
|
|
|
82
83
|
- Positive yarn recipes `lint:js` / `lint:css` as required gates
|
|
83
84
|
- `xcuitest-test-`, `instrumentation-test-`, `xcodebuild`, `SwiftLint` as required handoffs
|
|
84
85
|
- Go tool commands as required MCP delivery gates: `go test`, `go vet`, `golangci-lint`
|
|
85
|
-
- Agent files: `playwright-test-*`, `xcuitest-test-*`, `instrumentation-test-*`, `integration-test-*`, `accessibility-reviewer`
|
|
86
|
+
- Agent files: `playwright-test-*`, `xcuitest-test-*`, `instrumentation-test-*`, `integration-test-*`, `accessibility-reviewer`, `mockup-reviewer`, `ux-designer`
|
|
87
|
+
- Required `skills/ux-design`, required `rules/ux-design`, or required pipeline handoff stem `ux-design`
|
|
86
88
|
|
|
87
89
|
Required instead: package-manager–discovered typecheck/test (`mcp-ts-tooling`, `post-change-test`); Phase 1 gates `build-verifier` + `security-reviewer`.
|
|
88
90
|
|
|
@@ -31,7 +31,7 @@ Hard gates for the **php-laravel** stack (and peers):
|
|
|
31
31
|
|------|-----------|
|
|
32
32
|
| **twin-map** | `php-laravel` missing from `STACKS`, or Cursor↔Claude orphan/missing twins |
|
|
33
33
|
| **token-budget** | Cursor `alwaysApply` ≠ 3 or Claude session-start (excl. README) ≠ 3, or trio body sum > 140 |
|
|
34
|
-
| **leakage** | `PHP_FORBIDDEN_*` hits (Playwright/XCUITest/`lint:js`/`accessibility-reviewer` as required handoffs) |
|
|
34
|
+
| **leakage** | `PHP_FORBIDDEN_*` hits (Playwright/XCUITest/`lint:js`/`accessibility-reviewer` / `mockup-reviewer` as required handoffs) |
|
|
35
35
|
| **chain fork** | `hooks/chain-team-phases.sh` byte-identical to **next**, **ios-swift**, **go**, **java**, **mcp-ts**, or **php-hexagonal** (same platform) |
|
|
36
36
|
|
|
37
37
|
Also document:
|
|
@@ -44,6 +44,12 @@ Also document:
|
|
|
44
44
|
|
|
45
45
|
Document PASS/FAIL in `validation-report.md`.
|
|
46
46
|
|
|
47
|
+
|
|
48
|
+
**Forbidden mockup-reviewer:** agent file `agents/mockup-reviewer.md` or required `AGENT_HANDOFF` / pipeline handoff for `mockup-reviewer` → **FAIL** (no UI mockup reviewer).
|
|
49
|
+
|
|
50
|
+
**Forbidden ux-designer / ux-design:** agent file `agents/ux-designer.md` or required `skills/ux-design` / `rules/ux-design` / pipeline handoff stem `ux-design` → **FAIL** (no UI UX surface).
|
|
51
|
+
|
|
52
|
+
|
|
47
53
|
## Artifact contract
|
|
48
54
|
|
|
49
55
|
- **Authoritative inputs:** read `.cursor/team/tasks/<slug>/artifact-manifest.json` first; consume handoff `artifactInputIds` when supplied, otherwise consume the manifest entries for brief/decomposition, implementation evidence, pipeline scope, and changed files.
|
|
@@ -31,7 +31,7 @@ You are a task router for a **Laravel backend** agent team. You **do not** imple
|
|
|
31
31
|
| `spike` | «исследуй» (investigate), «spike», proof of concept | task-analyst → solution-architect | <!-- i18n-keep: E4 -->
|
|
32
32
|
| `retro` | «ретро» (retro), «postmortem» | (orchestrator → `/technical-retro`) | <!-- i18n-keep: E4 -->
|
|
33
33
|
|
|
34
|
-
**Never schedule** Playwright (`playwright-test-*`), XCUITest (`xcuitest-test-*`), or `accessibility-reviewer`. Put them in `skipped` with reason «PHP backend uses integration-test trio».
|
|
34
|
+
**Never schedule** Playwright (`playwright-test-*`), XCUITest (`xcuitest-test-*`), or `accessibility-reviewer` / `mockup-reviewer`. Put them in `skipped` with reason «PHP backend uses integration-test trio».
|
|
35
35
|
|
|
36
36
|
### Security-reviewer routing
|
|
37
37
|
|
|
@@ -70,7 +70,8 @@ Shared backend-stack bans (`go`, `java`, `php-hexagonal`, and `php-laravel`):
|
|
|
70
70
|
- `playwright-test-`, `playwright-e2e`, `user-playwright`, `app/__tests__/e2e`
|
|
71
71
|
- Positive yarn recipes `lint:js` / `lint:css`
|
|
72
72
|
- `xcuitest-test-`, `instrumentation-test-`, `xcodebuild`, `SwiftLint` as required handoffs
|
|
73
|
-
- Agent
|
|
73
|
+
- Agent files `accessibility-reviewer`, `mockup-reviewer`, `ux-designer` (no UI surface)
|
|
74
|
+
- Required `skills/ux-design`, required `rules/ux-design`, or required pipeline handoff stem `ux-design`
|
|
74
75
|
|
|
75
76
|
Required instead: `integration-test-*`; build-verifier / `post-change-test` plus stack tooling — `go-tooling` (`go test`, `go vet`), `java-tooling` (`mvn test` / `./gradlew test`), or `php-tooling` (`php artisan test` / `composer test` / `vendor/bin/phpunit`).
|
|
76
77
|
|
|
@@ -82,7 +83,8 @@ Same UI/mobile bans as backend stacks, plus:
|
|
|
82
83
|
- Positive yarn recipes `lint:js` / `lint:css` as required gates
|
|
83
84
|
- `xcuitest-test-`, `instrumentation-test-`, `xcodebuild`, `SwiftLint` as required handoffs
|
|
84
85
|
- Go tool commands as required MCP delivery gates: `go test`, `go vet`, `golangci-lint`
|
|
85
|
-
- Agent files: `playwright-test-*`, `xcuitest-test-*`, `instrumentation-test-*`, `integration-test-*`, `accessibility-reviewer`
|
|
86
|
+
- Agent files: `playwright-test-*`, `xcuitest-test-*`, `instrumentation-test-*`, `integration-test-*`, `accessibility-reviewer`, `mockup-reviewer`, `ux-designer`
|
|
87
|
+
- Required `skills/ux-design`, required `rules/ux-design`, or required pipeline handoff stem `ux-design`
|
|
86
88
|
|
|
87
89
|
Required instead: package-manager–discovered typecheck/test (`mcp-ts-tooling`, `post-change-test`); Phase 1 gates `build-verifier` + `security-reviewer`.
|
|
88
90
|
|
|
@@ -35,6 +35,7 @@ Role subagents for the Cursor team pipeline.
|
|
|
35
35
|
| A11y reviewer | `accessibility-reviewer.md` | no |
|
|
36
36
|
| Security reviewer | `security-reviewer.md` | no |
|
|
37
37
|
| Performance auditor | `performance-auditor.md` | no |
|
|
38
|
+
| Mockup reviewer | `mockup-reviewer.md` | no |
|
|
38
39
|
|
|
39
40
|
## Testing
|
|
40
41
|
|
|
@@ -70,7 +71,7 @@ Default SoT — YAML `model` in each agent file. Optional `steps[].model` (`chea
|
|
|
70
71
|
|------|---------------------|--------|
|
|
71
72
|
| **cheap** | `fast` | `task-router`, `task-analyst`, `build-verifier`, `code-reviewer`, `tech-writer`, `codebase-analyzer` |
|
|
72
73
|
| **standard** | `inherit` | `feature-developer`, `debugger`, `ci-investigator`, `api-contract-reviewer`, `accessibility-reviewer`, `qa-tester`, `unit-test-*`, `playwright-test-*` |
|
|
73
|
-
| **strong** | `claude-opus-4-8[effort=high]` | `solution-architect`, `migration-specialist`, `security-reviewer`, `performance-auditor` |
|
|
74
|
+
| **strong** | `claude-opus-4-8[effort=high]` | `solution-architect`, `migration-specialist`, `security-reviewer`, `performance-auditor`, `mockup-reviewer` |
|
|
74
75
|
|
|
75
76
|
**Notes**
|
|
76
77
|
|
|
@@ -49,6 +49,12 @@ When validating **preset packaging** changes (paths under `packages/ai-rules/pre
|
|
|
49
49
|
13. **Product-specs assets (FAIL):** package must ship `presets/_shared/assets/docs-specs/INDEX.md`, `_templates/page.md`, `_templates/feature.md`. Cursor+Claude twins for `product-specs` and `product-specs-authoring` must embed matching shared-core markers; both stems **requestable** (`alwaysApply: false` / Claude `paths: docs/specs/**`) — never session-start.
|
|
50
50
|
14. **Optional consumer check (WARN default):** `scripts/check-product-specs.sh` + schema stub may exist for opt-in consumer CI; **FAIL** only with `--strict` or AC that requires named specs — do not force consumer CI.
|
|
51
51
|
|
|
52
|
+
|
|
53
|
+
**mockup-reviewer (UI):** `agents/mockup-reviewer.md` and `skills/mockup-review/` must exist (Cursor + Claude). Missing → **FAIL**. Backend stacks must **not** ship that agent file or a required `mockup-reviewer` chain handoff → **FAIL** if present.
|
|
54
|
+
|
|
55
|
+
**ux-design (UI):** `skills/ux-design/` and requestable rule `ux-design` (`ux-design.mdc` / `tooling-and-review/ux-design.md`) must exist (Cursor + Claude). Missing → **FAIL**. Do **not** require `agents/ux-designer.md`. Backend stacks must **not** ship that agent file or a required `ux-design` skill/rule/handoff → **FAIL** if present.
|
|
56
|
+
|
|
57
|
+
|
|
52
58
|
### Soft notes
|
|
53
59
|
|
|
54
60
|
- Thin aliases may be <15 body lines.
|
|
@@ -52,6 +52,12 @@ Do not perform formal code review — that is the code-reviewer subagent's job.
|
|
|
52
52
|
|
|
53
53
|
- When editing `pages|components|stores|api|src/lib/**/*.{svelte,ts}`, load / follow rule `svelte-sveltekit-anti-hallucination`.
|
|
54
54
|
|
|
55
|
+
## UX design (behavioral)
|
|
56
|
+
|
|
57
|
+
Read order when present: manifest → `brief.md` / `decomposition.md` → **`ux-design.md`** (when listed on `analysis`) → approved `docs/specs` (behavior SoT) → **`mockup-review.md`** when Figma was in scope → `architecture.md`.
|
|
58
|
+
|
|
59
|
+
If required-signal fired (user asked UX, AC require flows/states, or spec-gen page/feature) and there is **no** `figma.com` URL, and `ux-design.md` is absent or verdict `INCOMPLETE` without user continue → emit **`blocked`** and hand back to `task-analyst`. Do not invent flows/states. Advisory / no UI AC / Figma-only visual tweak with mockup PASS → proceed from brief + mockup-review; do not demand a UX file.
|
|
60
|
+
|
|
55
61
|
## Product specs (docs/specs)
|
|
56
62
|
|
|
57
63
|
When work touches a page/feature/route/alias: if `docs/specs/INDEX.md` exists (or brief lists approved specs), load **`product-specs`** and treat **approved** specs from brief/handoff as **behavior SoT**. Soft-fail on miss (`open_questions` + code / `.ai/context` fallback); **never invent** product behavior.
|
|
@@ -0,0 +1,60 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: mockup-reviewer
|
|
3
|
+
description: Figma mockup review specialist. Audits design-system usage, tokens, mockup quality, feature coverage, and viewport matrix. Writes mockup-review.md only; never edits production code or Figma.
|
|
4
|
+
readonly: false
|
|
5
|
+
model: claude-opus-4-8[effort=high]
|
|
6
|
+
---
|
|
7
|
+
|
|
8
|
+
You are a Figma mockup reviewer for a SvelteKit Svelte frontend.
|
|
9
|
+
|
|
10
|
+
You write **only** `.cursor/team/tasks/<slug>/mockup-review.md` (and the owned manifest receipt). Never edit production code, `packages/**`, app sources, or Figma (no `use_figma` writes).
|
|
11
|
+
|
|
12
|
+
## Inputs
|
|
13
|
+
|
|
14
|
+
1. `.cursor/team/tasks/<slug>/artifact-manifest.json`.
|
|
15
|
+
2. Prompt Figma URL(s); `brief.md` / `decomposition.md` when present.
|
|
16
|
+
3. Requestable skill `mockup-review` and rule `mockup-review` (core checklist — do not inline it here).
|
|
17
|
+
4. If plugin skills `figma-use` / `figma-design-to-code` are installed: **reference** them for URL parse and MCP invocation only — do not copy their bodies; do not run design-to-code.
|
|
18
|
+
|
|
19
|
+
## MCP tools
|
|
20
|
+
|
|
21
|
+
**Required when MCP is up:** `get_metadata`, `get_design_context`, `search_design_system`, `get_variable_defs`, `get_screenshot`.
|
|
22
|
+
|
|
23
|
+
**Optional:** `get_libraries`, `get_code_connect_map`.
|
|
24
|
+
|
|
25
|
+
**Forbidden:** `use_figma`, `create_new_file`, `generate_*`, `weave_*`, `upload_assets`, `send_code_connect_mappings`. FigJam URL → `BLOCKED_MCP`.
|
|
26
|
+
|
|
27
|
+
Cite `fileKey` + node IDs. Screenshot is supporting evidence, not a second reviewer.
|
|
28
|
+
|
|
29
|
+
**Node caps:** ≤12 screen-level frames; `get_metadata` depth ≤3; ≤3 screenshots (prefer one per small/medium/large). `search_design_system` once; `get_variable_defs` once per file. Unbounded file without a frame link → `BLOCKED_MCP` (do not dump the whole file).
|
|
30
|
+
|
|
31
|
+
MCP unavailable or OAuth fail → verdict `BLOCKED_MCP`. Do not invent DS claims.
|
|
32
|
+
|
|
33
|
+
## Review dimensions
|
|
34
|
+
|
|
35
|
+
Follow the requestable `mockup-review` checklist (DS components, tokens, quality, coverage, viewports). Do not duplicate that checklist here.
|
|
36
|
+
|
|
37
|
+
## Output
|
|
38
|
+
|
|
39
|
+
Write `.cursor/team/tasks/<slug>/mockup-review.md` using the report headings in the `mockup-review` rule.
|
|
40
|
+
|
|
41
|
+
## Verdicts and receipts
|
|
42
|
+
|
|
43
|
+
Report verdict: `PASS | PASS_WITH_NOTES | FAIL | BLOCKED_MCP`.
|
|
44
|
+
|
|
45
|
+
| Verdict | Standalone receipt | Embedded receipt | Artifact `status` |
|
|
46
|
+
|---------|--------------------|------------------|-------------------|
|
|
47
|
+
| `PASS` / `PASS_WITH_NOTES` | `completed` | `completed` | `completed` |
|
|
48
|
+
| `FAIL` | `completed` (report-only, like `perf-audit`) | `changes_requested` | `blocked` |
|
|
49
|
+
| `BLOCKED_MCP` | `blocked` | `blocked` | `blocked` |
|
|
50
|
+
|
|
51
|
+
Standalone FAIL must **not** set `changes_requested`. Embedded FAIL is a FAIL-only hook gate — resume **only** via `/task-continue` (hook must not `scheduleRetry('feature-developer')`).
|
|
52
|
+
|
|
53
|
+
## Artifact contract
|
|
54
|
+
|
|
55
|
+
- **Authoritative inputs:** read `.cursor/team/tasks/<slug>/artifact-manifest.json` first; consume handoff `artifactInputIds` when supplied, otherwise consume the manifest entries for routing + analysis when present (standalone may have only the prompt + URL).
|
|
56
|
+
- **Owned outputs:** `mockup-review.md`; upsert only the manifest entry assigned by handoff (`artifactOutputId`; fallback `mockup-review`) and preserve all foreign entries.
|
|
57
|
+
- **Terminal receipt:** cover applicable AC/task IDs, list authoritative evidence paths, and emit `completed`, `changes_requested`, or `blocked` per the table above. Bind it to the supplied `attemptId` when present.
|
|
58
|
+
- **Shared state:** never create or mutate `status.json` or `metrics.json`; the orchestration runtime/hook owns lifecycle, gates, retries, attempts, and timestamps.
|
|
59
|
+
|
|
60
|
+
Do not modify production code or tests.
|
|
@@ -121,9 +121,26 @@ Add to `brief.md`:
|
|
|
121
121
|
```
|
|
122
122
|
|
|
123
123
|
|
|
124
|
+
## UX design (behavioral)
|
|
125
|
+
|
|
126
|
+
Load requestable skill **`ux-design`** and rule **`ux-design`** when:
|
|
127
|
+
- standalone router intent `ux-design`, or
|
|
128
|
+
- **required-signal:** the user asked for UX, **or** AC explicitly require flows/states, **or** `spec-gen` / `/spec-start` for a **page/feature**, or
|
|
129
|
+
- advisory UI AC on this UI stack (notes only; skip if no UI surface).
|
|
130
|
+
|
|
131
|
+
**Order:** write `ux-design.md` **before** author mode / skill `spec-authoring` when both apply. You remain the only INDEX writer.
|
|
132
|
+
|
|
133
|
+
Write `.cursor/team/tasks/<slug>/ux-design.md` with the headings in rule `ux-design` (Mode, Verdict, Scope, IA, Entry/actors, Primary flows, States, Interaction notes, Microcopy direction, Accessibility floor, Spec feed, Open probes). Modes: `synthesize` | `review`.
|
|
134
|
+
|
|
135
|
+
**Required vs advisory:** required-signal + missing named primary flows **or** empty/error/loading matrix → DoR not met (`open_questions` / blocked analysis). Isolated missing microcopy never blocks. Advisory `INCOMPLETE` → notes only. Do **not** copy the mockup FAIL-only hook.
|
|
136
|
+
|
|
137
|
+
**Forbidden:** Figma MCP tools (`get_metadata`, `get_design_context`, `get_screenshot`, `search_design_system`, `get_variable_defs`, `use_figma`, `create_new_file`, `generate_*`). When Figma is present and required-signal fires, emit a **thin** `ux-design.md` from AC only (no visual claims). Only `mockup-reviewer` reads Figma.
|
|
138
|
+
|
|
139
|
+
When produced, append `ux-design.md` to this step's **`analysis`** `authoritativePaths` / `evidencePaths`. No new manifest producer row.
|
|
140
|
+
|
|
124
141
|
## Artifact contract
|
|
125
142
|
|
|
126
143
|
- **Authoritative inputs:** read `.cursor/team/tasks/<slug>/artifact-manifest.json` first; consume `pipeline.json`, the manifest routing entry, user-approved decisions, and any authoritative architecture/approval entries.
|
|
127
|
-
- **Owned outputs:** `brief.md` and `decomposition.md
|
|
144
|
+
- **Owned outputs:** `brief.md` and `decomposition.md` (plus `ux-design.md` when produced); upsert only the manifest entry assigned by handoff (`artifactOutputId`; fallback `analysis`) and preserve all foreign entries.
|
|
128
145
|
- **Terminal receipt:** cover applicable AC/task IDs, list authoritative evidence paths, and emit `completed` or `blocked`. Bind it to the supplied `attemptId` when present.
|
|
129
146
|
- **Shared state:** never create or mutate `status.json` or `metrics.json`; the orchestration runtime/hook owns lifecycle, gates, retries, attempts, and timestamps.
|
|
@@ -23,6 +23,8 @@ You are a task router for a SvelteKit frontend agent team. You **do not** implem
|
|
|
23
23
|
| `migration` | “migration”, “upgrade”, “update SvelteKit”, “move to”, major version | task-analyst → migration-specialist → feature-developer → build-verifier → code-reviewer → qa-tester (regression) |
|
|
24
24
|
| `perf-audit` | “performance”, “perf”, “bundle”, “LCP”, “slow”, “waterfall” | performance-auditor |
|
|
25
25
|
| `a11y` | “a11y”, “accessibility”, “WCAG”, “screen reader”, “keyboard” | task-analyst → feature-developer → build-verifier → accessibility-reviewer → code-reviewer |
|
|
26
|
+
| `mockup-review` | «ревью макета» (mockup review), «mockup review», «проверь Figma» (check Figma), «figma review», «макет» (mockup) + review verb, `figma.com` + review-not-implement | mockup-reviewer | <!-- i18n-keep: E4 -->
|
|
27
|
+
| `ux-design` | «разработай UX» (design UX), «спроектируй» (design/plan) flows, «journey», «IA», «state matrix», «ревью UX» (UX review) without Figma | task-analyst | <!-- i18n-keep: E4 -->
|
|
26
28
|
| `review-only` | “review”, “review MR”, “check diff”, “code review” | code-reviewer |
|
|
27
29
|
| `test-only` | “cover with tests”, “write tests” (mixed unit+e2e, no impl) | task-analyst → qa-tester |
|
|
28
30
|
| `unit-only` | “unit”, “mapper tests”, “cover the mapper”, “fix unit” | unit-test-planner → unit-test-generator, or unit-test-healer |
|
|
@@ -34,7 +36,7 @@ You are a task router for a SvelteKit frontend agent team. You **do not** implem
|
|
|
34
36
|
|
|
35
37
|
## Pipeline profiles
|
|
36
38
|
|
|
37
|
-
Set optional top-level `"profile": "full" | "standard" | "light"` in `pipeline.json`. Default when omitted: **`standard`** for `feature`/`refactor`/`bugfix`; **`light`** for `review-only`, `perf-audit`; **`full`** when cross-layer or e2e AC required.
|
|
39
|
+
Set optional top-level `"profile": "full" | "standard" | "light"` in `pipeline.json`. Default when omitted: **`standard`** for `feature`/`refactor`/`bugfix`; **`light`** for `review-only`, `perf-audit`, `mockup-review`, `ux-design`; **`full`** when cross-layer or e2e AC required.
|
|
38
40
|
|
|
39
41
|
| Profile | When | Typical `feature` steps |
|
|
40
42
|
|---------|------|------------------------|
|
|
@@ -51,6 +53,8 @@ Set optional top-level `"profile": "full" | "standard" | "light"` in `pipeline.j
|
|
|
51
53
|
| `feature` | developer → build-verifier |
|
|
52
54
|
| `bugfix` | debugger → build-verifier (`skipIf: debugger.fixed` on developer) |
|
|
53
55
|
| `review-only` | code-reviewer |
|
|
56
|
+
| `mockup-review` | mockup-reviewer |
|
|
57
|
+
| `ux-design` | task-analyst |
|
|
54
58
|
| `docs-only` | tech-writer (skip analyst if brief exists) |
|
|
55
59
|
| `ci-fix` | ci-investigator → build-verifier (`skipIf: ci-investigator.resolved`) |
|
|
56
60
|
|
|
@@ -79,6 +83,9 @@ Keep top-level `profile` and emit this top-level object in every new `pipeline.j
|
|
|
79
83
|
|
|
80
84
|
## Adjust steps (when context is clear)
|
|
81
85
|
|
|
86
|
+
- If prompt or `brief.md` contains `figma.com` on `feature` / `refactor` / `spike` / `spec-gen`, insert **mockup-reviewer** after **task-analyst** (when present) and before **solution-architect** and **feature-developer**. Set `model: "strong"` on that step. Do not add static `humanGates: ["after:mockup-reviewer"]` (FAIL-only hook exception). Never put `mockup-reviewer` in a `parallel: true` step (FAIL-only gate is serial).
|
|
87
|
+
- Classify intent `mockup-review` **before** `ux-design` **before** `review-only`. A `figma.com` URL with review-not-implement language is `mockup-review` even without the word «макет», including when the user said «ревью UX». <!-- i18n-keep: E4 -->
|
|
88
|
+
- If UI stack and (required-signal or advisory UI AC), instruct **task-analyst** to load skill `ux-design` (no new pipeline step; analyst default model, not `strong`). Required-signal: user asked UX, or AC require flows/states, or spec-gen page/feature.
|
|
82
89
|
- Skip **task-analyst** if AC/scope fully specified → document in `skipped`.
|
|
83
90
|
- Add **solution-architect** for cross-layer / new public APIs — after analyst, before developer.
|
|
84
91
|
- Add **api-contract-reviewer** for new/changed backend contracts — before developer.
|
|
@@ -93,11 +100,11 @@ Optional per-step field: `"model": "cheap" | "standard" | "strong"`. Omit → ag
|
|
|
93
100
|
|
|
94
101
|
| When | What to write |
|
|
95
102
|
|------|----------------|
|
|
96
|
-
| `profile: light` | set `cheap` on **all** steps (
|
|
103
|
+
| `profile: light` | set `cheap` on **all** steps (exceptions: unclear bug root cause on `debugger` → `strong`; `mockup-reviewer` always `strong`) |
|
|
97
104
|
| `profile: standard` | omit (frontmatter defaults) |
|
|
98
105
|
| `profile: full` | set `strong` on `solution-architect`, `migration-specialist`, `security-reviewer`, `performance-auditor` when present; omit others |
|
|
99
106
|
| `intent: spike` | set `strong` on `solution-architect` (and analyst may stay default/`cheap`) |
|
|
100
|
-
| `intent: perf-audit` / security-heavy feature | `strong` on auditor/reviewer step |
|
|
107
|
+
| `intent: perf-audit` / `mockup-review` / security-heavy feature | `strong` on auditor/reviewer step (`mockup-reviewer` never `cheap`) |
|
|
101
108
|
| Always | **never** `strong` on `build-verifier`, `tech-writer`, `task-router` |
|
|
102
109
|
|
|
103
110
|
Cursor mapping when orchestrator invokes Task: `cheap` → pass `model: "fast"` if the tool accepts it; `standard`/`strong` → **do not** pass `fast` (rely on agent frontmatter pin / inherit).
|
|
@@ -114,6 +121,8 @@ Cursor mapping when orchestrator invokes Task: `cheap` → pass `model: "fast"`
|
|
|
114
121
|
| `bugfix`, `review-only`, `ci-fix` | `[]` |
|
|
115
122
|
| `spike` | `["after:solution-architect"]` |
|
|
116
123
|
| `perf-audit` | `[]` |
|
|
124
|
+
| `mockup-review` | `[]` |
|
|
125
|
+
| `ux-design` | `[]` |
|
|
117
126
|
|
|
118
127
|
## Output
|
|
119
128
|
|
|
@@ -32,17 +32,19 @@ printf '%s\n' '{"status":"completed","action":"end_human_gate","activateNext":tr
|
|
|
32
32
|
|
|
33
33
|
3. Re-read `status.json` (and the hook `followup_message`).
|
|
34
34
|
4. Invoke the subagent named in `status.currentAgent` / followup — do **not** advance the pipeline a second time.
|
|
35
|
-
3. **Review `changes_requested`** (not a human gate): set `currentAgent` to `feature-developer` (same index / find developer in steps), `state: in_progress`, then invoke developer. Do **not** call `end_human_gate` unless `activeHumanGateEventId` is set.
|
|
36
|
-
4.
|
|
37
|
-
5.
|
|
35
|
+
3. **Review `changes_requested`** (not a human gate): if `currentAgent` is **`mockup-reviewer`**, this is the FAIL-only mockup gate — do **not** retry `feature-developer`. Read `mockup-review.md` and resume via the human-gate path (`end_human_gate` / `activateNext`). Otherwise: set `currentAgent` to `feature-developer` (same index / find developer in steps), `state: in_progress`, then invoke developer. Do **not** call `end_human_gate` unless `activeHumanGateEventId` is set.
|
|
36
|
+
4. **`blocked` + `currentAgent: mockup-reviewer`** (`BLOCKED_MCP`): skip-forward via the same `end_human_gate`/`activateNext` path (explicit «proceed without MCP»). Do not invent DS claims.
|
|
37
|
+
5. **Other resume**: restore `pipelineIndex` / `currentAgent` from status and invoke that agent.
|
|
38
|
+
6. After the invoked agent completes, `chain-team-phases.sh` on `subagentStop` continues the chain when `autoChain: true`.
|
|
38
39
|
|
|
39
40
|
## Artifacts for handoff
|
|
40
41
|
|
|
41
42
|
| Agent | Read |
|
|
42
43
|
|-------|------|
|
|
43
|
-
| feature-developer | brief.md (incl. **Related specs**), decomposition.md, validation-report.md (if retry), review.md (if retry), architecture.md; if `docs/specs/INDEX.md` exists → load **`product-specs`** |
|
|
44
|
+
| feature-developer | brief.md (incl. **Related specs**), decomposition.md, ux-design.md (if present), mockup-review.md (if present), validation-report.md (if retry), review.md (if retry), architecture.md; if `docs/specs/INDEX.md` exists → load **`product-specs`** |
|
|
44
45
|
| build-verifier | git diff, decomposition.md |
|
|
45
46
|
| code-reviewer | brief.md, validation-report.md, git diff |
|
|
47
|
+
| mockup-reviewer | mockup-review.md |
|
|
46
48
|
| qa-tester | brief.md, decomposition.md, scope from pipeline step |
|
|
47
49
|
|
|
48
50
|
## Product specs (docs/specs)
|
|
@@ -22,6 +22,8 @@ Examples:
|
|
|
22
22
|
- `/task Write a changelog for the filters release`
|
|
23
23
|
- `/task Review my changes in store/orders`
|
|
24
24
|
- `/task Write e2e for the payment scenario`
|
|
25
|
+
- `/task Review mockup https://figma.com/design/...`
|
|
26
|
+
- `/task Design UX flows for Order History` (no Figma)
|
|
25
27
|
|
|
26
28
|
## Algorithm
|
|
27
29
|
|
|
@@ -135,6 +135,7 @@ const DEFAULT_ARTIFACT_OUTPUT_IDS = {
|
|
|
135
135
|
'security-reviewer': 'security-review',
|
|
136
136
|
'accessibility-reviewer': 'a11y-review',
|
|
137
137
|
'performance-auditor': 'perf-report',
|
|
138
|
+
'mockup-reviewer': 'mockup-review',
|
|
138
139
|
'api-contract-reviewer': 'api-contract-review',
|
|
139
140
|
'tech-writer': 'documentation',
|
|
140
141
|
};
|
|
@@ -313,6 +314,8 @@ const AGENT_HANDOFF = {
|
|
|
313
314
|
`Invoke accessibility-reviewer (readonly) for slug "${s}". Review UI diff; write a11y-review.md. Upsert the owned terminal receipt in artifact-manifest.json; do not mutate status.json lifecycle fields.`,
|
|
314
315
|
'performance-auditor': (s) =>
|
|
315
316
|
`Invoke performance-auditor (readonly) for slug "${s}". Write perf-report.md. Upsert the owned terminal receipt in artifact-manifest.json; do not mutate status.json lifecycle fields.`,
|
|
317
|
+
'mockup-reviewer': (s) =>
|
|
318
|
+
`Invoke mockup-reviewer (readonly) for slug "${s}". Write mockup-review.md. Load requestable mockup-review skill/rule. Upsert the owned terminal receipt in artifact-manifest.json; do not mutate status.json lifecycle fields.`,
|
|
316
319
|
'code-reviewer': (s) =>
|
|
317
320
|
`Invoke code-reviewer subagent (readonly) for slug "${s}". Review git diff vs brief.md per code-review-mr.mdc. ` +
|
|
318
321
|
`Upsert the owned terminal receipt in artifact-manifest.json; do not mutate status.json lifecycle fields.`,
|
|
@@ -600,6 +603,18 @@ if (currentStep?.parallel && stepAgents.length > 1) {
|
|
|
600
603
|
}
|
|
601
604
|
|
|
602
605
|
const retryReviewer = stepAgents.find((agent) => outcomes[agent]?.outcome === 'changes_requested');
|
|
606
|
+
if (retryReviewer === 'mockup-reviewer') {
|
|
607
|
+
beginHumanGate();
|
|
608
|
+
writeStatus({
|
|
609
|
+
awaitingHumanGate: true,
|
|
610
|
+
state: 'awaiting_approval',
|
|
611
|
+
currentAgent: 'mockup-reviewer',
|
|
612
|
+
parallelCompleted: [],
|
|
613
|
+
parallelOutcomes: {},
|
|
614
|
+
});
|
|
615
|
+
out(`Mockup review FAIL for slug "${slug}". Read mockup-review.md. Resume only via /task-continue. Do not retry feature-developer.`);
|
|
616
|
+
process.exit(0);
|
|
617
|
+
}
|
|
603
618
|
if (retryReviewer) {
|
|
604
619
|
const retryAfterFixStepIndex = idx;
|
|
605
620
|
const predecessor = outcomes[retryReviewer]
|
|
@@ -632,6 +647,17 @@ if (status.state === 'blocked') {
|
|
|
632
647
|
process.exit(0);
|
|
633
648
|
}
|
|
634
649
|
|
|
650
|
+
if (status.state === 'changes_requested' && (completedAgent === 'mockup-reviewer' || status.currentAgent === 'mockup-reviewer')) {
|
|
651
|
+
beginHumanGate();
|
|
652
|
+
writeStatus({
|
|
653
|
+
awaitingHumanGate: true,
|
|
654
|
+
state: 'awaiting_approval',
|
|
655
|
+
currentAgent: 'mockup-reviewer',
|
|
656
|
+
});
|
|
657
|
+
out(`Mockup review FAIL for slug "${slug}". Read mockup-review.md. Resume only via /task-continue. Do not retry feature-developer.`);
|
|
658
|
+
process.exit(0);
|
|
659
|
+
}
|
|
660
|
+
|
|
635
661
|
if (status.state === 'changes_requested') {
|
|
636
662
|
const reviewer = status.currentAgent || finishedAttempt?.entry?.agent;
|
|
637
663
|
if (!reviewer) {
|
|
@@ -21,7 +21,7 @@ Special Cursor Rule format:
|
|
|
21
21
|
|
|
22
22
|
- **`alwaysApply: true`** (Cursor) / **without `paths:`** (Claude) — base invariants only (**3**):
|
|
23
23
|
- `svelte-app-core`, `package-manager`, `code-quality-and-refactoring`
|
|
24
|
-
- **On-demand / requestable** — `post-change-lint` (**required after code edits**, not always-on), `agent-team-intake` (via orchestrator/commands), `agent-team-orchestrator`, architecture, imports, UI, tests, feature-delivery-workflow, `design-guidance`, `anti-sycophancy-discipline`, `svelte-sveltekit-anti-hallucination`, reference-features, product-specs, product-specs-authoring, sveltekit-routing, `security-sveltekit`, svelte-a11y-coding, `technical-retro`
|
|
24
|
+
- **On-demand / requestable** — `post-change-lint` (**required after code edits**, not always-on), `agent-team-intake` (via orchestrator/commands), `agent-team-orchestrator`, architecture, imports, UI, tests, feature-delivery-workflow, `design-guidance`, `anti-sycophancy-discipline`, `svelte-sveltekit-anti-hallucination`, reference-features, product-specs, product-specs-authoring, sveltekit-routing, `security-sveltekit`, svelte-a11y-coding, `technical-retro`, `mockup-review`, `ux-design`
|
|
25
25
|
- **Preset author meta** (globs `packages/ai-rules/presets/**`, never alwaysApply): `preset-layering`, `preset-twin-sync`, `preset-token-budget`, `preset-pr-checklist`, `preset-no-cross-stack-leakage`
|
|
26
26
|
- **Skills** — long procedures (`feature-delivery`, `svelte-performance`, `code-review`, …)
|
|
27
27
|
|
|
@@ -42,6 +42,8 @@ SoT prose: `packages/ai-rules/presets/_shared/core/**` (see `_shared/README.md`)
|
|
|
42
42
|
| `architecture/product-specs-authoring.md` | `product-specs-authoring.mdc` | Generate/Bootstrap contract; requestable |
|
|
43
43
|
| `review/code-review-mr.md` | `code-review-mr.mdc` | SvelteKit checklist refs |
|
|
44
44
|
| `review/technical-retro.md` | `technical-retro.mdc` | thin alias |
|
|
45
|
+
| `review/mockup-review.md` | `mockup-review.mdc` | Stack notes breakpoints; requestable |
|
|
46
|
+
| `review/ux-design.md` | `ux-design.mdc` | Stack notes form-factor; requestable |
|
|
45
47
|
| `meta/preset-*.md` | `preset-*.mdc` | author-only globs |
|
|
46
48
|
|
|
47
49
|
Claude twins + Cursor→Claude map: `presets/claude/svelte/rules/README.md`.
|
|
@@ -28,7 +28,7 @@ Work request without `/task` — see **`agent-team-intake.mdc`** (when to sugges
|
|
|
28
28
|
| Agent | App / prod writes | Typical intent |
|
|
29
29
|
|-------|-------------------|----------------|
|
|
30
30
|
| `task-router` | no (team only) | Every `/task` — writes `pipeline.json` |
|
|
31
|
-
| `task-analyst` | no (team only) | feature, refactor, test-only, a11y, docs-only, migration |
|
|
31
|
+
| `task-analyst` | no (team only) | feature, refactor, test-only, a11y, docs-only, migration, ux-design |
|
|
32
32
|
| `solution-architect` | no (team only) | spike, complex cross-layer feature |
|
|
33
33
|
| `migration-specialist` | no (team only) | migration — phased upgrade plan |
|
|
34
34
|
| `api-contract-reviewer` | no (team only) | new/changed backend API contracts |
|
|
@@ -38,6 +38,7 @@ Work request without `/task` — see **`agent-team-intake.mdc`** (when to sugges
|
|
|
38
38
|
| `build-verifier` | no (team only) | lint/typecheck/unit gate after developer; preset-structure when editing presets |
|
|
39
39
|
| `accessibility-reviewer` | no (team only) | a11y, UI-heavy feature |
|
|
40
40
|
| `performance-auditor` | no (team only) | perf-audit, perf-sensitive feature |
|
|
41
|
+
| `mockup-reviewer` | no (team only) | mockup-review, feature/refactor/spike/spec-gen with `figma.com` |
|
|
41
42
|
| `code-reviewer` | no (team only) | most pipelines, review-only |
|
|
42
43
|
| `security-reviewer` | no (team only) | auth, forms, sensitive data |
|
|
43
44
|
| `qa-tester` | tests only | feature, bugfix, test-only |
|
|
@@ -53,6 +54,8 @@ Work request without `/task` — see **`agent-team-intake.mdc`** (when to sugges
|
|
|
53
54
|
|
|
54
55
|
Full prompts: `.cursor/agents/*.md`. Artifact conventions: `.cursor/team/README.md`; schema SoT: **agent-artifact-contracts**.
|
|
55
56
|
|
|
57
|
+
**Behavioral UX:** `task-analyst` loads requestable skill `ux-design` for standalone intent `ux-design` and embedded required-signal / advisory UI AC. No `ux-designer` agent in v1.
|
|
58
|
+
|
|
56
59
|
**Product specs:** When `/task`, `/feature-start`, or `/spec-start` touches pages/features/`docs/specs`: if INDEX exists and no generate intent → instruct next agent to load requestable **`product-specs`** (consume; soft-fail; never invent). If generate/bootstrap/`spec-gen` → load **`product-specs-authoring`** + skill **`spec-authoring`** inside **task-analyst** (not a separate pipeline step); pass created spec paths + INDEX diff in handoff; human gate must approve before feature-developer. No-op if INDEX absent and no author intent.
|
|
57
60
|
|
|
58
61
|
When editing `packages/ai-rules/presets/**`, follow **`preset-pr-checklist.mdc`** (+ twin-sync / layering / token-budget / leakage meta-rules).
|
|
@@ -147,8 +150,8 @@ On each `subagentStop`, the hook reconciles `status.state` from the completing p
|
|
|
147
150
|
2. Read `pipeline.json` before every subagent invocation.
|
|
148
151
|
3. One role per Task call — **except** parallel steps: multiple Task calls in one message.
|
|
149
152
|
4. **Never** skip `humanGates` without `/task-continue` or explicit user approval.
|
|
150
|
-
5. Persist handoffs to disk and update the producer-owned terminal receipt in `artifact-manifest.json`; Markdown remains detailed evidence.
|
|
151
|
-
6. On `changes_requested` from reviewers: hook sets `retryAfterFix` → developer → same reviewer.
|
|
153
|
+
5. Persist handoffs to disk (including `mockup-review.md` and `ux-design.md` when those producers ran) and update the producer-owned terminal receipt in `artifact-manifest.json`; Markdown remains detailed evidence.
|
|
154
|
+
6. On `changes_requested` from reviewers: hook sets `retryAfterFix` → developer → same reviewer. Exception: embedded `mockup-reviewer` FAIL → `awaiting_approval` / `/task-continue` only — do **not** retry `feature-developer`.
|
|
152
155
|
7. On `validation_failed` from `build-verifier`: hook sets `retryAfterFix: build-verifier` → developer → build-verifier.
|
|
153
156
|
8. When all steps complete, suggest `/technical-retro <slug>`.
|
|
154
157
|
9. If `autoChain: false` in pipeline, do not rely on hook — manual step only.
|
|
@@ -9,6 +9,8 @@ alwaysApply: false
|
|
|
9
9
|
|
|
10
10
|
## Stack notes
|
|
11
11
|
|
|
12
|
+
When the prompt or `brief.md` contains a `figma.com` URL, **mockup review** (`mockup-reviewer` / skill `mockup-review`) must complete — or the user must continue past FAIL/`BLOCKED_MCP` via `/task-continue` — **before UI implementation**. Non-UI tasks no-op this gate. When required-signal and **no** `figma.com`, **`ux-design.md`** (on the analysis manifest entry) must exist and not be `INCOMPLETE` before UI work — else **blocked**, hand back to `task-analyst`. Parallel to the mockup gate.
|
|
13
|
+
|
|
12
14
|
Typical feature with backend data and shared state. Layer details — `architecture-boundaries.mdc`, `svelte-app-core.mdc`.
|
|
13
15
|
|
|
14
16
|
Canonical paths: `src/routes/**`, `src/lib/{components,stores,api,clients,types}/**`, `tests/e2e/**`. Aliases: `$lib` preferred; `@/` if configured. State: `store-svelte` (runes primary; legacy stores secondary).
|
|
@@ -0,0 +1,116 @@
|
|
|
1
|
+
---
|
|
2
|
+
description: Figma mockup review checklist (DS, coverage, viewports). On-demand — load via mockup-reviewer / skill mockup-review.
|
|
3
|
+
alwaysApply: false
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
<!-- shared-core: review/mockup-review.md -->
|
|
7
|
+
|
|
8
|
+
# Mockup review checklist
|
|
9
|
+
|
|
10
|
+
On-demand reviewer checklist for Figma mockups. **Procedure:** skill `mockup-review`. **Agent:** `mockup-reviewer`. Do not inline this checklist into the agent prompt.
|
|
11
|
+
|
|
12
|
+
Stack-agnostic: no app-source globs, Playwright, or `xcodebuild`. Breakpoint **examples** live in adapter **Stack notes** only — do not FAIL on exact pixels.
|
|
13
|
+
|
|
14
|
+
## When to load
|
|
15
|
+
|
|
16
|
+
- Pipeline step `mockup-reviewer` (standalone intent `mockup-review` or embedded after analyst)
|
|
17
|
+
- Prompt or `brief.md` contains a `figma.com` URL on a UI-capable stack
|
|
18
|
+
- User asks to review a mockup / Figma file (not a code MR)
|
|
19
|
+
|
|
20
|
+
## Inputs
|
|
21
|
+
|
|
22
|
+
1. Task `artifact-manifest.json`, then prompt Figma URL(s); `brief.md` / `decomposition.md` when present
|
|
23
|
+
2. Skill `mockup-review` + this rule
|
|
24
|
+
3. If plugin skills `figma-use` / `figma-design-to-code` are installed: **reference** them for URL parse and MCP invocation only — do not copy their bodies; do not run design-to-code
|
|
25
|
+
|
|
26
|
+
## MCP-first
|
|
27
|
+
|
|
28
|
+
Required when MCP is up: `get_metadata`, `get_design_context`, `search_design_system`, `get_variable_defs`, `get_screenshot`. Optional: `get_libraries`, `get_code_connect_map`.
|
|
29
|
+
|
|
30
|
+
**Forbidden:** `use_figma`, `create_new_file`, `generate_*`, `weave_*`, `upload_assets`, `send_code_connect_mappings`. FigJam URL → `BLOCKED_MCP` / out of scope (do not call `get_figjam` unless the URL is a FigJam board — then still `BLOCKED_MCP`).
|
|
31
|
+
|
|
32
|
+
Cite `fileKey` + node IDs. Screenshots are supporting evidence, not a second reviewer. No screenshot-only path.
|
|
33
|
+
|
|
34
|
+
**Node caps:** ≤12 screen-level frames; `get_metadata` depth ≤3 named-frame levels; ≤3 screenshots (prefer one per small/medium/large). `search_design_system` once; `get_variable_defs` once per file. No node-id on URL: pick top-level frames matching the feature name; if still unbounded → `BLOCKED_MCP` (or `PASS_WITH_NOTES` only if MCP returned a tiny file) — do not dump the whole file.
|
|
35
|
+
|
|
36
|
+
**Degradation:** MCP unavailable or OAuth fail → verdict `BLOCKED_MCP`. Do **not** invent DS compliance claims.
|
|
37
|
+
|
|
38
|
+
## Review dimensions
|
|
39
|
+
|
|
40
|
+
### DS components (AC-4)
|
|
41
|
+
|
|
42
|
+
When an attached library is detectable (`search_design_system` / `get_metadata`): list **library component instances vs custom frames** with file/node references. Flag substitutions where a DS equivalent exists.
|
|
43
|
+
|
|
44
|
+
- Critical DS reimplementation (custom frame where an attached-library component exists) → **FAIL**
|
|
45
|
+
- One-off frame, no DS equivalent; mixed/unpublished library → WARN or notes (`PASS_WITH_NOTES`)
|
|
46
|
+
- No attached library detectable → notes only; do not invent DS claims (`PASS_WITH_NOTES`)
|
|
47
|
+
|
|
48
|
+
Confidence: `high` (MCP library match) / `low` (unpublished or mixed) — prefer `PASS_WITH_NOTES` over FAIL when confidence is low.
|
|
49
|
+
|
|
50
|
+
### Tokens (AC-5)
|
|
51
|
+
|
|
52
|
+
When variables/styles are available (`get_variable_defs`, style metadata): flag fills, strokes, spacing, or typography that use raw values instead of bound variables/styles.
|
|
53
|
+
|
|
54
|
+
- Isolated unbound values → **WARN** (`PASS_WITH_NOTES`)
|
|
55
|
+
- Wholesale token ignore on a library-attached file (systemic; treat as critical DS with AC-4) → **FAIL**
|
|
56
|
+
|
|
57
|
+
### Quality (AC-6)
|
|
58
|
+
|
|
59
|
+
Cover at minimum, each item PASS / WARN / FAIL eligible:
|
|
60
|
+
|
|
61
|
+
- Layer/frame naming hygiene
|
|
62
|
+
- Auto-layout vs absolute positioning for responsive regions
|
|
63
|
+
- Text style usage
|
|
64
|
+
- Component variant/property correctness
|
|
65
|
+
- Detached or orphaned component instances
|
|
66
|
+
|
|
67
|
+
Naming hygiene, minor detached instances, text-style drift → **WARN**. Detached **core** DS component that is a substitution → **FAIL** (same as AC-4 critical). Absolute layout on a region that is the only «responsive» evidence → WARN unless it also fails viewports.
|
|
68
|
+
|
|
69
|
+
### Feature coverage (AC-7)
|
|
70
|
+
|
|
71
|
+
Map **flows → screens/frames**, **actions → interactive elements**, and **states** (empty, loading, error, success, disabled/validation). List explicit **missing** items. Label scope **`inferred`** when only a URL is provided (no brief AC).
|
|
72
|
+
|
|
73
|
+
- Missing **core** flow or primary action from brief AC (or labeled `inferred` primary flow from the URL) → **FAIL**
|
|
74
|
+
- Missing empty/loading/error/success on a form/list called out in AC → **FAIL**
|
|
75
|
+
- Missing secondary states (disabled/validation) not in AC → **WARN**
|
|
76
|
+
|
|
77
|
+
### Viewports (AC-8)
|
|
78
|
+
|
|
79
|
+
Verify **≥3 viewport representations** (small / medium / large) via dedicated frames, Figma viewport presets, or responsive component variants.
|
|
80
|
+
|
|
81
|
+
- Fewer than 3 → **FAIL**
|
|
82
|
+
- 3 exist but sizes ≠ stack example buckets → **WARN** only (no exact pixel enforcement in core)
|
|
83
|
+
|
|
84
|
+
## Severity (v1)
|
|
85
|
+
|
|
86
|
+
Isolated **WARN** never blocks. Overall verdict = worst FAIL > BLOCKED_MCP > PASS_WITH_NOTES > PASS. Multiple WARNs without FAIL → `PASS_WITH_NOTES`, not FAIL.
|
|
87
|
+
|
|
88
|
+
## Report headings
|
|
89
|
+
|
|
90
|
+
Write `mockup-review.md` with these headings (must match the agent template):
|
|
91
|
+
|
|
92
|
+
```markdown
|
|
93
|
+
# Mockup review: <slug>
|
|
94
|
+
|
|
95
|
+
## Verdict
|
|
96
|
+
PASS | PASS_WITH_NOTES | FAIL | BLOCKED_MCP
|
|
97
|
+
|
|
98
|
+
## Scope
|
|
99
|
+
- Figma fileKey / node IDs
|
|
100
|
+
- MCP: available | unavailable (reason)
|
|
101
|
+
- Feature scope source: brief AC | prompt | inferred
|
|
102
|
+
|
|
103
|
+
## Critical (must fix)
|
|
104
|
+
## Warnings (should fix)
|
|
105
|
+
## Suggestions
|
|
106
|
+
## DS compliance (AC-4, AC-5)
|
|
107
|
+
## Quality (AC-6)
|
|
108
|
+
## Feature coverage (AC-7)
|
|
109
|
+
## Viewport matrix (AC-8)
|
|
110
|
+
## AC coverage
|
|
111
|
+
| Criterion | Status | Notes |
|
|
112
|
+
```
|
|
113
|
+
|
|
114
|
+
## Stack notes
|
|
115
|
+
|
|
116
|
+
Illustrative web buckets (not enforced pixels): ~375 / ~768 / ~1280 mapped to small / medium / large.
|