@bonesofspring/ai-rules 0.2.10 → 0.2.12

package/presets/cursor/mcp-ts/rules/technical-retro.mdc

@@ -0,0 +1,16 @@
+---
+description: Technical retrospective facilitator (on-demand /technical-retro)
+alwaysApply: false
+---
+
+<!-- shared-core: review/technical-retro.md -->
+
+# Техническое ретро — rule alias
+
+Полный сценарий (включая блок **«Работа агентов»** для slug из team tasks) — в slash-команде:
+
+**`commands/technical-retro.md`** → `/technical-retro`
+
+When a task has `metrics.json`, use the local aggregation script and state the cohort, sample size, incomplete artifacts, attribution confidence, active attempt duration, and human-gate wait separately. Do not score malformed artifacts or gate wait as agent work.
+
+Используй rule только если command недоступен. Не дублируй содержимое command в ответе — следуй command-файлу и skill `technical-retro`.

package/presets/cursor/mcp-ts/rules/tests-unit.mdc

@@ -0,0 +1,31 @@
+---
+description: Unit testing conventions for MCP handlers and schemas
+globs:
+  - **/*.{test,spec}.{ts,tsx,js}
+  - **/__tests__/**/*
+alwaysApply: false
+---
+
+# Unit tests (MCP)
+
+- Table-driven tests for schema parse failures and handler outcomes.
+- Test **pure** handler logic with fakes for FS/network capabilities — no live MCP client required.
+- Cover invalid inputs that schemas should reject **before** side effects.
+- Prefer repository runner (Vitest/Jest/node:test) discovered via tooling rules.
+
+## Required shapes (when capability applies)
+
+- `schema.parse` / Zod: valid input; missing field; wrong type; empty string where non-empty required.
+- Path tools: reject `../` escape and symlink-outside-root (fake FS); accept in-root relative paths.
+- URL/fetch tools: deny blocked hosts (metadata IP, link-local) when allowlist is in play.
+- Auth-sensitive handlers: assert secrets never appear in returned content or thrown messages.
+
+## Forbidden smells
+
+- Hitting real external APIs in unit tests without an explicit integration harness and AC.
+- Asserting on unstable SDK private fields.
+- Browser e2e frameworks (Playwright) as the unit gate.
+
+## Naming
+
+- `toolName.validInput`, `toolName.rejectsPathTraversal`, `schema.parse.*` — follow repo style.

package/presets/cursor/mcp-ts/skills/README.md

@@ -0,0 +1,12 @@
+# Skills (mcp-ts Phase 1)
+
+| Skill | Use |
+|-------|-----|
+| `feature-delivery` | End-to-end MCP feature flow |
+| `unit-testing` | Schema/handler unit tests |
+| `code-review` | Diff review checklist |
+| `debug-investigation` | Bug investigation |
+
+Phase 2 may add `ci-investigation`, `technical-retro`, `write-adr`, `mcp-contract-testing` skills.
+
+Until then: `/technical-retro` uses `commands/technical-retro.md` (no skill required); review-only uses skill `code-review` on the parent (no `code-reviewer` agent).

package/presets/cursor/mcp-ts/skills/code-review/SKILL.md

@@ -0,0 +1,10 @@
+---
+name: code-review
+description: Reviews MCP TypeScript diffs for boundaries, schema contracts, capability scope, and secrets. Use for MR review or when code-review workflow is requested.
+---
+
+# Code review (mcp-ts)
+
+1. Follow `code-review-mr.mdc`, `mcp-server-boundaries.mdc`, `mcp-tool-design.mdc`, `security-mcp.mdc`.
+2. Flag monolithic entry files, schema/protocol mismatches, unscopeed capabilities, secret leakage.
+3. Phase 1: security-reviewer covers threat model; no separate `code-reviewer` agent yet — parent may apply this skill directly.

package/presets/cursor/mcp-ts/skills/debug-investigation/SKILL.md

@@ -0,0 +1,11 @@
+---
+name: debug-investigation
+description: Investigates MCP server bugs with runtime evidence — schema failures, handler errors, transport startup. Use for failing tests or incorrect tool behavior.
+---
+
+# Debug investigation (mcp-ts)
+
+1. Reproduce with unit/contract fixtures before changing code.
+2. Check schema validation vs handler logic vs registration wiring.
+3. Prefer repository tests over ad-hoc Inspector-only claims.
+4. Load `anti-sycophancy-discipline` — report what was verified.

package/presets/cursor/mcp-ts/skills/feature-delivery/SKILL.md

@@ -0,0 +1,29 @@
+---
+name: feature-delivery
+description: Delivers TypeScript MCP server features end-to-end across contracts, schemas, handlers, registration, tests, and package validation. Use when implementing or extending a feature, especially through /task or feature-developer.
+---
+
+# Feature Delivery (mcp-ts)
+
+1. Read brief, AC, and decomposition.
+2. Follow `feature-delivery-workflow.mdc` + `reference-features.mdc`: contract → schema → handler → register → unit/contract tests → package validation.
+3. Keep transport/lifecycle in the entry module; tools stay in registration modules.
+4. After TS edits: **invoke** `post-change-test.mdc` (+ `mcp-ts-tooling.mdc`).
+
+## Do / Don't
+
+- **Do** Zod-first authoring with JSON Schema-compatible protocol contracts.
+- **Don't** invent SDK APIs; use VERIFY markers / Context7.
+- **Don't** use Playwright, XCUITest, Next lint, or Go tools as this stack's gate.
+
+## Scope discipline
+
+Implement only the current AC / decomposition task. See `feature-developer` → **Zero improvisation**.
+
+## Handoff
+
+Summarize by layer + validation. Update `.cursor/team/tasks/<slug>/status.json`.
+
+## Design guidance
+
+- Load `design-guidance` (rule stem) when assessing structure, smells, or pattern fit.

package/presets/cursor/mcp-ts/skills/unit-testing/SKILL.md

@@ -0,0 +1,16 @@
+---
+name: unit-testing
+description: Plans and writes unit tests for MCP schemas and handlers using the repository test runner. Use for schema/handler coverage and fixing failing unit tests.
+---
+
+# Unit testing (mcp-ts)
+
+1. Prefer table-driven tests for schema reject/accept and handler outcomes.
+2. Fake FS/network capabilities — no live MCP client required for unit scope.
+3. Follow `tests-unit.mdc` and `mcp-contract-testing.mdc`.
+4. Discover runner via `mcp-ts-tooling` (Vitest/Jest/node:test).
+
+## Out of scope (Phase 1)
+
+- Dedicated `contract-test-*` agents (Phase 2).
+- Browser e2e (Playwright) — forbidden.

package/presets/cursor/mcp-ts/team/README.md

@@ -0,0 +1,25 @@
+# Team artifacts (mcp-ts)
+
+| Path | Purpose |
+|------|---------|
+| `tasks/<slug>/` | Pipeline artifacts (`brief.md`, `status.json`, …) |
+| `fixtures/` | Example pipelines for dogfood |
+| `conventions.md` | Living gotchas (consumer-owned) |
+
+Phase 1 agents: see `agents/README.md`.
+
+## Fixture policy (Phase 1)
+
+`team/fixtures/*.json` may list in `skipped[]` **only** agents that exist in the Phase 1 roster:
+
+`task-router`, `task-analyst`, `solution-architect`, `feature-developer`, `build-verifier`, `security-reviewer`.
+
+Do **not** name Phase 2 agents (`contract-test-*`, `debugger`, Playwright stems, etc.) in fixture JSON — even as skips. Defer those until the agents ship.
+
+## Local metrics ledger
+
+`metrics.json` is an append-only schema-v1 event ledger for one task run. It contains only allowlisted IDs, task dimensions, timestamps, outcomes, and attribution confidence—never prompts, secrets, file paths, or contents. The router writes `task_started` / `attempt_started`; the hook records host-clock completion and human-gate edges under a per-task lock with temp-and-rename.
+
+`status.json.activeAttempts` is a transient timing bridge keyed by `attemptId`; `lastCompletedAttempt` is diagnostic. For parallel stops, the hook must use a stable payload identity or the sole active attempt. Otherwise an explicit `.metrics-receipts.json` receipt is fallback data marked `source: agent`, `attributionConfidence: fallback`; it must never guess from `currentAgent`.
+
+Aggregate with `node packages/ai-rules/scripts/aggregate-agent-task-metrics.mjs --team-root .cursor/team`. It reports role/agent count, completed count, total/average duration, distinct completed run IDs, separate human-gate wait, and incomplete artifacts.

package/presets/cursor/mcp-ts/team/conventions.md

@@ -0,0 +1,14 @@
+# Team conventions (mcp-ts)
+
+Fill after init with living gotchas for this MCP server repo.
+
+## Suggested topics
+
+- Package manager + test/typecheck scripts actually used
+- SDK version pin and VERIFY notes
+- stdio entry / `bin` packaging
+- Capability allowlists (FS roots, outbound hosts)
+
+## Fixture policy
+
+Phase 1 fixtures: `skipped[]` may name only Phase 1 roster agents (see `team/README.md`).

package/presets/cursor/mcp-ts/team/fixtures/bugfix-standard.json

@@ -0,0 +1,32 @@
+{
+  "slug": "example-schema-bugfix",
+  "intent": "bugfix",
+  "profile": "standard",
+  "summary": "Fix schema validation rejecting valid tool input",
+  "steps": [
+    {
+      "agent": "task-analyst",
+      "label": "Reproduce + AC"
+    },
+    {
+      "agent": "feature-developer",
+      "label": "Fix schema/handler + tests"
+    },
+    {
+      "agent": "build-verifier",
+      "label": "typecheck + tests"
+    }
+  ],
+  "humanGates": [],
+  "autoChain": true,
+  "skipped": [
+    {
+      "agent": "security-reviewer",
+      "reason": "Proven schema/style-only bugfix — no auth/**, secrets, or FS/net capability change (document skip; otherwise route security-reviewer)"
+    },
+    {
+      "agent": "solution-architect",
+      "reason": "Localized schema bugfix"
+    }
+  ]
+}

package/presets/cursor/mcp-ts/team/fixtures/feature-full.json

@@ -0,0 +1,33 @@
+{
+  "slug": "example-add-tool-full",
+  "intent": "feature",
+  "profile": "full",
+  "summary": "Add MCP tool with schema, handler, registration, and tests",
+  "steps": [
+    {
+      "agent": "task-analyst",
+      "label": "Brief + decomposition"
+    },
+    {
+      "agent": "feature-developer",
+      "label": "contract→schema→handler→register→test→package"
+    },
+    {
+      "agent": "build-verifier",
+      "label": "typecheck + tests"
+    },
+    {
+      "agent": "security-reviewer",
+      "label": "Capability / secrets review",
+      "model": "strong"
+    }
+  ],
+  "humanGates": ["after:task-analyst"],
+  "autoChain": true,
+  "skipped": [
+    {
+      "agent": "solution-architect",
+      "reason": "Straightforward tool add; architecture spike not required"
+    }
+  ]
+}

package/presets/cursor/mcp-ts/team/fixtures/feature-light.json

@@ -0,0 +1,34 @@
+{
+  "slug": "example-add-tool-light",
+  "intent": "feature",
+  "profile": "light",
+  "summary": "Add a single MCP tool with explicit AC",
+  "steps": [
+    {
+      "agent": "feature-developer",
+      "label": "Implement tool schema/handler/register",
+      "model": "cheap"
+    },
+    {
+      "agent": "build-verifier",
+      "label": "typecheck + tests",
+      "model": "cheap"
+    }
+  ],
+  "humanGates": [],
+  "autoChain": true,
+  "skipped": [
+    {
+      "agent": "task-analyst",
+      "reason": "Explicit AC and single-tool scope"
+    },
+    {
+      "agent": "security-reviewer",
+      "reason": "Light profile valid only with no FS/net/auth expansion — otherwise use standard/full and include security-reviewer"
+    },
+    {
+      "agent": "solution-architect",
+      "reason": "Light profile — no architecture spike"
+    }
+  ]
+}

package/presets/cursor/next/agents/build-verifier.md

@@ -36,14 +36,14 @@ When validating **preset packaging** changes (paths under `packages/ai-rules/pre
 2. **Leakage (next):** hooks/agents must not require `xcuitest-test-*` handoffs or `xcodebuild` as the default Next post-change gate. See `preset-no-cross-stack-leakage.mdc`.
 3. **Mapping / README:** `claude/next/rules/README.md` must include a Cursor→Claude mapping table; stack `rules/README.md` should document core→stack mapping when `_shared` consumers exist.
 4. **shared-core consumers:** if `_shared/core/**` changed, every file with matching `<!-- shared-core: … -->` in this PR must be updated (or intentional fork documented in validation-report).
-5. **Twin presence:** Cursor rule change without Claude twin same PR → **FAIL** (next, ios-swift, go, and java). Domain twin body ≥15 lines; thin aliases (`agent-team-intake`, `technical-retro`) may be shorter.
+5. **Twin presence:** Cursor rule change without Claude twin same PR → **FAIL** (next, ios-swift, go, java, mcp-ts, php-hexagonal, and php-laravel). Domain twin body ≥15 lines; thin aliases (`agent-team-intake`, `technical-retro`) may be shorter.
 6. **Session-start body budget (soft→document, FAIL if grossly over):** sum body lines of the **3** intended always-on / session-start rules ≤ **140** (stretch ≤120); do **not** include `**/README.md`. Record the sum in validation-report.
 7. **Embed drift (hard in `check:preset-structure`):** run `packages/ai-rules/scripts/check-shared-core-drift.sh` with `AI_RULES_DRIFT_FAIL=1` (bundled by the structure orchestrator). Lineage stems are excluded from body equality.
 8. **Dogfood (monorepo soft):** if root `.cursor/` is in the PR, prefer sync via `packages/ai-rules/scripts/sync-dogfood-cursor.sh`; mass deletion of tracked dogfood without migration doc → note as risk / FAIL for maintainers.
 
-9. **Root AGENTS template:** each installable preset (`cursor|claude` × `next|ios-swift|go|java`) must ship `REPO_AGENTS.md` when validating preset packaging → **FAIL** if missing.
+9. **Root AGENTS template:** each installable preset (`cursor|claude` × `next|ios-swift|go|java|mcp-ts|php-hexagonal`) must ship `REPO_AGENTS.md` when validating preset packaging → **FAIL** if missing.
 10. **Hooks cookbook:** default `hooks.json` must **not** reference `hooks/examples/` → **FAIL** if it does.
-11. **No react-performance on ios/go/java:** skill directory / required handoff must be absent under ios-swift, go, and java → **FAIL** (leakage). Prefer `check:preset-leakage`.
+11. **No react-performance on ios/go/java:** skill directory / required handoff must be absent under ios-swift, go, java, mcp-ts, php-hexagonal, and php-laravel → **FAIL** (leakage). Prefer `check:preset-leakage`.
 12. **Rule eval (WARN):** `scripts/check-rule-eval.mjs` / `yarn check:rule-eval` should exist for maintainers; smoke optional. Hard fail only when the opt-in eval job runs — not part of default `check:preset-structure`.
 
 ### Soft notes

package/presets/cursor/next/agents/task-router.md

@@ -107,3 +107,7 @@ Write `.cursor/team/tasks/<slug>/pipeline.json` and initial `status.json` via th
 5. Invoke `steps[0].agent` now (unless `retro` → `/technical-retro`).
 
 Do not invoke implementation agents yourself.
+
+## Metrics initialization
+
+Alongside `pipeline.json` and `status.json`, create `metrics.json` with `schemaVersion: 1`, immutable task dimensions, `task_started`, and a generated `runId`. Before the parent invokes each agent, append `attempt_started` and set `status.activeAttempts[attemptId]` with agent, step index, attempt number, and host-clock `startedAt`. For parallel work create one entry per agent; do not use `currentAgent` to identify their completion.

package/presets/cursor/next/commands/task-continue.md

@@ -22,22 +22,19 @@ description: Continue an agent-team task after a human gate, pause, or review ch
 ## Алгоритм
 
 1. Запиши `.cursor/team/active-task.json` → `{ "slug": "<slug>" }`.
-2. Сбрось gate: `awaitingHumanGate: false`.
-3. Определи **следующий шаг**:
-   - После approval analyst/architect: `pipelineIndex + 1` → следующий agent в `steps`.
-   - После `changes_requested`: снова **feature-developer** (тот же index или найди developer в steps).
-4. Обнови `status.json`:
-   ```json
-   {
-     "pipelineIndex": <n>,
-     "currentAgent": "<steps[n].agent>",
-     "phase": "executing",
-     "state": "in_progress",
-     "awaitingHumanGate": false
-   }
-   ```
-5. Вызови subagent для `currentAgent` с контекстом slug и артефактов.
-6. Hook `chain-team-phases.sh` продолжит цепочку по `pipeline.json`, если `autoChain: true`.
+2. **Human gate resume** (`awaitingHumanGate` / `awaiting_approval`):
+   1. **Do not** manually increment `pipelineIndex` or invent `currentAgent` first.
+   2. Close the gate + activate the next attempt via the **installed** hook (single authority for ledger + status):
+
+```bash
+printf '%s\n' '{"status":"completed","action":"end_human_gate","activateNext":true}' | bash .cursor/hooks/chain-team-phases.sh
+```
+
+   3. Re-read `status.json` (and the hook `followup_message`).
+   4. Invoke the subagent named in `status.currentAgent` / followup — do **not** advance the pipeline a second time.
+3. **Review `changes_requested`** (not a human gate): set `currentAgent` to `feature-developer` (same index / find developer in steps), `state: in_progress`, then invoke developer. Do **not** call `end_human_gate` unless `activeHumanGateEventId` is set.
+4. **Other resume**: restore `pipelineIndex` / `currentAgent` from status and invoke that agent.
+5. After the invoked agent completes, `chain-team-phases.sh` on `subagentStop` continues the chain when `autoChain: true`.
 
 ## Артефакты для handoff
 
@@ -47,3 +44,7 @@ description: Continue an agent-team task after a human gate, pause, or review ch
 | build-verifier | git diff, decomposition.md |
 | code-reviewer | brief.md, validation-report.md, git diff |
 | qa-tester | brief.md, decomposition.md, scope from pipeline step |
+
+## Metrics
+
+On human-gate resume, the hook action above appends `human_gate_ended` under the per-task lock **before** any new `attempt_started`. Agents must not calculate durations.

package/presets/cursor/next/commands/task.md

@@ -48,3 +48,7 @@ description: Route a natural-language task through the agent-team pipeline: task
 ## Legacy
 
 `/feature-start` и `/feature-continue` остаются совместимыми; для новых задач предпочитай `/task`.
+
+## Metrics
+
+Initialize `metrics.json` before the first invocation with frozen task dimensions and `task_started`; add one `activeAttempts[attemptId]` entry plus `attempt_started` per scheduled agent. On `/task-continue`, append `human_gate_ended` (referencing the stored gate event) before activating the next attempt. Do not calculate durations in agents.

package/presets/cursor/next/commands/technical-retro.md

@@ -79,3 +79,7 @@ description: Facilitate a technical retrospective for a period, incident, releas
 - Не приписывать цитаты и факты без входа.
 - Не выдавать HR‑рекомендации.
 - Если просят только шаблон — **шаблон повестки** без выдуманного контента.
+
+### Metrics evidence
+
+When `metrics.json` exists, run the local aggregation script and report the cohort, sample size, incomplete artifacts, attribution confidence, active attempt duration, and human-gate wait separately. Do not treat gate wait or malformed ledgers as agent duration.