@bompus/house-rules 0.15.0 → 0.15.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bompus/house-rules",
-  "version": "0.15.0",
+  "version": "0.15.2",
   "description": "Composable working rules and skills for AI coding agents",
   "homepage": "https://github.com/bompus/house-rules#readme",
   "license": "MIT",

package/skills/hr-handoff/references/reconciliation.md

@@ -23,7 +23,12 @@ A predecessor plan needs no conversion. Name its `plan.md` as the source
 `file`; the checker reads each item line of its `## Ledger` section (`- [ ]`,
 `- [~]`, `- [x]`, `- [-]`) as a record named `L<line>` (`L12`). Other text in
 the section is not read, so turn any follow-up written there into an item line
-before the handoff. Take a copy of the plan as it stood at the handoff,
+before the handoff. Item lines elsewhere in the file are not read either. The
+checker counts them and reports a gap that names the first five lines (the open
+or deferred ones, when there are any), so the receipt is partial and cannot claim complete
+coverage until they move into the ledger section.
+
+Take a copy of the plan as it stood at the handoff,
 because later edits renumber the lines. Each open or deferred line must map to
 an item; a context-only reason such as "the rest, reopen only if asked" is
 rejected. When one item absorbs several open or deferred lines, give the item

package/skills/hr-handoff/references/successor-thread.md

@@ -57,7 +57,9 @@ registry row, the project and the thread id.
   ledger or source record still shows it open. An offer answered, completed,
   deferred or superseded since the handoff was written authorizes nothing. A
   bare code or `go` in the successor selects an offer only when one listed offer
-  is open. With several, it asks which one, as § Offers requires.
+  is open. With several, it asks which one, as § Offers requires. A thread that
+  holds no offer, such as a project Orchestrator, writes the list as "none"; an
+  empty list is not left out.
 - The inventory and read-backs from the skill's thread-move step. The
   receiving thread re-points to itself each item the host lets it bind:
   registry rows, scheduled tasks, pull request watches and the messaging name

package/skills/hr-handoff/scripts/check-reconciliation.mjs

@@ -56,18 +56,36 @@ function unique(entries, label) {
 // A plan file (`.md`) is read as its `## Ledger` item lines, one record per item, named `L<line>`;
 // other text in the section, wrapped continuation lines included, is not read.
 // Open (`- [ ]`) and deferred (`- [~]`) lines are remembered: they must carry over as items.
+// Item lines elsewhere in the file are not records either, but they are counted and reported as a gap.
 function ledgerRecords(raw) {
   const lines = raw.split(/\r?\n/);
   const start = lines.findIndex((line) => /^#{1,6}\s+Ledger\s*$/i.test(line));
   if (start < 0) return null;
   const level = lines[start].match(/^#+/)[0].length;
   const records = [];
-  for (let i = start + 1; i < lines.length; i++) {
-    if (new RegExp(`^#{1,${level}}\\s`).test(lines[i])) break;
+  const outside = [];
+  let inside = false;
+  for (let i = 0; i < lines.length; i++) {
+    if (i === start) inside = true;
+    else if (inside && new RegExp(`^#{1,${level}}\\s`).test(lines[i])) inside = false;
     const match = lines[i].match(/^\s*[-*]\s+\[([ x~-])\]\s+(.*)$/i);
-    if (match) records.push({ id: `L${i + 1}`, text: match[2], mark: match[1] });
+    if (!match) continue;
+    if (inside) records.push({ id: `L${i + 1}`, text: match[2], mark: match[1] });
+    else outside.push({ id: `L${i + 1}`, mark: match[1] });
   }
-  return { records };
+  return { records, outside };
+}
+
+function outsideGap(label, outside) {
+  const open = outside.filter((line) => /[ ~]/.test(line.mark));
+  const named = open.length > 0 ? open : outside;
+  const shown = named
+    .slice(0, 5)
+    .map((line) => line.id)
+    .join(", ");
+  const more = named.length > 5 ? ` and ${named.length - 5} more` : "";
+  const count = open.length > 0 ? `, ${open.length} of them open or deferred` : "";
+  return `${label}: ${outside.length} item line(s) outside the \`## Ledger\` section were not read${count} (${shown}${more}); move them into the ledger section`;
 }
 
 function check(receipt, directory) {
@@ -125,6 +143,8 @@ function check(receipt, directory) {
       errors.push(`${label}: snapshot must be an object`);
       continue;
     }
+    if (source.file.endsWith(".md") && data.outside.length > 0)
+      gaps.push(outsideGap(label, data.outside));
     const rows = unique(entries(data.records, `${label}.records`), `${label} record`);
     if (Number.isSafeInteger(source.expectedRecords) && source.expectedRecords !== rows.size) {
       gaps.push(`${label}: expected ${source.expectedRecords} records, read ${rows.size}`);

package/skills/hr-pr-followup/scripts/merge-pr.sh

@@ -28,6 +28,8 @@
 #
 # Exit status: 0 landed and every local default current; 1 refused or failed; 2 usage; 3 landed, local sync pending.
 # --idle-primary <path> is deprecated: accepted and ignored with a note on stderr, removed in a later release.
+# It takes the next argument as its path unless that argument is missing or starts with "-".
+# --preflight is not accepted here (unknown argument, exit 2); only verify-landed.sh still takes it.
 #
 # Usage: bash scripts/merge-pr.sh <pr> [--merge] [--remote <name>]
 set -euo pipefail

package/skills/hr-pr-followup/scripts/verify-landed.sh

@@ -26,8 +26,11 @@
 # verified, but a local checkout was skipped (local sync pending). After a failure, rerun this
 # script, not merge-pr.sh: the PR is already merged.
 #
-# Deprecated, accepted and ignored with a note on stderr, and removed in a later release:
-# --idle-primary <path> and --preflight. Landing no longer waits on any local checkout.
+# Deprecated, removed in a later release; landing no longer waits on any local checkout.
+# --idle-primary <path> is accepted and ignored with a note on stderr. It takes the next argument as its
+# path unless that argument is missing or starts with "-".
+# --preflight prints a note and "preflight skipped: it no longer gates landing" and exits 0 without
+# checking anything; with --commit or --branch it exits 2.
 # Usage:
 #   bash scripts/verify-landed.sh --commit <sha> [--default <branch>]
 #     [--branch <merged-head>] [--remote <name>] [--ff]

package/skills/hr-what-next/scripts/check-open-work.mjs

@@ -209,7 +209,11 @@ function parsePlan(text) {
       i > 0 &&
       (NARRATIVE.test(line) || PROSE_MARKER.test(line) || /^\s*[-*]\s+\[[ ~]\]/.test(line))
     )
-      narrative.push({ line: i + 1, text: line.trim() });
+      narrative.push({
+        line: i + 1,
+        text: line.trim(),
+        box: /^\s*[-*]\s+\[[ ~]\]/.test(line),
+      });
   });
   return { status, owner, purpose, project, items, errors, narrative };
 }
@@ -580,7 +584,15 @@ async function run(options) {
   };
   const open = plan.items.filter((item) => item.mark === " " || item.mark === "~");
   report.open = open.map(row);
-  if (report.errors.length) return report;
+  // A plan that fails its lint still gets every check that reads only its text. The checks that read the
+  // host (scratch, checkouts, the audit record, GitHub) wait until the plan is valid.
+  const invalid = report.errors.length > 0;
+  if (invalid) {
+    report.invalidPlan = true;
+    report.skipped.push(
+      "scratch, checkout, audit record and GitHub checks: they wait until the plan passes its lint",
+    );
+  }
   report.awaitingUser = open.filter(awaitsUser).map(row);
   if (TERMINAL_STATUS.test(plan.status) && open.length)
     report.findings.push(
@@ -588,7 +600,7 @@ async function run(options) {
     );
   const roots = notesRoot(planPath);
   const scratch = options.scratch ?? (roots ? join(roots.notes, "tmp") : null);
-  if (scratch) {
+  if (scratch && !invalid) {
     const { owned, unreadable } = ownedScratch(scratch, plan.owner);
     for (const manifest of unreadable)
       report.errors.push(
@@ -596,7 +608,7 @@ async function run(options) {
       );
     for (const name of owned) accountFor(`scratch ${name}`, [name], plan.items, report.findings);
   }
-  for (const path of options.checkouts) {
+  for (const path of invalid ? [] : options.checkouts) {
     const state = checkoutState(path);
     if (state.error) report.errors.push(state.error);
     else if (state.dirty || state.unpushed)
@@ -608,7 +620,7 @@ async function run(options) {
       );
   }
   // An app retires its own checkouts, so their state is reported but is not a finding.
-  for (const path of options.appManaged) {
+  for (const path of invalid ? [] : options.appManaged) {
     const state = checkoutState(path);
     if (state.error) report.errors.push(state.error);
     else if (state.dirty || state.unpushed)
@@ -620,20 +632,23 @@ async function run(options) {
     report.warnings.push(
       "no `Purpose:` line in the first 40 lines (the session's purpose, one sentence)",
     );
-  for (const entry of plan.narrative.slice(0, 5))
-    report.warnings.push(`L${entry.line} outside the ledger: ${clip(entry.text, 70)}`);
-  if (plan.narrative.length > 5)
-    report.warnings.push(`${plan.narrative.length - 5} more narrative marker line(s)`);
+  // Every unchecked box outside the ledger is a possible lost item, so each is listed. Prose labels such
+  // as "Deferred:" are listed up to five, with a count of the rest. Lines stay in file order.
+  let prose = 0;
+  for (const entry of plan.narrative)
+    if (entry.box || ++prose <= 5)
+      report.warnings.push(`L${entry.line} outside the ledger: ${clip(entry.text, 70)}`);
+  if (prose > 5) report.warnings.push(`${prose - 5} more narrative marker line(s)`);
   offerWarnings(plan.items, report.warnings);
   report.unansweredOffers = unansweredOffers(plan.items);
   if (report.unansweredOffers.length >= OFFER_LIMIT)
     report.warnings.push(
       `${report.unansweredOffers.length} offers are open and unanswered; the offers rule says to present no further offer at ${OFFER_LIMIT} or more. Queue the new decision in a walk-through (hr-what-next, Walk-through) instead`,
     );
-  const audit = plan.project && auditWarning(plan.project, roots, options.today);
+  const audit = !invalid && plan.project && auditWarning(plan.project, roots, options.today);
   if (audit) report.warnings.push(audit);
   report.recheckDue = rechecks(open, options.today, report.warnings);
-  report.stale = await possiblyFinished(open, options, report);
+  if (!invalid) report.stale = await possiblyFinished(open, options, report);
   if (options.archive && !report.errors.length) {
     if (!COMPLETED_STATUS.test(plan.status))
       report.findings.push(`archiving refused: Status is "${plan.status}", not completed`);
@@ -678,7 +693,7 @@ async function main() {
     console.log(
       `plan: ${report.plan}\nstatus: ${report.status ?? "?"} | owner: ${report.owner ?? "?"}`,
     );
-    if (code !== 1) console.log(`unanswered offers: ${report.unansweredOffers.length}`);
+    console.log(`unanswered offers: ${report.unansweredOffers.length}`);
     for (const [label, rows] of [
       ["error", report.errors],
       ["open", report.open],
@@ -696,7 +711,7 @@ async function main() {
       code === 0
         ? "result: nothing open"
         : code === 1
-          ? "result: invalid input"
+          ? `result: invalid input${report.invalidPlan ? " (the checks that read only the plan text still ran)" : ""}`
           : `result: ${report.open.length} open item(s) (${report.awaitingUser.length} awaiting your yes/no), ${report.findings.length} finding(s)`,
     );
   }