@bompus/house-rules 0.14.0 → 0.14.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bompus/house-rules",
-  "version": "0.14.0",
+  "version": "0.14.1",
   "description": "Composable working rules and skills for AI coding agents",
   "homepage": "https://github.com/bompus/house-rules#readme",
   "license": "MIT",

package/rules/references/github-actions.md

@@ -8,6 +8,38 @@ Give jobs finite timeouts. Cancel an older pull-request run only when a newer
 run for the same pull request covers the same required checks; preserve required
 default-branch and release evidence.
 
+### Cancel superseded pull-request runs
+
+Key the `concurrency` group on the workflow and the pull request number, and
+cancel only for pull-request events:
+
+```yaml
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+```
+
+- Concurrency groups are shared by every workflow in the repository, so keep a
+  value unique to the workflow in the key. `github.workflow` is the workflow's
+  name, so it is unique only while workflow names are; otherwise use a fixed
+  prefix. Without a unique value, one workflow's run can cancel another's.
+- Keep the pull-request key stable across pushes: never a commit SHA or run ID
+  for a pull-request run, which differs on every push, so nothing is cancelled.
+  A workflow that runs only on pull requests can use `cancel-in-progress: true`.
+  A reusable workflow inherits the caller's `github.workflow`, so give caller and
+  callee different keys.
+- Cancellation needs a newer run in the same group. When a path filter means a
+  push starts no run, the older run finishes. Add a cleanup workflow only when
+  run history shows older runs finishing after pushes that started no
+  replacement; it must not check out pull-request code.
+- To skip checks on draft pull requests, add `github.event.pull_request.draft != true`
+  to each check job's `if`, including reusable-workflow callers and aggregate
+  jobs. A job guard stops a runner being allocated; a step guard does not. Add
+  `ready_for_review` and `converted_to_draft` to the `pull_request` types, so
+  checks start when review begins and a replacement run can cancel old work.
+  Use this only when the repository's policy says draft pull requests do not
+  need these checks.
+
 ### Choose the concurrency boundary
 
 Independent jobs can run on separate runners. A job's steps normally run in

package/rules/references/squash-landing.md

@@ -19,8 +19,8 @@ the review body too: findings outside the diff arrive there, not as threads.
 Let an enabled automatic review start; do not comment to request one. When none
 starts, check the integration's status instead of tagging the bot again. A bot's
 config file in the repository does not show that it is enabled, and an existing
-check on the head must report completion before you merge (for CodeRabbit, a
-successful status whose description starts with "Review completed").
+check on the head must report completion before you merge. A skipped or
+cancelled review is not a completed one.
 
 During integration, never switch, reset or remove the session's own checkout: no
 `checkout` or `switch` to another ref, no `reset` or branch force-move, and no

package/skills/hr-pr-followup/references/review-helpers.md

@@ -19,7 +19,9 @@ the head contains `.coderabbit.yaml`. It also checks bot review bodies with
 outside-diff, nitpick or duplicate findings. A completed CodeRabbit CheckRun
 must conclude SUCCESS; failed, cancelled, skipped or missing conclusions block
 the gate. A CodeRabbit status also requires SUCCESS and a description starting
-with "Review completed". It does not check every CI result or authorize landing.
+with "Review completed"; that is how the gate tests the general squash rule that an
+existing review check must report completion. It does not check every CI result or
+authorize landing.
 
 The check named exactly "cubic · AI code reviewer" on the head commit is held to the
 same rule: while it runs, the gate refuses, and a completed one must conclude