@boehringer-ingelheim/eslint-config 4.0.0-next.1 → 4.0.0-next.3

package/README.md

@@ -84,6 +84,16 @@ module.exports = {
 };
 ```
 
+### `@boehringer-ingelheim/eslint-config/base/local`
+
+```js
+module.exports = {
+  extends: ["@boehringer-ingelheim/eslint-config/base/strict", "@boehringer-ingelheim/eslint-config/base/local"],
+};
+```
+
+This shared ESLint configuration configures or disables some rules for a better performance locally. With the help of [`is-ci`](https://www.npmjs.com/package/is-ci) those configs only apply to environments outside the CI pipelines.
+
 ### `@boehringer-ingelheim/eslint-config/base/strict`
 
 ```js

package/base/index.js

@@ -41,9 +41,7 @@ module.exports = {
   rules: {
     // @typescript-eslint: https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/eslint-plugin/docs/rules
     "@typescript-eslint/adjacent-overload-signatures": "off", // disabled due to conflict with eslint-plugin-perfectionist
-    "@typescript-eslint/consistent-type-imports": "error",
     "@typescript-eslint/no-floating-promises": ["error", { ignoreVoid: true }],
-    "@typescript-eslint/no-import-type-side-effects": "error",
     "@typescript-eslint/no-misused-promises": [
       "error",
       {
@@ -85,7 +83,6 @@ module.exports = {
     "sort-keys": "off", // disabled due to conflict with eslint-plugin-perfectionist
 
     // eslint-plugin-import: https://github.com/import-js/eslint-plugin-import/tree/main/docs/rules
-    "import/consistent-type-specifier-style": ["error", "prefer-top-level"],
     "import/no-cycle": "error",
     "import/no-unused-modules": [
       "error",
@@ -98,6 +95,12 @@ module.exports = {
     "import/order": "off", // disabled due to conflict with eslint-plugin-perfectionist
     "import/prefer-default-export": "off",
 
+    // Deactivated as TypeScript provides the same checks as part of standard type checking: https://typescript-eslint.io/linting/troubleshooting/performance-troubleshooting
+    "import/default": "off",
+    "import/named": "off",
+    "import/namespace": "off",
+    "import/no-named-as-default-member": "off",
+
     // eslint-plugin-perfectionist: https://github.com/azat-io/eslint-plugin-perfectionist
     "perfectionist/sort-array-includes": ["error", { "ignore-case": true, type: "natural" }],
     "perfectionist/sort-astro-attributes": ["error", { "ignore-case": true, type: "natural" }],

package/base/local.js

@@ -0,0 +1,20 @@
+/**
+ * Workaround to allow ESLint to resolve plugins that were installed
+ * by an external config, see https://github.com/eslint/eslint/issues/3458.
+ */
+require("@rushstack/eslint-patch/modern-module-resolution");
+
+const isCI = require("is-ci");
+
+/** @type {import('eslint').ESLint.ConfigData}  */
+module.exports = {
+  rules: isCI
+    ? {}
+    : {
+        // Only activate in CI, as suggested here: https://typescript-eslint.io/linting/troubleshooting/performance-troubleshooting#eslint-plugin-import
+        "import/no-cycle": "off",
+        "import/no-deprecated": "off",
+        "import/no-named-as-default": "off",
+        "import/no-unused-modules": "off",
+      },
+};

package/base/strict.js

@@ -7,4 +7,12 @@ require("@rushstack/eslint-patch/modern-module-resolution");
 /** @type {import('eslint').ESLint.ConfigData}  */
 module.exports = {
   extends: ["./index.js", "plugin:@typescript-eslint/strict-type-checked"],
+  rules: {
+    // @typescript-eslint: https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/eslint-plugin/docs/rules
+    "@typescript-eslint/consistent-type-imports": "error",
+    "@typescript-eslint/no-import-type-side-effects": "error",
+
+    // eslint-plugin-import: https://github.com/import-js/eslint-plugin-import/tree/main/docs/rules
+    "import/consistent-type-specifier-style": ["error", "prefer-top-level"],
+  },
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@boehringer-ingelheim/eslint-config",
-  "version": "4.0.0-next.1",
+  "version": "4.0.0-next.3",
   "description": "Shared eslint configuration used at Boehringer Ingelheim for code styling",
   "keywords": [
     "boehringer",
@@ -31,28 +31,29 @@
   },
   "dependencies": {
     "@rushstack/eslint-patch": "^1.5.1",
-    "@typescript-eslint/eslint-plugin": "^6.7.5",
-    "@typescript-eslint/parser": "^6.7.5",
+    "@typescript-eslint/eslint-plugin": "^6.10.0",
+    "@typescript-eslint/parser": "^6.10.0",
     "eslint-import-resolver-typescript": "^3.6.1",
-    "eslint-plugin-import": "^2.28.1",
-    "eslint-plugin-jsx-a11y": "^6.7.1",
+    "eslint-plugin-import": "^2.29.0",
+    "eslint-plugin-jsx-a11y": "^6.8.0",
     "eslint-plugin-perfectionist": "^2.2.0",
-    "eslint-plugin-playwright": "^0.16.0",
+    "eslint-plugin-playwright": "^0.18.0",
     "eslint-plugin-react": "^7.33.2",
     "eslint-plugin-react-hooks": "^4.6.0",
-    "eslint-plugin-sonarjs": "^0.21.0",
-    "eslint-plugin-typescript-enum": "^2.1.0"
+    "eslint-plugin-sonarjs": "^0.23.0",
+    "eslint-plugin-typescript-enum": "^2.1.0",
+    "is-ci": "^3.0.1"
   },
   "devDependencies": {
     "@boehringer-ingelheim/prettier-config": "1.0.0",
-    "@commitlint/cli": "17.8.0",
-    "@commitlint/config-conventional": "17.8.0",
-    "@commitlint/types": "17.4.4",
+    "@commitlint/cli": "18.2.0",
+    "@commitlint/config-conventional": "18.1.0",
+    "@commitlint/types": "18.1.0",
     "@semantic-release/changelog": "6.0.3",
     "@semantic-release/git": "10.0.1",
     "dotenv-cli": "7.3.0",
     "husky": "8.0.3",
     "prettier": "3.0.3",
-    "semantic-release": "22.0.5"
+    "semantic-release": "22.0.7"
   }
 }