@bobfrankston/rmfmail 1.2.230 → 1.2.232

package/TODO.md

@@ -661,6 +661,33 @@ Was part of S1 "local-first reconciliation refactor" until 2026-04-23 when S1's
 
 <a id="priority-1"></a>
 
+<a id="ext162"></a>
+
+### C162 — Vetting sweep 2026-08-09: dead paths & duplicated mechanisms  [↑ summary](#sum)
+
+Requested 2026-08-08 22:34 ("spend the night vetting the code to look for dead path and duplicated mechanism"); the session crashed before it started. First pass below. Every row is a reachability result (grep for importers across `bin/`, `packages/`, `client/`, `android-maui/`, the HTML importmaps and the bundle config), not an impression.
+
+**Dead — no path reaches it**
+
+| What | Lines | Evidence | Call |
+|---|---|---|---|
+| `packages/mailx-core` | 665 | no importer anywhere; contains 2 of the 8 RFC822 assembly copies | delete |
+| `packages/mailx-server` | 452 | `--server` mode removed v1.2.80; nothing imports it | delete |
+| `packages/mailx-compose` | 111 | sole export `buildComposeInit` uncalled | delete |
+| `packages/mailx-send` + its nested `mailsend/` copy | 1236 | the app never imports it — it publishes the `mailsend`/`mailq` CLI bins. The two copies differ by **8 lines, all comments** | keep only if the CLI is still wanted, and collapse to one copy |
+| `client/components/calendar.ts` | 213 | superseded by `calendar-sidebar.ts` (951 lines, live); nothing imports it | delete |
+| `client/components/tasks.ts` | 234 | ditto — tasks UI lives in calendar-sidebar + alarms | delete |
+| `showSelectionMenu` in `message-list.ts` | ~55 | the toolbar **Selection** button and its handler were deleted 2026-06-26 (`e9c1efa9`); the menu was never re-anchored, so the whole bulk-actions menu is unreachable | re-anchor to the bulk bar **or** delete — this one is a lost feature, not just dead weight |
+| uncalled exports | — | `destroyGhostText`, `local-service.handleCall`, `local-store.storeBody`, `spellcheck-core.MARKER_ATTR`, `mailx-settings`: `isCloudMode`/`getLastCloudError`/`getMicrosoftProfile`, `mailx-host.hostName`, `mailx-store-web`: `createWorkerHost`/`loadDeviceState`/`saveDeviceState`, `mailx-types`: `answeredOf`/`deletedOf`/`setAnswered`/`setDraft`/`toggleFlagged` | delete with their packages where applicable |
+
+This is not tidiness. The RFC 2047 header fix on 2026-08-08 was hand-applied to **7 sites — 4 of them in the dead packages above**, which is real fix-time spent on code that cannot run.
+
+**Duplicated mechanism**
+
+- **RFC822/MIME assembly — the expensive one.** Eight sites build a message by hand (`mailx-service` ×2 live, `mailx-store-web` ×2 live, `mailx-core` ×2 dead, `mailx-send` ×2 dead). The two LIVE pairs — desktop and Android/web — are **72% identical line-for-line**. Every send-path fix since May has had to be applied 2–4×: quoted-header envelope scrape (v1.2.166, "SAME shape in 3 files"), inline images data:→cid (v1.2.179, "BOTH send paths"), RFC 2047 encoded-words (v1.2.226, 7 sites). Fix: one `buildMimeMessage()` in `mailx-types`, which already hosts `encodeHeaderWord`, `encodeQuotedPrintable`, `extractInlineImages` and `htmlToPlainText` — the parts each copy already shares. [M]
+- ~~**Context menus** — three clipboard implementations (rich editor, compose recipient field, nothing at all elsewhere)~~ — **FIXED v1.2.230**, see DONE.md.
+- **`escapeHtml`** — 15 separate definitions across client + packages. [S]
+
 ## Priority 1 — Get basics working  [↑ top](#top)
 
 ### External content security

package/client/app.bundle.js

@@ -2364,7 +2364,7 @@ async function showMessage(accountId, uid, folderId, specialUse, isRetry = false
         items.push({ label: "Reply", action: () => document.dispatchEvent(new CustomEvent("mailx-compose", { detail: { mode: "reply" } })) });
         items.push({ label: "Reply All", action: () => document.dispatchEvent(new CustomEvent("mailx-compose", { detail: { mode: "replyAll" } })) });
         items.push({ label: "Forward", action: () => document.dispatchEvent(new CustomEvent("mailx-compose", { detail: { mode: "forward" } })) });
-        showContextMenu(me.clientX, me.clientY, items);
+        showContextMenu(me.clientX, me.clientY, items, { editTarget: me.target });
       });
     }
     headerEl.querySelector(".mv-date").textContent = new Date(msg.date).toLocaleString(void 0, { year: "numeric", month: "short", day: "numeric", hour: "2-digit", minute: "2-digit", hour12: false });
@@ -2897,7 +2897,7 @@ async function showMessage(accountId, uid, folderId, specialUse, isRetry = false
               } });
             }
           }
-          showContextMenu(e.clientX, e.clientY, items);
+          showContextMenu(e.clientX, e.clientY, items, { editTarget: e.target });
         });
         attEl.appendChild(chip);
       }
@@ -6266,7 +6266,7 @@ async function renderTasks(prefetched) {
           await deleteTask(uuid);
           renderTasks();
         } }
-      ]);
+      ], { editTarget: e.target });
     });
   });
 }