@bobfrankston/rmfmail 1.2.178 → 1.2.180

package/TODO.md

@@ -23,6 +23,7 @@ These items don't need user input — source-only changes, compile-verified befo
 | **10** | **C159 — Harper local grammar check** [M] | M | **Desktop SHIPPED v1.2.168** (2026-07-22): daemon-side Harper engine + `grammarLint` IPC, generic squiggle overlay + suggestion popup across ALL THREE editors, Settings toggle default ON, quoted chains + spelling lints skipped. **Remaining: Android** (host LocalLinter in android-bootstrap, harper.js dist in APK assets like sql.js, ~+18 MB) + per-rule config + userdict merge. Details: `docs/harper-integration.md`. |
 | **9** | **C158 — Android double-init after fold-triggered reload** [M] | M | 2026-07-22 13:07:49 logit trail: ONE page reload after unfolding produced TWO module loads, duplicate "bridge installed", duplicate GDrive lookups, and THREE "Starting OAuth flow" launches. Activity did NOT recreate (ConfigChanges already declared; no OnCreate in trail) — find what reloads the WebView on fold and make android-bootstrap init idempotent (single-flight guard on the module-level init, dedupe OAuth intent launches). |
 | **11** | **C160 — Attachment delete: Gmail + Android halves** [M] | M | Desktop IMAP shipped v1.2.173 (right-click chip → Delete one/all: verified local strip + append-confirm-then-delete server replace, .pre-strip.bak backup, UID rebind). Remaining: Gmail REST path (messages.insert + trash of original — changes message id, provider_id rebind) and Android (bridge method + web-service strip using its own parser). Strip helper lives in mailx-service (enumerateMimeLeafParts) — move to mailx-types when Android needs it. |
+| **12** | **C161 — `_rmfmail` IMAP folder for cross-machine state sync** [M] | M | Bob 2026-07-27: use a hidden `_rmfmail` folder on the mail server itself as a per-account sync channel for state that today rides on Google Drive or nowhere — reminder dismissals, per-machine prefs, read-position, contact edits for non-Google accounts. Advantages over Drive files: works for every IMAP account (no Google dependency), naturally per-account, versioned by APPEND, and reuses the existing connection/sync machinery. Shape: one message per state document with a stable `X-Rmfmail-State: <name>` header, save = delete-and-reappend (the draft-dedup pattern), merge semantics per document type (reminders already have per-key max merge in mailx-types). Design Qs: folder visibility (subscribe or not, hide from folder tree), conflict handling when two machines append concurrently, and whether reminders.jsonc migrates or dual-writes. First shipped consumer of the pattern: draft freshness probe (v1.2.180) already proves the search-by-header primitive. |
 | **5** | **C124 — mailto handler on macOS** (Linux ✅ 2026-07-08 v1.2.115) | S | Linux half shipped: `--register-mailto` on linux writes `~/.local/share/applications/rmfmail.desktop` (`MimeType=x-scheme-handler/mailto;`, quoted node+mailx.js Exec, bare `%u`), runs `xdg-mime default` + `update-desktop-database`; `--unregister-mailto` removes it. **Remaining: macOS** — real `.app` bundle (LaunchServices won't register a bare script) with `Info.plist` `CFBundleURLTypes` declaring `mailto` + a tiny launcher binary; `LSSetDefaultHandlerForURLScheme` programmatically sets the default. Rust `rmfmailto-src/` crate already portable — drop the Win32 imports and `cargo build --target x86_64-apple-darwin` produces the macOS launcher. Needs a Mac to build/verify. |
 | ~~7~~ | ~~**C154 — Audit Android bridge vs MailxApi contract**~~ — **DONE** (2026-07-08, v1.2.115). Bridge now has a generic contract-backstop: every service method not explicitly adapted gets a positional pass-through, so a missing method can never again fail as `parent bridge has no method "X"`. Wire-shape mismatches adapted explicitly (`readJsoncFile`/`writeJsoncFile`/`formatJsonc`/`readConfigHelp` → `{content}`/`{ok}`, `drainStoreSync`/`syncFolderNow` → `{ok}`). Contract gained the missing entries (`getMessageSource`, `copyMessages`, `syncFolderNow`, `cancelServerSearch`, `getReminderSound`, `getCalendars`, optional `popoutWindow`) with web-service stubs per the policy (reads → graceful default, writes/OS → notImpl). Bonus fixes: bridge `getMessages` was dropping sort/sortDir/search and `searchMessages` was dropping scope/accountId/folderId — Android sort toggles and scoped search silently didn't work. | S | |
 ~~done — C120 read transport diagnostics~~ shipped v1.0.583 (per-folder timeout error now includes `[conn#X r=YB w=ZB writes=N sinceLastRead=Tms]` snapshot for the doomed socket).

package/client/android-bootstrap.bundle.js

@@ -2386,6 +2386,28 @@ var init_reminder_state = __esm({
   }
 });
 
+// packages/mailx-types/mime-inline-images.js
+function extractInlineImages(html, idDomain) {
+  const images = [];
+  const byDataUri = /* @__PURE__ */ new Map();
+  const stamp = `${Date.now().toString(36)}${Math.random().toString(36).slice(2, 8)}`;
+  const out = html.replace(/(<img\b[^>]*?\ssrc=)(["'])(data:(image\/[\w.+-]+);base64,([A-Za-z0-9+/=\s]+))\2/gi, (_m, prefix, quote, dataUri, mime, b64) => {
+    let cid = byDataUri.get(dataUri);
+    if (!cid) {
+      cid = `img${images.length + 1}.${stamp}@${idDomain}`;
+      byDataUri.set(dataUri, cid);
+      images.push({ contentId: cid, mime, base64: b64.replace(/\s+/g, "") });
+    }
+    return `${prefix}${quote}cid:${cid}${quote}`;
+  });
+  return { html: out, images };
+}
+var init_mime_inline_images = __esm({
+  "packages/mailx-types/mime-inline-images.js"() {
+    "use strict";
+  }
+});
+
 // packages/mailx-types/index.js
 var mailx_types_exports = {};
 __export(mailx_types_exports, {
@@ -2399,6 +2421,7 @@ __export(mailx_types_exports, {
   encodeQuotedPrintable: () => encodeQuotedPrintable,
   expandRecipients: () => expandRecipients,
   extractAddress: () => extractAddress,
+  extractInlineImages: () => extractInlineImages,
   flaggedOf: () => flaggedOf,
   htmlToPlainText: () => htmlToPlainText,
   isAddressToken: () => isAddressToken,
@@ -2607,6 +2630,7 @@ var init_mailx_types = __esm({
     init_contacts_config();
     init_groups();
     init_reminder_state();
+    init_mime_inline_images();
     _SEEN = "\\Seen";
     _FLAGGED = "\\Flagged";
     _ANSWERED = "\\Answered";
@@ -6170,12 +6194,14 @@ var WebMailxService = class _WebMailxService {
     const cc = msg.cc?.map((a) => a.name ? `${a.name} <${a.address}>` : a.address).join(", ");
     const bcc = msg.bcc?.map((a) => a.name ? `${a.name} <${a.address}>` : a.address).join(", ");
     const hasHtml = !!msg.bodyHtml;
-    const htmlBody = msg.bodyHtml || "";
+    const domain = account.email.split("@")[1] || "mailx.local";
+    const messageId = `<${Date.now()}.${Math.random().toString(36).slice(2)}@${domain}>`;
+    const extracted = hasHtml ? extractInlineImages(msg.bodyHtml, domain) : { html: "", images: [] };
+    const htmlBody = extracted.html;
+    const inlineImages = extracted.images;
     const textBody = msg.bodyText || (hasHtml ? htmlToPlainText(htmlBody) : "");
     const htmlEncoded = hasHtml ? encodeQuotedPrintable(htmlBody) : "";
     const textEncoded = encodeQuotedPrintable(textBody);
-    const domain = account.email.split("@")[1] || "mailx.local";
-    const messageId = `<${Date.now()}.${Math.random().toString(36).slice(2)}@${domain}>`;
     const envelope = [
       `From: ${fromHeader}`,
       `To: ${to}`,
@@ -6188,9 +6214,11 @@ var WebMailxService = class _WebMailxService {
       msg.references?.length ? `References: ${msg.references.join(" ")}` : null,
       `MIME-Version: 1.0`
     ].filter((h) => h !== null);
+    const newBoundary = () => `mailx_${Date.now().toString(36)}_${Math.random().toString(36).slice(2, 10)}`;
+    const wrap76 = (s) => s.match(/.{1,76}/g)?.join("\r\n") || s;
     const makeInner = () => {
       if (hasHtml) {
-        const altBoundary = `mailx_${Date.now().toString(36)}_${Math.random().toString(36).slice(2, 10)}`;
+        const altBoundary = newBoundary();
         const body = `--${altBoundary}\r
 Content-Type: text/plain; charset=UTF-8\r
 Content-Transfer-Encoding: quoted-printable\r
@@ -6203,7 +6231,29 @@ Content-Transfer-Encoding: quoted-printable\r
 ${htmlEncoded}\r
 --${altBoundary}--\r
 `;
-        return { headers: [`Content-Type: multipart/alternative; boundary="${altBoundary}"`], body };
+        const alt = { headers: [`Content-Type: multipart/alternative; boundary="${altBoundary}"`], body };
+        if (inlineImages.length === 0)
+          return alt;
+        const relBoundary = newBoundary();
+        const relParts = [
+          `--${relBoundary}\r
+` + alt.headers.join("\r\n") + `\r
+\r
+` + alt.body,
+          ...inlineImages.map((im) => `--${relBoundary}\r
+Content-Type: ${im.mime}\r
+Content-ID: <${im.contentId}>\r
+Content-Disposition: inline\r
+Content-Transfer-Encoding: base64\r
+\r
+${wrap76(im.base64)}\r
+`)
+        ];
+        return {
+          headers: [`Content-Type: multipart/related; boundary="${relBoundary}"; type="multipart/alternative"`],
+          body: relParts.join("") + `--${relBoundary}--\r
+`
+        };
       }
       return {
         headers: [`Content-Type: text/plain; charset=UTF-8`, `Content-Transfer-Encoding: quoted-printable`],
@@ -6213,7 +6263,6 @@ ${htmlEncoded}\r
     const atts = Array.isArray(msg.attachments) ? msg.attachments : [];
     let rawMessage;
     if (atts.length > 0) {
-      const wrap76 = (s) => s.match(/.{1,76}/g)?.join("\r\n") || s;
       const mixedBoundary = `mailxmix_${Date.now().toString(36)}_${Math.random().toString(36).slice(2, 10)}`;
       const inner = makeInner();
       const parts = [];
@@ -11429,6 +11478,8 @@ function installBridge() {
       await service.deleteDraft(accountId, draftUid);
       return { ok: true };
     },
+    // No IMAP-side draft probe on Android — compose keeps its local copy.
+    checkDraftNewer: async () => null,
     // Full arg pass-through — dropping scope/accountId/folderId made every
     // Android search behave as all-mailboxes regardless of the UI scope.
     searchMessages: (query, page, pageSize, scope, accountId, folderId, includeTrashSpam) => service.searchMessages(query, page, pageSize, scope, accountId, folderId, includeTrashSpam),