@bobfrankston/rmfmail 1.2.172 → 1.2.173

package/TODO.md

@@ -22,6 +22,7 @@ These items don't need user input — source-only changes, compile-verified befo
 | **8** | **C157 — Android fresh install: paint folder list before message sync** [S/M] | S/M | First sync ran minutes with an empty tree. Prioritize per-account folder-LIST fetch + paint ahead of message sync so the skeleton appears in seconds; message counts stream in behind. |
 | **10** | **C159 — Harper local grammar check** [M] | M | **Desktop SHIPPED v1.2.168** (2026-07-22): daemon-side Harper engine + `grammarLint` IPC, generic squiggle overlay + suggestion popup across ALL THREE editors, Settings toggle default ON, quoted chains + spelling lints skipped. **Remaining: Android** (host LocalLinter in android-bootstrap, harper.js dist in APK assets like sql.js, ~+18 MB) + per-rule config + userdict merge. Details: `docs/harper-integration.md`. |
 | **9** | **C158 — Android double-init after fold-triggered reload** [M] | M | 2026-07-22 13:07:49 logit trail: ONE page reload after unfolding produced TWO module loads, duplicate "bridge installed", duplicate GDrive lookups, and THREE "Starting OAuth flow" launches. Activity did NOT recreate (ConfigChanges already declared; no OnCreate in trail) — find what reloads the WebView on fold and make android-bootstrap init idempotent (single-flight guard on the module-level init, dedupe OAuth intent launches). |
+| **11** | **C160 — Attachment delete: Gmail + Android halves** [M] | M | Desktop IMAP shipped v1.2.173 (right-click chip → Delete one/all: verified local strip + append-confirm-then-delete server replace, .pre-strip.bak backup, UID rebind). Remaining: Gmail REST path (messages.insert + trash of original — changes message id, provider_id rebind) and Android (bridge method + web-service strip using its own parser). Strip helper lives in mailx-service (enumerateMimeLeafParts) — move to mailx-types when Android needs it. |
 | **5** | **C124 — mailto handler on macOS** (Linux ✅ 2026-07-08 v1.2.115) | S | Linux half shipped: `--register-mailto` on linux writes `~/.local/share/applications/rmfmail.desktop` (`MimeType=x-scheme-handler/mailto;`, quoted node+mailx.js Exec, bare `%u`), runs `xdg-mime default` + `update-desktop-database`; `--unregister-mailto` removes it. **Remaining: macOS** — real `.app` bundle (LaunchServices won't register a bare script) with `Info.plist` `CFBundleURLTypes` declaring `mailto` + a tiny launcher binary; `LSSetDefaultHandlerForURLScheme` programmatically sets the default. Rust `rmfmailto-src/` crate already portable — drop the Win32 imports and `cargo build --target x86_64-apple-darwin` produces the macOS launcher. Needs a Mac to build/verify. |
 | ~~7~~ | ~~**C154 — Audit Android bridge vs MailxApi contract**~~ — **DONE** (2026-07-08, v1.2.115). Bridge now has a generic contract-backstop: every service method not explicitly adapted gets a positional pass-through, so a missing method can never again fail as `parent bridge has no method "X"`. Wire-shape mismatches adapted explicitly (`readJsoncFile`/`writeJsoncFile`/`formatJsonc`/`readConfigHelp` → `{content}`/`{ok}`, `drainStoreSync`/`syncFolderNow` → `{ok}`). Contract gained the missing entries (`getMessageSource`, `copyMessages`, `syncFolderNow`, `cancelServerSearch`, `getReminderSound`, `getCalendars`, optional `popoutWindow`) with web-service stubs per the policy (reads → graceful default, writes/OS → notImpl). Bonus fixes: bridge `getMessages` was dropping sort/sortDir/search and `searchMessages` was dropping scope/accountId/folderId — Android sort toggles and scoped search silently didn't work. | S | |
 ~~done — C120 read transport diagnostics~~ shipped v1.0.583 (per-folder timeout error now includes `[conn#X r=YB w=ZB writes=N sinceLastRead=Tms]` snapshot for the doomed socket).

package/client/app.bundle.js

@@ -38,6 +38,7 @@ __export(api_client_exports, {
   createFolder: () => createFolder,
   createTask: () => createTask,
   debugEvalResult: () => debugEvalResult,
+  deleteAttachments: () => deleteAttachments,
   deleteCalendarEvent: () => deleteCalendarEvent,
   deleteContact: () => deleteContact,
   deleteDraft: () => deleteDraft,
@@ -633,6 +634,12 @@ async function openAttachment(accountId, uid, attachmentId, folderId, filename)
 async function getMessageSource(accountId, uid, folderId) {
   return ipc().getMessageSource(accountId, uid, folderId);
 }
+async function deleteAttachments(accountId, uid, folderId, ids) {
+  const fn = ipc().deleteAttachments;
+  if (!fn)
+    throw new Error("Attachment delete not available in this host");
+  return fn(accountId, uid, folderId, ids);
+}
 async function grammarLint(blocks) {
   const fn = ipc().grammarLint;
   if (!fn)
@@ -1558,6 +1565,47 @@ function clearViewer() {
   if (attEl)
     attEl.hidden = true;
 }
+function confirmDeleteAttachments(msg, accountId, uid, ids, question) {
+  const backdrop = document.createElement("div");
+  backdrop.className = "mailx-modal-backdrop";
+  backdrop.style.cssText = "position:fixed;inset:0;z-index:2100;background:rgba(0,0,0,0.4);display:flex;align-items:center;justify-content:center;";
+  const panel = document.createElement("div");
+  panel.style.cssText = "background:var(--color-bg,#fff);color:var(--color-text,#000);border-radius:8px;box-shadow:0 8px 32px rgba(0,0,0,0.3);width:min(440px,90vw);padding:16px;display:flex;flex-direction:column;gap:12px;";
+  const body = document.createElement("div");
+  body.style.cssText = "line-height:1.5;";
+  body.textContent = `${question} The attachment is removed from the local copy and from the server copy. The message text is kept. This cannot be undone.`;
+  const status = document.createElement("div");
+  status.style.cssText = "min-height:1.2em;font-size:0.9em;color:var(--color-text-muted);";
+  const row = document.createElement("div");
+  row.style.cssText = "display:flex;gap:8px;justify-content:flex-end;";
+  const cancel = document.createElement("button");
+  cancel.textContent = "Cancel";
+  cancel.style.cssText = "padding:6px 14px;";
+  cancel.addEventListener("click", () => backdrop.remove());
+  const del = document.createElement("button");
+  del.textContent = "Delete";
+  del.style.cssText = "padding:6px 14px;font-weight:600;background:#c0392b;color:#fff;border:none;border-radius:4px;cursor:pointer;";
+  del.addEventListener("click", async () => {
+    del.disabled = true;
+    cancel.disabled = true;
+    status.textContent = "Removing\u2026";
+    try {
+      const { deleteAttachments: deleteAttachments2 } = await Promise.resolve().then(() => (init_api_client(), api_client_exports));
+      const r = await deleteAttachments2(accountId, uid, msg.folderId, ids);
+      backdrop.remove();
+      void showMessage(accountId, uid, msg.folderId);
+      void r;
+    } catch (e) {
+      status.textContent = e?.message || "Delete failed \u2014 message unchanged.";
+      del.disabled = false;
+      cancel.disabled = false;
+    }
+  });
+  row.append(cancel, del);
+  panel.append(body, status, row);
+  backdrop.append(panel);
+  document.body.append(backdrop);
+}
 async function showMessage(accountId, uid, folderId, specialUse, isRetry = false, envelope) {
   const gen = ++showMessageGeneration;
   if (!isRetry)
@@ -2308,6 +2356,16 @@ async function showMessage(accountId, uid, folderId, specialUse, isRetry = false
               void saveAllAttachments();
             } });
           }
+          if (window.mailxapi?.platform !== "android") {
+            items.push({ label: `Delete "${att.filename}"\u2026`, separator: true, action: () => {
+              confirmDeleteAttachments(msg, accountId, uid, [att.id], `Delete "${att.filename}" from this message?`);
+            } });
+            if (msg.attachments.length > 1) {
+              items.push({ label: `Delete all (${msg.attachments.length})\u2026`, action: () => {
+                confirmDeleteAttachments(msg, accountId, uid, "all", `Delete all ${msg.attachments.length} attachments from this message?`);
+              } });
+            }
+          }
           showContextMenu(e.clientX, e.clientY, items);
         });
         attEl.appendChild(chip);