@bobfrankston/rmfmail 1.2.167 → 1.2.168

package/TODO.md

@@ -20,6 +20,7 @@ These items don't need user input — source-only changes, compile-verified befo
 | **6** | **C125 — Unify desktop + Android IMAP code paths** | M | Today's split (`mailx-imap` Node-only + `mailx-store-web` browser-only) duplicates orchestration that's protocol-identical. Differences boil down to (a) transport factory choice (b) whether clients are persistent — both parameters, not architectural divides. Plan: extract `mailx-imap-core` with ImapManager + ops queue + fast-lane + sync orchestration over a `Transport` and a `Storage` interface, no Node-specific imports. `mailx-imap` and `mailx-store-web` become thin shims that wire engine-specific Storage + Transport. `{persistent: true\|false}` flag on ImapManager covers the lifetime split (no fast-lane queue when ephemeral). Pre-req for Android non-Gmail IMAP without forking sync code. |
 | **7** | **C156 — Android first-boot/setup progress narration** [M] | M | New-device install looked frozen (Bob 2026-07-22): no indication of "Signing into <gmail>…", "Fetching settings from Google Drive…", "Syncing INBOX (120/2000)…". Surface the android-bootstrap stage breadcrumbs (already vlog'd since v1.2.167) in the startup status area / folder-tree loading slot. |
 | **8** | **C157 — Android fresh install: paint folder list before message sync** [S/M] | S/M | First sync ran minutes with an empty tree. Prioritize per-account folder-LIST fetch + paint ahead of message sync so the skeleton appears in seconds; message counts stream in behind. |
+| **10** | **C159 — Harper local grammar check** [M] | M | **Desktop SHIPPED v1.2.168** (2026-07-22): daemon-side Harper engine + `grammarLint` IPC, generic squiggle overlay + suggestion popup across ALL THREE editors, Settings toggle default ON, quoted chains + spelling lints skipped. **Remaining: Android** (host LocalLinter in android-bootstrap, harper.js dist in APK assets like sql.js, ~+18 MB) + per-rule config + userdict merge. Details: `docs/harper-integration.md`. |
 | **9** | **C158 — Android double-init after fold-triggered reload** [M] | M | 2026-07-22 13:07:49 logit trail: ONE page reload after unfolding produced TWO module loads, duplicate "bridge installed", duplicate GDrive lookups, and THREE "Starting OAuth flow" launches. Activity did NOT recreate (ConfigChanges already declared; no OnCreate in trail) — find what reloads the WebView on fold and make android-bootstrap init idempotent (single-flight guard on the module-level init, dedupe OAuth intent launches). |
 | **5** | **C124 — mailto handler on macOS** (Linux ✅ 2026-07-08 v1.2.115) | S | Linux half shipped: `--register-mailto` on linux writes `~/.local/share/applications/rmfmail.desktop` (`MimeType=x-scheme-handler/mailto;`, quoted node+mailx.js Exec, bare `%u`), runs `xdg-mime default` + `update-desktop-database`; `--unregister-mailto` removes it. **Remaining: macOS** — real `.app` bundle (LaunchServices won't register a bare script) with `Info.plist` `CFBundleURLTypes` declaring `mailto` + a tiny launcher binary; `LSSetDefaultHandlerForURLScheme` programmatically sets the default. Rust `rmfmailto-src/` crate already portable — drop the Win32 imports and `cargo build --target x86_64-apple-darwin` produces the macOS launcher. Needs a Mac to build/verify. |
 | ~~7~~ | ~~**C154 — Audit Android bridge vs MailxApi contract**~~ — **DONE** (2026-07-08, v1.2.115). Bridge now has a generic contract-backstop: every service method not explicitly adapted gets a positional pass-through, so a missing method can never again fail as `parent bridge has no method "X"`. Wire-shape mismatches adapted explicitly (`readJsoncFile`/`writeJsoncFile`/`formatJsonc`/`readConfigHelp` → `{content}`/`{ok}`, `drainStoreSync`/`syncFolderNow` → `{ok}`). Contract gained the missing entries (`getMessageSource`, `copyMessages`, `syncFolderNow`, `cancelServerSearch`, `getReminderSound`, `getCalendars`, optional `popoutWindow`) with web-service stubs per the policy (reads → graceful default, writes/OS → notImpl). Bonus fixes: bridge `getMessages` was dropping sort/sortDir/search and `searchMessages` was dropping scope/accountId/folderId — Android sort toggles and scoped search silently didn't work. | S | |

package/client/app.bundle.js

@@ -72,6 +72,7 @@ __export(api_client_exports, {
   getUnifiedInbox: () => getUnifiedInbox,
   getUserDict: () => getUserDict,
   getVersion: () => getVersion,
+  grammarLint: () => grammarLint,
   hasBccHistoryTo: () => hasBccHistoryTo,
   hasCcHistoryTo: () => hasCcHistoryTo,
   installConsoleCapture: () => installConsoleCapture,
@@ -632,6 +633,12 @@ async function openAttachment(accountId, uid, attachmentId, folderId, filename)
 async function getMessageSource(accountId, uid, folderId) {
   return ipc().getMessageSource(accountId, uid, folderId);
 }
+async function grammarLint(blocks) {
+  const fn = ipc().grammarLint;
+  if (!fn)
+    throw new Error("no grammarLint bridge");
+  return fn(blocks);
+}
 async function registerMailto() {
   const fn = ipc().registerMailto;
   if (!fn)
@@ -11873,6 +11880,15 @@ getSettings().then((s) => {
     const px = Number(s.ui?.composeFontSize);
     fontEl.value = String(Number.isFinite(px) && px >= 8 && px <= 32 ? px : 15);
   }
+  const gcEl = document.getElementById("opt-grammar-check");
+  if (gcEl) {
+    const on = s.ui?.grammarCheck !== false;
+    gcEl.checked = on;
+    try {
+      localStorage.setItem("mailx-grammar-check", on ? "1" : "0");
+    } catch {
+    }
+  }
 }).catch(() => {
 });
 document.getElementById("opt-compose-window")?.addEventListener("change", (e) => {
@@ -11887,6 +11903,18 @@ document.getElementById("opt-compose-window")?.addEventListener("change", (e) =>
   }).catch(() => {
   });
 });
+document.getElementById("opt-grammar-check")?.addEventListener("change", (e) => {
+  const on = e.target.checked;
+  try {
+    localStorage.setItem("mailx-grammar-check", on ? "1" : "0");
+  } catch {
+  }
+  getSettings().then((settings) => {
+    settings.ui = { ...settings.ui, grammarCheck: on };
+    saveSettings(settings);
+  }).catch(() => {
+  });
+});
 document.getElementById("opt-compose-font-size")?.addEventListener("change", (e) => {
   const el = e.target;
   const px = Number(el.value);