@bobfrankston/rmfmail 1.2.112 → 1.2.114

package/TODO.md

@@ -13,13 +13,13 @@ These items don't need user input — source-only changes, compile-verified befo
 | Order | Item | Scope | Status |
 |---|---|---|---|
 | ~~1~~ | ~~**C118 — STATUS-before-SELECT in syncFolder**~~ — **DONE** (already implemented at `mailx-imap/index.ts:1079`; TODO entry was stale). | S | |
-| **2** | **C119 — Lazy folder sync** | M | Don't sync all 96 bobma folders on every periodic pass. Only sync (a) folders the user has expanded in the tree, (b) special-use folders (INBOX/Sent/Drafts/Trash), (c) folders touched by recent local actions. Other folders sync on-demand when user clicks them. Closes most of the Thunderbird-vs-mailx speed gap. Touches `mailx-imap/index.ts` syncAll loop. |
-| **3** | **C121 — Counting timer for server connect** | S | Visible elapsed-time counter while the connection is being established, so Bob can tell "DNS slow", "TCP handshake stuck", "TLS hung", "IMAP greeting missing", or "LOGIN slow" apart at a glance. Phases: `dns → tcp connect → tls handshake → imap greeting → LOGIN ack`. Each phase emits a start event with `phase` + `accountId`; client renders `Connecting to <host> (<phase>, 3.2s)` in the status bar with a 100 ms ticking elapsed counter. On success or failure, drop the indicator and log per-phase durations. Touches `node-tcp-transport.connect()` + `iflow-direct.imap-native.ts:connect`/`login` + a new `imapManager.emit("connectProgress", ...)` chain. Pairs naturally with C120 — same `connId` ID space so the timer indicator can name the connection that later times out. |
-| **4** | **C122 — Recent-unread count overlay on taskbar icon** | S | Show recent-unread count as a numeric overlay on the running mailx taskbar icon (Win11 style: small badge in the lower-right corner of the icon). `setOverlayIcon` is already wired (used as a placeholder); needs (a) a number-rendered overlay bitmap (1 / 2 / … / 9+ glyphs at 16×16 or via `DrawText` to a memory DC) and (b) hook into the unread-counter event chain so the badge updates when `folderCountsChanged` or `idle` events arrive. Distinct from S65 — that one is "badge persists when mailx isn't running" and is blocked on tray-process / Win11 Notification Center integration; this one is the *while-running* number. |
+| ~~2~~ | ~~**C119 — Lazy folder sync**~~ — **DONE** (shipped 2026-06-01; TODO entry was stale). `isLazyEligible` in `mailx-imap/index.ts` syncAccount: never-touched folders (highestUid=0, non-special) are not auto-swept at all — they sync on-demand via `syncFolderNow` when opened, then join the periodic set. Previously-seen folders stay in the sweep but C118's STATUS-before-SELECT makes an unchanged folder cost one round-trip. | M | |
+| ~~3~~ | ~~**C121 — Counting timer for server connect**~~ — **DONE v1** (2026-07-08, v1.2.111). `newClient` in `mailx-imap/index.ts` wraps the injected transport + `client.connect` and emits `connectProgress` (phases `socket` → `handshake` → `done`/`failed`); bin forwards as an event; `client/app.ts handleConnectProgress` renders `Connecting to <host> (<phase> <purpose>, 3.2s)` with a 100 ms ticker, gated to attempts >1.5 s so healthy connects never flicker. Connects >3 s log per-phase timings (`[conn-slow]`). *Residual*: splitting `socket` into dns/tcp/tls needs an `onConnectPhase` hook inside iflow-node's NodeTransport — do when next touching iflow. | S | |
+| ~~4~~ | ~~**C122 — Recent-unread count overlay on taskbar icon**~~ — **DONE** (shipped ~v1.1.x 2026-05-29; TODO entry was stale). `updateBadge` in `client/app.ts` renders the red count pill on a 32×32 canvas (badge-only, transparent field) and pushes it via `mailxapi.setTaskbarOverlay`; hooked to `folderCountsChanged` + startup via `updateNewMessageCount`. Badge shows NEW-since-last-seen, matching the "recent-unread" spec. S65 (badge while not running) remains open/blocked. | S | |
 | ~~5~~ | ~~**C126 — Cold-start latency (~28s observed)**~~ — **MOSTLY DONE** (2026-05-11). Root cause IDed from boot log: 43 s of cascading ES module imports through msger's custom protocol IPC (one roundtrip per file). Fixes shipped: (a) bundling via esbuild (`bin/build-bundles.mjs`) collapses the cascade to one fetch per entry point — `client/app.bundle.js` 345 kb, `client/compose/compose.bundle.js` 99 kb; (b) boot-snapshot hydration — bundled app saves `folder-tree` + `ml-body` innerHTML to localStorage every 30 s; inline script in `index.html` restores at cold start before the bundle has fetched. Sub-bullet (c) [500 ms placeholder pause] not in current code at cited line — skipped as stale. Expected cold start now 3-5 s (full WebView2 + bundle parse), with near-instant *feel* via hydrated snapshot after the first run. | M | |
 | **6** | **C125 — Unify desktop + Android IMAP code paths** | M | Today's split (`mailx-imap` Node-only + `mailx-store-web` browser-only) duplicates orchestration that's protocol-identical. Differences boil down to (a) transport factory choice (b) whether clients are persistent — both parameters, not architectural divides. Plan: extract `mailx-imap-core` with ImapManager + ops queue + fast-lane + sync orchestration over a `Transport` and a `Storage` interface, no Node-specific imports. `mailx-imap` and `mailx-store-web` become thin shims that wire engine-specific Storage + Transport. `{persistent: true\|false}` flag on ImapManager covers the lifetime split (no fast-lane queue when ephemeral). Pre-req for Android non-Gmail IMAP without forking sync code. |
-| **5** | **C124 — mailto handler on Linux + macOS** | S | Counterpart to P115 (Win). Linux: write a `~/.local/share/applications/rmfmail.desktop` with `MimeType=x-scheme-handler/mailto;` + `Exec=node /path/to/mailx.js --mailto %u`, `xdg-mime default rmfmail.desktop x-scheme-handler/mailto`, `update-desktop-database`. No exe-launcher needed — Linux pickers read `Name=` from the `.desktop` directly. macOS: real `.app` bundle (LaunchServices won't register a bare script) with `Info.plist` `CFBundleURLTypes` declaring `mailto` + a tiny launcher binary; `LSSetDefaultHandlerForURLScheme` programmatically sets the default. Rust `rmfmailto-src/` crate already portable — drop the Win32 imports and `cargo build --target x86_64-apple-darwin` produces the macOS launcher. |
-| **7** | **C154 — Audit Android bridge vs MailxApi contract** | S | The hand-written `installBridge()` api object in `mailx-store-web/android-bootstrap.ts` exposes ~45 fewer methods than `client/lib/api-client.ts` can call (`getThreadMessages`, `getOutboxStatus`, `unsubscribeOneClick`, calendar/tasks, user-dict, …). Any missing one fails as `parent bridge has no method "X"` from the compose/app IPC relay — that's how the ⊘ denylist button broke on the phone (fixed v1.2.109: added `addToDenylist`/`addPreferredContact`/`hasBccHistoryTo`/`loadContactsConfig`). Web-service already `implements MailxApi` with explicit stubs, so the gap is purely the bridge layer. Audit each remaining name: expose real impls + notImpl stubs (arg shapes per `client/lib/mailxapi.js`), consciously comment-skip desktop-only ones, and add a typed check or generic stub pass-through so the class of bug can't recur. |
+| **5** | **C124 — mailto handler on macOS** (Linux ✅ 2026-07-08 v1.2.111) | S | Linux half shipped: `--register-mailto` on linux writes `~/.local/share/applications/rmfmail.desktop` (`MimeType=x-scheme-handler/mailto;`, quoted node+mailx.js Exec, bare `%u`), runs `xdg-mime default` + `update-desktop-database`; `--unregister-mailto` removes it. **Remaining: macOS** — real `.app` bundle (LaunchServices won't register a bare script) with `Info.plist` `CFBundleURLTypes` declaring `mailto` + a tiny launcher binary; `LSSetDefaultHandlerForURLScheme` programmatically sets the default. Rust `rmfmailto-src/` crate already portable — drop the Win32 imports and `cargo build --target x86_64-apple-darwin` produces the macOS launcher. Needs a Mac to build/verify. |
+| ~~7~~ | ~~**C154 — Audit Android bridge vs MailxApi contract**~~ — **DONE** (2026-07-08, v1.2.111). Bridge now has a generic contract-backstop: every service method not explicitly adapted gets a positional pass-through, so a missing method can never again fail as `parent bridge has no method "X"`. Wire-shape mismatches adapted explicitly (`readJsoncFile`/`writeJsoncFile`/`formatJsonc`/`readConfigHelp` → `{content}`/`{ok}`, `drainStoreSync`/`syncFolderNow` → `{ok}`). Contract gained the missing entries (`getMessageSource`, `copyMessages`, `syncFolderNow`, `cancelServerSearch`, `getReminderSound`, `getCalendars`, optional `popoutWindow`) with web-service stubs per the policy (reads → graceful default, writes/OS → notImpl). Bonus fixes: bridge `getMessages` was dropping sort/sortDir/search and `searchMessages` was dropping scope/accountId/folderId — Android sort toggles and scoped search silently didn't work. | S | |
 ~~done — C120 read transport diagnostics~~ shipped v1.0.583 (per-folder timeout error now includes `[conn#X r=YB w=ZB writes=N sinceLastRead=Tms]` snapshot for the doomed socket).
 | 11 | **[P116](#ext116) — Signature edit in Settings menu** | M | Deferred v1.0.401 — turns out to be M (multi-account modal + save path + JSONC round-trip), not S. Real work when Settings UI gets its proper pass. |
 | 13 | **S56 full AbortController plumbing** | L | Thread `AbortSignal` through `getMessage → fetchMessageBody → provider.fetchOne`. Touches IMAP + Gmail + Outlook providers. |

package/bin/mailx.js

@@ -180,11 +180,61 @@ const isDaemon = hasFlag("daemon"); // internal: re-spawned detached process
 }
 if (hasFlag("register-mailto") || hasFlag("unregister-mailto")) {
     const unregister = hasFlag("unregister-mailto");
+    // C124: Linux registration — a .desktop entry claiming the mailto:
+    // scheme + xdg-mime default. No exe-launcher needed (unlike Windows):
+    // Linux pickers read Name= from the .desktop file directly.
+    if (process.platform === "linux") {
+        const appsDir = path.join(os.homedir(), ".local", "share", "applications");
+        const desktopPath = path.join(appsDir, "rmfmail.desktop");
+        if (unregister) {
+            try {
+                fs.unlinkSync(desktopPath);
+            }
+            catch { /* not registered */ }
+            try {
+                execSync(`update-desktop-database "${appsDir}"`);
+            }
+            catch { /* optional tool */ }
+            console.log("Unregistered rmfmail mailto: handler.");
+            process.exit(0);
+        }
+        const __mailtoJs = path.join(import.meta.dirname, "mailx.js");
+        const __iconPng = path.join(import.meta.dirname, "..", "client", "icon.png");
+        // Exec quoting follows the Desktop Entry spec: quoted absolute paths,
+        // bare %u field code (quoting %u breaks argument expansion).
+        const desktopEntry = [
+            "[Desktop Entry]",
+            "Type=Application",
+            "Name=rmfmail",
+            "Comment=rmfmail email client",
+            `Exec="${process.execPath}" "${__mailtoJs}" --mailto %u`,
+            `Icon=${__iconPng}`,
+            "Terminal=false",
+            "MimeType=x-scheme-handler/mailto;",
+            "Categories=Network;Email;",
+            "",
+        ].join("\n");
+        fs.mkdirSync(appsDir, { recursive: true });
+        fs.writeFileSync(desktopPath, desktopEntry);
+        try {
+            execSync("xdg-mime default rmfmail.desktop x-scheme-handler/mailto");
+        }
+        catch (e) {
+            console.error(`xdg-mime failed (${e.message}) — handler installed but not set as default. Set it in your DE's default-apps settings.`);
+        }
+        try {
+            execSync(`update-desktop-database "${appsDir}"`);
+        }
+        catch { /* optional tool */ }
+        console.log(`Registered rmfmail as mailto: handler (${desktopPath}).`);
+        process.exit(0);
+    }
     if (process.platform !== "win32") {
-        console.error("--register-mailto / --unregister-mailto are Windows-only.");
+        // macOS needs a real .app bundle with CFBundleURLTypes — LaunchServices
+        // won't register a bare script. Tracked as the macOS half of C124.
+        console.error("--register-mailto / --unregister-mailto: macOS registration not implemented yet (needs an .app bundle — TODO C124).");
         process.exit(1);
     }
-    const { execSync } = await import("node:child_process");
     // Registered command points at the rmfmailto.exe launcher (per-app
     // binary at %LOCALAPPDATA%\rmfmail\bin\rmfmailto.exe). The exe has its
     // own VERSIONINFO with FileDescription="rmfmail" so the Win11 "Select
@@ -1973,6 +2023,10 @@ RFC 5322 with CRLF line endings. Bodies are quoted-printable encoded (readable i
     let popoutInfo = null;
     let sendToClient = null;
     const popoutWindows = new Map();
+    // Timestamp of the most recent popout close — reported as a delta in the
+    // main-window shutdown log line to prove/refute the "closing a popout
+    // closes the main window" coupling (Bob 2026-07-06, unreproduced).
+    let lastPopoutClose = null;
     const popoutKey = (a, f, u) => `${a}|${f ?? ""}|${u}`;
     try {
         const { startPopoutServer } = await import("./popout-server.js");
@@ -2133,6 +2187,7 @@ RFC 5322 with CRLF line endings. Bodies are quoted-printable encoded (readable i
                 popoutWindows.delete(key);
                 if (typeof h.pid === "number")
                     removeChildPid(h.pid);
+                lastPopoutClose = { at: Date.now(), key };
                 console.log(`  [popout] window CLOSED pid=${h.pid ?? "?"} key=${key} — main daemon still pid=${process.pid}`);
             });
             return { ok: true };
@@ -2339,6 +2394,13 @@ RFC 5322 with CRLF line endings. Bodies are quoted-printable encoded (readable i
             }, 1000);
         }
     });
+    // C121: connect-phase progress → status-bar "Connecting to <host>
+    // (<phase>, N.Ns)" ticker. Low-rate (a handful of events per connection
+    // attempt), so no batching — the phase TRANSITIONS are the signal and
+    // coalescing them away would defeat the point.
+    imapManager.on("connectProgress", (accountId, info) => {
+        handle.send({ _event: "connectProgress", type: "connectProgress", accountId, ...info });
+    });
     imapManager.on("syncError", (accountId, error) => {
         handle.send({ _event: "error", type: "error", message: `${accountId}: ${error}` });
     });
@@ -2807,8 +2869,15 @@ RFC 5322 with CRLF line endings. Bodies are quoted-printable encoded (readable i
     // window ONLY — popout windows are separate showMessageBoxEx children and
     // must never resolve this. Log open popouts at shutdown so if a popout
     // close ever coincides with a main-window close we can see the timing.
+    // The 2026-07-06 incident (log 13:59:56) shows the main child's own Rust
+    // process emitting the close result 123ms after a popout interaction —
+    // the correlation delta below is what will prove/refute the coupling
+    // next time it fires.
     await handle.closed;
-    await gracefulShutdown(`Window closed (main service child; ${popoutWindows.size} popout window(s) still tracked)`);
+    const popoutDelta = lastPopoutClose
+        ? `; last popout closed ${Date.now() - lastPopoutClose.at}ms ago (${lastPopoutClose.key})`
+        : "; no popout closed this session";
+    await gracefulShutdown(`Window closed (main service child; ${popoutWindows.size} popout window(s) still tracked${popoutDelta})`);
 }
 main().catch(console.error);
 //# sourceMappingURL=mailx.js.map