@bobfrankston/rmfmail 1.1.228 → 1.1.231

package/client/app.js

@@ -601,6 +601,29 @@ function refreshSyncTooltip() {
 // Refresh the tooltip every 30s so the "(12m ago)" stays current even with
 // no new sync events.
 setInterval(refreshSyncTooltip, 30_000);
+// Honest "Synced" indicator. "Synced HH:MM" must mean sync is IDLE, not fire
+// on every tick — folderCountsChanged/syncProgress fire repeatedly during a
+// catch-up backfill (e.g. after the daemon was offline) while messages are
+// STILL arriving, so stamping "Synced" each time misled (Bob 2026-06-06: "it
+// says synced but I don't see this afternoon's mail" — they were mid-backfill).
+// Any sync activity (re)arms this settle timer; only when activity goes quiet
+// for SYNC_SETTLE_MS do we stamp the time. While the storm runs, the handlers
+// keep the bar on "Syncing…".
+let syncSettleTimer = null;
+const SYNC_SETTLE_MS = 4000;
+function scheduleSyncedStamp() {
+    if (syncSettleTimer)
+        clearTimeout(syncSettleTimer);
+    syncSettleTimer = setTimeout(() => {
+        syncSettleTimer = null;
+        const el = document.getElementById("status-sync");
+        // Only flip a "Syncing…" display to "Synced" — never clobber an error
+        // ("Sync error: …") or a transient action message ("Trashed 1 …").
+        if (el && (el.textContent || "").startsWith("Syncing")) {
+            el.textContent = `Synced ${new Date().toLocaleTimeString(undefined, { hour: "2-digit", minute: "2-digit", hour12: false })}`;
+        }
+    }, SYNC_SETTLE_MS);
+}
 // ── Auto two-line when message list is narrow ──
 const messageList = document.getElementById("message-list");
 if (messageList) {
@@ -1495,14 +1518,19 @@ async function deleteSelectedMessages() {
     // An IPC 120s timeout doesn't mean the trash failed — surfacing it
     // as a status-bar error would only mislead. Real errors are still
     // reported by next sync's diagnostics.
+    // Carry folderId per message so the daemon trashes the exact (folder, uid),
+    // not whatever folder a bare (account, uid) lookup happens to resolve to
+    // (Bob 2026-06-06: Del trashed the wrong message). uids/folderIds stay
+    // index-aligned per account.
     const byAccount = new Map();
     for (const msg of snapshot) {
-        const uids = byAccount.get(msg.accountId) || [];
-        uids.push(msg.uid);
-        byAccount.set(msg.accountId, uids);
+        const g = byAccount.get(msg.accountId) || { uids: [], folderIds: [] };
+        g.uids.push(msg.uid);
+        g.folderIds.push(msg.folderId);
+        byAccount.set(msg.accountId, g);
     }
-    for (const [accountId, uids] of byAccount) {
-        deleteMessages(accountId, uids).catch((e) => {
+    for (const [accountId, g] of byAccount) {
+        deleteMessages(accountId, g.uids, g.folderIds).catch((e) => {
             console.error(`Delete failed for ${accountId}: ${e?.message || e}`);
             if (statusSync)
                 statusSync.textContent = `Delete sync issue (${accountId}): ${e?.message || e}`;
@@ -2767,6 +2795,7 @@ onWsEvent((event) => {
                 statusSync.textContent = `Syncing ${event.accountId}: ${label}`;
             if (startupStatus)
                 startupStatus.textContent = `Syncing ${event.accountId}: ${label}`;
+            scheduleSyncedStamp(); // re-arm the settle timer; stamp "Synced" when this quiets
             // Mark syncing folder in tree — bubble up to visible parent if collapsed
             const syncPath = event.phase?.startsWith("sync:") ? event.phase.slice(5) : null;
             // Clear previous syncing markers for this account
@@ -2795,6 +2824,7 @@ onWsEvent((event) => {
             refreshFolderTree();
             // Q53: track per-account last-sync timestamp for the status-bar hover.
             recordAccountSync(event.accountId);
+            scheduleSyncedStamp(); // settle → "Synced HH:MM" once activity stops
             // Earlier I added reloadCurrentFolder() here to fix the
             // "phone INBOX stays on placeholder" report. That broke desktop
             // because syncComplete fires repeatedly on the desktop sync
@@ -2839,8 +2869,13 @@ onWsEvent((event) => {
                 syncBtn.disabled = false;
                 syncBtn.classList.remove("syncing");
             }
-            if (statusSync)
-                statusSync.textContent = `Synced ${new Date().toLocaleTimeString(undefined, { hour: "2-digit", minute: "2-digit", hour12: false })}`;
+            // Honest indicator: a count change means activity, not necessarily
+            // "done". Show "Syncing…" and let the settle timer stamp the time
+            // once the backfill goes quiet (see scheduleSyncedStamp).
+            if (statusSync && !(statusSync.textContent || "").startsWith("Sync error")) {
+                statusSync.textContent = "Syncing…";
+            }
+            scheduleSyncedStamp();
             break;
         }
         case "updateAvailable": {