npm - @bobfrankston/rmfmail - Versions diffs - 1.1.199 → 1.1.201 - Mend

@bobfrankston/rmfmail 1.1.199 → 1.1.201

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (18) hide show

package/TODO.md +4 -2
package/client/app.bundle.js +39 -11
package/client/app.bundle.js.map +2 -2
package/client/app.js +29 -11
package/client/app.js.map +1 -1
package/client/app.ts +29 -11
package/client/components/message-list.js +48 -0
package/client/components/message-list.js.map +1 -1
package/client/components/message-list.ts +47 -0
package/package.json +3 -3
package/packages/mailx-imap/index.d.ts.map +1 -1
package/packages/mailx-imap/index.js +8 -0
package/packages/mailx-imap/index.js.map +1 -1
package/packages/mailx-imap/index.ts +8 -0
package/packages/mailx-imap/package-lock.json +2 -2
package/packages/mailx-imap/package.json +1 -1
package/packages/mailx-settings/package.json +1 -1
/package/packages/mailx-imap/{node_modules.npmglobalize-stash-77016 → node_modules.npmglobalize-stash-50612}/.package-lock.json +0 -0

package/TODO.md CHANGED Viewed

@@ -236,10 +236,12 @@ Previously shown as showstoppers; moved here because they haven't recurred on re
 Small, self-contained items. Pick them up between higher-priority blocks without asking. Bump version per fix.
+- ~~**Q152 — "Edit as new message" / resend on a sent (or any) message.**~~ **DONE 2026-05-31.** New `editAsNew` compose mode in `client/app.ts` (`openCompose` branch + `editAsNewBody` helper) clones the selected message into a fresh compose: original To/Cc/Subject verbatim, body via `sanitizeQuotedBody` with no quote/forward wrapper, no In-Reply-To/References (new Message-ID at send). Right-click menu entry "Edit as new message" added after Forward in `message-list.ts`. Replaces the move-to-Drafts kludge. *(Original entry below.)* Bob 2026-05-29: no clean way to take an already-sent message, tweak it, and send it again — today's only path is move-to-Drafts-then-edit (a kludge) or Forward (adds `Fwd:` + quote wrapper, wrong recipients). Add an **"Edit as new message"** affordance — in the viewer toolbar (next to Forward) and/or the message-list right-click menu — that loads the selected message's `.eml` **straight into a fresh compose** as the author: original To/Cc/Subject/body editable, **no `Fwd:`/`Re:` prefix, no quote indent, no In-Reply-To/References threading headers**, a new Message-ID. Effectively "duplicate into compose." Distinct from the existing Drafts `Edit & Send` (that edits the draft in place); this clones any message into a new outgoing draft. Reuse the compose-init plumbing the draft-edit path already uses (`showComposeOverlay` + the init payload built in `app.ts`); the only difference is which headers get stripped vs. carried. Most natural as the message-viewer From/To right-click "duplicate"-style action plus a toolbar button gated on non-draft messages. [S]
+- ~~**Preview CSS leak — `<style>`/`<head>` contents bled into the message-list one-liner.**~~ DONE 2026-05-31. `extractPreview` (`mailx-imap/index.ts`) flattened HTML by stripping tags only, leaving the CSS *between* `<style>…</style>` (and `<head>`/`<script>`) in the preview as `*{box-sizing…}` / `@media…{…}` garbage (Bob's marketing-mail shot). Now strips those block contents + HTML comments before the tag-strip; `[image]` marker preserved. IMAP-path only (Gmail uses Google's clean snippet). Existing rows refresh via `rmfmail -repair`.
 - ~~**Q138 — Quoted-reply image sizes lost.**~~ DONE 2026-05-11 in `client/app.ts:1000` — strip skips `<img>`. Two-pass loop handles multiple stripped attrs per tag.
-- **Q140 — User-configurable holiday calendars (generalization).** Today the holiday-pull list is hardcoded to two Google calendars: `en.usa.official#holiday` (federal-secular) and `en.judaism#holiday` (Jewish), each with its own sidebar checkbox + leading symbol (🇺🇸 / ✡). Bob 2026-05-11: "Static calendars are OK. You can add generalization to the maybe-future list. Unlikely to do unless I want a more general audience." When that audience expands, generalize to `settings.calendar.holidayCalendars: Array<{ id: string; label: string; symbol: string; enabled: boolean }>`. The refresh loop iterates the array; the sidebar renders one checkbox per entry plus its symbol on each row; a small editor in Settings → calendar lets the user add/remove entries by calendar ID. Schema-side `calendar_id` column already partitions rows by source, so toggling one off doesn't affect the others — the existing reconcile logic carries straight over.
+- ~~**Q140 — User-configurable holiday calendars (generalization).**~~ **RETIRED 2026-05-29 — already dynamic, superseded by Q143.** Bob: the holiday list is pulled automatically from whatever calendars the user has selected in Google Calendar, so it's dynamic already. Confirmed in code: `refreshCalendarEvents` enumerates `listCalendars().filter(c => c.selected)` and tags each row with its source; the old hardcoded `HOLIDAY_SOURCES` + `showHolidays`/`showJewishHolidays` toggles are retired (`mailx-service/index.ts:1485`). The user curates the set in Google's web UI — no in-app holiday-calendar editor needed. The curation-gotcha + Hebcal notes below are kept only as reference IF a free-form calendar-ID *picker* is ever added (not currently planned — selection happens in Google, not mailx).
-  **Curation gotcha worth carrying into the implementation**: Google's `<locale>.<tradition>#holiday@group.v.calendar.google.com` IDs are NOT all clean per-tradition feeds. The "obvious" IDs are mis-curated catch-alls; the `.official` / proper-noun variant is the actually-clean source for each tradition. Documented examples from 2026-05-11 testing:
+  **Curation gotcha (reference only)**: Google's `<locale>.<tradition>#holiday@group.v.calendar.google.com` IDs are NOT all clean per-tradition feeds. The "obvious" IDs are mis-curated catch-alls; the `.official` / proper-noun variant is the actually-clean source for each tradition. Documented examples from 2026-05-11 testing:
   - `en.usa#holiday` — mixed (federal + Christian + Jewish + Orthodox + Armenian + Ethiopian Jewish + …)
   - `en.usa.official#holiday` — clean federal-secular
   - `en.jewish#holiday` — mixed (Jewish + Christian + Orthodox neighbors)

package/client/app.bundle.js CHANGED Viewed

@@ -2595,10 +2595,29 @@ __export(message_list_exports, {
   reloadCurrentFolder: () => reloadCurrentFolder,
   removeMessagesAndReconcile: () => removeMessagesAndReconcile,
   scrollFocusedIntoView: () => scrollFocusedIntoView,
+  setLiveFilter: () => setLiveFilter,
   setRowFlagged: () => setRowFlagged,
   setRowSeen: () => setRowSeen,
   showThreadPopup: () => showThreadPopup
 });
+function setLiveFilter(query) {
+  liveFilterText = (query || "").trim().toLowerCase();
+  const body = document.getElementById("ml-body");
+  if (body)
+    applyLiveFilter(body);
+}
+function applyLiveFilter(body) {
+  if (!liveFilterText) {
+    for (const row of body.querySelectorAll(".ml-row.filter-hidden")) {
+      row.classList.remove("filter-hidden");
+    }
+    return;
+  }
+  for (const row of body.querySelectorAll(".ml-row")) {
+    const text = row.textContent?.toLowerCase() || "";
+    row.classList.toggle("filter-hidden", !text.includes(liveFilterText));
+  }
+}
 function cacheKey(mode, a, f, flagged, q) {
   if (mode === "folder")
     return `folder:${a}:${f}:${flagged ? "flag" : ""}`;
@@ -3034,6 +3053,8 @@ function removeMessagesAndReconcile(uids) {
 function reloadCurrentFolder() {
   if (searchMode)
     return;
+  if (liveFilterText)
+    return;
   if (unifiedMode) {
     loadUnifiedInbox(false);
   } else if (currentAccountId2 && currentFolderId) {
@@ -3042,6 +3063,7 @@ function reloadCurrentFolder() {
 }
 function clearSearchMode() {
   searchMode = false;
+  liveFilterText = "";
   currentSearchQuery = "";
   if (wasUnifiedBeforeSearch)
     unifiedMode = true;
@@ -3114,6 +3136,7 @@ async function loadSearchResults(query, scope = "all", accountId = "", folderId
   if (!searchMode)
     wasUnifiedBeforeSearch = unifiedMode;
   searchMode = true;
+  liveFilterText = "";
   unifiedMode = false;
   currentSearchQuery = query;
   currentPage = 1;
@@ -3307,6 +3330,8 @@ function renderMessages(body, accountId, items) {
       focusedRow = null;
     }
   }
+  if (liveFilterText)
+    applyLiveFilter(body);
 }
 function selectFirst(body) {
   if (window.innerWidth <= 768)
@@ -3478,7 +3503,7 @@ function escapeHtml2(s) {
   div.textContent = s;
   return div.innerHTML;
 }
-var onMessageSelect, currentAccountId2, currentFolderId, currentSpecialUse, lastClickedRow, currentPage, totalMessages, loading, unifiedMode, searchMode, currentSearchQuery, wasUnifiedBeforeSearch, showToInsteadOfFrom, touchWasScroll, currentSort, currentSortDir, loadGen, listCache, CACHE_KEY_UNIFIED, positionMemory, POSITION_STORAGE_KEY, focusedRow, rowByKey, prioritySenders, priorityDomains, timeFmt, dateFmt, dateFmtSameYear, MessageRow;
+var onMessageSelect, currentAccountId2, currentFolderId, currentSpecialUse, lastClickedRow, currentPage, totalMessages, loading, unifiedMode, searchMode, liveFilterText, currentSearchQuery, wasUnifiedBeforeSearch, showToInsteadOfFrom, touchWasScroll, currentSort, currentSortDir, loadGen, listCache, CACHE_KEY_UNIFIED, positionMemory, POSITION_STORAGE_KEY, focusedRow, rowByKey, prioritySenders, priorityDomains, timeFmt, dateFmt, dateFmtSameYear, MessageRow;
 var init_message_list = __esm({
   "client/components/message-list.js"() {
     "use strict";
@@ -3493,6 +3518,7 @@ var init_message_list = __esm({
     loading = false;
     unifiedMode = false;
     searchMode = false;
+    liveFilterText = "";
     currentSearchQuery = "";
     wasUnifiedBeforeSearch = false;
     showToInsteadOfFrom = false;
@@ -3983,6 +4009,7 @@ var init_message_list = __esm({
           { label: "Reply", action: () => document.dispatchEvent(new CustomEvent("mailx-compose", { detail: { mode: "reply" } })) },
           { label: "Reply All", action: () => document.dispatchEvent(new CustomEvent("mailx-compose", { detail: { mode: "replyAll" } })) },
           { label: "Forward", action: () => document.dispatchEvent(new CustomEvent("mailx-compose", { detail: { mode: "forward" } })) },
+          { label: "Edit as new message", action: () => document.dispatchEvent(new CustomEvent("mailx-compose", { detail: { mode: "editAsNew" } })) },
           { label: "", action: () => {
           }, separator: true },
           {
@@ -7434,13 +7461,13 @@ document.getElementById("btn-factory-reset")?.addEventListener("click", async ()
 async function openCompose(mode, overrideMsg, overrideAccountId) {
   logClientEvent("openCompose-entry", { mode });
   const current = overrideMsg ? { message: overrideMsg, accountId: overrideAccountId || currentAccountId3 } : getCurrentMessage();
-  if ((mode === "reply" || mode === "replyAll" || mode === "forward") && !current) {
+  if ((mode === "reply" || mode === "replyAll" || mode === "forward" || mode === "editAsNew") && !current) {
     console.warn(`[compose] ${mode} \u2014 no message selected`);
     return;
   }
   const accountsP = getAccounts();
   const msg = current?.message;
-  const titlePrefix = mode === "reply" ? "Reply" : mode === "replyAll" ? "Reply All" : mode === "forward" ? "Forward" : "Compose";
+  const titlePrefix = mode === "reply" ? "Reply" : mode === "replyAll" ? "Reply All" : mode === "forward" ? "Forward" : mode === "editAsNew" ? "Edit as new" : "Compose";
   const titleSubject = mode === "new" ? "" : msg?.subject || "";
   const frame = showComposeOverlay(titleSubject ? `${titlePrefix}: ${titleSubject}` : titlePrefix);
   const accounts = await accountsP;
@@ -7548,6 +7575,11 @@ async function openCompose(mode, overrideMsg, overrideAccountId) {
     init.subject = `Fwd: ${cleanSubject}`;
     init.bodyHtml = forwardBody(msg);
     init.fromAddress = detectReplyFrom();
+  } else if (msg && mode === "editAsNew") {
+    init.to = Array.isArray(msg.to) ? msg.to : [];
+    init.cc = Array.isArray(msg.cc) ? msg.cc : [];
+    init.subject = msg.subject || "";
+    init.bodyHtml = editAsNewBody(msg);
   }
   const initJson = JSON.stringify(init);
   try {
@@ -7795,6 +7827,9 @@ function quoteBody(msg) {
   const body = sanitizeQuotedBody(msg);
   return `<p></p><br><br><div class="reply"><p>On ${date}, ${from} wrote:</p><blockquote>${body}</blockquote></div>`;
 }
+function editAsNewBody(msg) {
+  return `<p></p>${sanitizeQuotedBody(msg)}`;
+}
 function forwardBody(msg) {
   const date = new Date(msg.date).toLocaleString();
   const from = msg.from.name ? `${msg.from.name} &lt;${msg.from.address}&gt;` : msg.from.address;
@@ -8381,14 +8416,7 @@ function doSearch(immediate = false) {
   }
   cancelServerSearch();
   if (localScope === "current" && !serverOn && !immediate) {
-    const body = document.getElementById("ml-body");
-    if (body) {
-      const lower = query.toLowerCase();
-      for (const row of body.querySelectorAll(".ml-row")) {
-        const text = row.textContent?.toLowerCase() || "";
-        row.classList.toggle("filter-hidden", !text.includes(lower));
-      }
-    }
+    setLiveFilter(query);
     return;
   }
   const localScopeEff = localScope === "current" ? "current" : "all";