@bobfrankston/rmfmail 1.1.186 → 1.1.188

package/client/app.js

@@ -3609,14 +3609,38 @@ document.addEventListener("pointerdown", (e) => {
     // close-then-reopen-then-close.
     if (target.closest("#btn-view, #btn-settings, #rail-view, #rail-settings, #rail-menu-backdrop"))
         return;
-    if (viewDropdown && !viewDropdown.hidden && !target.closest("#view-menu") && !target.closest("#view-dropdown")) {
-        viewDropdown.hidden = true;
-    }
-    if (settingsDropdown && !settingsDropdown.hidden && !target.closest("#settings-menu") && !target.closest("#settings-dropdown")) {
-        settingsDropdown.hidden = true;
-    }
+    // Re-query the dropdown elements FRESH on every pointerdown rather than
+    // using the module-load-time references. If anything re-rendered the
+    // toolbar (theme change, update banner, settings-applied repaint) the
+    // cached node is detached and `.hidden = true` on it does nothing while
+    // the live element stays visible — the "menu won't close until I restart
+    // the app" bug (Bob 2026-05-28). Querying live makes it robust against
+    // element replacement.
+    const viewDd = document.getElementById("view-dropdown");
+    const settingsDd2 = document.getElementById("settings-dropdown");
+    if (viewDd && !viewDd.hidden && !target.closest("#view-menu") && !target.closest("#view-dropdown")) {
+        hideDropdownHard(viewDd);
+    }
+    if (settingsDd2 && !settingsDd2.hidden && !target.closest("#settings-menu") && !target.closest("#settings-dropdown")) {
+        hideDropdownHard(settingsDd2);
+    }
+    document.getElementById("rail-menu-backdrop")?.remove();
     refreshToolbarOverlayShield();
 }, true);
+/** Hide a toolbar/rail dropdown so it STAYS hidden regardless of how it was
+ *  opened. `.hidden = true` alone isn't enough when the rail path left inline
+ *  `position:fixed; display/visibility` styles on the element — an inline
+ *  `display` would override the `[hidden]` UA rule and the menu would stay
+ *  visible until an app restart cleared the element (Bob 2026-05-28 "click
+ *  outside the settings menu but it does not go away"). Clear the inline
+ *  style block too so nothing can keep it on screen. */
+function hideDropdownHard(dd) {
+    dd.hidden = true;
+    // Wipe rail-modal inline styles (position/top/left/transform/zIndex/…).
+    // Safe for the toolbar path too — its position comes from CSS classes,
+    // not inline styles, so clearing inline leaves it correct.
+    dd.style.cssText = "";
+}
 // Click-to-dismiss for the toolbar dropdowns relies on `pointerdown` firing
 // on the parent document. Clicks inside the compose iframe stay in the
 // iframe's document and never bubble out, so a Settings/View menu opened