@bobfrankston/rmfmail 1.0.694 → 1.0.696

package/client/app.js

@@ -1232,21 +1232,23 @@ async function deleteSelectedMessages() {
         if (statusSync?.textContent?.includes("undo"))
             statusSync.textContent = "";
     }, 30000);
-    try {
-        const byAccount = new Map();
-        for (const msg of snapshot) {
-            const uids = byAccount.get(msg.accountId) || [];
-            uids.push(msg.uid);
-            byAccount.set(msg.accountId, uids);
-        }
-        for (const [accountId, uids] of byAccount) {
-            await deleteMessages(accountId, uids);
-        }
-    }
-    catch (e) {
-        console.error(`Delete failed: ${e.message}`);
-        if (statusSync)
-            statusSync.textContent = `Delete failed: ${e?.message || e}`;
+    // Fire-and-forget per local-first: optimistic remove above already
+    // updated the UI; the daemon-side trash is sync DB + queued IMAP.
+    // An IPC 120s timeout doesn't mean the trash failed — surfacing it
+    // as a status-bar error would only mislead. Real errors are still
+    // reported by next sync's diagnostics.
+    const byAccount = new Map();
+    for (const msg of snapshot) {
+        const uids = byAccount.get(msg.accountId) || [];
+        uids.push(msg.uid);
+        byAccount.set(msg.accountId, uids);
+    }
+    for (const [accountId, uids] of byAccount) {
+        deleteMessages(accountId, uids).catch((e) => {
+            console.error(`Delete failed for ${accountId}: ${e?.message || e}`);
+            if (statusSync)
+                statusSync.textContent = `Delete sync issue (${accountId}): ${e?.message || e}`;
+        });
     }
 }
 async function undoDelete() {
@@ -1357,28 +1359,31 @@ async function spamSelectedMessages() {
     // sync is a background detail, the user's action should feel instant.
     const snapshot = [...selected];
     removeMessagesAndReconcile(selected);
-    try {
-        const byAccount = new Map();
-        for (const msg of snapshot) {
-            const uids = byAccount.get(msg.accountId) || [];
-            uids.push(msg.uid);
-            byAccount.set(msg.accountId, uids);
-        }
-        for (const [accountId, uids] of byAccount) {
-            const result = await markAsSpamMessages(accountId, uids);
-            console.log(`[spam] ${accountId}: moved ${result?.moved ?? uids.length} to folderId=${result?.targetFolderId}`);
-        }
-        if (statusSync)
-            statusSync.textContent = `Spam: ${snapshot.length} queued — pending server sync`;
+    // Fire-and-forget per local-first: the optimistic remove above has
+    // already updated the UI; the service-side move is sync DB + queued
+    // IMAP. An IPC 120s timeout here doesn't mean the move failed — it
+    // means the response is stuck behind a long-running prior op (e.g.
+    // simpleParser blocking the event loop). The local commit and server
+    // sync still happen. Surfacing it as a failure with an alert lies to
+    // the user; the next folder reload reconciles either way.
+    const byAccount = new Map();
+    for (const msg of snapshot) {
+        const uids = byAccount.get(msg.accountId) || [];
+        uids.push(msg.uid);
+        byAccount.set(msg.accountId, uids);
     }
-    catch (e) {
-        console.error(`[spam] failed:`, e);
-        if (statusSync)
-            statusSync.textContent = `Spam failed: ${e?.message || e}`;
-        alert(`Mark-as-spam failed: ${e?.message || e}\n\n${selected.length} message(s) stayed in the list; check Settings → account spam folder and accounts.jsonc.`);
-        // Best-effort restore: re-set the messages we optimistically removed.
-        // removeMessages has no inverse in message-state, so we'll rely on the
-        // next folder reload to repopulate. Surface the failure clearly.
+    if (statusSync)
+        statusSync.textContent = `Spam: ${snapshot.length} queued — pending server sync`;
+    for (const [accountId, uids] of byAccount) {
+        markAsSpamMessages(accountId, uids)
+            .then(result => {
+            console.log(`[spam] ${accountId}: moved ${result?.moved ?? uids.length} to folderId=${result?.targetFolderId}`);
+        })
+            .catch(e => {
+            console.error(`[spam] ${accountId} failed:`, e);
+            if (statusSync)
+                statusSync.textContent = `Spam sync issue (${accountId}): ${e?.message || e}`;
+        });
     }
 }
 document.getElementById("btn-spam")?.addEventListener("click", spamSelectedMessages);