@bobfrankston/rmfmail 1.0.667 → 1.0.668

package/client/components/calendar-sidebar.ts

@@ -599,25 +599,34 @@ export function initCalendarSidebar(): void {
             refresh();
         });
     }
-    // Q131: Show-holidays toggle. Lives in service settings (not localStorage)
-    // because the daemon decides whether to pull from the US holidays
-    // calendar — so this preference has to round-trip to it.
-    const holiCb = document.getElementById("cal-side-show-holidays") as HTMLInputElement | null;
-    if (holiCb && !(holiCb as any).__wired) {
-        (holiCb as any).__wired = true;
+    // Holiday-calendar toggles. Each lives in service settings (not
+    // localStorage) because the daemon's refresh loop decides which
+    // calendars to pull — the preference has to round-trip to it.
+    // Two separate Google public calendars today: US federal holidays
+    // and Jewish holidays. Generalization to arbitrary user-supplied
+    // calendars is filed as Q140 (low priority unless the audience
+    // broadens beyond Bob).
+    const wireHolidayCheckbox = (
+        cbId: string,
+        settingsKey: "showHolidays" | "showJewishHolidays",
+    ): void => {
+        const cb = document.getElementById(cbId) as HTMLInputElement | null;
+        if (!cb || (cb as any).__wired) return;
+        (cb as any).__wired = true;
         getSettings().then((s: any) => {
-            holiCb.checked = !!s?.calendar?.showHolidays;
+            cb.checked = !!s?.calendar?.[settingsKey];
         }).catch(() => { /* */ });
-        holiCb.addEventListener("change", async () => {
+        cb.addEventListener("change", async () => {
             try {
                 const s = await getSettings();
-                s.calendar = { ...(s.calendar || {}), showHolidays: holiCb.checked };
+                s.calendar = { ...(s.calendar || {}), [settingsKey]: cb.checked };
                 await saveSettings(s);
-            } catch (e: any) { console.error("[cal] showHolidays save failed:", e); }
-            // Service picks up the new value on the next refresh tick.
+            } catch (e: any) { console.error(`[cal] ${settingsKey} save failed:`, e); }
             refresh();
         });
-    }
+    };
+    wireHolidayCheckbox("cal-side-show-holidays", "showHolidays");
+    wireHolidayCheckbox("cal-side-show-jewish-holidays", "showJewishHolidays");
     // Horizon input — how many days ahead to list events. Bounded 1..365.
     const horizonInput = document.getElementById("cal-side-horizon") as HTMLInputElement | null;
     if (horizonInput && !(horizonInput as any).__wired) {