@bobfrankston/rmfmail 1.0.634 → 1.0.640

package/TODO.md

@@ -215,7 +215,7 @@ Items blocked on a design decision. Short-form question here; full context in th
 | [**C46**](#ext46) | PARTIAL | Mailto handler split out as [P115](#ext115) (registry-only, not blocked). Remaining (Share target, tray, notifications, MSIX) still blocked on MSIX packaging. |
 | **C127** | OPTIONAL | **Push relay for calendar / mail / tasks** — design at [`docs/push-relay.md`](push-relay.md). New `MailApps/relayer/` package, alerter-shape (single Node Express+ws process, deploy alongside other small services). Generic API: client POSTs `/subscribe` with upstream + params, relay registers the upstream `events.watch` and returns an SSE/WS endpoint the client holds open. Per-upstream adapter files (`google-calendar.ts`, `google-gmail.ts`, `ms-graph-events.ts`); fan-out + replay buffer + subscription store generic. Client side: `pushRelayUrl` + credentials in settings, falls back to syncToken polling when relay unreachable. **Build only when polling latency demonstrably matters** — for typical use, 5–10 s syncToken cadence is functionally instant. Push is a freshness boost, not a correctness fix. |
 | **C128** | OPEN | **Body pre-parse on prefetch** — first click on any unviewed message pays `simpleParser` + `sanitizeHtml` cost (~100–500 ms on rich HTML). The parsedCache (added 2026-05-09) eliminates 2nd-and-later view costs but not the first. Fix: extend prefetch to ALSO parse + sanitize the body during background fetch and store the result alongside the .eml (e.g., `<uuid>.parsed.json` next to `<uuid>.eml`, or a `body_html_cached` column). Click-time path reads pre-parsed JSON, no parser invocation. Touches `mailx-imap/index.ts` prefetch path + `mailx-store/file-store.ts` for the parsed-blob storage. |
-| **C129** | OPEN | **Android prod/dev split via parallel MAUI projects** — User 2026-05-09: production APK from current default MAUI project, dev APK from a sibling `MailxAppDev/` project under `android-maui/`. Different package id (`com.frankston.rmfmail` vs `com.frankston.rmfmail.dev`), different AUMID, side-by-side install possible. Each builds independently; release flow: dev folder publishes APK, prod folder publishes APK from a known-good source state. Re-visit when desktop dist-tag flow has settled and Android needs the same separation. Notes-only until that time. |
+| **C129** | OPEN | **Android prod/dev split via filename/URL channel** — User 2026-05-09 (revised): no separate MAUI project. Same source tree builds; output filenames distinguish channels: Phase 1 (start now) writes `rmfmaildev.apk` alongside today's `mailx-maui.apk`. Phase 2 (when a release is declared) switches to `rmfmail-<version>.apk` versioned + `rmfmaildev.apk` for latest, with promotion = re-pointing `rmfmail.apk` at a chosen version. Single APK contents per build; channel is runtime setting in AppUpdater (Settings toggle for which URL to poll). Side-by-side install on one device NOT supported by this design (single Android package id) — that's a separate need. See `docs/prod-android.md` for full plan. Phase 1 ~30 min; full flow ~2.5 hours when activated. |
 | **C130** | OPEN | **Reset prefetch error budget after fresh sync** — Android: `errors`/`failedThisSession` accumulate within a prefetch session. Already resets on next syncAll cycle (since each `prefetchBodies(account)` call is fresh). Verify this works in practice via logit; if a long sync session burns through budget and stays stuck, add an explicit reset on `bodyAvailable` events that fire while prefetch is still running. |
 
 <a id="concerns"></a>
@@ -236,6 +236,8 @@ Previously shown as showstoppers; moved here because they haven't recurred on re
 
 Small, self-contained items. Pick them up between higher-priority blocks without asking. Bump version per fix.
 
+- **Q132 — importgen bugs blocking "always use importgen" rule for rmfmail.** Three issues, fix in `y:\dev\utils\importgen`: (1) reads CWD's `package.json`, so running from `client/` reads `client/package.json` (declares only quill); needs a `-p` flag or to walk up. (2) `resolveEntryPoint` blows up on packages with conditional `exports` (e.g. `".": { "import": { "node": "...", "browser": "..." } }`) — `dotExport.import` becomes an object, then `entryPoint.startsWith` throws. (3) Doesn't follow dynamic `await import()` calls if it scans imports rather than package.json deps (still need to verify which path it actually takes). Until fixed, rmfmail's import map is hand-maintained.
+- **Q131 — Show holidays in calendar sidebar.** Thunderbird-style "Show holidays" checkbox. When checked, daemon's `getCalendarEvents` ALSO fetches `en.usa#holiday@group.v.calendar.google.com` (Google's standard US holidays) and merges into results, marking each with `isHoliday: true`. UI renders holiday rows with a distinct style (muted color, no edit/delete actions). Concrete edits: (a) `mailx-service/index.ts` line 1075ish `getCalendarEvents` — also call `gsync.listCalendarEvents(tp, fromMs, toMs, "en.usa#holiday@group.v.calendar.google.com")` when settings.calendar.showHolidays is true, store with `is_holiday=1` flag; (b) `mailx-store/db.ts` `calendar_events` schema — add `is_holiday` column; (c) `client/components/calendar-sidebar.ts` — render rows with `data-holiday="1"` styled distinctly; (d) settings UI radio/checkbox in the calendar sidebar's options popover. ~2 hours.
 - **Q117 — Spring-loaded folders (drag-hover-expand).** When the user is dragging messages and hovers over a collapsed folder in the folder tree, expand it after a short hover delay so the user can see / target child folders. Auto-collapse back to its prior state when the drag leaves the folder OR the drop completes. Standard pattern in Outlook / Thunderbird / Finder. Implementation: `dragenter` on a folder row starts a timer (named constant `DRAG_HOVER_EXPAND_MS`, ~600ms target); `dragleave` cancels; on timer fire, set an `expanded-during-drag` flag and toggle the disclosure triangle. `dragend` / `drop` walks back up clearing flags and restoring prior state. No persistence — purely transient. (Per `feedback_no_magic_numbers.md`: timing values go in named constants, not inline.)
 - **Verify rail-view / rail-settings dropdowns in narrow mode (paused 2026-04-30).** Added `rail-view` icon (👁) and `openMenuFromRail()` in `client/app.ts` that reparents the toolbar dropdown to `<body>` and switches to `position:fixed` anchored to the rail icon — so the toolbar's `display:none` in narrow mode no longer hides the menu. Compile not yet re-verified after the edits because Bash kept wedging; user paused to start the monorepo reorg (mailx → mailxapp). When resuming: run `tsc` in `client/`, sanity-check that opening View / Settings from the rail in narrow mode shows the dropdown anchored next to the icon, and that toolbar buttons in wide mode still work (they just toggle `hidden` on the same dropdown DOM, which is now a body child but still works).
 

package/client/app.js

@@ -3811,6 +3811,22 @@ const settingsBtn = document.getElementById("btn-settings");
 const settingsDropdown = document.getElementById("settings-dropdown");
 const optEditorQuill = document.getElementById("opt-editor-quill");
 const optEditorTiptap = document.getElementById("opt-editor-tiptap");
+const optEditorTinymce = document.getElementById("opt-editor-tinymce");
+const optTinymceCdn = document.getElementById("opt-tinymce-cdn");
+// Restore TinyMCE CDN URL (Android-only path) from localStorage; the
+// adapter reads it on demand. Persisted client-side because it's a
+// per-device setting (Android needs CDN; desktop has npm install).
+try {
+    if (optTinymceCdn)
+        optTinymceCdn.value = localStorage.getItem("mailx-tinymce-cdn") || "";
+}
+catch { /* */ }
+optTinymceCdn?.addEventListener("change", () => {
+    try {
+        localStorage.setItem("mailx-tinymce-cdn", optTinymceCdn.value.trim());
+    }
+    catch { /* */ }
+});
 settingsBtn?.addEventListener("click", (e) => {
     e.stopPropagation();
     if (viewDropdown)
@@ -3830,6 +3846,8 @@ getSettings().then((s) => {
         optEditorQuill.checked = ed === "quill";
     if (optEditorTiptap)
         optEditorTiptap.checked = ed === "tiptap";
+    if (optEditorTinymce)
+        optEditorTinymce.checked = ed === "tinymce";
 }).catch(() => { });
 // Save editor choice to server settings
 function saveEditorSetting(editor) {
@@ -3846,6 +3864,10 @@ optEditorTiptap?.addEventListener("change", () => {
     if (optEditorTiptap.checked)
         saveEditorSetting("tiptap");
 });
+optEditorTinymce?.addEventListener("change", () => {
+    if (optEditorTinymce.checked)
+        saveEditorSetting("tinymce");
+});
 // External editor preference (Edit-in-Word handoff target). Stored under
 // settings.externalEditor so the service can read it via loadSettings().
 // "auto" tries Word → LibreOffice → OS default; explicit values force