@bobfrankston/rmfmail 1.0.607 → 1.0.619

package/client/app.js

@@ -9,8 +9,36 @@ import { connectWebSocket, onWsEvent, triggerSync, syncAccount, reauthenticate,
 import * as messageState from "./lib/message-state.js";
 // ── New message badge (favicon + title) ──
 /** The user-visible app name. Single point of change for the rename;
- *  every UI surface that shows "rmfmail" reads from here. */
+ *  every UI surface that shows "rmfmail" reads from here. Static HTML
+ *  uses placeholder text that `propagateAppName` (called immediately
+ *  below) overwrites — so the constant is the only place the literal
+ *  string lives. */
 export const APP_NAME = "rmfmail";
+/** Stamp APP_NAME into every static HTML element that should show it.
+ *  Runs synchronously at module load — before paint when imports are
+ *  fast, with a sub-frame flash of the placeholder otherwise. Add new
+ *  surfaces here, never inline literals. */
+function propagateAppName() {
+    const set = (id, fn) => {
+        const el = document.getElementById(id);
+        if (el)
+            el.textContent = fn(APP_NAME);
+    };
+    document.title = APP_NAME;
+    set("startup-status", n => `Starting ${n}…`);
+    set("status-version", n => n);
+    set("app-version", n => n);
+    // About-button label / restart-button hover-titles live in HTML
+    // attributes; rewrite the ones that include the name.
+    const aboutBtn = document.getElementById("btn-about");
+    if (aboutBtn)
+        aboutBtn.title = `Show version and build info`;
+    const aboutText = aboutBtn?.textContent || "";
+    if (aboutBtn && aboutText.toLowerCase().includes("about")) {
+        aboutBtn.textContent = `About ${APP_NAME}...`;
+    }
+}
+propagateAppName();
 let baseTitle = APP_NAME;
 let lastSeenCount = 0;
 let badgeCount = 0;
@@ -894,10 +922,36 @@ async function deleteSelectedMessages() {
         selected.push({ accountId: current.accountId, uid: current.message.uid, folderId: current.message.folderId });
     }
     const statusSync = document.getElementById("status-sync");
+    // Optimistic UI: remove from list IMMEDIATELY, then queue the IPC.
+    // Old order awaited the daemon round-trip (IPC + DB updates) before
+    // the rows disappeared, which felt sluggish on bigger selections or
+    // when the IPC was congested. Spam button already worked this way;
+    // trash now matches. If the IPC fails, the next folder reload
+    // re-populates the row and the catch block surfaces the error.
+    const snapshot = [...selected];
+    removeMessagesAndReconcile(selected);
+    // Undo support set immediately too — Ctrl+Z works the moment rows
+    // disappear from the list, not only after the daemon ACKs.
+    if (snapshot.length === 1) {
+        lastDeleted = { ...snapshot[0], subject: "" };
+        if (statusSync)
+            statusSync.textContent = `Trashed 1 message (syncing) — Ctrl+Z to undo`;
+    }
+    else {
+        lastDeleted = null;
+        if (statusSync)
+            statusSync.textContent = `Trashed ${snapshot.length} messages (syncing)`;
+    }
+    if (undoTimeout)
+        clearTimeout(undoTimeout);
+    undoTimeout = setTimeout(() => {
+        lastDeleted = null;
+        if (statusSync?.textContent?.includes("undo"))
+            statusSync.textContent = "";
+    }, 30000);
     try {
-        // Delete on server — group by account for bulk operations
         const byAccount = new Map();
-        for (const msg of selected) {
+        for (const msg of snapshot) {
             const uids = byAccount.get(msg.accountId) || [];
             uids.push(msg.uid);
             byAccount.set(msg.accountId, uids);
@@ -905,32 +959,11 @@ async function deleteSelectedMessages() {
         for (const [accountId, uids] of byAccount) {
             await deleteMessages(accountId, uids);
         }
-        // Undo supports the last batch
-        if (selected.length === 1) {
-            lastDeleted = { ...selected[0], subject: "" };
-            if (statusSync)
-                statusSync.textContent = `Trashed 1 message (syncing) — Ctrl+Z to undo`;
-        }
-        else {
-            lastDeleted = null;
-            if (statusSync)
-                statusSync.textContent = `Trashed ${selected.length} messages (syncing)`;
-        }
-        if (undoTimeout)
-            clearTimeout(undoTimeout);
-        undoTimeout = setTimeout(() => {
-            lastDeleted = null;
-            if (statusSync?.textContent?.includes("undo"))
-                statusSync.textContent = "";
-        }, 30000);
-        // Remove via the list controller — single transaction filters
-        // state, deletes DOM rows, hands focus to a survivor (or clears
-        // the viewer). Replaces the old "state.removeMessages broadcasts
-        // a removed event, list+viewer subscribe independently" model.
-        removeMessagesAndReconcile(selected);
     }
     catch (e) {
         console.error(`Delete failed: ${e.message}`);
+        if (statusSync)
+            statusSync.textContent = `Delete failed: ${e?.message || e}`;
     }
 }
 async function undoDelete() {
@@ -1790,7 +1823,7 @@ window.addEventListener("message", (e) => {
         // instantly and lingers when the user moves to do anything else,
         // including punching through the compose overlay (which sits at
         // z-index 1000 — popover was at 10000, hence the bug in the
-        // screenshot). Now: 500ms hover delay; suppressed entirely when
+        // screenshot). Now: 1500ms hover delay; suppressed entirely when
         // any overlay (compose, modal) is open; auto-dismissed on click,
         // scroll, blur, or any keypress.
         const w = window;
@@ -1815,7 +1848,7 @@ window.addEventListener("message", (e) => {
         const source = e.source;
         w._linkHoverShowTimer = setTimeout(() => {
             // Re-check overlay state at fire time — overlay may have appeared
-            // during the 500ms wait.
+            // during the 1500ms wait.
             if (document.querySelector(".compose-overlay, .mailx-modal-backdrop"))
                 return;
             if (!pop) {
@@ -1850,7 +1883,7 @@ window.addEventListener("message", (e) => {
                 pop.style.left = x + "px";
                 pop.style.top = y + "px";
             }
-        }, 500);
+        }, 1500);
     }
     if (e.data?.type === "previewKey" && typeof e.data.key === "string") {
         // Re-dispatch as a real keydown on document so the hotkey handler
@@ -2429,11 +2462,18 @@ document.addEventListener("keydown", (e) => {
     // Ctrl+D or Delete = Delete selected messages.
     // P15: don't hijack Delete inside text inputs / textareas / contenteditable
     // — JSONC editor's Delete key was being eaten because we always preventDefault'd.
+    // 2026-05-09 fix: if the LIST has multiple selected rows, the user
+    // clearly means "delete those" regardless of where focus is — search
+    // input retaining focus after filtering shouldn't make the key dead.
+    // Only defer to native behavior when there's no list selection AND
+    // focus is in a text-editing surface.
     if ((e.ctrlKey && e.key === "d") || e.key === "Delete") {
         const t = e.target;
         const tag = t?.tagName;
         const editable = t?.isContentEditable;
-        if (tag === "INPUT" || tag === "TEXTAREA" || tag === "SELECT" || editable)
+        const inEditable = tag === "INPUT" || tag === "TEXTAREA" || tag === "SELECT" || editable;
+        const listSelectionCount = document.querySelectorAll("#ml-body .ml-row.selected").length;
+        if (inEditable && listSelectionCount === 0)
             return;
         e.preventDefault();
         deleteSelection();