@bobfrankston/npmglobalize 1.0.219 → 1.0.220

package/README.md

@@ -756,7 +756,7 @@ As with import maps, these have historically been built only by a second `.vscod
 Before building, `npmglobalize` looks for sub-projects, in this order:
 
 1. `.vscode/tasks.json` has a task that runs `tsc` or `importgen` with `"options": { "cwd": "${workspaceFolder}/client" }`, or runs `tsc` with `-p`/`--project` naming a sub-directory (authoritative — it's how the project is actually built today; the task's `label` is quoted back in the prompt).
-2. An immediate sub-directory containing its own `package.json` or `tsconfig.json`. A sub-package without a build script gets one set up the same way the root does (importgen, `tsc`, its own sub-projects) before the root delegates to it. Build output and vendored trees (`node_modules`, `prev`, `dist`, `built`, `out`, `wwwroot`, `coverage`, `temp`, `preflight`, dot-directories) are never scanned.
+2. An immediate sub-directory that is a build of its own: a `package.json` with a `build` script or an import map to regenerate (a sub-package gets its build script set up the same way the root does — importgen, `tsc`, its own sub-projects — before the root delegates to it), or a `tsconfig.json` the root `tsconfig.json` does not already compile. A `package.json` that only holds dependencies for files the root `tsc` compiles (`whts/pdfToImg`) is not a sub-project. Build output and vendored trees (`node_modules`, `prev`, `dist`, `built`, `out`, `wwwroot`, `coverage`, `temp`, `preflight`, dot-directories) are never scanned.
 
 Nothing is detected when the root `tsconfig.json` uses project `references` — that build graph belongs to `tsc -b` and isn't second-guessed.
 

package/lib.d.ts

@@ -397,16 +397,6 @@ export declare function missingDeps(pkgDir: string, pkg: any): string[];
  *  re-run" (partial-sync) cases. Also covers `cwd` itself on the first call.
  *  Cycle-safe via the shared `visited` set. */
 export declare function ensureFileDepModules(cwd: string, verbose?: boolean, visited?: Set<string>): Promise<boolean>;
-/** Cheap freshness check so the build cascade can skip packages whose output is
- *  already current. Returns true only when provably up to date:
- *  - outDir projects: newest source (.ts/.tsx/.mts/.cts + tsconfig*.json) must
- *    not be newer than the newest file under outDir.
- *  - side-by-side projects: every source must have an emitted sibling
- *    (.js/.jsx/.mjs/.cjs or declaration) at least as new.
- *  Conservative: project references, allowJs, missing outputs, or unreadable
- *  tsconfig all report stale (→ build). package.json mtime is deliberately
- *  ignored — npmglobalize itself rewrites it around every publish, which would
- *  otherwise force a rebuild on every run. */
 export declare function isBuildUpToDate(cwd: string): boolean;
 /** Detect whether a package is an importgen project — a browser app whose HTML
  *  carries a generated `<script type="importmap">`. Signals, in order:

package/lib.js

@@ -2888,6 +2888,35 @@ function newestMtimeUnder(dir) {
  *  tsconfig all report stale (→ build). package.json mtime is deliberately
  *  ignored — npmglobalize itself rewrites it around every publish, which would
  *  otherwise force a rebuild on every run. */
+/** The directories a parsed tsconfig's `exclude` keeps out of the compile, as
+ *  lower-cased relative paths. Matches on the literal path prefix (glob tails
+ *  like "tests/**" reduce to "tests"). */
+function tsconfigExcludedDirs(tsconfig) {
+    return (Array.isArray(tsconfig?.exclude) ? tsconfig.exclude : [])
+        .filter((x) => typeof x === 'string')
+        .map((x) => x.replace(/^\.\//, '').replace(/[\\/]?\*.*$/, '').replace(/[\\/]+$/, '').toLowerCase())
+        .filter((x) => x.length > 0 && !x.includes('*'));
+}
+/** True when the root tsconfig in `cwd` already compiles the sources under
+ *  `rel`: it exists, doesn't narrow the compile with `files`/`include`, and
+ *  doesn't `exclude` the directory. Conservative — a root that uses `include`
+ *  is treated as not covering the sub-directory. */
+function rootTsconfigCompiles(cwd, rel) {
+    let tsconfig;
+    try {
+        tsconfig = JSON5.parse(fs.readFileSync(path.join(cwd, 'tsconfig.json'), 'utf-8'));
+    }
+    catch {
+        return false;
+    }
+    if (Array.isArray(tsconfig.files) || Array.isArray(tsconfig.include))
+        return false;
+    const target = normalizeProjectPath(rel).toLowerCase();
+    const parts = target.split('/');
+    const excludes = tsconfigExcludedDirs(tsconfig);
+    // Excluding a parent excludes everything under it.
+    return !parts.some((_, i) => excludes.includes(parts.slice(0, i + 1).join('/')));
+}
 export function isBuildUpToDate(cwd) {
     let tsconfig;
     try {
@@ -2901,12 +2930,8 @@ export function isBuildUpToDate(cwd) {
         return false;
     const outDir = typeof co.outDir === 'string' ? path.resolve(cwd, co.outDir) : null;
     // tsconfig "exclude" dirs aren't compiled, so their .ts files never get
-    // outputs — don't count them as sources. Match on the literal path prefix
-    // (glob tails like "tests/**" reduce to "tests").
-    const excludes = (Array.isArray(tsconfig.exclude) ? tsconfig.exclude : [])
-        .filter((x) => typeof x === 'string')
-        .map((x) => x.replace(/^\.\//, '').replace(/[\\/]?\*.*$/, '').replace(/[\\/]+$/, '').toLowerCase())
-        .filter((x) => x.length > 0 && !x.includes('*'));
+    // outputs — don't count them as sources.
+    const excludes = tsconfigExcludedDirs(tsconfig);
     const sources = [];
     const collect = (dir, rel) => {
         let entries;
@@ -3198,13 +3223,31 @@ function resolveOnDiskCase(base, rel) {
     }
     return out.length ? out.join('/') : null;
 }
-/** Classify `rel` under `cwd`: a package (its own package.json — its build
- *  script is set up by `ensureBuildScript` if it lacks one), a plain tsconfig
- *  sub-project, or null when it's neither. */
+/** Classify `rel` under `cwd`: a package (its own package.json with a build
+ *  script, or an importgen project — `ensureBuildScript` sets its script up),
+ *  a plain tsconfig sub-project the root tsc doesn't compile, or null when it
+ *  is neither.
+ *  2026-09-06 — Claude Code (Fable 5.1), at Bob's direction. whts/pdfToImg has
+ *  a package.json that only holds puppeteer/sharp for a file the root tsc
+ *  already compiles; treating every package.json as a sub-package gave it a
+ *  `build: tsc` it never needed and a second compile under its stale tsconfig.
+ *  A package.json is a build of its own only when it has something the root
+ *  can't do — its own build script, or an import map to regenerate. */
 function subProjectKind(cwd, rel) {
-    if (fs.existsSync(path.join(cwd, rel, 'package.json')))
-        return 'package';
-    return fs.existsSync(path.join(cwd, rel, 'tsconfig.json')) ? 'tsconfig' : null;
+    const dir = path.join(cwd, rel);
+    if (fs.existsSync(path.join(dir, 'package.json'))) {
+        let pkg = {};
+        try {
+            pkg = readPackageJson(dir);
+        }
+        catch { /* unreadable — treat as having no build script */ }
+        const hasBuild = typeof pkg?.scripts?.build === 'string' && pkg.scripts.build.trim();
+        if (hasBuild || detectImportgen(dir))
+            return 'package';
+    }
+    if (!fs.existsSync(path.join(dir, 'tsconfig.json')))
+        return null;
+    return rootTsconfigCompiles(cwd, rel) ? null : 'tsconfig';
 }
 /** The command the root build script runs for a sub-project. */
 function subProjectBuildCommand(s) {
@@ -3505,7 +3548,7 @@ export async function buildProject(cwd, opts = {}) {
     // tsconfig.json, which makes the freshness check correctly read as stale.
     const tsconfigSnapshot = new Map();
     const issueMark = markBuildIssues();
-    const migratedUpFront = fs.existsSync(path.join(cwd, 'tsconfig.json')) && migrateTsconfigDeprecations(cwd, tsconfigSnapshot);
+    let migratedUpFront = fs.existsSync(path.join(cwd, 'tsconfig.json')) && migrateTsconfigDeprecations(cwd, tsconfigSnapshot);
     const setup = await ensureBuildScript(cwd);
     if (!setup)
         return true;
@@ -3514,6 +3557,16 @@ export async function buildProject(cwd, opts = {}) {
     // freshness — one the user declined to wire in isn't this build's business.
     const finalBuild = typeof pkg.scripts?.build === 'string' ? pkg.scripts.build : '';
     const wiredSubs = detectSubProjects(cwd).filter(s => scriptBuildsSubProject(finalBuild, s.dir));
+    // 2026-09-06 — Claude Code (Fable 5.1), at Bob's direction.
+    // The sub-projects this build runs get the same TS7 migration as the root.
+    // whts: `tsc -p pdfToImg` failed on pdfToImg/tsconfig.json's
+    // `moduleResolution: node10` (TS5107) and the retry below re-migrated only
+    // the root chain, which had nothing left to fix — so no retry ever happened.
+    const migrateSubProjects = () => wiredSubs
+        .map(s => migrateTsconfigDeprecations(path.join(cwd, s.dir), tsconfigSnapshot))
+        .some(Boolean);
+    if (migrateSubProjects())
+        migratedUpFront = true;
     // A migration just changed how modules resolve — never report that as fresh;
     // the rebuild is what validates it (and what the revert path above needs).
     if (!opts.forceBuild && !migratedUpFront && isBuildUpToDate(cwd) && areSubProjectsUpToDate(cwd, wiredSubs)
@@ -3529,7 +3582,7 @@ export async function buildProject(cwd, opts = {}) {
         // We don't silence with ignoreDeprecations — the retry may now surface real
         // resolution errors, which are genuine bugs to fix, not deprecations.
         const out = (buildResult.stderr || '') + (buildResult.output || '');
-        if (/error TS510[17]\b/.test(out) && migrateTsconfigDeprecations(cwd, tsconfigSnapshot)) {
+        if (/error TS510[17]\b/.test(out) && [migrateTsconfigDeprecations(cwd, tsconfigSnapshot), migrateSubProjects()].some(Boolean)) {
             buildResult = await runCommandAsync('npm', ['run', 'build'], { cwd, silent: true });
         }
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bobfrankston/npmglobalize",
-  "version": "1.0.219",
+  "version": "1.0.220",
   "description": "Transform file: dependencies to npm versions for publishing",
   "main": "index.js",
   "type": "module",