@bobfrankston/npmglobalize 1.0.213 → 1.0.215

package/README.md

@@ -298,10 +298,10 @@ reachable `repository.url` in `package.json`. If found, it offers two paths:
 ```
 How would you like to set up git?
   1) Adopt history from existing remote (recommended)
-  2) Initialize fresh git repository
-  a) Adopt ALL (don't ask again for remaining deps)
-  3) Use local install only (skip git/publish)
-  4) Abort
+  2) Adopt for ALL remaining deps (don't ask again)
+  3) Initialize fresh git repository
+  4) Use local install only (skip git/publish)
+  5) Abort
 ```
 
 **Adopt** runs:

package/cli.js

@@ -2,7 +2,7 @@
 /**
  * npmglobalize CLI - Transform file: dependencies to npm versions for publishing
  */
-import { globalize, globalizeWorkspace, installCleanupHandlers, readConfig, readPackageJson, readUserNpmConfig, writeConfig, writePackageJson, getBuildIssues, clearBuildIssues, ensureFileDepModules, buildProject, buildFileDepsTopologically, reportTs7Deprecations, fixTs7Deprecations } from './lib.js';
+import { globalize, globalizeWorkspace, installCleanupHandlers, readConfig, readPackageJson, readUserNpmConfig, writeConfig, writePackageJson, getBuildIssues, clearBuildIssues, ensureFileDepModules, buildProject, buildFileDepsTopologically, reportTs7Deprecations, fixTs7Deprecations, canonicalCase } from './lib.js';
 import fs from 'fs';
 import path from 'path';
 import { colors } from './colors.js';
@@ -549,6 +549,19 @@ export async function main() {
             process.exit(1);
         }
     }
+    // 2026-09-06 — Claude Code (Fable 5.1), at Bob's direction.
+    // `process.cwd()` carries whatever letter case the shell was started with
+    // (`y:\dev\...` from a lowercase prompt). Every `file:` junction npm writes
+    // inherits that case, and mixed `y:`/`Y:` junction targets are exactly what
+    // makes arborist crash with "Cannot read properties of null (reading
+    // 'package')" — see `caseDiffers` in lib.ts. Canonicalizing once up front
+    // means every npm the cascade spawns writes junctions with the on-disk
+    // spelling, so the repair in verifyDepPathCase stops being needed again.
+    const canonicalCwd = canonicalCase(cwd);
+    if (canonicalCwd && canonicalCwd !== cwd) {
+        cwd = canonicalCwd;
+        process.chdir(cwd);
+    }
     // Report-only TS7-readiness scan (no transform / build / publish).
     if (cliOptions.ts7Report) {
         printTs7Report(cwd);

package/lib.d.ts

@@ -287,6 +287,16 @@ export type UnpublishedDep = {
     path: string;
     reason: 'new' | 'update';
 };
+/** The canonical on-disk spelling of `target`, or null if it does not exist.
+ *  Windows answers path queries case-insensitively, so the only way to learn how
+ *  a directory is really spelled is to ask its parent to list it — a segment at a
+ *  time, from the root down. The drive letter is always uppercased.
+ *
+ *  2026-09-06 — Claude Code (Fable 5.1), at Bob's direction: exported so cli.ts can
+ *  canonicalize the working directory at startup (see there for why). Deliberately
+ *  NOT `fs.realpathSync.native`: that would also resolve a junction the user is
+ *  standing inside, which is a behaviour change nobody asked for. */
+export declare function canonicalCase(target: string): string;
 /** Vet the casing of every `file:` dependency path, in BOTH places it is recorded:
  *  the spec in package.json and the junction npm created in node_modules.
  *
@@ -589,8 +599,14 @@ export declare function validatePackageJson(pkg: any): string[];
 export declare function confirm(message: string, defaultYes?: boolean): Promise<boolean>;
 /** Prompt user for free text input */
 export declare function promptText(message: string, defaultValue?: string): Promise<string>;
-/** Prompt user for multiple choice */
-export declare function promptChoice(message: string, choices: string[]): Promise<string | null>;
+/**
+ * Prompt user for multiple choice. Re-asks until the answer is one of `choices`.
+ *
+ * 2026-09-01 — Claude Code (Fable 5.1), at Bob's direction. Previously an unrecognized
+ * answer resolved null and every caller fell through to its default action, so a typo
+ * silently did something. Now it says what it didn't understand and asks again.
+ */
+export declare function promptChoice(message: string, choices: string[]): Promise<string>;
 /** Initialize a local git repo by adopting history from an existing remote.
  *  Preserves the working tree — local files appear as uncommitted changes
  *  on top of the remote's HEAD. No force-push is required. */

package/lib.js

@@ -1323,8 +1323,13 @@ function hasLocalChanges(packageName, version, targetPath, verbose) {
 /** The canonical on-disk spelling of `target`, or null if it does not exist.
  *  Windows answers path queries case-insensitively, so the only way to learn how
  *  a directory is really spelled is to ask its parent to list it — a segment at a
- *  time, from the root down. */
-function canonicalCase(target) {
+ *  time, from the root down. The drive letter is always uppercased.
+ *
+ *  2026-09-06 — Claude Code (Fable 5.1), at Bob's direction: exported so cli.ts can
+ *  canonicalize the working directory at startup (see there for why). Deliberately
+ *  NOT `fs.realpathSync.native`: that would also resolve a junction the user is
+ *  standing inside, which is a behaviour change nobody asked for. */
+export function canonicalCase(target) {
     const full = path.resolve(target);
     if (!fs.existsSync(full))
         return null;
@@ -1347,10 +1352,22 @@ function canonicalCase(target) {
     return cur;
 }
 /** True when two paths name the same place but are spelled with different case
- *  in a directory name. A bare drive-letter difference (`y:` vs `Y:`) doesn't
- *  count — it resolves identically everywhere, including WSL's /mnt/y. */
+ *  anywhere — the drive letter included.
+ *
+ *  2026-09-06 — Claude Code (Fable 5.1), at Bob's direction. This used to strip the
+ *  root before comparing, on the theory that `y:` vs `Y:` "resolves identically
+ *  everywhere". It does on the filesystem; it does NOT inside npm's arborist.
+ *  Traced with an instrumented `loadActual` on dbitemx / pings / itemw: arborist
+ *  keeps the junction target's case in `realpath` (an exact-string index) but
+ *  computes `location` with `path.win32.relative`, which folds drive-letter case.
+ *  One directory reached as `Y:\...` and `y:\...` becomes two target nodes at one
+ *  location; the second clobbers the first, every Link into the first is left with
+ *  `target === null`, and the next same-case Link crashes on `target.package` —
+ *  the "Cannot read properties of null (reading 'package')" failure. npm writes
+ *  the junction target with whatever drive case the cwd had, so a lowercase shell
+ *  is all it takes. Full trace: `.llm/arborist-trace.md`. */
 function caseDiffers(a, b) {
-    const strip = (p) => p.replace(/[\\/]+$/, '').slice(path.parse(p).root.length);
+    const strip = (p) => p.replace(/[\\/]+$/, '');
     return strip(a) !== strip(b);
 }
 /** Vet the casing of every `file:` dependency path, in BOTH places it is recorded:
@@ -4995,23 +5012,46 @@ export async function promptText(message, defaultValue) {
         });
     });
 }
-/** Prompt user for multiple choice */
-export async function promptChoice(message, choices) {
+/**
+ * Prompt user for multiple choice. Re-asks until the answer is one of `choices`.
+ *
+ * 2026-09-01 — Claude Code (Fable 5.1), at Bob's direction. Previously an unrecognized
+ * answer resolved null and every caller fell through to its default action, so a typo
+ * silently did something. Now it says what it didn't understand and asks again.
+ */
+export function promptChoice(message, choices) {
     const rl = readline.createInterface({
         input: process.stdin,
         output: process.stdout
     });
+    const shown = choices.filter(c => c !== '').join(', ');
+    // A 'line' listener rather than repeated rl.question(): when stdin is piped, several
+    // lines can arrive in one chunk and a line landing between two question() calls is
+    // dropped. The listener sees every line.
     return new Promise((resolve) => {
-        rl.question(`${message} `, (answer) => {
+        let done = false;
+        const finish = (value) => {
+            done = true;
             rl.close();
+            resolve(value);
+        };
+        rl.setPrompt(`${message} `);
+        rl.prompt();
+        rl.on('line', (answer) => {
+            if (done)
+                return;
             const a = answer.trim().toLowerCase();
-            if (choices.includes(a)) {
-                resolve(a);
-            }
-            else {
-                resolve(null);
-            }
+            if (choices.includes(a))
+                return finish(a);
+            console.log(colors.yellow(`Unrecognized choice "${a}" — expected one of: ${shown}`));
+            rl.prompt();
         });
+        // EOF with no valid answer: behave as "just pressed Enter" ('' is the default where
+        // a default exists; callers without one treat '' as abort).
+        rl.on('close', () => { if (!done) {
+            done = true;
+            resolve('');
+        } });
     });
 }
 /** Check npm authentication status */
@@ -6393,51 +6433,60 @@ export async function globalize(cwd, options = {}, configOptions = {}) {
             justInitialized = true;
         }
         else if (!init && !options.autoInit && !publishDepsYes) {
+            // 2026-09-01 — Claude Code (Fable 5.1), at Bob's direction. These menus were
+            // numbered "1 a 2 3": the "ALL" option was lettered and sat between 1 and 2, so
+            // a reader who wanted the second line typed 2 and got something else. Bob:
+            // "I type 2 when I mean a because that's what humans do." Options are now
+            // numbered in display order; the ALL variant is 2, directly under the single.
             let choice;
             if (adoptable) {
                 choice = await promptChoice('How would you like to set up git?\n'
                     + '  1) Adopt history from existing remote (recommended)\n'
-                    + '  a) Adopt ALL (don\'t ask again for remaining deps)\n'
-                    + '  2) Initialize fresh git repository\n'
-                    + '  3) Use local install only (skip git/publish)\n'
-                    + '  4) Abort\nChoice:', ['1', 'a', '2', '3', '4', '']);
-                if (choice === '3') {
+                    + '  2) Adopt for ALL remaining deps (don\'t ask again)\n'
+                    + '  3) Initialize fresh git repository\n'
+                    + '  4) Use local install only (skip git/publish)\n'
+                    + '  5) Abort\nChoice [1]:', ['1', '2', '3', '4', '5', '']);
+                if (choice === '4') {
                     console.log(colors.dim('Switching to local-only mode...'));
                     writeConfig(cwd, { ...configOptions, local: true }, new Set(['local']));
                     return doLocalInstall(cwd, options);
                 }
-                if (choice === '4') {
+                if (choice === '5') {
                     console.log('Aborted. Run with --init to initialize.');
                     return false;
                 }
-                if (choice === 'a')
+                if (choice === '2')
                     options.autoInit = true;
-                if (choice === '2') {
+                if (choice === '3') {
                     const success = await initGit(cwd, gitVisibility, dryRun, allowTs);
                     if (!success)
                         return false;
                 }
                 else {
-                    // '1', 'a', '' default → adopt
+                    // '1', '2', '' default → adopt
                     const success = await adoptExistingRemote(cwd, adoptable.url, adoptable.defaultBranch, dryRun);
                     if (!success)
                         return false;
                 }
             }
             else {
-                choice = await promptChoice('No git repository found. What would you like to do?\n  1) Initialize git repository (default)\n  a) Initialize ALL (don\'t ask again for remaining deps)\n  2) Use local install only (skip git/publish)\n  3) Abort\nChoice:', ['1', 'a', '2', '3', '']);
-                if (choice === '2') {
+                choice = await promptChoice('No git repository found. What would you like to do?\n'
+                    + '  1) Initialize git repository\n'
+                    + '  2) Initialize for ALL remaining deps (don\'t ask again)\n'
+                    + '  3) Use local install only (skip git/publish)\n'
+                    + '  4) Abort\nChoice [1]:', ['1', '2', '3', '4', '']);
+                if (choice === '3') {
                     console.log(colors.dim('Switching to local-only mode...'));
                     writeConfig(cwd, { ...configOptions, local: true }, new Set(['local']));
                     return doLocalInstall(cwd, options);
                 }
-                if (choice === '3') {
+                if (choice === '4') {
                     console.log('Aborted. Run with --init to initialize.');
                     return false;
                 }
-                if (choice === 'a')
+                if (choice === '2')
                     options.autoInit = true;
-                // choice is '1', 'a', or '' (default)
+                // choice is '1', '2', or '' (default) → init
                 const success = await initGit(cwd, gitVisibility, dryRun, allowTs);
                 if (!success)
                     return false;
@@ -6463,17 +6512,22 @@ export async function globalize(cwd, options = {}, configOptions = {}) {
     else if (!gitStatus.hasRemote) {
         // Git repo exists but no remote - need to create GitHub repo
         if (!init && !options.autoInit && !publishDepsYes) {
-            const choice = await promptChoice('No git remote configured. What would you like to do?\n  1) Create GitHub repository (default)\n  a) Initialize ALL (don\'t ask again for remaining deps)\n  2) Use local install only (skip git/publish)\n  3) Abort\nChoice:', ['1', 'a', '2', '3', '']);
-            if (choice === '2') {
+            // 2026-09-01 — Claude Code (Fable 5.1): renumbered from "1 a 2 3" (see note above).
+            const choice = await promptChoice('No git remote configured. What would you like to do?\n'
+                + '  1) Create GitHub repository\n'
+                + '  2) Create for ALL remaining deps (don\'t ask again)\n'
+                + '  3) Use local install only (skip git/publish)\n'
+                + '  4) Abort\nChoice [1]:', ['1', '2', '3', '4', '']);
+            if (choice === '3') {
                 console.log(colors.dim('Switching to local-only mode...'));
                 writeConfig(cwd, { ...configOptions, local: true }, new Set(['local']));
                 return doLocalInstall(cwd, options);
             }
-            if (choice === '3') {
+            if (choice === '4') {
                 console.log('Aborted. Run with --init to set up GitHub repository.');
                 return false;
             }
-            if (choice === 'a') {
+            if (choice === '2') {
                 options.autoInit = true;
             }
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bobfrankston/npmglobalize",
-  "version": "1.0.213",
+  "version": "1.0.215",
   "description": "Transform file: dependencies to npm versions for publishing",
   "main": "index.js",
   "type": "module",