@bobfrankston/npmglobalize 1.0.186 → 1.0.187

package/README.md

@@ -585,6 +585,18 @@ Cycle-safe via a shared visited set; each project is built at most once per run.
 
 This complements the existing publish cascade (which ensures version refs are correct) by closing the build-freshness gap that `npm install` alone left open.
 
+#### TypeScript 6 `types` auto-fix
+
+TypeScript 6 dropped the legacy behavior of auto-including every installed `@types/*` package. A `tsconfig.json` with no explicit `compilerOptions.types` then loses the Node globals (`process`, `Buffer`, …) and the build fails with `TS2591`.
+
+Before each build, when the global `tsc` is version 6 or newer, `npmglobalize` patches the project's `tsconfig.json` to add an explicit `types` list — enumerating the installed `@types/*` packages (e.g. `"types": ["node", …]`) — restoring the old behavior. The edit is:
+
+- **Conservative** — only applied when `compilerOptions.types` is **absent**, `node_modules/@types/node` is actually installed, and there is no `extends` (whose merged `types` can't be seen). An explicit `types` you already set is never overridden.
+- **Format-preserving** — the single `types` key is inserted into the existing `compilerOptions` block; comments, ordering, and indentation are left intact.
+- **Idempotent** — once the list is present, subsequent runs skip it.
+
+If the patch can't be applied for some reason and the build still fails with `TS2591`, the failure summary prints a hint to add `"types": ["node"]` manually.
+
 ### The `.dependencies` Backup (Internal/Transient)
 
 **You should never see `.dependencies` in your `package.json` under normal operation.** It is a temporary internal backup that exists only during the brief publish cycle and is removed automatically when the cycle completes.

package/lib.js

@@ -1927,6 +1927,120 @@ export async function ensureFileDepModules(cwd, verbose = false, visited = new S
         }
     }
 }
+/** Cached major version of the global `tsc`. null = not yet probed,
+ *  0 = probe failed / tsc not found. TypeScript 6 stopped auto-including
+ *  every `@types/*` package, so a tsconfig that relied on that needs an
+ *  explicit `types` list under TS6+. */
+let _tscMajor = null;
+/** Major version of the globally-installed `tsc`, or 0 if undeterminable.
+ *  Cached for the run. Needs shell:true on Windows to resolve `tsc.cmd`. */
+function getTscMajor() {
+    if (_tscMajor !== null)
+        return _tscMajor;
+    _tscMajor = 0;
+    try {
+        const result = spawnSafe('tsc', ['--version'], { stdio: 'pipe', shell: true, env: process.env });
+        const m = (result.stdout || '').match(/Version\s+(\d+)\./);
+        if (m)
+            _tscMajor = parseInt(m[1], 10);
+    }
+    catch { /* leave at 0 — can't probe, assume pre-6 (no patch) */ }
+    return _tscMajor;
+}
+/** Insert a `"types": [...]` line as the first property of `compilerOptions`,
+ *  preserving the file's existing formatting/comments. Returns the patched text,
+ *  or null if the object couldn't be located safely (caller leaves file alone).
+ *  Only ever called when `compilerOptions.types` is absent. */
+function insertTypesIntoTsconfig(text, typesArr) {
+    const arrLiteral = '[' + typesArr.map(t => JSON.stringify(t)).join(', ') + ']';
+    const m = text.match(/"compilerOptions"\s*:\s*\{/);
+    if (!m)
+        return null;
+    const braceEnd = m.index + m[0].length;
+    const rest = text.slice(braceEnd);
+    const ws = rest.match(/^\s*/)[0];
+    // Empty object: `compilerOptions: {}` (or whitespace only before `}`)
+    if (rest.slice(ws.length).startsWith('}')) {
+        // Indent one level deeper than the `compilerOptions` line itself.
+        const lineStart = text.lastIndexOf('\n', m.index) + 1;
+        const baseIndent = text.slice(lineStart, m.index).match(/^\s*/)[0];
+        const propIndent = baseIndent + '  ';
+        return text.slice(0, braceEnd) + '\n' + propIndent + `"types": ${arrLiteral}\n` + baseIndent + text.slice(braceEnd + ws.length);
+    }
+    // Multiline object: derive property indent from the existing first property.
+    if (ws.includes('\n')) {
+        const propIndent = ws.slice(ws.lastIndexOf('\n') + 1);
+        return text.slice(0, braceEnd) + '\n' + propIndent + `"types": ${arrLiteral},` + text.slice(braceEnd);
+    }
+    // Inline single-line object: `{ "target": ... }`
+    return text.slice(0, braceEnd) + ` "types": ${arrLiteral},` + text.slice(braceEnd);
+}
+/** TypeScript 6 dropped the legacy behavior of auto-including every installed
+ *  `@types/*` package. A tsconfig with no explicit `compilerOptions.types` then
+ *  loses the Node globals (`process`, `Buffer`, ...), breaking the build with
+ *  `TS2591`. When building under TS6+, add an explicit `types` list enumerating
+ *  the installed `@types/*` (restoring the old behavior). Idempotent and
+ *  conservative — only patches when `types` is absent, `@types/node` is actually
+ *  installed, and there is no `extends` (whose merged `types` we can't see). */
+function ensureTsconfigNodeTypes(cwd) {
+    if (getTscMajor() < 6)
+        return;
+    const tsconfigPath = path.join(cwd, 'tsconfig.json');
+    let text;
+    try {
+        text = fs.readFileSync(tsconfigPath, 'utf-8');
+    }
+    catch {
+        return;
+    }
+    let parsed;
+    try {
+        parsed = JSON5.parse(text);
+    }
+    catch {
+        return;
+    }
+    const co = parsed?.compilerOptions;
+    if (!co || typeof co !== 'object')
+        return;
+    // Respect any explicit choice; never override a user-set `types`.
+    if (co.types !== undefined)
+        return;
+    // `extends` may already supply `types`; a local array would override it, so leave it.
+    if (parsed.extends !== undefined)
+        return;
+    // Gate on @types/node actually being installed so the list resolves and we
+    // only touch genuine Node projects.
+    const typesDir = path.join(cwd, 'node_modules', '@types');
+    if (!fs.existsSync(path.join(typesDir, 'node')))
+        return;
+    let installed;
+    try {
+        installed = fs.readdirSync(typesDir, { withFileTypes: true })
+            .filter(e => e.isDirectory() && !e.name.startsWith('.'))
+            .map(e => e.name);
+    }
+    catch {
+        return;
+    }
+    if (!installed.length)
+        return;
+    // node first, rest sorted, for a stable readable list.
+    installed.sort();
+    const typesArr = ['node', ...installed.filter(n => n !== 'node')];
+    const patched = insertTypesIntoTsconfig(text, typesArr);
+    if (!patched) {
+        recordBuildIssue(parsed.name || path.basename(cwd), 'warning', `TS6+ build may fail: couldn't locate compilerOptions in ${tsconfigPath} to add explicit "types"`);
+        return;
+    }
+    try {
+        fs.writeFileSync(tsconfigPath, patched);
+        console.log(colors.cyan(`  Patched tsconfig.json: added "types": [${typesArr.join(', ')}] (TypeScript ${_tscMajor}+ no longer auto-includes @types/*)`));
+    }
+    catch (error) {
+        console.error(colors.yellow(`  Could not write tsconfig.json patch: ${error.message}`));
+    }
+}
 /** Build a single project: detect tsconfig, prompt to add `build: tsc` if a
  *  TypeScript project lacks a build script, run `npm run build`, record
  *  failures. Returns true if build succeeded (or was skipped because no
@@ -1959,6 +2073,7 @@ export async function buildProject(cwd, opts = {}) {
             return true;
         }
     }
+    ensureTsconfigNodeTypes(cwd);
     console.log(`Building ${pkg.name || cwd}...`);
     const buildResult = await runCommandAsync('npm', ['run', 'build'], { cwd, silent: true });
     if (buildResult.success) {
@@ -2313,6 +2428,13 @@ function diagnoseBuildFailure(errorText, cwd) {
         console.error(colors.yellow('  Check file ownership and that no other process has files locked.'));
         diagnosed = true;
     }
+    // Pattern: TS6 dropped @types/* auto-inclusion → Node globals missing.
+    // (Safety net for when the proactive ensureTsconfigNodeTypes patch didn't fire.)
+    if (!diagnosed && /error TS2591|Do you need to install type definitions for node/.test(errorText)) {
+        console.error(colors.yellow('\n  Hint: TypeScript 6 no longer auto-includes @types/*, so Node globals (process, Buffer) are unresolved.'));
+        console.error(colors.yellow(`  Fix: add  "types": ["node"]  to compilerOptions in ${path.join(cwd, 'tsconfig.json')}`));
+        diagnosed = true;
+    }
     // Pattern: TypeScript compilation error
     if (!diagnosed && /error TS\d+/.test(errorText)) {
         console.error(colors.yellow('\n  Hint: TypeScript compilation errors. Fix the type errors above before publishing.'));
@@ -4168,6 +4290,7 @@ export async function globalize(cwd, options = {}, configOptions = {}) {
             // workspaces[] array order; rewrite to topological order so deps build
             // before consumers (avoids stale-.d.ts errors in cross-package imports).
             const restoreWorkspaces = reorderWorkspacesForBuild(cwd, pkg, verbose);
+            ensureTsconfigNodeTypes(cwd);
             try {
                 // Always capture output so we can extract tsc errors for the summary
                 const buildResult = await runCommandAsync('npm', ['run', 'build'], { cwd, silent: true });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bobfrankston/npmglobalize",
-  "version": "1.0.186",
+  "version": "1.0.187",
   "description": "Transform file: dependencies to npm versions for publishing",
   "main": "index.js",
   "type": "module",
@@ -32,8 +32,8 @@
   },
   "dependencies": {
     "@bobfrankston/freezepak": "^0.1.8",
-    "@bobfrankston/importgen": "^0.1.36",
-    "@bobfrankston/themecolors": "^0.1.6",
+    "@bobfrankston/importgen": "^0.1.37",
+    "@bobfrankston/themecolors": "^0.1.7",
     "@bobfrankston/userconfig": "^1.0.9",
     "@npmcli/package-json": "^7.0.4",
     "json5": "^2.2.3",
@@ -60,8 +60,8 @@
   ".transformedSnapshot": {
     "dependencies": {
       "@bobfrankston/freezepak": "^0.1.8",
-      "@bobfrankston/importgen": "^0.1.36",
-      "@bobfrankston/themecolors": "^0.1.6",
+      "@bobfrankston/importgen": "^0.1.37",
+      "@bobfrankston/themecolors": "^0.1.7",
       "@bobfrankston/userconfig": "^1.0.9",
       "@npmcli/package-json": "^7.0.4",
       "json5": "^2.2.3",