@bobfrankston/npmglobalize 1.0.151 → 1.0.153

package/README.md

@@ -350,6 +350,11 @@ Workspace mode is auto-detected when run from a root with `"private": true` and
 -asis           Skip ignore file checks (or set "asis": true in .globalize.json5)
 -fix-tags       Automatically fix version/tag mismatches
 -rebase         Automatically rebase if local is behind remote
+-clean-nested-modules, -clean-nested
+                Before npm pack, wipe node_modules/ inside each file: dep
+                target. Fixes arborist "Cannot read properties of null"
+                crashes caused by sibling file: deps with nested
+                node_modules. Suggested automatically when the error hits.
 -show           Show package.json dependency changes
 -package, -pkg  Update package.json scripts to use npmglobalize (see below)
 -h, -help       Show help

package/cli.js

@@ -75,6 +75,10 @@ Other Options:
                   (noEmit projects: removes TS ignores from .npmignore)
   -asis           Skip ignore file checks (or set "asis": true in .globalize.json5)
   -rebase         Automatically rebase if local is behind remote
+  -clean-nested-modules, -clean-nested
+                  Before npm pack, wipe node_modules/ in each file: dep target.
+                  Fixes arborist "Cannot read properties of null" crashes when
+                  sibling file: deps have their own nested node_modules.
   -show           Show package.json dependency changes
   -package, -pkg  Update package.json scripts to use npmglobalize
   -h, -help       Show this help
@@ -318,6 +322,11 @@ function parseArgs(args) {
                 options.importgen = false;
                 options.explicitKeys.add('importgen');
                 break;
+            case '-clean-nested':
+            case '-clean-nested-modules':
+                options.cleanNestedModules = true;
+                options.explicitKeys.add('cleanNestedModules');
+                break;
             default:
                 if (arg.startsWith('-')) {
                     unrecognized.push(arg);

package/lib/config.js

@@ -64,7 +64,7 @@ export function writeConfig(dir, config, explicitKeys) {
     const existing = readConfig(dir);
     // Filter out temporary flags and default values (unless explicitly set)
     const filtered = {};
-    const omitKeys = new Set(['cleanup', 'init', 'dryRun', 'message', 'conform', 'asis', 'help', 'error', 'updateDeps', 'updateMajor', 'publishDeps', 'forcePublish', 'once']);
+    const omitKeys = new Set(['cleanup', 'init', 'dryRun', 'message', 'conform', 'asis', 'help', 'error', 'updateDeps', 'updateMajor', 'publishDeps', 'forcePublish', 'once', 'cleanNestedModules']);
     for (const [key, value] of Object.entries(config)) {
         if (omitKeys.has(key))
             continue;

package/lib/types.d.ts

@@ -82,6 +82,9 @@ export interface GlobalizeOptions {
     local?: boolean;
     /** Freeze node_modules: replace symlinks/junctions with real copies for network share use */
     freeze?: boolean;
+    /** Before `npm pack`, delete `node_modules/` inside each `file:` dep target.
+     *  Works around arborist crashes when siblings have nested node_modules. */
+    cleanNestedModules?: boolean;
     /** Internal: signals this call is from workspace orchestrator */
     _fromWorkspace?: boolean;
     /** Internal: signals this call is from CLI (version already printed) */

package/lib.d.ts

@@ -95,6 +95,9 @@ export interface GlobalizeOptions {
     local?: boolean;
     /** Freeze node_modules: replace symlinks/junctions with real copies for network share use */
     freeze?: boolean;
+    /** Before `npm pack`, delete `node_modules/` inside each `file:` dep target.
+     *  Works around arborist crashes when siblings have nested node_modules. */
+    cleanNestedModules?: boolean;
     /** Internal: auto-initialize git repos without prompting (user chose "all") */
     autoInit?: boolean;
     /** Internal: signals this call is from workspace orchestrator */

package/lib.js

@@ -236,7 +236,7 @@ export function writeConfig(dir, config, explicitKeys) {
     const existing = readConfig(dir);
     // Filter out temporary flags and default values (unless explicitly set)
     const filtered = {};
-    const omitKeys = new Set(['cleanup', 'init', 'dryRun', 'message', 'conform', 'asis', 'help', 'error', 'updateDeps', 'updateMajor', 'publishDeps', 'forcePublish', 'once']);
+    const omitKeys = new Set(['cleanup', 'init', 'dryRun', 'message', 'conform', 'asis', 'help', 'error', 'updateDeps', 'updateMajor', 'publishDeps', 'forcePublish', 'once', 'cleanNestedModules']);
     for (const [key, value] of Object.entries(config)) {
         if (omitKeys.has(key))
             continue;
@@ -1262,6 +1262,59 @@ function waitForNpmVersion(pkgName, version, maxWaitMs = 90000) {
     process.stdout.write(' timed out\n');
     return false;
 }
+function cleanNestedDepModules(pkg, cwd, verbose) {
+    const stashed = [];
+    const seen = new Set();
+    const suffix = `.npmglobalize-stash-${process.pid}`;
+    for (const key of ['.dependencies', '.devDependencies', 'dependencies', 'devDependencies']) {
+        const deps = pkg?.[key];
+        if (!deps || typeof deps !== 'object')
+            continue;
+        for (const [name, spec] of Object.entries(deps)) {
+            if (seen.has(name))
+                continue;
+            if (typeof spec !== 'string' || !spec.startsWith('file:'))
+                continue;
+            const target = path.resolve(cwd, spec.slice('file:'.length));
+            const nm = path.join(target, 'node_modules');
+            if (!fs.existsSync(nm))
+                continue;
+            seen.add(name);
+            const backup = nm + suffix;
+            try {
+                if (fs.existsSync(backup))
+                    fs.rmSync(backup, { recursive: true, force: true });
+                fs.renameSync(nm, backup);
+                stashed.push({ name, nm, backup });
+                if (verbose)
+                    console.log(colors.dim(`  stashed ${nm} -> ${path.basename(backup)}`));
+            }
+            catch (e) {
+                console.error(colors.yellow(`  warning: could not stash ${nm}: ${e.message}`));
+            }
+        }
+    }
+    return stashed;
+}
+/** Restore `node_modules/` previously moved aside by `cleanNestedDepModules`.
+ *  Safe to call multiple times; missing backups are skipped. */
+function restoreNestedDepModules(stashed, verbose) {
+    for (const s of stashed) {
+        try {
+            if (!fs.existsSync(s.backup))
+                continue;
+            if (fs.existsSync(s.nm))
+                fs.rmSync(s.nm, { recursive: true, force: true });
+            fs.renameSync(s.backup, s.nm);
+            if (verbose)
+                console.log(colors.dim(`  restored ${s.nm}`));
+        }
+        catch (e) {
+            console.error(colors.yellow(`  warning: could not restore ${s.nm}: ${e.message}`));
+            console.error(colors.yellow(`    backup remains at ${s.backup} — restore manually`));
+        }
+    }
+}
 /** Run npm install -g with retries for registry propagation delay */
 function installGlobalWithRetry(pkgSpec, cwd, maxRetries = 3) {
     let result = runCommand('npm', ['install', '-g', pkgSpec], { cwd, silent: false, showCommand: true });
@@ -4237,8 +4290,25 @@ export async function globalize(cwd, options = {}, configOptions = {}) {
         if (verbose) {
             console.log(colors.green(`✓ Authenticated as ${authStatus.username}`));
         }
+        // Optionally stash nested node_modules in file: dep targets before pack
+        // (arborist crashes when sibling file: deps have populated node_modules).
+        // Restored immediately after pack so symlinked file: deps stay runnable.
+        let stashedDepModules = [];
+        if (options.cleanNestedModules) {
+            stashedDepModules = cleanNestedDepModules(pkg, cwd, verbose);
+            if (stashedDepModules.length > 0) {
+                console.log(colors.yellow(`  Cleaned node_modules in ${stashedDepModules.length} file: dep target(s): ${stashedDepModules.map(s => s.name).join(', ')}`));
+            }
+            else if (verbose) {
+                console.log(colors.dim('  --clean-nested-modules: nothing to clean'));
+            }
+        }
         // Create tarball first
         const packResult = runCommand('npm', ['pack'], { cwd, silent: true });
+        // Restore stashed node_modules now that pack is done — must happen
+        // before any subsequent install -g symlinks to these dep targets.
+        if (stashedDepModules.length > 0)
+            restoreNestedDepModules(stashedDepModules, verbose);
         if (!packResult.success) {
             const d = diagnoseNpmPackFailure(cwd, packResult.output, packResult.stderr, pkg);
             console.error(colors.red(`ERROR: ${d.summary}`));
@@ -4248,6 +4318,9 @@ export async function globalize(cwd, options = {}, configOptions = {}) {
                 console.error(colors.yellow(`  Caused by referenced module: ${d.referencedModule}`));
             if (d.hint)
                 console.error(colors.yellow(`  Hint: ${d.hint}`));
+            if (d.summary.includes('arborist') && !options.cleanNestedModules) {
+                console.error(colors.yellow(`  Retry with --clean-nested-modules to wipe node_modules/ inside each file: dep target`));
+            }
             recordBuildIssue(pkg.name || path.basename(cwd), 'error', d.referencedModule ? `${d.summary} (via ${d.referencedModule})` : d.summary);
             return false;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bobfrankston/npmglobalize",
-  "version": "1.0.151",
+  "version": "1.0.153",
   "description": "Transform file: dependencies to npm versions for publishing",
   "main": "index.js",
   "type": "module",
@@ -32,7 +32,7 @@
   },
   "dependencies": {
     "@bobfrankston/freezepak": "^0.1.7",
-    "@bobfrankston/importgen": "^0.1.33",
+    "@bobfrankston/importgen": "^0.1.34",
     "@bobfrankston/themecolors": "^0.1.5",
     "@bobfrankston/userconfig": "^1.0.7",
     "@npmcli/package-json": "^7.0.4",
@@ -60,7 +60,7 @@
   ".transformedSnapshot": {
     "dependencies": {
       "@bobfrankston/freezepak": "^0.1.7",
-      "@bobfrankston/importgen": "^0.1.33",
+      "@bobfrankston/importgen": "^0.1.34",
       "@bobfrankston/themecolors": "^0.1.5",
       "@bobfrankston/userconfig": "^1.0.7",
       "@npmcli/package-json": "^7.0.4",