@bobfrankston/msger 0.1.93 → 0.1.96

package/TODO.md

@@ -1,15 +1,109 @@
 # msger TODO List
 
-## Recent Session (2025-11-12) - Hash Option, F11 Fix, Button Response, Debug Mode
+## Recent Session (2025-11-12) - Warning Cleanup
+
+**Status:** ✅ COMPLETED - Version 0.1.95
+
+### What Was Fixed:
+
+1. **Rust Compiler Warnings**
+   - Fixed "unused variable: webview" warning on Linux
+   - Fixed "variable does not need to be mutable" warning
+   - Fixed "unused Result that must be used" warning
+   - Added `#[cfg_attr(not(windows), allow(unused_variables))]` for webview (only used on Windows for About menu)
+   - Changed `let mut webview` to `let webview`
+   - Changed `SetWindowSubclass(...).ok();` to `let _ = SetWindowSubclass(...).ok();`
+
+### Testing:
+- ✅ Windows build: Zero warnings
+- ✅ Linux build: Zero warnings
+- ✅ Windows runtime: Working perfectly
+- ✅ WSL runtime: Working perfectly
+
+---
+
+## Session (2025-11-12) - WSL Linux Support Fixed
+
+**Status:** ✅ COMPLETED - Version 0.1.94
+
+### What Was Implemented:
+
+1. **Fixed WSL/Linux Support**
+   - Root cause: `wry` webview library requires platform-specific builders on Linux
+   - Windows uses `.build(window.as_ref())` with native window handles
+   - Linux requires `.build_gtk(vbox)` with GTK container
+   - Added imports:
+     - `tao::platform::unix::WindowExtUnix` for Linux
+     - `wry::WebViewBuilderExtUnix` for Linux
+   - Added conditional compilation to use correct builder per platform
+   - Location: msger-native/src/main.rs
+
+2. **Fixed Build Script Binary Placement**
+   - Linux binary was placed in wrong location (`../msgernative-linux-x64`)
+   - shower.ts expected it in `msger-native/bin/msgernative`
+   - Updated build.ts to copy to correct location
+   - Also maintains old location for compatibility
+
+3. **Platform-Specific Imports**
+   - Made Windows-specific imports conditional with `#[cfg(target_os = "windows")]`
+   - Added Linux-specific imports with `#[cfg(target_os = "linux")]`
+   - Prevents compilation errors when building for different platforms
+
+### Files Changed:
+- `msger-native/src/main.rs` - Added GTK support for Linux webview creation
+- `msger-native/build.ts` - Fixed binary placement for Linux builds
+- `package.json` - Version bump to 0.1.94
+
+### Testing:
+- ✅ Windows build and runtime (v0.1.94)
+- ✅ Linux build via WSL (v0.1.94)
+- ✅ WSL runtime - window displays correctly with GTK/webkit2gtk
+- ✅ Timeout functionality works in WSL
+- ✅ Button responses work in WSL
+
+### Previous WSL Issue - RESOLVED:
+- Previous error: `Failed to create webview: UnsupportedWindowHandle`
+- Cause: Using `.build(window.as_ref())` on Linux instead of `.build_gtk(vbox)`
+- Fix: Implemented platform-specific webview building
+- WSL now works perfectly with WSLg GUI support
+
+---
+
+## Session (2025-11-12) - Hash Option, F11 Fix, Button Response, Debug Mode
 
 **Status:** ✅ COMPLETED - Version 0.1.91 (published to npm)
 
 ### Installation Status:
 - ✅ Windows build successful (0.1.91)
 - ✅ Published to npm as @bobfrankston/msger@0.1.91
-- ⚠️ WSL Linux build failed (Rust compile error E0432)
-- ⚠️ Global install pending (npm needs time to propagate new version)
-- Note: WSL build issue needs investigation, Windows version fully functional
+- ✅ Installed globally (required `taskkill /im msger*` to unlock files)
+- ❌ WSL fails with `UnsupportedWindowHandle` error (tested with v0.1.91)
+
+### Known Issues:
+1. **WSL Build Error (E0432)**
+   - WSL Linux build fails during Rust compilation in installer script
+   - Error: Could not compile msgernative (bin "msgernative")
+   - Needs investigation of import/dependency issue
+   - Impact: Can't build Linux binary from Windows, but published npm package includes prebuilt binary
+
+2. **WSL Runtime Error - CONFIRMED in v0.1.91**
+   - Error: `Failed to create webview: UnsupportedWindowHandle`
+   - Location: main.rs:314 (`.build(window.as_ref())`)
+   - Root cause: WSL doesn't have native GUI/display server for Windows apps
+   - The `wry` crate requires a native window handle (HWND on Windows, X11 on Linux)
+   - **WSL environment:**
+     - Running from `wsl msger` tries to use Windows binary with WSL context
+     - No valid window handle available in this hybrid environment
+   - **Resolution options:**
+     1. Use WSLg (Windows 11) - may need DISPLAY env var configuration
+     2. Run from Windows PowerShell instead: `msger "hello"` (works perfectly)
+     3. Future: Investigate if WSL2 GUI apps can create windows
+   - **Workaround:** Always run msger from Windows, not through `wsl` command
+
+3. **Installation Tip**
+   - Running msger processes can block file updates
+   - Before installing: `taskkill /im msger* /F` or close all msger windows
+   - This frees up binary files for replacement
 
 ### Next Steps:
 1. Wait ~5-10 minutes for npm to propagate version 0.1.91

package/msger-native/build.ts

@@ -151,18 +151,29 @@ function main() {
 
         if (success) {
             const srcPath = `./target/release/msgernative`;
-            const destPath = `../msgernative-linux-x64`;
+            const destPath = `./bin/msgernative`;
 
             if (existsSync(srcPath)) {
+                // Ensure bin directory exists
+                if (!existsSync('./bin')) {
+                    mkdirSync('./bin', { recursive: true });
+                }
+
                 copyFileSync(srcPath, destPath);
                 // Make executable
                 chmodSync(destPath, 0o755);
                 console.log(`\n✅ Binary copied to: ${destPath}`);
-                
+
                 // Show file size
                 const stats = statSync(destPath);
                 const sizeMB = (stats.size / (1024 * 1024)).toFixed(2);
                 console.log(`📊 Binary size: ${sizeMB} MB`);
+
+                // Also copy to root for compatibility (old location)
+                const rootDestPath = `../msgernative-linux-x64`;
+                copyFileSync(srcPath, rootDestPath);
+                chmodSync(rootDestPath, 0o755);
+                console.log(`📋 Also copied to: ${rootDestPath} (for compatibility)`);
             }
         }
     } else {
@@ -171,18 +182,29 @@ function main() {
 
         if (success) {
             const srcPath = `./target/release/msgernative`;
-            const destPath = `../msgernative-linux-x64`;
+            const destPath = `./bin/msgernative`;
 
             if (existsSync(srcPath)) {
+                // Ensure bin directory exists
+                if (!existsSync('./bin')) {
+                    mkdirSync('./bin', { recursive: true });
+                }
+
                 copyFileSync(srcPath, destPath);
                 // Make executable
                 chmodSync(destPath, 0o755);
                 console.log(`\n✅ Binary copied to: ${destPath}`);
-                
+
                 // Show file size
                 const stats = statSync(destPath);
                 const sizeMB = (stats.size / (1024 * 1024)).toFixed(2);
                 console.log(`📊 Binary size: ${sizeMB} MB`);
+
+                // Also copy to root for compatibility (old location)
+                const rootDestPath = `../msgernative-linux-x64`;
+                copyFileSync(srcPath, rootDestPath);
+                chmodSync(rootDestPath, 0o755);
+                console.log(`📋 Also copied to: ${rootDestPath} (for compatibility)`);
             }
         }
     }

package/msger-native/src/main.rs

@@ -5,10 +5,18 @@ use tao::{
     event_loop::{ControlFlow, EventLoop},
     keyboard::KeyCode,
     window::WindowBuilder,
-    platform::windows::WindowExtWindows,
 };
 use wry::{WebViewBuilder, WebContext};
 
+#[cfg(target_os = "windows")]
+use tao::platform::windows::WindowExtWindows;
+
+#[cfg(target_os = "linux")]
+use tao::platform::unix::WindowExtUnix;
+
+#[cfg(target_os = "linux")]
+use wry::WebViewBuilderExtUnix;
+
 #[cfg(windows)]
 use windows::Win32::UI::WindowsAndMessaging::{
     GetSystemMenu, AppendMenuW, MF_STRING, MF_SEPARATOR, WM_SYSCOMMAND,
@@ -381,7 +389,7 @@ fn main() {
             AppendMenuW(hmenu, MF_STRING, IDM_ABOUT as usize, PCWSTR(about_text.as_ptr())).ok();
         }
         // Install window subclass to intercept WM_SYSCOMMAND
-        SetWindowSubclass(hwnd, Some(subclass_proc), 1, 0).ok();
+        let _ = SetWindowSubclass(hwnd, Some(subclass_proc), 1, 0).ok();
     }
 
     // Generate HTML
@@ -434,9 +442,15 @@ fn main() {
     let mut web_context = WebContext::new(data_directory);
 
     // Create webview with IPC handler
-    let mut webview = if let Some(ref url) = options.url {
+    // Get GTK container for Linux, or use window reference for other platforms
+    #[cfg(target_os = "linux")]
+    let vbox = window.default_vbox().expect("Failed to get GTK vbox");
+
+    // webview is only used on Windows for About menu functionality
+    #[cfg_attr(not(windows), allow(unused_variables))]
+    let webview = if let Some(ref url) = options.url {
         // Load URL with msger API injected
-        WebViewBuilder::with_web_context(&mut web_context)
+        let builder = WebViewBuilder::with_web_context(&mut web_context)
             .with_url(url)
             .with_initialization_script(MSGER_JS_API)
             .with_devtools(true)
@@ -482,12 +496,19 @@ fn main() {
                 } else if std::env::var("MSGER_DEBUG").is_ok() {
                     eprintln!("🐛 Failed to parse IPC message as MessageBoxResult");
                 }
-            })
-            .build(window.as_ref())
-            .expect("Failed to create webview")
+            });
+
+        // Platform-specific webview building
+        #[cfg(target_os = "linux")]
+        let webview = builder.build_gtk(vbox).expect("Failed to create webview");
+
+        #[cfg(not(target_os = "linux"))]
+        let webview = builder.build(window.as_ref()).expect("Failed to create webview");
+
+        webview
     } else {
         // Use HTML content (msger API already in template.html)
-        WebViewBuilder::with_web_context(&mut web_context)
+        let builder = WebViewBuilder::with_web_context(&mut web_context)
             .with_html(&html)
             .with_devtools(true)
             .with_ipc_handler(move |msg| {
@@ -532,9 +553,16 @@ fn main() {
                 } else if std::env::var("MSGER_DEBUG").is_ok() {
                     eprintln!("🐛 Failed to parse IPC message as MessageBoxResult");
                 }
-            })
-            .build(window.as_ref())
-            .expect("Failed to create webview")
+            });
+
+        // Platform-specific webview building
+        #[cfg(target_os = "linux")]
+        let webview = builder.build_gtk(vbox).expect("Failed to create webview");
+
+        #[cfg(not(target_os = "linux"))]
+        let webview = builder.build(window.as_ref()).expect("Failed to create webview");
+
+        webview
     };
 
     // Open DevTools if -dev flag was specified

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@bobfrankston/msger",
-    "version": "0.1.93",
+    "version": "0.1.96",
     "description": "Fast, lightweight, cross-platform message box - Rust-powered alternative to msgview",
     "type": "module",
     "main": "./index.js",