@bobfrankston/mailx 1.0.391 → 1.0.393

package/#build-apk.cmd.asv#

@@ -0,0 +1,4 @@
+setlocal
+cd %~dp0android-maui
+call build-apk.cmd
+cls & 

package/bin/mailx.js

@@ -907,7 +907,9 @@ async function main() {
         fs.mkdirSync(logDir, { recursive: true });
         // Prune logs older than LOG_RETENTION_DAYS on startup. Keep it simple:
         // scan the dir, stat, delete. Cheap even with years of history.
-        const LOG_RETENTION_DAYS = 7;
+        // Bumped 7 → 30 days so "where did my letter go?" reports can still
+        // reach the `[reconcile-delete]` log entry weeks after the fact.
+        const LOG_RETENTION_DAYS = 30;
         const cutoff = Date.now() - LOG_RETENTION_DAYS * 86400000;
         try {
             for (const name of fs.readdirSync(logDir)) {

package/build-apk.cmd

@@ -0,0 +1,3 @@
+setlocal
+cd %~dp0android-maui
+call build-apk.cmd

package/client/app.js

@@ -1573,11 +1573,12 @@ onWsEvent((event) => {
             }
             break;
         case "folderCountsChanged": {
-            // Update folder badges + full tree refresh (not just counts) so
-            // newly-synced folders appear. Without this, the first sync after
-            // setup creates DB folders but the tree never picks them up because
-            // syncComplete fires during page reload and gets lost.
-            refreshFolderTree();
+            // Incremental update only — updateFolderCounts patches badge counts
+            // in-place and falls back to a full refreshFolderTree() when the
+            // folder structure has actually changed. Calling both was doing a
+            // 300 ms debounced rebuild on every sync tick even when just the
+            // unread count moved — visible as folder-tree flicker on Dovecot
+            // accounts where STATUS polls fire frequently.
             updateFolderCounts();
             updateNewMessageCount();
             // Debounced silent reload — preserves scroll position, selection, and viewer
@@ -1677,6 +1678,52 @@ onWsEvent((event) => {
         case "outboxStatus":
             renderOutboxStatus(event);
             break;
+        case "calendarUpdated":
+        case "tasksUpdated":
+            // Reauth succeeded (or was never broken): clear any lingering
+            // scope banner for this feature. Handled here (not just in the
+            // sidebar) because the global fallback banner isn't tied to the
+            // sidebar's lifecycle.
+            if (alertBanner && /^scope-(calendar|tasks|google)$/.test(alertBanner.dataset.key || "")) {
+                alertBanner.hidden = true;
+                alertBanner.dataset.key = "";
+                alertBanner.querySelector(".status-action")?.remove();
+            }
+            break;
+        case "authScopeError": {
+            // Fallback banner: calendar-sidebar.ts already shows this inline
+            // when the sidebar is visible, but if the user has the sidebar
+            // off or is on a narrow tier where it's hidden, the error would
+            // otherwise be invisible. Global banner with the same button.
+            const feat = event.feature || "google";
+            const key = `scope-${feat}`;
+            const msg = event.message || `Google ${feat} access needs re-consent.`;
+            showAlert(msg, key, { sticky: true });
+            const bannerText = document.getElementById("alert-text");
+            if (bannerText && bannerText.textContent === msg) {
+                const existing = bannerText.parentElement?.querySelector(".status-action");
+                if (!existing) {
+                    const btn = document.createElement("button");
+                    btn.className = "status-action";
+                    btn.textContent = "Re-authenticate";
+                    btn.addEventListener("click", async () => {
+                        btn.disabled = true;
+                        btn.textContent = "Opening browser…";
+                        try {
+                            const { reauthGoogleScopes } = await import("./lib/api-client.js");
+                            await reauthGoogleScopes();
+                            btn.textContent = "Consent opened — finish in browser";
+                        }
+                        catch (err) {
+                            btn.disabled = false;
+                            btn.textContent = `Failed: ${err?.message || err}`;
+                        }
+                    });
+                    bannerText.parentElement?.insertBefore(btn, document.getElementById("alert-dismiss"));
+                }
+            }
+            break;
+        }
         case "accountError": {
             // Show actual error + hint in banner
             const msg = `${event.accountId}: ${event.error}`;

package/client/components/message-list.js

@@ -793,6 +793,22 @@ function appendMessages(body, accountId, items) {
                     label: "Delete",
                     action: () => document.dispatchEvent(new CustomEvent("mailx-delete")),
                 },
+                { label: "", action: () => { }, separator: true },
+                {
+                    label: "Copy Message-ID",
+                    action: async () => {
+                        // Useful when asking "where did my letter go?" — pair the
+                        // Message-ID with the reconcile-delete log line.
+                        if (!msg.messageId) {
+                            alert("No Message-ID on this row.");
+                            return;
+                        }
+                        try {
+                            await navigator.clipboard.writeText(msg.messageId);
+                        }
+                        catch { /* */ }
+                    },
+                },
             ];
             showContextMenu(e.clientX, e.clientY, items);
         });

package/client/compose/compose.js

@@ -853,10 +853,8 @@ function formatSize(n) {
 document.getElementById("btn-attach")?.addEventListener("click", () => {
     fileInput?.click();
 });
-fileInput?.addEventListener("change", async () => {
-    if (!fileInput.files)
-        return;
-    for (const file of Array.from(fileInput.files)) {
+async function ingestFiles(files) {
+    for (const file of Array.from(files)) {
         const buf = await file.arrayBuffer();
         // base64 the whole thing — mailx-service builds the multipart/mixed
         let binary = "";
@@ -871,10 +869,68 @@ fileInput?.addEventListener("change", async () => {
             dataBase64,
         });
     }
-    fileInput.value = "";
     renderAttachmentChips();
     scheduleDraftSave();
+}
+fileInput?.addEventListener("change", async () => {
+    if (!fileInput.files)
+        return;
+    await ingestFiles(fileInput.files);
+    fileInput.value = "";
 });
+// Drag-and-drop: dropping files anywhere on the compose window attaches them.
+// Highlights a subtle overlay while dragging so the target is obvious. The
+// editor iframe swallows drag events internally so we attach to the compose
+// document root; Quill's own paste/drop handling doesn't fight us because
+// files-with-no-HTML-or-text dragover never hits Quill's clipboard module.
+(() => {
+    let dragDepth = 0;
+    const root = document.body;
+    const overlay = document.createElement("div");
+    overlay.id = "compose-drop-overlay";
+    // Toggle `display` directly — can't use the `hidden` attribute here
+    // because the inline `display` property in cssText outranks it, which is
+    // why the overlay showed permanently when I used `overlay.hidden = true`
+    // (user-reported 2026-04-24 with screenshot — blue tint + dashed border
+    // were visible before any drag started).
+    const baseStyle = "position:fixed;inset:0;background:oklch(0.6 0.18 250 / 0.15);border:3px dashed oklch(0.55 0.2 250);z-index:9999;pointer-events:none;align-items:center;justify-content:center;font-size:1.5rem;font-weight:500;color:oklch(0.35 0.2 250)";
+    overlay.style.cssText = baseStyle + ";display:none";
+    overlay.textContent = "Drop files to attach";
+    root.appendChild(overlay);
+    const show = () => { overlay.style.display = "flex"; };
+    const hide = () => { overlay.style.display = "none"; };
+    const hasFiles = (e) => Array.from(e.dataTransfer?.types || []).includes("Files");
+    root.addEventListener("dragenter", (e) => {
+        if (!hasFiles(e))
+            return;
+        dragDepth++;
+        show();
+    });
+    root.addEventListener("dragleave", (e) => {
+        if (!hasFiles(e))
+            return;
+        dragDepth = Math.max(0, dragDepth - 1);
+        if (dragDepth === 0)
+            hide();
+    });
+    root.addEventListener("dragover", (e) => {
+        if (!hasFiles(e))
+            return;
+        e.preventDefault(); // required so drop fires
+        if (e.dataTransfer)
+            e.dataTransfer.dropEffect = "copy";
+    });
+    root.addEventListener("drop", async (e) => {
+        if (!hasFiles(e))
+            return;
+        e.preventDefault();
+        dragDepth = 0;
+        hide();
+        const files = e.dataTransfer?.files;
+        if (files && files.length > 0)
+            await ingestFiles(files);
+    });
+})();
 // ── Save and close (X button from parent) ──
 window.addEventListener("compose-save-and-close", () => {
     handleCloseRequest();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bobfrankston/mailx",
-  "version": "1.0.391",
+  "version": "1.0.393",
   "description": "Local-first email client with IMAP sync and standalone native app",
   "type": "module",
   "main": "bin/mailx.js",

package/packages/mailx-service/index.js

@@ -351,7 +351,8 @@ export class MailxService {
     }
     // ── Search ──
     async search(q, page = 1, pageSize = 50, scope = "all", accountId, folderId) {
-        if (!q.trim())
+        q = (q || "").trim();
+        if (!q)
             return { items: [], total: 0, page, pageSize };
         if (scope === "server") {
             // Parse qualifiers once; SEARCH runs per folder.
@@ -1345,6 +1346,7 @@ export class MailxService {
     }
     // ── Contacts ──
     searchContacts(query) {
+        query = (query || "").trim();
         if (query.length < 1)
             return [];
         return this.db.searchContacts(query);

package/packages/mailx-store/db.js

@@ -168,6 +168,9 @@ const SCHEMA = `
     );
     CREATE INDEX IF NOT EXISTS idx_calendar_events_start ON calendar_events(account_id, start_ms);
     CREATE INDEX IF NOT EXISTS idx_calendar_events_dirty ON calendar_events(dirty) WHERE dirty = 1;
+    -- getCalendarEventByProviderId runs once per event on every Google refresh;
+    -- without this index each lookup is a full table scan over calendar_events.
+    CREATE INDEX IF NOT EXISTS idx_calendar_events_provider ON calendar_events(account_id, provider_id);
 
     -- Tasks: two-way cache of Google Tasks / local tasks. Same shape as
     -- calendar_events minus the time range.
@@ -188,6 +191,10 @@ const SCHEMA = `
     );
     CREATE INDEX IF NOT EXISTS idx_tasks_account ON tasks(account_id);
     CREATE INDEX IF NOT EXISTS idx_tasks_dirty ON tasks(dirty) WHERE dirty = 1;
+    -- Mirror calendar_events: any provider_id lookup path needs a proper index,
+    -- even if today's reconcile does the dedup in memory — prevents a future
+    -- refactor from accidentally introducing an O(N) scan.
+    CREATE INDEX IF NOT EXISTS idx_tasks_provider ON tasks(account_id, provider_id);
 
     -- Generic store-sync queue for domains OTHER than messages. Messages
     -- use sync_actions above. This table queues push-to-server actions
@@ -208,6 +215,10 @@ const SCHEMA = `
         UNIQUE(kind, target_uuid, op)
     );
     CREATE INDEX IF NOT EXISTS idx_store_sync_account ON store_sync(account_id, kind);
+    -- UNIQUE(kind, target_uuid, op) covers queries that start with kind; lookups
+    -- by target_uuid alone ("is this uuid queued for any op?") would otherwise
+    -- table-scan. Cheap; store_sync is tiny and write-heavy.
+    CREATE INDEX IF NOT EXISTS idx_store_sync_target_uuid ON store_sync(target_uuid);
 `;
 export class MailxDB {
     db;
@@ -1023,6 +1034,9 @@ export class MailxDB {
     }
     /** Search contacts by name or email prefix */
     searchContacts(query, limit = 10) {
+        query = (query || "").trim();
+        if (!query)
+            return [];
         // Ranking: prefix matches beat substring matches, then recency-weighted
         // use_count within a tier. Recency decay: half-life of 30 days, so a
         // contact used today edges out one from months ago even with a lower
@@ -1064,7 +1078,8 @@ export class MailxDB {
     }
     /** List all contacts (address-book view) with pagination + optional filter. */
     listContacts(query, page = 1, pageSize = 100) {
-        const hasQuery = !!query.trim();
+        query = (query || "").trim();
+        const hasQuery = !!query;
         const q = `%${query}%`;
         const whereClause = hasQuery ? "WHERE email LIKE ? OR name LIKE ?" : "";
         const params = hasQuery ? [q, q] : [];
@@ -1105,6 +1120,7 @@ export class MailxDB {
     // ── Search ──
     /** Full-text search across all messages. Supports qualifiers: from:, to:, subject: */
     searchMessages(query, page = 1, pageSize = 50, accountId, folderId) {
+        query = (query || "").trim();
         // Parse qualifiers (C45: extended set — date:, has:, is:, folder:).
         let ftsQuery = "";
         const parts = query.match(/(?:[^\s"]+|"[^"]*")+/g) || [];