@bobfrankston/mailx 1.0.287 → 1.0.289

package/bin/mailx.js

@@ -661,9 +661,17 @@ async function runTest() {
     console.log("Test complete. Check your inbox for the test message(s).");
     process.exit(0);
 }
-/** Register this client on GDrive — writes/updates clients.jsonc with device info */
+/** Register this client on GDrive — writes/updates clients.jsonc with device info.
+ *  Best-effort: silently skips when cloud isn't ready (fresh install, expired
+ *  token). The scary "No cloud configured" banner must NOT fire for this. */
 async function registerClient(settings) {
-    const { cloudRead, cloudWrite } = await import("@bobfrankston/mailx-settings");
+    const { cloudRead, cloudWrite, getStorageInfo } = await import("@bobfrankston/mailx-settings");
+    // Check if cloud is actually ready before attempting a write — cloudWrite
+    // calls setCloudError which pushes an error banner to the UI. We'd rather
+    // silently skip than show "No cloud configured" at startup.
+    const info = getStorageInfo();
+    if (info.mode === "local" || !info.provider || info.provider === "local")
+        return;
     // Device ID: stable per machine, stored locally
     const deviceIdPath = path.join(os.homedir(), ".mailx", "device-id");
     let deviceId;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bobfrankston/mailx",
-  "version": "1.0.287",
+  "version": "1.0.289",
   "description": "Local-first email client with IMAP sync and standalone native app",
   "type": "module",
   "main": "bin/mailx.js",

package/packages/mailx-settings/cloud.js

@@ -58,18 +58,25 @@ async function getGoogleDriveToken() {
         console.error("  [cloud] No Google credentials found (checked ~/.mailx/google-credentials.json and iflow package)");
         return null;
     }
-    // Delete stale token if scope changed (drive → drive.file or vice versa)
     const tokenPath = path.join(GDRIVE_TOKEN_DIR, "token.json");
+    // Log token state so failures are diagnosable
     if (fs.existsSync(tokenPath)) {
         try {
             const existing = JSON.parse(fs.readFileSync(tokenPath, "utf-8"));
+            const expired = existing.expires_at ? Date.now() >= existing.expires_at : true;
+            const hasRefresh = !!existing.refresh_token;
+            console.log(`  [cloud] GDrive token: ${expired ? "expired" : "valid"}, refresh_token: ${hasRefresh ? "yes" : "NO"}, scope: ${existing.scope || "?"}`);
+            // Delete stale token if scope changed (drive → drive.file or vice versa)
             if (existing.scope && existing.scope !== GDRIVE_SCOPES) {
-                console.log(`  [cloud] Scope changed — re-authenticating...`);
+                console.log(`  [cloud] Scope changed (${existing.scope} → ${GDRIVE_SCOPES}) — re-authenticating...`);
                 fs.unlinkSync(tokenPath);
             }
         }
         catch { /* ignore parse errors */ }
     }
+    else {
+        console.log(`  [cloud] GDrive token: not found at ${tokenPath}`);
+    }
     try {
         const token = await authenticateOAuth(creds, {
             scope: GDRIVE_SCOPES,
@@ -78,10 +85,16 @@ async function getGoogleDriveToken() {
             credentialsKey: "installed",
             includeOfflineAccess: true,
         });
+        if (token?.access_token) {
+            console.log(`  [cloud] GDrive auth: success (token refreshed/valid)`);
+        }
+        else {
+            console.error(`  [cloud] GDrive auth: returned null — OAuth callback likely timed out or was denied`);
+        }
         return token?.access_token || null;
     }
     catch (e) {
-        console.error(`  [cloud] Google Drive auth failed: ${e.message}`);
+        console.error(`  [cloud] GDrive auth FAILED: ${e.message}`);
         return null;
     }
 }

package/packages/mailx-settings/index.js

@@ -145,7 +145,8 @@ export async function cloudRead(filename) {
  *  and the onCloudError listener. */
 export async function cloudWrite(filename, content) {
     if (!pendingCloudConfig) {
-        const err = `No cloud configured — cannot save ${filename} to cloud`;
+        const err = `Cloud not initialized yet — cannot save ${filename} (pendingCloudConfig is null; loadSettings may not have run, or config.jsonc has no sharedDir)`;
+        console.error(`  [cloud] cloudWrite: ${err}`);
         setCloudError(err, { op: "write", filename });
         throw new Error(err);
     }