@bobfrankston/mailx 1.0.218 → 1.0.220

package/client/.msger-window.json

@@ -1 +1 @@
-{"height":1344,"width":2151,"x":243,"y":28}
+{"height":1344,"width":2151,"x":1060,"y":329}

package/client/app.js

@@ -192,6 +192,24 @@ document.getElementById("folder-tree")?.addEventListener("click", (e) => {
         document.querySelector(".folder-panel")?.classList.remove("open");
     }
 });
+// Close folder overlay when user clicks outside it (narrow mode OR
+// medium-width mode where the folder panel slides in as an overlay).
+// Uses capture phase so it beats any child handler that might stopPropagation.
+document.addEventListener("pointerdown", (e) => {
+    const panel = document.querySelector(".folder-panel");
+    if (!panel || !panel.classList.contains("open"))
+        return;
+    const target = e.target;
+    // Ignore clicks inside the panel itself and on the hamburger toggle
+    if (target.closest(".folder-panel") || target.closest("#btn-menu"))
+        return;
+    // Only auto-dismiss when we're in overlay mode (small or medium screens).
+    // On wide screens the panel is a permanent column and the "open" class
+    // is irrelevant.
+    if (window.innerWidth <= 1100 || window.innerHeight <= 600) {
+        panel.classList.remove("open");
+    }
+}, true);
 // ── Toolbar actions ──
 document.getElementById("btn-sync")?.addEventListener("click", async () => {
     const btn = document.getElementById("btn-sync");
@@ -371,30 +389,49 @@ function showComposeOverlay() {
     closeBtn.addEventListener("mouseenter", () => closeBtn.style.color = "#c00");
     closeBtn.addEventListener("mouseleave", () => closeBtn.style.color = "#666");
     closeBtn.addEventListener("click", () => {
+        // compose.ts handles the prompt (Save/Discard/Cancel) and then calls
+        // window.close() which is redirected to wrapper.remove() at line below.
+        // If the user cancels the prompt, closeCompose() is never called and
+        // the wrapper stays. Don't force-remove on a timer — that defeats Cancel.
         try {
             const win = frame.contentWindow;
             if (win)
                 win.dispatchEvent(new Event("compose-save-and-close"));
         }
         catch { /* */ }
-        setTimeout(() => wrapper.remove(), 500);
     });
     titleBar.appendChild(closeBtn);
-    // Drag to move
+    // Drag to move. While dragging we set pointer-events:none on the iframe
+    // so mouse events don't get swallowed by the inner document the moment
+    // the cursor crosses into the iframe region. Without that, drag only
+    // worked if you stayed on the title bar pixels, which is why it felt
+    // broken except at the lower-right (resize grip) corner.
     let dragX = 0, dragY = 0;
     titleBar.addEventListener("mousedown", (e) => {
         if (e.target === closeBtn)
             return;
         e.preventDefault();
-        dragX = e.clientX - wrapper.offsetLeft;
-        dragY = e.clientY - wrapper.offsetTop;
-        const onMove = (e) => {
-            wrapper.style.left = `${e.clientX - dragX}px`;
-            wrapper.style.top = `${e.clientY - dragY}px`;
+        const rect = wrapper.getBoundingClientRect();
+        dragX = e.clientX - rect.left;
+        dragY = e.clientY - rect.top;
+        // Clamp movement to the viewport so the title bar stays grabbable.
+        const clamp = (val, min, max) => Math.max(min, Math.min(max, val));
+        frame.style.pointerEvents = "none";
+        document.body.style.userSelect = "none";
+        const onMove = (ev) => {
+            ev.preventDefault();
+            const w = wrapper.offsetWidth;
+            const h = wrapper.offsetHeight;
+            const left = clamp(ev.clientX - dragX, 0, window.innerWidth - 40);
+            const top = clamp(ev.clientY - dragY, 0, window.innerHeight - 40);
+            wrapper.style.left = `${left}px`;
+            wrapper.style.top = `${top}px`;
             wrapper.style.bottom = "auto";
             wrapper.style.right = "auto";
         };
         const onUp = () => {
+            frame.style.pointerEvents = "";
+            document.body.style.userSelect = "";
             document.removeEventListener("mousemove", onMove);
             document.removeEventListener("mouseup", onUp);
         };

package/client/compose/compose.js

@@ -439,18 +439,65 @@ document.getElementById("btn-send")?.addEventListener("click", async () => {
         alert(`Send failed: ${e.message}`);
     }
 });
-// ── Discard ──
-document.getElementById("btn-discard")?.addEventListener("click", () => {
-    if (editor.getText().trim() || toInput.value) {
-        if (!confirm("Discard this message?"))
-            return;
+// ── Close handling ──
+/** True if the compose has anything worth asking about. */
+function composeHasContent() {
+    return !!(editor.getText().trim() || toInput.value.trim() || ccInput.value.trim() || bccInput.value.trim() || subjectInput.value.trim());
+}
+/** Ask Save/Discard/Cancel. Returns "save" | "discard" | "cancel". */
+function promptSaveOrDiscard() {
+    // Three-way prompt built from two native dialogs: OK(save) / Cancel → then
+    // for Cancel, ask "Really discard?" which becomes Discard / Cancel.
+    const saveIt = confirm("Save this message as a draft?\n\nOK = Save as draft\nCancel = continue...");
+    if (saveIt)
+        return "save";
+    const discard = confirm("Discard the message without saving?\n\nOK = Discard\nCancel = Keep editing");
+    if (discard)
+        return "discard";
+    return "cancel";
+}
+/** Handle any "close the compose" action (Discard button, Escape, X, window close). */
+async function handleCloseRequest() {
+    if (!composeHasContent()) {
+        closeCompose();
+        return true;
     }
-    window.close();
+    const choice = promptSaveOrDiscard();
+    if (choice === "cancel")
+        return false;
+    // Stop auto-save so it can't race with our explicit save/discard.
+    if (draftDebounceTimer) {
+        clearTimeout(draftDebounceTimer);
+        draftDebounceTimer = null;
+    }
+    if (draftTimer) {
+        clearInterval(draftTimer);
+        draftTimer = null;
+    }
+    if (choice === "save") {
+        try {
+            await saveDraft();
+        }
+        catch { /* already logged */ }
+    }
+    else {
+        // Discard: if we have a tracked draft, delete it so the orphan doesn't stick around.
+        if (draftUid || draftId) {
+            try {
+                await deleteDraft(getFromAccountId(), draftUid || 0, draftId || "");
+            }
+            catch { /* ignore */ }
+        }
+    }
+    closeCompose();
+    return true;
+}
+document.getElementById("btn-discard")?.addEventListener("click", () => {
+    handleCloseRequest();
 });
 // ── Save and close (X button from parent) ──
-window.addEventListener("compose-save-and-close", async () => {
-    await saveDraft();
-    closeCompose();
+window.addEventListener("compose-save-and-close", () => {
+    handleCloseRequest();
 });
 // ── Keyboard shortcuts ──
 document.addEventListener("keydown", (e) => {
@@ -458,17 +505,20 @@ document.addEventListener("keydown", (e) => {
         document.getElementById("btn-send")?.click();
     }
     if (e.key === "Escape") {
-        document.getElementById("btn-discard")?.click();
-    }
-    // Ctrl+K = trigger address completion
-    if (e.ctrlKey && e.key === "k") {
         e.preventDefault();
+        handleCloseRequest();
+    }
+    // Ctrl+K in an address field = trigger address completion.
+    // NOTE: Ctrl+K is ALSO the editor's "insert link" shortcut. Scope this handler
+    // strictly to the to/cc/bcc inputs so it doesn't shadow the editor binding when
+    // focus is in the body.
+    if (e.ctrlKey && (e.key === "k" || e.key === "K")) {
         const active = document.activeElement;
         const addressFields = [toInput, ccInput, bccInput];
-        const target = addressFields.includes(active) ? active : toInput;
-        target.focus();
-        // Force trigger autocomplete by dispatching input event
-        target.dispatchEvent(new Event("input"));
+        if (addressFields.includes(active)) {
+            e.preventDefault();
+            active.dispatchEvent(new Event("input"));
+        }
     }
 });
 //# sourceMappingURL=compose.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bobfrankston/mailx",
-  "version": "1.0.218",
+  "version": "1.0.220",
   "description": "Local-first email client with IMAP sync and standalone native app",
   "type": "module",
   "main": "bin/mailx.js",
@@ -20,11 +20,11 @@
     "postinstall": "node bin/postinstall.js"
   },
   "dependencies": {
-    "@bobfrankston/iflow-direct": "^0.1.7",
+    "@bobfrankston/iflow-direct": "^0.1.9",
     "@bobfrankston/iflow-node": "^0.1.2",
     "@bobfrankston/miscinfo": "^1.0.8",
     "@bobfrankston/oauthsupport": "^1.0.22",
-    "@bobfrankston/msger": "^0.1.280",
+    "@bobfrankston/msger": "^0.1.282",
     "@capacitor/android": "^8.3.0",
     "@capacitor/cli": "^8.3.0",
     "@capacitor/core": "^8.3.0",
@@ -74,11 +74,11 @@
   },
   ".transformedSnapshot": {
     "dependencies": {
-      "@bobfrankston/iflow-direct": "^0.1.7",
+      "@bobfrankston/iflow-direct": "^0.1.9",
       "@bobfrankston/iflow-node": "^0.1.2",
       "@bobfrankston/miscinfo": "^1.0.8",
       "@bobfrankston/oauthsupport": "^1.0.22",
-      "@bobfrankston/msger": "^0.1.280",
+      "@bobfrankston/msger": "^0.1.282",
       "@capacitor/android": "^8.3.0",
       "@capacitor/cli": "^8.3.0",
       "@capacitor/core": "^8.3.0",

package/packages/mailx-imap/index.js

@@ -1250,8 +1250,15 @@ export class ImapManager extends EventEmitter {
     /** Fetch a single message body on demand, caching in the store.
      *  Uses its own fresh connection — never blocked by background prefetch. */
     async fetchMessageBody(accountId, folderId, uid) {
-        // Already cached?
+        // Already cached? If the file is on disk but body_path wasn't written to
+        // the DB (e.g. from an interrupted earlier run), the prefetch loop would
+        // otherwise keep returning the same missing rows forever — once saw
+        // "gmail: 17266796 bodies cached" in the logs, which is the counter
+        // spinning on the same 100 rows.
         if (await this.bodyStore.hasMessage(accountId, folderId, uid)) {
+            const existingPath = this.bodyStore.getMessagePath?.(accountId, folderId, uid);
+            if (existingPath)
+                this.db.updateBodyPath(accountId, uid, existingPath);
             return this.bodyStore.getMessage(accountId, folderId, uid);
         }
         if (!this.configs.has(accountId))
@@ -1359,6 +1366,14 @@ export class ImapManager extends EventEmitter {
                 this.db.queueSyncAction(accountId, "delete", msg.uid, msg.folderId);
             }
         }
+        // Recalc folder counts so the tree badge updates immediately instead
+        // of showing stale numbers until the next full sync.
+        const sourceFolderIds = new Set(messages.map(m => m.folderId));
+        for (const fid of sourceFolderIds)
+            this.db.recalcFolderCounts(fid);
+        if (trash)
+            this.db.recalcFolderCounts(trash.id);
+        this.emit("folderCountsChanged", accountId, {});
         // Process all queued actions in one IMAP session
         this.debounceSyncActions(accountId);
     }
@@ -1375,6 +1390,13 @@ export class ImapManager extends EventEmitter {
         for (const msg of messages) {
             this.db.queueSyncAction(accountId, "move", msg.uid, msg.folderId, { targetFolderId });
         }
+        // Recalc folder counts (source folders + destination) so the tree
+        // badge updates immediately.
+        const sourceFolderIds = new Set(messages.map(m => m.folderId));
+        for (const fid of sourceFolderIds)
+            this.db.recalcFolderCounts(fid);
+        this.db.recalcFolderCounts(targetFolderId);
+        this.emit("folderCountsChanged", accountId, {});
         // Process all queued actions in one IMAP session
         this.debounceSyncActions(accountId);
     }

package/packages/mailx-service/index.js

@@ -341,11 +341,34 @@ export class MailxService {
         const account = settings.accounts.find(a => a.id === msg.from);
         if (!account)
             throw new Error(`Unknown account: ${msg.from}`);
+        // Vet every recipient address — refuse to send if any field contains a
+        // non-email (e.g. "Bob Frankston <Bob Frankston>" from a bad contact
+        // autocomplete). This catches garbage BEFORE it hits SMTP, where the
+        // server would either accept-and-bounce or reject the whole envelope.
+        const emailRe = /^[^\s<>@]+@[^\s<>@]+\.[^\s<>@]+$/;
+        const validateList = (label, list) => {
+            if (!list)
+                return;
+            for (const a of list) {
+                const addr = (a?.address || "").trim();
+                if (!addr)
+                    throw new Error(`${label} has an empty address`);
+                if (!emailRe.test(addr))
+                    throw new Error(`${label} has an invalid address: "${addr}"${a?.name ? ` (displayed as "${a.name}")` : ""}`);
+            }
+        };
+        validateList("To", msg.to);
+        validateList("Cc", msg.cc);
+        validateList("Bcc", msg.bcc);
+        if (!msg.to?.length)
+            throw new Error("No To recipients");
         // Extract bare email from fromAddress (may be "Name <addr>" or just "addr")
         let fromAddr = msg.fromAddress || account.email;
         const angleMatch = fromAddr.match(/<([^>]+)>/);
         if (angleMatch)
             fromAddr = angleMatch[1];
+        if (!emailRe.test(fromAddr))
+            throw new Error(`From address is not a valid email: "${fromAddr}"`);
         const fromHeader = `${account.name} <${fromAddr}>`;
         const to = msg.to.map((a) => a.name ? `${a.name} <${a.address}>` : a.address).join(", ");
         const cc = msg.cc?.map((a) => a.name ? `${a.name} <${a.address}>` : a.address).join(", ");

package/packages/mailx-store/db.js

@@ -369,6 +369,11 @@ export class MailxDB {
     // ── Contacts ──
     /** Record an address used in sent mail */
     recordSentAddress(name, email) {
+        // Don't pollute the contacts table with non-addresses. Anything without
+        // an @ or without a TLD-ish tail would show up in autocomplete and end
+        // up back in To/Cc headers as "Name <not an email>".
+        if (!email || !/^[^\s<>@]+@[^\s<>@]+\.[^\s<>@]+$/.test(email))
+            return;
         const now = Date.now();
         const existing = this.db.prepare("SELECT id FROM contacts WHERE email = ?").get(email);
         if (existing) {
@@ -387,6 +392,9 @@ export class MailxDB {
              GROUP BY from_address`).all();
         let added = 0;
         for (const r of rows) {
+            // Skip invalid addresses so contact autocomplete never proposes non-emails
+            if (!r.from_address || !/^[^\s<>@]+@[^\s<>@]+\.[^\s<>@]+$/.test(r.from_address))
+                continue;
             const existing = this.db.prepare("SELECT id FROM contacts WHERE email = ?").get(r.from_address);
             if (!existing) {
                 this.db.prepare("INSERT INTO contacts (source, name, email, last_used, use_count, updated_at) VALUES ('received', ?, ?, ?, ?, ?)").run(r.from_name || "", r.from_address, r.last, r.cnt, now);

package/packages/mailx-store/file-store.d.ts

@@ -8,6 +8,8 @@ export declare class FileMessageStore implements MessageStore {
     private basePath;
     constructor(basePath: string);
     private messagePath;
+    /** Public lookup of the on-disk path without touching the file. */
+    getMessagePath(accountId: string, folderId: number, uid: number): string;
     putMessage(accountId: string, folderId: number, uid: number, raw: Buffer): Promise<string>;
     getMessage(accountId: string, folderId: number, uid: number): Promise<Buffer>;
     deleteMessage(accountId: string, folderId: number, uid: number): Promise<void>;

package/packages/mailx-store/file-store.js

@@ -14,6 +14,10 @@ export class FileMessageStore {
     messagePath(accountId, folderId, uid) {
         return path.join(this.basePath, accountId, String(folderId), `${uid}.eml`);
     }
+    /** Public lookup of the on-disk path without touching the file. */
+    getMessagePath(accountId, folderId, uid) {
+        return this.messagePath(accountId, folderId, uid);
+    }
     async putMessage(accountId, folderId, uid, raw) {
         const filePath = this.messagePath(accountId, folderId, uid);
         fs.mkdirSync(path.dirname(filePath), { recursive: true });