@bobfrankston/mailx 1.0.214 → 1.0.216

package/client/.msger-window.json

@@ -1 +1 @@
-{"height":1344,"width":2151,"x":304,"y":36}
+{"height":1344,"width":2151,"x":243,"y":28}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bobfrankston/mailx",
-  "version": "1.0.214",
+  "version": "1.0.216",
   "description": "Local-first email client with IMAP sync and standalone native app",
   "type": "module",
   "main": "bin/mailx.js",
@@ -20,11 +20,11 @@
     "postinstall": "node bin/postinstall.js"
   },
   "dependencies": {
-    "@bobfrankston/iflow-direct": "^0.1.6",
+    "@bobfrankston/iflow-direct": "^0.1.7",
     "@bobfrankston/iflow-node": "^0.1.2",
     "@bobfrankston/miscinfo": "^1.0.8",
     "@bobfrankston/oauthsupport": "^1.0.22",
-    "@bobfrankston/msger": "^0.1.276",
+    "@bobfrankston/msger": "^0.1.278",
     "@capacitor/android": "^8.3.0",
     "@capacitor/cli": "^8.3.0",
     "@capacitor/core": "^8.3.0",
@@ -74,11 +74,11 @@
   },
   ".transformedSnapshot": {
     "dependencies": {
-      "@bobfrankston/iflow-direct": "^0.1.6",
+      "@bobfrankston/iflow-direct": "^0.1.7",
       "@bobfrankston/iflow-node": "^0.1.2",
       "@bobfrankston/miscinfo": "^1.0.8",
       "@bobfrankston/oauthsupport": "^1.0.22",
-      "@bobfrankston/msger": "^0.1.276",
+      "@bobfrankston/msger": "^0.1.278",
       "@capacitor/android": "^8.3.0",
       "@capacitor/cli": "^8.3.0",
       "@capacitor/core": "^8.3.0",

package/packages/mailx-imap/index.js

@@ -16,6 +16,32 @@ import * as os from "node:os";
 // Well-known ports — no magic numbers
 const SMTP_PORT_STARTTLS = 587;
 const SMTP_PORT_IMPLICIT_TLS = 465;
+/** Per-message SMTP retry delay: if a send attempt fails, wait this long before
+ *  the same file is retried. Gives the server time to settle so a retry after a
+ *  lost-ack doesn't arrive while the first copy is still being processed. */
+const OUTBOX_RETRY_DELAY_MS = 60000;
+/** Parse X-Mailx-Retry* tracking headers from a raw RFC822 message. */
+function parseRetryInfo(raw) {
+    const headerEnd = raw.search(/\r?\n\r?\n/);
+    const headers = headerEnd >= 0 ? raw.slice(0, headerEnd) : raw;
+    const attemptCount = (headers.match(/^X-Mailx-Retry:/gmi) || []).length;
+    const nextMatch = headers.match(/^X-Mailx-Retry-After:\s*(.+)$/mi);
+    const parsed = nextMatch ? Date.parse(nextMatch[1].trim()) : NaN;
+    return { attemptCount, nextAttemptAt: Number.isFinite(parsed) ? parsed : 0 };
+}
+/** Remove every occurrence of a header field from a raw RFC822 message. */
+function stripHeaderField(raw, name) {
+    const re = new RegExp(`^${name.replace(/[.*+?^${}()|[\\]\\\\]/g, "\\\\$&")}:.*\\r?\\n`, "gmi");
+    return raw.replace(re, "");
+}
+/** Insert a header line just before the header/body blank line. Preserves CRLF vs LF. */
+function insertHeaderBeforeBody(raw, line) {
+    const m = raw.match(/\r?\n\r?\n/);
+    if (!m)
+        return raw + "\r\n" + line + "\r\n";
+    const nl = m[0].startsWith("\r\n") ? "\r\n" : "\n";
+    return raw.slice(0, m.index) + nl + line + raw.slice(m.index);
+}
 /** Extract full error detail with provenance */
 function imapError(err) {
     const msg = err.message || err.reason || err.code || (typeof err === "string" ? err : "");
@@ -1734,36 +1760,38 @@ export class ImapManager extends EventEmitter {
             return;
         // Gmail/API accounts: send directly via SMTP from local queue (no IMAP outbox)
         const sentDir = path.join(getConfigDir(), "sending", accountId, "sent");
-        const failedDir = path.join(getConfigDir(), "sending", accountId, "failed");
         fs.mkdirSync(sentDir, { recursive: true });
-        fs.mkdirSync(failedDir, { recursive: true });
         if (this.isGmailAccount(accountId)) {
+            const nowMs = Date.now();
             for (const { dir, file } of filesToSend) {
                 const filePath = path.join(dir, file);
-                const raw = fs.readFileSync(filePath, "utf-8");
+                let raw = fs.readFileSync(filePath, "utf-8");
+                // Per-message rate limit: if a prior attempt set X-Mailx-Retry-After
+                // in the future, skip this file for now. Minimizes the race where the
+                // SMTP server actually accepted DATA but we lost the ack and would
+                // otherwise retry immediately on the next 10s tick.
+                const retryInfo = parseRetryInfo(raw);
+                if (retryInfo.nextAttemptAt > nowMs)
+                    continue;
+                // Record this attempt: strip internal X-Mailx-Retry-After, append a new
+                // X-Mailx-Retry: N <ISO-timestamp> line to the headers. The updated file
+                // is written back *before* the send so a crash mid-send doesn't lose state.
+                const attempt = retryInfo.attemptCount + 1;
+                raw = stripHeaderField(raw, "X-Mailx-Retry-After");
+                raw = insertHeaderBeforeBody(raw, `X-Mailx-Retry: ${attempt} ${new Date().toISOString()}`);
+                fs.writeFileSync(filePath, raw, "utf-8");
                 try {
                     await this.sendRawViaSMTP(accountId, raw);
                     fs.renameSync(filePath, path.join(sentDir, file));
-                    console.log(`  [outbox] Sent ${file} via SMTP → sent/`);
+                    console.log(`  [outbox] Sent ${file} via SMTP → sent/ (attempt ${attempt})`);
                 }
                 catch (e) {
-                    // Critical: NEVER leave a .ltr in the queue after a send attempt unless the
-                    // failure was clearly pre-connect. An error after the SMTP session opened may
-                    // mean the server actually accepted DATA but we lost the ack — retrying would
-                    // double-send. Classify conservatively: only keep-in-queue for clearly
-                    // network-level / pre-auth errors.
-                    const code = String(e?.code || "");
-                    const cmd = String(e?.command || "").toUpperCase();
-                    const preConnect = /^(ECONNREFUSED|ENOTFOUND|EAI_AGAIN|ECONNECTION|ETIMEDOUT)$/.test(code)
-                        && (!cmd || cmd === "CONN");
-                    if (preConnect) {
-                        console.error(`  [outbox] Pre-connect failure for ${file} (${code}), will retry: ${e.message}`);
-                    }
-                    else {
-                        // Ambiguous or terminal — move to failed/ so we don't resend if SMTP actually delivered
-                        fs.renameSync(filePath, path.join(failedDir, file));
-                        console.error(`  [outbox] Send failed for ${file} → failed/ (no auto-retry, code=${code || "?"}): ${e.message}`);
-                    }
+                    // Persist a next-attempt timestamp so the same file won't be retried
+                    // until RETRY_DELAY_MS later — gives the server time to settle.
+                    const nextAt = new Date(nowMs + OUTBOX_RETRY_DELAY_MS).toISOString();
+                    const withDelay = insertHeaderBeforeBody(raw, `X-Mailx-Retry-After: ${nextAt}`);
+                    fs.writeFileSync(filePath, withDelay, "utf-8");
+                    console.error(`  [outbox] Send failed for ${file} (attempt ${attempt}, retry after ${nextAt}): ${e.message}`);
                 }
             }
             return;