@bobfrankston/mailx-store 0.1.42 → 0.1.44

package/db.d.ts

@@ -371,10 +371,20 @@ export declare class MailxDB {
      *  reply arrives. Idempotent — UPDATE on an already-1 row is a no-op. */
     markRepliedByMessageId(accountId: string, messageId: string): boolean;
     /** Get messages without cached bodies (for background prefetch) */
-    getMessagesWithoutBody(accountId: string, limit?: number): {
+    getMessagesWithoutBody(accountId: string, limit?: number, excludeFolderIds?: number[]): {
         uid: number;
         folderId: number;
     }[];
+    /** Record a prefetch failure (0-body fetch / store-write fail) for a UID,
+     *  incrementing its backoff count. Persisted so it survives restarts. */
+    recordPrefetchFailure(accountId: string, folderId: number, uid: number): void;
+    /** Read a UID's prefetch-failure record (count + lastTried), or null. */
+    getPrefetchFailure(accountId: string, folderId: number, uid: number): {
+        count: number;
+        lastTried: number;
+    } | null;
+    /** Clear a UID's prefetch-failure record after a successful fetch. */
+    clearPrefetchFailure(accountId: string, folderId: number, uid: number): void;
     /** Highest server UID we've seen in this folder. After the
      *  message_folders refactor, this reads from the membership table
      *  rather than messages.uid — a server-side move from this folder

package/db.js

@@ -315,6 +315,23 @@ const SCHEMA = `
         PRIMARY KEY(scope, key)
     );
 
+    -- Prefetch-failure backoff, PERSISTED (was an in-memory Map that every
+    -- daemon restart wiped — so un-fetchable "ghost" UIDs, e.g. stale Outbox
+    -- rows for already-sent messages that return 0 bodies, got re-tried in
+    -- full on every launch and re-clogged the size-asc prefetch queue,
+    -- starving healthy folders. "So much unfetched, never drains" — Bob
+    -- 2026-06-01. Persisting the count+timestamp lets the 5min→12h backoff
+    -- survive restarts so zombies stay sidelined. Pure cache-control state;
+    -- safe to lose (worst case = one extra retry), so no reconstruction needed.
+    CREATE TABLE IF NOT EXISTS prefetch_failures (
+        account_id TEXT NOT NULL,
+        folder_id INTEGER NOT NULL,
+        uid INTEGER NOT NULL,
+        count INTEGER NOT NULL,
+        last_tried INTEGER NOT NULL,
+        PRIMARY KEY(account_id, folder_id, uid)
+    );
+
     -- Audit trail of every destructive DB operation. Writes ONLY — the row
     -- inserted here records the deletion the caller is about to (or just
     -- did) commit on the messages table. Lets the user retroactively answer
@@ -1998,14 +2015,41 @@ export class MailxDB {
         return r.changes > 0;
     }
     /** Get messages without cached bodies (for background prefetch) */
-    getMessagesWithoutBody(accountId, limit = 50) {
+    getMessagesWithoutBody(accountId, limit = 50, excludeFolderIds = []) {
         // Prefetch order: smallest first, NULLs last, recent within tiebreak.
         // Reasoning: on slow / metered Android networks, the user feels the
         // cache "fill up" much faster when the queue is dominated by short
         // notification mails (a handful of KB each) instead of a single
         // multi-megabyte attachment that monopolizes bandwidth for minutes.
         // Size 0 / NULL fall to the end so they don't masquerade as small.
-        return this.db.prepare("SELECT uid, folder_id as folderId FROM messages WHERE account_id = ? AND (body_path IS NULL OR body_path = '') ORDER BY (size IS NULL OR size = 0), size ASC, date DESC LIMIT ?").all(accountId, limit);
+        //
+        // excludeFolderIds: folders the caller has put in error-cooldown. We
+        // exclude them HERE (at the query) rather than after slicing, because a
+        // single bloated/failing folder (e.g. a server-side Outbox stuffed with
+        // hundreds of stuck messages) would otherwise fill the entire size-asc
+        // result and starve every healthy folder of its prefetch turn — the
+        // "so much unfetched, nothing draining" symptom (Bob 2026-06-01).
+        const exclusion = excludeFolderIds.length
+            ? ` AND folder_id NOT IN (${excludeFolderIds.map(() => "?").join(",")})`
+            : "";
+        return this.db.prepare(`SELECT uid, folder_id as folderId FROM messages WHERE account_id = ? AND (body_path IS NULL OR body_path = '')${exclusion} ORDER BY (size IS NULL OR size = 0), size ASC, date DESC LIMIT ?`).all(accountId, ...excludeFolderIds, limit);
+    }
+    /** Record a prefetch failure (0-body fetch / store-write fail) for a UID,
+     *  incrementing its backoff count. Persisted so it survives restarts. */
+    recordPrefetchFailure(accountId, folderId, uid) {
+        this.db.prepare(`INSERT INTO prefetch_failures (account_id, folder_id, uid, count, last_tried)
+             VALUES (?, ?, ?, 1, ?)
+             ON CONFLICT(account_id, folder_id, uid)
+             DO UPDATE SET count = count + 1, last_tried = excluded.last_tried`).run(accountId, folderId, uid, Date.now());
+    }
+    /** Read a UID's prefetch-failure record (count + lastTried), or null. */
+    getPrefetchFailure(accountId, folderId, uid) {
+        const r = this.db.prepare("SELECT count, last_tried AS lastTried FROM prefetch_failures WHERE account_id = ? AND folder_id = ? AND uid = ?").get(accountId, folderId, uid);
+        return r ? { count: r.count, lastTried: r.lastTried } : null;
+    }
+    /** Clear a UID's prefetch-failure record after a successful fetch. */
+    clearPrefetchFailure(accountId, folderId, uid) {
+        this.db.prepare("DELETE FROM prefetch_failures WHERE account_id = ? AND folder_id = ? AND uid = ?").run(accountId, folderId, uid);
     }
     /** Highest server UID we've seen in this folder. After the
      *  message_folders refactor, this reads from the membership table

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bobfrankston/mailx-store",
-  "version": "0.1.42",
+  "version": "0.1.44",
   "type": "module",
   "main": "index.js",
   "types": "index.d.ts",
@@ -10,7 +10,7 @@
   "license": "ISC",
   "dependencies": {
     "@bobfrankston/mailx-types": "^0.1.18",
-    "@bobfrankston/mailx-settings": "^0.1.25",
+    "@bobfrankston/mailx-settings": "^0.1.26",
     "@bobfrankston/mailx-bus": "^0.1.2",
     "mailparser": "^3.7.2"
   },
@@ -30,7 +30,7 @@
   ".transformedSnapshot": {
     "dependencies": {
       "@bobfrankston/mailx-types": "^0.1.18",
-      "@bobfrankston/mailx-settings": "^0.1.25",
+      "@bobfrankston/mailx-settings": "^0.1.26",
       "@bobfrankston/mailx-bus": "^0.1.2",
       "mailparser": "^3.7.2"
     }