@bobfrankston/mailx-store 0.1.40 → 0.1.41

package/db.d.ts

@@ -302,7 +302,15 @@ export declare class MailxDB {
      *  Existing callers without folderId are tolerated (legacy) but should
      *  be migrated. */
     getMessageBodyPath(accountId: string, uid: number, folderId?: number): string;
-    updateMessageFlags(accountId: string, uid: number, flags: string[]): void;
+    /** Update flags for a message. folderId is REQUIRED — same UID-collision
+     *  bug class as the deleteMessage one we fixed 2026-05-27. The
+     *  WHERE-account-AND-uid query previously updated EVERY folder's row
+     *  that shared the numeric UID, causing the "stars on letters I never
+     *  starred" symptom (Bob 2026-05-27: flagging one INBOX message lit
+     *  up stars on a same-numeric-UID row in Drafts/Sent/sub-folders).
+     *  folderId === null is allowed as an explicit "every folder" override
+     *  for code paths that mean it; everyone else must pass folderId. */
+    updateMessageFlags(accountId: string, folderId: number | null, uid: number, flags: string[]): void;
     updateMessageFolder(accountId: string, uid: number, targetFolderId: number): void;
     /** Local-first move of a message between folders. Updates BOTH the
      *  legacy `messages.folder_id` column AND the `message_folders`

package/db.js

@@ -1815,8 +1815,21 @@ export class MailxDB {
             : this.db.prepare("SELECT body_path FROM messages WHERE account_id = ? AND uid = ?").get(accountId, uid);
         return r?.body_path || "";
     }
-    updateMessageFlags(accountId, uid, flags) {
-        this.db.prepare("UPDATE messages SET flags_json = ? WHERE account_id = ? AND uid = ?").run(JSON.stringify(flags), accountId, uid);
+    /** Update flags for a message. folderId is REQUIRED — same UID-collision
+     *  bug class as the deleteMessage one we fixed 2026-05-27. The
+     *  WHERE-account-AND-uid query previously updated EVERY folder's row
+     *  that shared the numeric UID, causing the "stars on letters I never
+     *  starred" symptom (Bob 2026-05-27: flagging one INBOX message lit
+     *  up stars on a same-numeric-UID row in Drafts/Sent/sub-folders).
+     *  folderId === null is allowed as an explicit "every folder" override
+     *  for code paths that mean it; everyone else must pass folderId. */
+    updateMessageFlags(accountId, folderId, uid, flags) {
+        if (folderId != null) {
+            this.db.prepare("UPDATE messages SET flags_json = ? WHERE account_id = ? AND folder_id = ? AND uid = ?").run(JSON.stringify(flags), accountId, folderId, uid);
+        }
+        else {
+            this.db.prepare("UPDATE messages SET flags_json = ? WHERE account_id = ? AND uid = ?").run(JSON.stringify(flags), accountId, uid);
+        }
     }
     updateMessageFolder(accountId, uid, targetFolderId) {
         // Idempotency: if a row already exists at (account, target_folder, uid)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bobfrankston/mailx-store",
-  "version": "0.1.40",
+  "version": "0.1.41",
   "type": "module",
   "main": "index.js",
   "types": "index.d.ts",

package/store.js

@@ -450,7 +450,7 @@ export class Store {
      *    `folder:<id>`    (auto fan-out)
      */
     updateFlags(accountId, uid, folderId, flags) {
-        this.db.updateMessageFlags(accountId, uid, flags);
+        this.db.updateMessageFlags(accountId, folderId, uid, flags);
         const env = this.db.getMessageByUid(accountId, uid, folderId);
         const msgUuid = env?.uuid;
         if (msgUuid) {