@bobfrankston/mailx-store 0.1.38 → 0.1.39

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (4) hide show
  1. package/db.d.ts +8 -1
  2. package/db.js +11 -2
  3. package/package.json +3 -3
  4. package/store.js +1 -1
package/db.d.ts CHANGED
@@ -294,7 +294,14 @@ export declare class MailxDB {
294
294
  * is stable. Use this as the identity in any long-lived reference
295
295
  * (compose in-reply-to, dally, undo stacks). */
296
296
  getMessageByUuid(uuid: string): MessageEnvelope;
297
- getMessageBodyPath(accountId: string, uid: number): string;
297
+ /** Look up a message's body_path. folderId is REQUIRED when available
298
+ * because (account, uid) is not a unique key — the same numeric UID
299
+ * refers to different messages in INBOX vs Outbox vs Sent etc. Passing
300
+ * no folderId returns the first matching row, which may be the wrong
301
+ * message's body — same class of bug as the parsedCache UID collision.
302
+ * Existing callers without folderId are tolerated (legacy) but should
303
+ * be migrated. */
304
+ getMessageBodyPath(accountId: string, uid: number, folderId?: number): string;
298
305
  updateMessageFlags(accountId: string, uid: number, flags: string[]): void;
299
306
  updateMessageFolder(accountId: string, uid: number, targetFolderId: number): void;
300
307
  /** Local-first move of a message between folders. Updates BOTH the
package/db.js CHANGED
@@ -1802,8 +1802,17 @@ export class MailxDB {
1802
1802
  return null;
1803
1803
  return this.rowToEnvelope(r);
1804
1804
  }
1805
- getMessageBodyPath(accountId, uid) {
1806
- const r = this.db.prepare("SELECT body_path FROM messages WHERE account_id = ? AND uid = ?").get(accountId, uid);
1805
+ /** Look up a message's body_path. folderId is REQUIRED when available
1806
+ * because (account, uid) is not a unique key the same numeric UID
1807
+ * refers to different messages in INBOX vs Outbox vs Sent etc. Passing
1808
+ * no folderId returns the first matching row, which may be the wrong
1809
+ * message's body — same class of bug as the parsedCache UID collision.
1810
+ * Existing callers without folderId are tolerated (legacy) but should
1811
+ * be migrated. */
1812
+ getMessageBodyPath(accountId, uid, folderId) {
1813
+ const r = folderId != null
1814
+ ? this.db.prepare("SELECT body_path FROM messages WHERE account_id = ? AND folder_id = ? AND uid = ?").get(accountId, folderId, uid)
1815
+ : this.db.prepare("SELECT body_path FROM messages WHERE account_id = ? AND uid = ?").get(accountId, uid);
1807
1816
  return r?.body_path || "";
1808
1817
  }
1809
1818
  updateMessageFlags(accountId, uid, flags) {
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@bobfrankston/mailx-store",
3
- "version": "0.1.38",
3
+ "version": "0.1.39",
4
4
  "type": "module",
5
5
  "main": "index.js",
6
6
  "types": "index.d.ts",
@@ -10,7 +10,7 @@
10
10
  "license": "ISC",
11
11
  "dependencies": {
12
12
  "@bobfrankston/mailx-types": "^0.1.18",
13
- "@bobfrankston/mailx-settings": "^0.1.24",
13
+ "@bobfrankston/mailx-settings": "^0.1.25",
14
14
  "@bobfrankston/mailx-bus": "^0.1.2",
15
15
  "mailparser": "^3.7.2"
16
16
  },
@@ -30,7 +30,7 @@
30
30
  ".transformedSnapshot": {
31
31
  "dependencies": {
32
32
  "@bobfrankston/mailx-types": "^0.1.18",
33
- "@bobfrankston/mailx-settings": "^0.1.24",
33
+ "@bobfrankston/mailx-settings": "^0.1.25",
34
34
  "@bobfrankston/mailx-bus": "^0.1.2",
35
35
  "mailparser": "^3.7.2"
36
36
  }
package/store.js CHANGED
@@ -224,7 +224,7 @@ export class Store {
224
224
  // the historical lookup. Either may be empty (body never fetched).
225
225
  let storedPath = envelope.bodyPath || "";
226
226
  if (!storedPath)
227
- storedPath = this.db.getMessageBodyPath(accountId, uid) || "";
227
+ storedPath = this.db.getMessageBodyPath(accountId, uid, folderId) || "";
228
228
  const empty = {
229
229
  ...envelope,
230
230
  bodyHtml: "", bodyText: "",