@bobfrankston/mailx-store 0.1.10 → 0.1.11

package/db.js

@@ -334,6 +334,25 @@ export class MailxDB {
         // this column landed. One UPDATE + an id roundtrip per row — cheap
         // at our row counts, runs once per DB upgrade.
         this.backfillUuids();
+        // One-shot cleanup: the retired insertOptimisticSentRow path wrote
+        // synthetic-negative-UID rows into Sent. Those rows are stale (the
+        // real server-synced row eventually appears with a positive UID),
+        // they pollute MAX(uid) (which broke Sent sync entirely), and the
+        // mechanism is gone. Drop them. Bodies on disk are orphaned; the
+        // body-store has no GC today but a one-time leak is fine.
+        try {
+            const purgedFlag = this.getKv("schema", "drop_synthetic_uids_v1");
+            if (!purgedFlag) {
+                const r = this.db.prepare("DELETE FROM messages WHERE uid < 0").run();
+                if (r.changes) {
+                    console.log(`  [migration] dropped ${r.changes} synthetic-UID rows from messages`);
+                }
+                this.setKv("schema", "drop_synthetic_uids_v1", "1");
+            }
+        }
+        catch (e) {
+            console.error(`  [migration] synthetic-UID cleanup failed: ${e?.message || e}`);
+        }
         // One-shot contacts table reset: the contacts schema's UNIQUE constraint
         // was widened from `(email)` to `(source, email, name)` so the same
         // address can carry multiple distinct (name, source) entries — Bob's
@@ -1029,15 +1048,14 @@ export class MailxDB {
         // LEFT JOIN sync_actions so each row carries a `pending` flag —
         // true when the user has a queued local action (move/flag/delete)
         // not yet acknowledged by the server. UI renders these in pink so
-        // local-only state is visible (Slice C of S1). Negative UIDs also
-        // count as pending: that's the convention for optimistic local
-        // inserts (e.g. Sent rows written the moment the user hits Send,
-        // before the real APPENDUID comes back from the server).
+        // local-only state is visible (Slice C of S1). The optimistic-Sent
+        // negative-UID convention was retired — Sent now reflects only what
+        // the server has; pending sends live in the Outbox view.
         const rows = this.db.prepare(`SELECT m.*, (
                 EXISTS(
                     SELECT 1 FROM sync_actions sa
                     WHERE sa.account_id = m.account_id AND sa.uid = m.uid
-                ) OR m.uid < 0
+                )
             ) AS pending
             FROM messages m WHERE ${where.replace(/\b(account_id|folder_id|uid|date|subject|from_name|from_address|flags_json)\b/g, "m.$1")}
             ORDER BY m.${sortCol} ${sortDir} LIMIT ? OFFSET ?`).all(...params, pageSize, offset);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bobfrankston/mailx-store",
-  "version": "0.1.10",
+  "version": "0.1.11",
   "type": "module",
   "main": "index.js",
   "types": "index.d.ts",
@@ -10,7 +10,7 @@
   "license": "ISC",
   "dependencies": {
     "@bobfrankston/mailx-types": "^0.1.10",
-    "@bobfrankston/mailx-settings": "^0.1.12"
+    "@bobfrankston/mailx-settings": "^0.1.13"
   },
   "repository": {
     "type": "git",
@@ -26,7 +26,7 @@
   ".transformedSnapshot": {
     "dependencies": {
       "@bobfrankston/mailx-types": "^0.1.10",
-      "@bobfrankston/mailx-settings": "^0.1.12"
+      "@bobfrankston/mailx-settings": "^0.1.13"
     }
   }
 }