@bobfrankston/mailx-imap 0.1.69 → 0.1.71

package/index.d.ts

@@ -59,6 +59,7 @@ export interface OutboxStatus {
 export declare class ImapManager extends EventEmitter {
     private configs;
     private watchers;
+    private watcherClients;
     private fetchClients;
     /** The Store is the architectural nexus — owner of MailxDB +
      *  FileMessageStore + the event bus. This package (mailx-imap) is a

package/index.js

@@ -158,6 +158,14 @@ async function withTimeout(promise, ms, client, label) {
 export class ImapManager extends EventEmitter {
     configs = new Map();
     watchers = new Map();
+    // Parallel map of the IDLE watch client per account, so runFullSync /
+    // startWatching can health-check the live socket and refresh ONLY dead
+    // watchers instead of tearing every watcher down each cycle. The blanket
+    // teardown was the IDLE-churn driver: it dropped healthy IDLE every 5 min,
+    // and re-establishing competed for the saturated 4-permit host semaphore
+    // (folder syncs holding all permits, timing out at 360s), leaving new mail
+    // on 5-min polling for minutes at a time (Bob 2026-05-28).
+    watcherClients = new Map();
     fetchClients = new Map();
     /** The Store is the architectural nexus — owner of MailxDB +
      *  FileMessageStore + the event bus. This package (mailx-imap) is a
@@ -294,6 +302,7 @@ export class ImapManager extends EventEmitter {
                 }
                 catch { /* */ }
                 this.watchers.delete(accountId);
+                this.watcherClients.delete(accountId);
             }
             // Delete only the IMAP token (not contacts — separate scope, separate consent)
             const accountDir = tokenDirName(account.imap.user);
@@ -1049,6 +1058,18 @@ export class ImapManager extends EventEmitter {
      *
      *  Fires the same emits as a normal sync so the UI updates. */
     async insertLocalRowFromSource(accountId, folder, uid, source, flags) {
+        // Guard against uid <= 0. Valid IMAP UIDs are always ≥ 1; a 0 here
+        // means the APPENDUID capture failed (server returned no UIDPLUS, or
+        // appendMessage resolved to 0 instead of null) and the caller didn't
+        // catch it. Inserting uid=0 created a phantom INBOX row with no
+        // message_id, no body, no subject — the "blank line in the summary"
+        // (Bob 2026-05-28). Refuse it; the caller's syncFolder fallback will
+        // pick the message up with its real UID on the next sync.
+        if (!uid || uid <= 0) {
+            console.error(`  [insert] refusing uid=${uid} for ${accountId}/${folder.path} — invalid IMAP UID (APPENDUID likely failed); deferring to sync`);
+            this.syncFolder(accountId, folder.id).catch(() => { });
+            return;
+        }
         // insertLocalRowFromSource runs right after sendMessage — that's a
         // user-initiated path but the parse cost is on the post-send
         // background work, not the click-through. Tag as background so a
@@ -2461,7 +2482,12 @@ export class ImapManager extends EventEmitter {
     async runFullSync() {
         console.log(`  [periodic] Full sync at ${new Date().toLocaleTimeString()}`);
         await this.syncAll();
-        await this.stopWatching();
+        // Do NOT tear down healthy IDLE here. startWatching is idempotent and
+        // now health-checks each existing watcher: alive ones are left intact,
+        // dead/missing ones are re-established. The old unconditional
+        // stopWatching()+startWatching() dropped healthy IDLE every cycle and
+        // the re-establish stalled behind the saturated host semaphore — the
+        // "still slow polling / not subscribing" gaps (Bob 2026-05-28).
         await this.startWatching();
     }
     /** Stop periodic sync */
@@ -2482,8 +2508,28 @@ export class ImapManager extends EventEmitter {
      *  right way to make that cheap, not piling per-folder IDLE sockets). */
     async startWatching() {
         for (const [accountId] of this.configs) {
-            if (this.watchers.has(accountId))
-                continue;
+            if (this.watchers.has(accountId)) {
+                // Already watching — but is the socket still alive? A silently
+                // dropped IDLE leaves the watcher entry in place, so without
+                // this health-check the deadman (which only checks for MISSING
+                // entries) would never refresh it. If dead, tear down just THIS
+                // one and fall through to re-establish; if alive, leave it.
+                const wc = this.watcherClients.get(accountId);
+                const sock = wc?.native?.transport?.socket;
+                const dead = !wc || sock?.destroyed || sock?.readyState === "closed" || wc?._dead;
+                if (!dead)
+                    continue;
+                console.log(`  [idle] ${accountId}: watcher socket dead — refreshing`);
+                const stop = this.watchers.get(accountId);
+                if (stop) {
+                    try {
+                        await stop();
+                    }
+                    catch { /* */ }
+                }
+                this.watchers.delete(accountId);
+                this.watcherClients.delete(accountId);
+            }
             try {
                 // IDLE keeps its own dedicated socket — once the connection
                 // is parked in IDLE, it's unusable for any other command, so
@@ -2545,6 +2591,7 @@ export class ImapManager extends EventEmitter {
                     await stop();
                     await watchClient.logout();
                 });
+                this.watcherClients.set(accountId, watchClient);
                 console.log(`  [idle] Watching INBOX for ${accountId}${useNotify ? " (+NOTIFY personal mailboxes)" : ""}`);
             }
             catch (e) {
@@ -2578,6 +2625,7 @@ export class ImapManager extends EventEmitter {
             catch { /* ignore */ }
         }
         this.watchers.clear();
+        this.watcherClients.clear();
     }
     /** Unlink the on-disk body file for a message by reading its `body_path`
      *  from the DB. Safe to call either before or after `db.deleteMessage`

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bobfrankston/mailx-imap",
-  "version": "0.1.69",
+  "version": "0.1.71",
   "type": "module",
   "main": "index.js",
   "types": "index.d.ts",
@@ -11,7 +11,7 @@
   "dependencies": {
     "@bobfrankston/mailx-types": "^0.1.18",
     "@bobfrankston/mailx-settings": "^0.1.25",
-    "@bobfrankston/mailx-store": "^0.1.40",
+    "@bobfrankston/mailx-store": "^0.1.41",
     "@bobfrankston/iflow-direct": "^0.1.51",
     "@bobfrankston/tcp-transport": "^0.1.6",
     "@bobfrankston/smtp-direct": "^0.1.8",
@@ -39,7 +39,7 @@
     "dependencies": {
       "@bobfrankston/mailx-types": "^0.1.18",
       "@bobfrankston/mailx-settings": "^0.1.25",
-      "@bobfrankston/mailx-store": "^0.1.40",
+      "@bobfrankston/mailx-store": "^0.1.41",
       "@bobfrankston/iflow-direct": "^0.1.51",
       "@bobfrankston/tcp-transport": "^0.1.6",
       "@bobfrankston/smtp-direct": "^0.1.8",