@bobfrankston/mailx-imap 0.1.68 → 0.1.70

package/index.js

@@ -1049,6 +1049,18 @@ export class ImapManager extends EventEmitter {
      *
      *  Fires the same emits as a normal sync so the UI updates. */
     async insertLocalRowFromSource(accountId, folder, uid, source, flags) {
+        // Guard against uid <= 0. Valid IMAP UIDs are always ≥ 1; a 0 here
+        // means the APPENDUID capture failed (server returned no UIDPLUS, or
+        // appendMessage resolved to 0 instead of null) and the caller didn't
+        // catch it. Inserting uid=0 created a phantom INBOX row with no
+        // message_id, no body, no subject — the "blank line in the summary"
+        // (Bob 2026-05-28). Refuse it; the caller's syncFolder fallback will
+        // pick the message up with its real UID on the next sync.
+        if (!uid || uid <= 0) {
+            console.error(`  [insert] refusing uid=${uid} for ${accountId}/${folder.path} — invalid IMAP UID (APPENDUID likely failed); deferring to sync`);
+            this.syncFolder(accountId, folder.id).catch(() => { });
+            return;
+        }
         // insertLocalRowFromSource runs right after sendMessage — that's a
         // user-initiated path but the parse cost is on the post-send
         // background work, not the click-through. Tag as background so a
@@ -1250,7 +1262,7 @@ export class ImapManager extends EventEmitter {
                     for (const m of qr.changedMessages) {
                         try {
                             const flagsArr = Array.from(m.flags || []).map(f => String(f));
-                            this.db.updateMessageFlags(accountId, m.uid, flagsArr);
+                            this.db.updateMessageFlags(accountId, folderId, m.uid, flagsArr);
                         }
                         catch { /* row may have just been VANISHED */ }
                     }
@@ -3467,6 +3479,12 @@ export class ImapManager extends EventEmitter {
             // Delete previous draft — try UID first (fast path), and ALWAYS also try
             // searchByHeader(X-Mailx-Draft-ID) as a safety net. Running both catches
             // orphans from a crash-mid-save or a UID delete that failed silently.
+            //
+            // CRITICAL: also delete the LOCAL DB row for the superseded UID. Without
+            // that, every checkpoint save left a stale row behind — IMAP had only
+            // the latest copy but the local Drafts view rendered every past UID as
+            // its own row, producing the "Drafts is flooded with droppings" symptom
+            // (Bob 2026-05-27 — 8+ rows for a single in-progress reply).
             if (previousDraftUid) {
                 try {
                     await client.deleteMessageByUid(drafts.path, previousDraftUid);
@@ -3474,6 +3492,10 @@ export class ImapManager extends EventEmitter {
                 catch (e) {
                     console.error(`  [drafts] Delete prev UID ${previousDraftUid} failed: ${e.message}`);
                 }
+                try {
+                    this.db.deleteMessage(accountId, drafts.id, previousDraftUid, "previous draft superseded", "saveDraft");
+                }
+                catch { /* */ }
             }
             if (draftId) {
                 try {
@@ -3483,6 +3505,10 @@ export class ImapManager extends EventEmitter {
                             await client.deleteMessageByUid(drafts.path, uid);
                         }
                         catch { /* next */ }
+                        try {
+                            this.db.deleteMessage(accountId, drafts.id, uid, `draft superseded by newer save (id=${draftId})`, "saveDraft");
+                        }
+                        catch { /* */ }
                     }
                     if (uids.length > 0)
                         console.log(`  [drafts] Deleted ${uids.length} stale draft(s) by ID ${draftId}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bobfrankston/mailx-imap",
-  "version": "0.1.68",
+  "version": "0.1.70",
   "type": "module",
   "main": "index.js",
   "types": "index.d.ts",
@@ -11,7 +11,7 @@
   "dependencies": {
     "@bobfrankston/mailx-types": "^0.1.18",
     "@bobfrankston/mailx-settings": "^0.1.25",
-    "@bobfrankston/mailx-store": "^0.1.40",
+    "@bobfrankston/mailx-store": "^0.1.41",
     "@bobfrankston/iflow-direct": "^0.1.51",
     "@bobfrankston/tcp-transport": "^0.1.6",
     "@bobfrankston/smtp-direct": "^0.1.8",
@@ -39,7 +39,7 @@
     "dependencies": {
       "@bobfrankston/mailx-types": "^0.1.18",
       "@bobfrankston/mailx-settings": "^0.1.25",
-      "@bobfrankston/mailx-store": "^0.1.40",
+      "@bobfrankston/mailx-store": "^0.1.41",
       "@bobfrankston/iflow-direct": "^0.1.51",
       "@bobfrankston/tcp-transport": "^0.1.6",
       "@bobfrankston/smtp-direct": "^0.1.8",