@bobfrankston/mailx-imap 0.1.142 → 0.1.146

package/index.d.ts

@@ -68,6 +68,15 @@ export declare class ImapManager extends EventEmitter {
      *  giving two watchers each for bobma/gmail and pushing aol into
      *  "[LIMIT] LOGIN Rate limit hit". This set closes that window. */
     private watchStarting;
+    /** Accounts whose IDLE watcher was refused for a CREDENTIAL reason, with
+     *  the error text. Retrying those every 60s forever is pure waste: the
+     *  outlook account has failed `AUTHENTICATE failed.` on every boot for
+     *  weeks (its mail syncs over Graph, so nothing is lost — but each attempt
+     *  burns a connection slot and buries the log). Suppressed until the
+     *  account re-authenticates, which clears the entry. Transient refusals
+     *  (rate limits, network) are NOT recorded here — they keep the normal
+     *  60s deadman cadence. */
+    private watchAuthFailed;
     private fetchClients;
     /** The Store is the architectural nexus — owner of MailxDB +
      *  FileMessageStore + the event bus. This package (mailx-imap) is a

package/index.js

@@ -210,6 +210,15 @@ export class ImapManager extends EventEmitter {
      *  giving two watchers each for bobma/gmail and pushing aol into
      *  "[LIMIT] LOGIN Rate limit hit". This set closes that window. */
     watchStarting = new Set();
+    /** Accounts whose IDLE watcher was refused for a CREDENTIAL reason, with
+     *  the error text. Retrying those every 60s forever is pure waste: the
+     *  outlook account has failed `AUTHENTICATE failed.` on every boot for
+     *  weeks (its mail syncs over Graph, so nothing is lost — but each attempt
+     *  burns a connection slot and buries the log). Suppressed until the
+     *  account re-authenticates, which clears the entry. Transient refusals
+     *  (rate limits, network) are NOT recorded here — they keep the normal
+     *  60s deadman cadence. */
+    watchAuthFailed = new Map();
     fetchClients = new Map();
     /** The Store is the architectural nexus — owner of MailxDB +
      *  FileMessageStore + the event bus. This package (mailx-imap) is a
@@ -371,6 +380,9 @@ export class ImapManager extends EventEmitter {
             if (config?.tokenProvider) {
                 console.log(`  [reauth] ${accountId}: success`);
                 this.accountErrorShown.delete(accountId);
+                // Fresh credentials — let IDLE try again on an account whose
+                // watcher was suppressed for an auth failure.
+                this.watchAuthFailed.delete(accountId);
                 this.syncInbox().catch(() => { });
                 return true;
             }
@@ -903,6 +915,15 @@ export class ImapManager extends EventEmitter {
         const skipSemaphore = purpose === "idle";
         const releaseHostSlot = skipSemaphore ? (() => { }) : await this.acquireHostSlot(host);
         let client;
+        // Forward declaration: the connect wrapper below is DEFINED here but
+        // only CALLED after newClient returns, by which time the real
+        // markClosed is installed. A connect that throws (aol "[LIMIT] LOGIN
+        // Rate limit hit", outlook "AUTHENTICATE failed") used to leave the
+        // client registered in openClients forever AND never release its host
+        // semaphore permit — the counter climbed to 141 over a 37-hour session
+        // (Bob 2026-08-05 shutdown log) and every leaked permit is one fewer
+        // concurrent connection that account can ever open again.
+        let markClosed = () => { };
         try {
             // Verbose IMAP wire trace — diagnostic for silently-hanging
             // commands. It was left permanently ON for the ops/fast lanes, but
@@ -954,10 +975,21 @@ export class ImapManager extends EventEmitter {
                         const total = Date.now() - connT0;
                         if (total > 3000)
                             console.log(`  [conn-slow] ${accountId} (${purpose}): connect took ${total}ms — ${phaseTimings()}`);
+                        // A socket that dies on its own — server drop, TLS
+                        // reset, idle timeout — never routes through
+                        // logout()/destroy(), so without this the connection
+                        // stays "open" in our books and its semaphore permit
+                        // is gone for the life of the process. Node always
+                        // emits 'close' after 'error', so one listener covers
+                        // both.
+                        const sock = client?.native?.transport?.socket;
+                        if (typeof sock?.once === "function")
+                            sock.once("close", () => markClosed("socket-close"));
                         return r;
                     }
                     catch (e) {
                         emitPhase("failed", e?.message || String(e));
+                        markClosed("connect-failed");
                         throw e;
                     }
                 };
@@ -975,10 +1007,17 @@ export class ImapManager extends EventEmitter {
         open.add(client);
         console.log(`  [conn+] ${accountId} (${purpose}) — ${open.size} open`);
         let closed = false;
-        const markClosed = (how) => {
+        markClosed = (how) => {
             if (closed)
                 return;
             closed = true;
+            // Flag the client itself so the IDLE watcher health-check (which
+            // inspects `_dead` alongside the raw socket state) re-establishes
+            // a watcher whose socket died under it.
+            try {
+                client._dead = true;
+            }
+            catch { /* frozen client — the socket checks still catch it */ }
             open.delete(client);
             releaseHostSlot();
             console.log(`  [conn-] ${accountId} (${purpose}/${how}) — ${open.size} open`);
@@ -3236,6 +3275,10 @@ export class ImapManager extends EventEmitter {
                 console.log(`  [idle] ${accountId}: watcher already being established — skipping duplicate`);
                 continue;
             }
+            // Credentials were refused last time. Don't re-offer them every
+            // 60s — wait for a re-auth to clear this. See watchAuthFailed.
+            if (this.watchAuthFailed.has(accountId))
+                continue;
             this.watchStarting.add(accountId);
             try {
                 // IDLE keeps its own dedicated socket — once the connection
@@ -3336,6 +3379,17 @@ export class ImapManager extends EventEmitter {
                     ? parts.join(" ")
                     : `<no message> ${typeof e} ${e?.constructor?.name || ""}`.trim();
                 console.error(`  [idle] Failed to watch ${accountId}: ${desc}`);
+                // Separate "these credentials are wrong" from "the server is
+                // busy right now". A rate limit ([LIMIT] LOGIN Rate limit hit
+                // — aol does this when we over-connect) says nothing about the
+                // credentials and must stay retryable, so it is checked FIRST
+                // even though its text also contains "Login failed".
+                const transient = /\[LIMIT\]|rate limit|too many|try again|timed? ?out|ECONNRESET|ETIMEDOUT|ENOTFOUND|EAI_AGAIN|socket/i.test(desc);
+                const authFailed = !transient && /authenticat|login failed|AUTHENTICATIONFAILED|invalid credential|password|\[AUTH/i.test(desc);
+                if (authFailed) {
+                    this.watchAuthFailed.set(accountId, desc);
+                    console.error(`  [idle] ${accountId}: credentials refused — suppressing IDLE retries until this account re-authenticates`);
+                }
             }
             finally {
                 this.watchStarting.delete(accountId);
@@ -6127,7 +6181,11 @@ export class ImapManager extends EventEmitter {
         try {
             do {
                 const params = new URLSearchParams({
-                    personFields: "names,emailAddresses,organizations,photos",
+                    // The full contact card. Before 2026-08-07 this asked for
+                    // names/emails/orgs only, so phone numbers, job titles,
+                    // postal addresses, websites, notes and birthdays that
+                    // Google already held were thrown away on every sync.
+                    personFields: "names,emailAddresses,organizations,photos,phoneNumbers,addresses,urls,biographies,birthdays",
                     pageSize: "100",
                 });
                 if (nextPageToken)
@@ -6178,7 +6236,25 @@ export class ImapManager extends EventEmitter {
                         const names = person.names || [];
                         const orgs = person.organizations || [];
                         const name = names[0]?.displayName || "";
-                        const org = orgs[0]?.name || "";
+                        // Google returns each field as an array of typed
+                        // entries (home/work/other) ordered with the primary
+                        // first; we keep the first of each. Birthdays come as
+                        // {date:{year?,month,day}} — year is optional, and a
+                        // missing one is normal (people omit it), so format as
+                        // YYYY-MM-DD when known and --MM-DD when not.
+                        const bd = person.birthdays?.[0]?.date;
+                        const pad = (n) => String(n).padStart(2, "0");
+                        const card = {
+                            organization: orgs[0]?.name || "",
+                            title: orgs[0]?.title || "",
+                            phone: person.phoneNumbers?.[0]?.value || "",
+                            address: person.addresses?.[0]?.formattedValue || "",
+                            website: person.urls?.[0]?.value || "",
+                            notes: person.biographies?.[0]?.value || "",
+                            birthday: bd?.month && bd?.day
+                                ? `${bd.year ? bd.year : "-"}-${pad(bd.month)}-${pad(bd.day)}`
+                                : "",
+                        };
                         for (const emailEntry of emails) {
                             const email = emailEntry.value?.toLowerCase();
                             if (!email)
@@ -6189,9 +6265,15 @@ export class ImapManager extends EventEmitter {
                             if (wasNew)
                                 changed++;
                             try {
-                                this.db.db.prepare("UPDATE contacts SET source = 'google', google_id = ?, organization = ?, updated_at = ? WHERE email = ?").run(googleId, org, now, email);
+                                this.db.db.prepare(`UPDATE contacts SET source = 'google', google_id = ?, organization = ?, title = ?,
+                                        phone = ?, address = ?, website = ?, notes = ?, birthday = ?, updated_at = ?
+                                     WHERE email = ?`).run(googleId, card.organization, card.title, card.phone, card.address, card.website, card.notes, card.birthday, now, email);
+                            }
+                            catch (e) {
+                                // Loud: a schema drift here silently reverts the
+                                // address book to name+email only.
+                                console.error(`  [contacts] field update failed for ${email}: ${e?.message || e}`);
                             }
-                            catch { /* ignore */ }
                         }
                     }
                 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bobfrankston/mailx-imap",
-  "version": "0.1.142",
+  "version": "0.1.146",
   "type": "module",
   "main": "index.js",
   "types": "index.d.ts",
@@ -11,7 +11,7 @@
   "dependencies": {
     "@bobfrankston/mailx-types": "^0.1.38",
     "@bobfrankston/mailx-settings": "^0.1.48",
-    "@bobfrankston/mailx-store": "^0.1.80",
+    "@bobfrankston/mailx-store": "^0.1.81",
     "@bobfrankston/iflow-direct": "^0.1.65",
     "@bobfrankston/tcp-transport": "^0.1.8",
     "@bobfrankston/smtp-direct": "^0.1.9",
@@ -39,7 +39,7 @@
     "dependencies": {
       "@bobfrankston/mailx-types": "^0.1.38",
       "@bobfrankston/mailx-settings": "^0.1.48",
-      "@bobfrankston/mailx-store": "^0.1.80",
+      "@bobfrankston/mailx-store": "^0.1.81",
       "@bobfrankston/iflow-direct": "^0.1.65",
       "@bobfrankston/tcp-transport": "^0.1.8",
       "@bobfrankston/smtp-direct": "^0.1.9",