@bobfrankston/gcards 0.1.13 → 0.1.15

package/.claude/settings.local.json

@@ -22,7 +22,8 @@
       "Bash(npx tsx:*)",
       "WebFetch(domain:lh3.googleusercontent.com)",
       "Bash(curl:*)",
-      "Bash(bun build:*)"
+      "Bash(bun build:*)",
+      "Bash(xargs -I {} sh -c 'echo \"\"=== {} ===\"\" && head -20 {}')"
     ],
     "deny": [],
     "ask": []

package/gfix.ts

@@ -746,7 +746,13 @@ function parseFullName(fullName: string): ParsedName {
     };
 }
 
-/** Fix names: parse givenName into first/middle/last, clean fileAs */
+/** Check if string looks like a phone number */
+function looksLikePhone(s: string): boolean {
+    const digits = s.replace(/\D/g, '');
+    return digits.length >= 7 && digits.length <= 15 && /^[\d\s\-.()+]+$/.test(s);
+}
+
+/** Fix names: parse givenName into first/middle/last, clean fileAs, handle nameless contacts */
 async function runNamesFix(user: string, mode: 'inspect' | 'apply'): Promise<void> {
     const paths = getUserPaths(user);
 
@@ -769,12 +775,32 @@ async function runNamesFix(user: string, mode: 'inspect' | 'apply'): Promise<voi
     const problems: string[] = [];
     let contactsModified = 0;
 
+    // Track nameless contacts for deletion
+    const emailOnly: { file: string; resourceName: string; email: string }[] = [];
+    const phoneOnly: { file: string; resourceName: string; phone: string }[] = [];
+    const emailOnlyFile = path.join(paths.userDir, 'emailonly.json');
+    const phoneOnlyFile = path.join(paths.userDir, 'phoneonly.json');
+
     for (const file of files) {
         const filePath = path.join(paths.contactsDir, file);
         const contact = JSON.parse(fs.readFileSync(filePath, 'utf-8')) as GooglePerson;
 
         const name = contact.names?.[0];
-        if (!name) continue;
+
+        // Handle contacts with no names or phone-as-name
+        if (!name || !name.givenName) {
+            const email = contact.emailAddresses?.[0]?.value || '(no email)';
+            emailOnly.push({ file, resourceName: contact.resourceName, email });
+            console.log(`  [EMAIL-ONLY] ${file}: ${email}`);
+            continue;
+        }
+
+        // Check if name is actually a phone number
+        if (looksLikePhone(name.givenName)) {
+            phoneOnly.push({ file, resourceName: contact.resourceName, phone: name.givenName });
+            console.log(`  [PHONE-ONLY] ${file}: "${name.givenName}"`);
+            continue;
+        }
 
         const changes: string[] = [];
         let modified = false;
@@ -997,17 +1023,50 @@ async function runNamesFix(user: string, mode: 'inspect' | 'apply'): Promise<voi
         console.log(`\nProblems file: ${problemsPath}`);
     }
 
+    // Handle email-only and phone-only contacts
+    if (mode === 'apply' && (emailOnly.length > 0 || phoneOnly.length > 0)) {
+        if (!fs.existsSync(paths.toDeleteDir)) {
+            fs.mkdirSync(paths.toDeleteDir, { recursive: true });
+        }
+
+        if (emailOnly.length > 0) {
+            for (const entry of emailOnly) {
+                const src = path.join(paths.contactsDir, entry.file);
+                const dst = path.join(paths.toDeleteDir, entry.file);
+                fs.renameSync(src, dst);
+            }
+            const existing = fs.existsSync(emailOnlyFile) ? JSON.parse(fs.readFileSync(emailOnlyFile, 'utf-8')) : [];
+            existing.push(...emailOnly.map(e => ({ file: e.file, resourceName: e.resourceName, email: e.email, movedAt: new Date().toISOString() })));
+            fs.writeFileSync(emailOnlyFile, JSON.stringify(existing, null, 2));
+        }
+
+        if (phoneOnly.length > 0) {
+            for (const entry of phoneOnly) {
+                const src = path.join(paths.contactsDir, entry.file);
+                const dst = path.join(paths.toDeleteDir, entry.file);
+                fs.renameSync(src, dst);
+            }
+            const existing = fs.existsSync(phoneOnlyFile) ? JSON.parse(fs.readFileSync(phoneOnlyFile, 'utf-8')) : [];
+            existing.push(...phoneOnly.map(e => ({ file: e.file, resourceName: e.resourceName, phone: e.phone, movedAt: new Date().toISOString() })));
+            fs.writeFileSync(phoneOnlyFile, JSON.stringify(existing, null, 2));
+        }
+    }
+
     console.log(`\n${'='.repeat(50)}`);
     console.log(`Summary:`);
     console.log(`  Contacts with changes: ${changeLogs.length}`);
+    console.log(`  Email-only (no name): ${emailOnly.length}`);
+    console.log(`  Phone-only (phone as name): ${phoneOnly.length}`);
     console.log(`  Ambiguous (see problems.txt): ${problems.length}`);
     if (mode === 'apply') {
         console.log(`  Contacts modified: ${contactsModified}`);
+        if (emailOnly.length > 0) console.log(`  Email-only moved to _delete/ (recovery: emailonly.json)`);
+        if (phoneOnly.length > 0) console.log(`  Phone-only moved to _delete/ (recovery: phoneonly.json)`);
     }
-    if (mode === 'inspect' && changeLogs.length > 0) {
+    if (mode === 'inspect' && (changeLogs.length > 0 || emailOnly.length > 0 || phoneOnly.length > 0)) {
         console.log(`\nTo apply fixes, run: gfix names -u ${user} --apply`);
     }
-    if (mode === 'apply' && contactsModified > 0) {
+    if (mode === 'apply' && (contactsModified > 0 || emailOnly.length > 0 || phoneOnly.length > 0)) {
         console.log(`\nAfter review, run: gcards push -u ${user}`);
     }
 }

package/glib/parsecli.ts

@@ -27,29 +27,50 @@ export function parseArgs(args: string[]): CliOptions {
         since: ''
     };
 
+    const unrecognized: string[] = [];
+
     for (let i = 0; i < args.length; i++) {
         const arg = args[i];
-        if (arg === '--full' || arg === '-f') {
-            options.full = true;
-        } else if (arg === '--yes' || arg === '-y') {
-            options.yes = true;
-        } else if (arg === '--help' || arg === '-h') {
-            options.help = true;
-        } else if (arg === '--verbose' || arg === '-v') {
-            options.verbose = true;
-        } else if (arg === '--all' || arg === '-all' || arg === '-a') {
-            options.all = true;
-        } else if ((arg === '--user' || arg === '-user' || arg === '-u') && i + 1 < args.length) {
-            options.user = args[++i];
-        } else if ((arg === '--limit' || arg === '-limit') && i + 1 < args.length) {
-            options.limit = parseInt(args[++i], 10) || 0;
-        } else if ((arg === '--since' || arg === '-since') && i + 1 < args.length) {
-            options.since = args[++i];
-        } else if (!arg.startsWith('-') && !options.command) {
-            options.command = arg;
+        switch (arg) {
+            case '--full': case '-full': case '-f':
+                options.full = true;
+                break;
+            case '--yes': case '-y':
+                options.yes = true;
+                break;
+            case '--help': case '-h':
+                options.help = true;
+                break;
+            case '--verbose': case '-v':
+                options.verbose = true;
+                break;
+            case '--all': case '-all': case '-a':
+                options.all = true;
+                break;
+            case '--user': case '-user': case '-u':
+                options.user = args[++i] || '';
+                break;
+            case '--limit': case '-limit':
+                options.limit = parseInt(args[++i], 10) || 0;
+                break;
+            case '--since': case '-since':
+                options.since = args[++i] || '';
+                break;
+            default:
+                if (!arg.startsWith('-') && !options.command) {
+                    options.command = arg;
+                } else {
+                    unrecognized.push(arg);
+                }
         }
     }
 
+    if (unrecognized.length > 0) {
+        console.error(`Unrecognized argument(s): ${unrecognized.join(', ')}`);
+        console.error(`Use --help for usage information.`);
+        process.exit(1);
+    }
+
     return options;
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bobfrankston/gcards",
-  "version": "0.1.13",
+  "version": "0.1.15",
   "description": "Google Contacts cleanup and management tool",
   "type": "module",
   "main": "gcards.ts",