@blumintinc/eslint-plugin-blumint 1.21.8 → 1.21.10

package/lib/index.js

@@ -224,7 +224,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.21.8',
+        version: '1.21.10',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/global-const-style.js

@@ -313,8 +313,10 @@ const isWriteTarget = (node) => {
  * Storing a reference does not copy it: the same array stays reachable through
  * the container, so `holder.items.push(3)` writes through to the binding
  * exactly as a direct alias does, and freezing it raises the same TS2339. A
- * `SpreadElement` is excluded because it genuinely builds a fresh value
- * (`const COPY = [...ITEMS]`), and a computed key is excluded because it coerces
+ * `SpreadElement` is excluded because it builds a fresh VALUE
+ * (`const COPY = [...ITEMS]`) — it is not excluded from the walk entirely,
+ * because the copy still carries the constant's frozen TYPE, which
+ * `copyExpressionOf` handles. A computed key is excluded because it coerces
  * the reference to a property name rather than retaining it.
  */
 const storageContainerOf = (node) => {
@@ -359,7 +361,8 @@ const aliasDeclaratorOf = (identifier) => {
         const declarator = value.parent;
         if (declarator?.type === utils_1.AST_NODE_TYPES.VariableDeclarator &&
             declarator.init === value &&
-            declarator.id.type === utils_1.AST_NODE_TYPES.Identifier) {
+            (declarator.id.type === utils_1.AST_NODE_TYPES.Identifier ||
+                declarator.id.type === utils_1.AST_NODE_TYPES.ObjectPattern)) {
             return declarator;
         }
         const container = storageContainerOf(value);
@@ -369,6 +372,113 @@ const aliasDeclaratorOf = (identifier) => {
         value = outermostValueOf(container);
     }
 };
+/**
+ * Whether a callee spells `Object.assign`, in either the dotted or the
+ * bracketed form — read through `accessedPropertyName` so the two spellings
+ * cannot diverge from how the mutation walk already reads a method name.
+ */
+const isNamespacedCallee = (callee, namespace, method) => {
+    const value = outermostValueOf(callee);
+    return (value.type === utils_1.AST_NODE_TYPES.MemberExpression &&
+        value.object.type === utils_1.AST_NODE_TYPES.Identifier &&
+        value.object.name === namespace &&
+        accessedPropertyName(value) === method);
+};
+const isObjectAssignCallee = (callee) => isNamespacedCallee(callee, 'Object', 'assign');
+/** Whether a callee is the bare global `structuredClone`. */
+const isStructuredCloneCallee = (callee) => {
+    const value = outermostValueOf(callee);
+    return (value.type === utils_1.AST_NODE_TYPES.Identifier && value.name === 'structuredClone');
+};
+/**
+ * Whether a call COPIES the argument at `index` while keeping its type.
+ *
+ * `Array.from(X)` and `structuredClone(X)` both hand back a fresh, mutable
+ * value whose element or property types are the argument's — so freezing the
+ * argument narrows the copy exactly as a spread does. `Array.from(X, fn)` is
+ * excluded for the same reason `map` is: a mapper retypes the result, so
+ * nothing of the constant's type survives into it.
+ */
+const isCopyingCall = (call, index) => {
+    if (isObjectAssignCallee(call.callee)) {
+        return true;
+    }
+    if (index !== 0) {
+        return false;
+    }
+    if (isStructuredCloneCallee(call.callee)) {
+        return true;
+    }
+    if (isNamespacedCallee(call.callee, 'Array', 'from')) {
+        return call.arguments.length === 1;
+    }
+    return false;
+};
+/**
+ * Array methods whose result keeps the receiver's ELEMENT type. `map` is
+ * absent because its result is typed from the CALLBACK, so the constant's type
+ * reaches it only for a callback that returns its argument unchanged — a no-op
+ * `map`. Admitting it would withhold the assertion from every derived array
+ * anything is computed from, to cover a spelling nobody writes.
+ */
+const TYPE_PRESERVING_COPY_METHODS = new Set([
+    'concat',
+    'slice',
+    'filter',
+    'flat',
+    // The ES2023 copying methods. Listed even though this repo's TypeScript
+    // predates them, because they are the same category and admitting them costs
+    // nothing: a name that does not resolve produces no reports to lose.
+    'toSorted',
+    'toReversed',
+    'toSpliced',
+    'with',
+]);
+/**
+ * The expression that builds a COPY carrying this value's type — the literal
+ * around a spread of it, the call of a copying array method on it, or an
+ * `Object.assign` it feeds.
+ *
+ * A copy is a fresh, mutable value, which is why `storageContainerOf` refuses
+ * it: writing to the copy cannot write through to the constant. But `as const`
+ * changes the constant's TYPE as well as its mutability, and a copy inherits
+ * that type — `[...ITEMS]` of a frozen `readonly [1, 2]` is `(1 | 2)[]`, so
+ * `COPY.push(3)` is TS2345 for an input that compiled. The copy is therefore
+ * followed for exactly the same question the alias walk asks: is the derived
+ * binding written?
+ */
+const copyExpressionOf = (node) => {
+    const parent = node.parent;
+    if (!parent) {
+        return null;
+    }
+    if (parent.type === utils_1.AST_NODE_TYPES.SpreadElement &&
+        parent.argument === node &&
+        (parent.parent?.type === utils_1.AST_NODE_TYPES.ObjectExpression ||
+            parent.parent?.type === utils_1.AST_NODE_TYPES.ArrayExpression)) {
+        return parent.parent;
+    }
+    if (parent.type === utils_1.AST_NODE_TYPES.CallExpression) {
+        const index = parent.arguments.indexOf(node);
+        if (index !== -1 && isCopyingCall(parent, index)) {
+            return parent;
+        }
+    }
+    if (parent.type === utils_1.AST_NODE_TYPES.MemberExpression &&
+        parent.object === node) {
+        const method = accessedPropertyName(parent);
+        const callee = outermostValueOf(parent);
+        // A method REFERENCE (`const take = ITEMS.concat;`) builds nothing, so the
+        // copy only exists once the method is actually called.
+        if (method !== null &&
+            TYPE_PRESERVING_COPY_METHODS.has(method) &&
+            callee.parent?.type === utils_1.AST_NODE_TYPES.CallExpression &&
+            callee.parent.callee === callee) {
+            return callee.parent;
+        }
+    }
+    return null;
+};
 /** Pattern nodes a parameter's binding can be nested inside. */
 const PATTERN_CONTAINERS = new Set([
     utils_1.AST_NODE_TYPES.AssignmentPattern,
@@ -376,6 +486,10 @@ const PATTERN_CONTAINERS = new Set([
     utils_1.AST_NODE_TYPES.ObjectPattern,
     utils_1.AST_NODE_TYPES.ArrayPattern,
     utils_1.AST_NODE_TYPES.RestElement,
+    // A parameter property is a parameter AND declares a class property, so it
+    // infers twice over. Without it the walk stops before reaching the
+    // constructor's params and `constructor(public stage = DEFAULT)` narrows.
+    utils_1.AST_NODE_TYPES.TSParameterProperty,
 ]);
 const FUNCTION_TYPES = new Set([
     utils_1.AST_NODE_TYPES.FunctionDeclaration,
@@ -414,16 +528,27 @@ const isInferredParameterDefault = (pattern) => {
     }
 };
 /**
- * Whether a reference sits where TypeScript INFERS a type from it — the value
- * of a default parameter, reached directly or through a composite literal it
- * is stored into.
+ * Whether a reference sits where TypeScript INFERS a type from it — a default
+ * parameter or a class property initializer — reached directly or through a
+ * composite literal it is stored into.
  *
  * `as const` does not only freeze: it makes the literal type NON-WIDENING, and
  * an inference site that widened `'ready'` to `string` then keeps the literal.
  * A parameter defaulted from the constant therefore narrows to that one value,
  * and every call passing a different one stops compiling (TS2345) for an input
  * that compiled. The mutation walk cannot see this: nothing is written, the
- * signature is simply inferred from a value the assertion changes.
+ * declaration is simply inferred from a value the assertion changes.
+ *
+ * Both sites are answered on the same terms, because an annotation is what
+ * settles the question in each: a type written by hand is DECLARED, so nothing
+ * infers from the value and freezing it cannot move the declaration. Only the
+ * unannotated spelling narrows.
+ *
+ * A RETURN position infers in exactly the same way and is deliberately absent.
+ * Declining there costs 59 of 778 consumer reports (7.6%) — the constant need
+ * only be held in a literal that is returned — to prevent breaks that the
+ * consumer does not contain, so it is documented as a limitation instead. The
+ * comparable trade in #2330 was rejected at 5%.
  */
 const isInferenceSite = (identifier) => {
     let value = outermostValueOf(identifier);
@@ -433,6 +558,14 @@ const isInferenceSite = (identifier) => {
             parent.right === value) {
             return isInferredParameterDefault(parent.left);
         }
+        // A class property's type is inferred from its initializer exactly as a
+        // parameter's is from its default, so `session.stage = 'live'` becomes
+        // TS2322 once the constant behind `stage = DEFAULT_STAGE` is frozen.
+        if ((parent?.type === utils_1.AST_NODE_TYPES.PropertyDefinition ||
+            parent?.type === utils_1.AST_NODE_TYPES.AccessorProperty) &&
+            parent.value === value) {
+            return !parent.typeAnnotation;
+        }
         const container = storageContainerOf(value);
         if (!container) {
             return false;
@@ -448,8 +581,13 @@ const isInferenceSite = (identifier) => {
  * value, so a WRITE — through the binding (`X.push(1)`), or to a binding that
  * aliases it (`other = X`) — becomes TS2339/TS2540. And it makes the literal
  * type NON-WIDENING, so an INFERENCE site that read the widened type keeps the
- * literal instead, which rewrites a signature the assertion was never asked to
- * touch.
+ * literal instead, which rewrites a declaration the assertion was never asked
+ * to touch.
+ *
+ * The type half reaches further than the value half, so the walk follows one
+ * edge the mutation question does not need: a COPY (`[...X]`, `X.concat()`),
+ * which is a fresh value but not a fresh type, and breaks on a write to the
+ * copy rather than to `X`.
  *
  * Answered from the scope manager's reference list rather than a textual
  * search for the name, so a same-named binding in
@@ -493,13 +631,20 @@ const blocksAsConstAssertion = (variable, declaredVariablesOf) => {
                 return true;
             }
             const path = accessPathOf(reference.identifier);
-            if (path !== null) {
-                if (isMutatingMethodCall(path) || isWriteTarget(path)) {
-                    return true;
-                }
-                continue;
+            if (path !== null &&
+                (isMutatingMethodCall(path) || isWriteTarget(path))) {
+                return true;
             }
-            const declarator = aliasDeclaratorOf(reference.identifier);
+            // A copy carries the constant's frozen type into a second binding, so it
+            // is enrolled on the same terms as an alias — but it is reached through a
+            // member access (`ITEMS.concat()`), which the alias walk deliberately
+            // refuses, so it is resolved before that refusal applies.
+            const copy = copyExpressionOf(outermostValueOf(reference.identifier));
+            const declarator = copy
+                ? aliasDeclaratorOf(copy)
+                : path === null
+                    ? aliasDeclaratorOf(reference.identifier)
+                    : null;
             if (!declarator) {
                 continue;
             }

package/lib/rules/memo-nested-react-components.js

@@ -347,6 +347,90 @@ const isInsideFunction = (node) => {
     return findEnclosingFunction(node) !== null;
 };
 const isPascalCaseName = (name) => /^[A-Z]/.test(name);
+/**
+ * Prop names whose value a parent MOUNTS rather than calls. Kept identical to
+ * the `JSXAttribute` visitor's own test so the two paths cannot disagree about
+ * what a component-type prop is — the disagreement between them is #2334.
+ */
+const COMPONENT_PROP_SUFFIX = /(Wrapper|Component|Template|Header|Footer)$/;
+const isComponentPropName = (name) => isPascalCaseName(name) && COMPONENT_PROP_SUFFIX.test(name);
+const consumptionOfReference = (identifier, reactImports) => {
+    // `<Binding />`. The scope manager reports the tag name as a reference whose
+    // identifier is a `JSXIdentifier`, which no other position produces.
+    if (identifier.type === utils_1.AST_NODE_TYPES.JSXIdentifier) {
+        return 'component';
+    }
+    let current = identifier;
+    for (;;) {
+        const parent = parentBeyondChain(current);
+        if (!parent) {
+            return 'unknown';
+        }
+        // `Binding as Something` / `Binding!` keep the value on its way to a use.
+        if ((parent.type === utils_1.AST_NODE_TYPES.TSAsExpression ||
+            parent.type === utils_1.AST_NODE_TYPES.TSNonNullExpression ||
+            parent.type === utils_1.AST_NODE_TYPES.TSSatisfiesExpression) &&
+            parent.expression === current) {
+            current = parent;
+            continue;
+        }
+        if (parent.type === utils_1.AST_NODE_TYPES.CallExpression) {
+            // `createElement(Binding, ...)` mounts it exactly as a tag name does.
+            if (parent.arguments[0] === current &&
+                isReactCreateElementCall(parent, reactImports)) {
+                return 'component';
+            }
+            // `Binding(onClose)` — the parent INVOKES it, which is what a render
+            // callback is for. A component is never called directly.
+            if (parent.callee === current) {
+                return 'callback';
+            }
+            return 'unknown';
+        }
+        // `<Host ContentComponent={Binding} />` mounts it; `<Host render={Binding} />`
+        // calls it. The prop name is the parent's contract, and it is read on the
+        // same terms the `JSXAttribute` visitor uses so the two cannot disagree.
+        if (parent.type === utils_1.AST_NODE_TYPES.JSXExpressionContainer &&
+            parent.parent?.type === utils_1.AST_NODE_TYPES.JSXAttribute &&
+            parent.parent.name.type === utils_1.AST_NODE_TYPES.JSXIdentifier) {
+            return isComponentPropName(parent.parent.name.name)
+                ? 'component'
+                : 'callback';
+        }
+        return 'unknown';
+    }
+};
+/**
+ * Whether the binding a memo-hook call initializes is MOUNTED, CALLED, or
+ * neither, read from the scope manager's reference list rather than a textual
+ * search so a same-named binding in a sibling scope cannot answer for this one.
+ *
+ * `unknown` is the honest answer for a binding with no informative reference —
+ * an exported component has none in its own file, and so does a fixture
+ * fragment. Falling back to the name there keeps the rule's reach while letting
+ * evidence override the guess wherever evidence exists.
+ */
+const consumptionOfBinding = (node, context, reactImports) => {
+    const declarator = parentBeyondChain(node);
+    if (declarator?.type !== utils_1.AST_NODE_TYPES.VariableDeclarator) {
+        return 'unknown';
+    }
+    let sawCallback = false;
+    for (const variable of context.getDeclaredVariables(declarator)) {
+        for (const reference of variable.references) {
+            const consumption = consumptionOfReference(reference.identifier, reactImports);
+            // A single mounting use settles it: the identity churn happens there
+            // regardless of how many other places merely call it.
+            if (consumption === 'component') {
+                return 'component';
+            }
+            if (consumption === 'callback') {
+                sawCallback = true;
+            }
+        }
+    }
+    return sawCallback ? 'callback' : 'unknown';
+};
 /**
  * The values a container hands to its caller: object property values and array
  * elements. Mirrors `containedValues` in the paired `require-memo` rule (#1919),
@@ -725,10 +809,20 @@ See: https://react.dev/learn/your-first-component#nesting-and-organizing-compone
                     }
                 }
                 const variableName = getVariableName(node);
-                // A non-PascalCase binding (e.g. renderHit) is a render callback used
-                // with a render={...} prop, not a component—skip it.
-                if (variableName && !isPascalCaseName(variableName)) {
-                    return;
+                // The NAME was the whole discriminator here, which reported every
+                // PascalCase render callback the message explicitly exempts and missed
+                // every lowercase binding handed to a component-type prop. Evidence
+                // from the use site overrides it in both directions; the name still
+                // decides where there is no evidence, which is where an exported
+                // component lives (#2334).
+                if (variableName) {
+                    const consumption = consumptionOfBinding(node, context, reactImports);
+                    if (consumption === 'callback') {
+                        return;
+                    }
+                    if (consumption === 'unknown' && !isPascalCaseName(variableName)) {
+                        return;
+                    }
                 }
                 // Inside an HOC factory the binding has a stable identity, so it does
                 // not remount on re-render and must not be flagged.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.21.8",
+  "version": "1.21.10",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,40 @@
 [
+  {
+    "version": "1.21.10",
+    "date": "2026-09-05T09:28:38.523Z",
+    "rules": [
+      {
+        "name": "global-const-style",
+        "changeType": "fix",
+        "issues": [
+          2333
+        ],
+        "summary": "follow every copy that carries the frozen type, and the parameter property that infers from it (closes #2333)"
+      },
+      {
+        "name": "memo-nested-react-components",
+        "changeType": "fix",
+        "issues": [
+          2334
+        ],
+        "summary": "decide by the use site, not the binding's first letter (closes #2334)"
+      }
+    ]
+  },
+  {
+    "version": "1.21.9",
+    "date": "2026-09-05T05:55:33.427Z",
+    "rules": [
+      {
+        "name": "global-const-style",
+        "changeType": "fix",
+        "issues": [
+          2331
+        ],
+        "summary": "withhold the assertion where a copy or a class property carries the frozen type (closes #2331)"
+      }
+    ]
+  },
   {
     "version": "1.21.8",
     "date": "2026-09-05T03:15:57.605Z",