@blumintinc/eslint-plugin-blumint 1.21.10 → 1.21.11

package/lib/index.js

@@ -224,7 +224,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.21.10',
+        version: '1.21.11',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/global-const-style.js

@@ -350,9 +350,14 @@ const storageContainerOf = (node) => {
  * the file compiling is not.
  *
  * A reference STORED INTO a composite literal is followed through that
- * container, since storing does not copy — see `storageContainerOf`. A
- * destructuring id extracts a member rather than the whole, so it is not an
- * alias here.
+ * container, since storing does not copy — see `storageContainerOf`.
+ *
+ * A destructuring id is accepted in BOTH spellings. It does not name the whole
+ * value, but every binding it introduces is typed from that value, and a rest
+ * element is itself a fresh container the assertion narrows: `const [, ...rest]
+ * = ITEMS` gives `rest` the frozen element type, so `rest.push(4)` is TS2345
+ * for an input that compiled. Admitting only the object spelling gave the same
+ * construct opposite verdicts (#2336).
  */
 const aliasDeclaratorOf = (identifier) => {
     // Ascends strictly, so reaching a node with no parent terminates the walk.
@@ -362,7 +367,8 @@ const aliasDeclaratorOf = (identifier) => {
         if (declarator?.type === utils_1.AST_NODE_TYPES.VariableDeclarator &&
             declarator.init === value &&
             (declarator.id.type === utils_1.AST_NODE_TYPES.Identifier ||
-                declarator.id.type === utils_1.AST_NODE_TYPES.ObjectPattern)) {
+                declarator.id.type === utils_1.AST_NODE_TYPES.ObjectPattern ||
+                declarator.id.type === utils_1.AST_NODE_TYPES.ArrayPattern)) {
             return declarator;
         }
         const container = storageContainerOf(value);

package/lib/rules/memo-nested-react-components.js

@@ -410,13 +410,16 @@ const consumptionOfReference = (identifier, reactImports) => {
  * fragment. Falling back to the name there keeps the rule's reach while letting
  * evidence override the guess wherever evidence exists.
  */
-const consumptionOfBinding = (node, context, reactImports) => {
-    const declarator = parentBeyondChain(node);
-    if (declarator?.type !== utils_1.AST_NODE_TYPES.VariableDeclarator) {
-        return 'unknown';
-    }
+const consumptionOfDeclaration = (declaration, id, context, reactImports) => {
+    // `getDeclaredVariables` on a FunctionDeclaration yields its PARAMETERS
+    // alongside the function name, and a parameter handed to a non-component prop
+    // votes `callback` for a binding it says nothing about. Keep only the
+    // variable this declaration's own id introduces.
+    const declared = context
+        .getDeclaredVariables(declaration)
+        .filter((variable) => variable.defs.some((def) => def.name === id));
     let sawCallback = false;
-    for (const variable of context.getDeclaredVariables(declarator)) {
+    for (const variable of declared) {
         for (const reference of variable.references) {
             const consumption = consumptionOfReference(reference.identifier, reactImports);
             // A single mounting use settles it: the identity churn happens there
@@ -431,6 +434,14 @@ const consumptionOfBinding = (node, context, reactImports) => {
     }
     return sawCallback ? 'callback' : 'unknown';
 };
+const consumptionOfBinding = (node, context, reactImports) => {
+    const declarator = parentBeyondChain(node);
+    if (declarator?.type !== utils_1.AST_NODE_TYPES.VariableDeclarator ||
+        declarator.id.type !== utils_1.AST_NODE_TYPES.Identifier) {
+        return 'unknown';
+    }
+    return consumptionOfDeclaration(declarator, declarator.id, context, reactImports);
+};
 /**
  * The values a container hands to its caller: object property values and array
  * elements. Mirrors `containedValues` in the paired `require-memo` rule (#1919),
@@ -841,8 +852,10 @@ See: https://react.dev/learn/your-first-component#nesting-and-organizing-compone
                     return;
                 if (node.id.type !== utils_1.AST_NODE_TYPES.Identifier)
                     return;
-                // Only check if name starts with uppercase (convention for components)
-                if (!isPascalCaseName(node.id.name))
+                const vdConsumption = consumptionOfDeclaration(node, node.id, context, reactImports);
+                if (vdConsumption === 'callback')
+                    return;
+                if (vdConsumption === 'unknown' && !isPascalCaseName(node.id.name))
                     return;
                 if (!isInsideFunction(node))
                     return;
@@ -866,7 +879,12 @@ See: https://react.dev/learn/your-first-component#nesting-and-organizing-compone
                 reportNestedComponentViolation(node, node.id.name, 'a render body');
             },
             FunctionDeclaration(node) {
-                if (!node.id || !isPascalCaseName(node.id.name))
+                if (!node.id)
+                    return;
+                const fdConsumption = consumptionOfDeclaration(node, node.id, context, reactImports);
+                if (fdConsumption === 'callback')
+                    return;
+                if (fdConsumption === 'unknown' && !isPascalCaseName(node.id.name))
                     return;
                 if (!isInsideFunction(node))
                     return;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.21.10",
+  "version": "1.21.11",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,26 @@
 [
+  {
+    "version": "1.21.11",
+    "date": "2026-09-05T11:06:01.167Z",
+    "rules": [
+      {
+        "name": "global-const-style",
+        "changeType": "fix",
+        "issues": [
+          2336
+        ],
+        "summary": "follow the array spelling of a destructured copy, and the rest element that needs no copy (closes #2336)"
+      },
+      {
+        "name": "memo-nested-react-components",
+        "changeType": "fix",
+        "issues": [
+          2335
+        ],
+        "summary": "decide by the use site in the two non-hook visitors too (closes #2335)"
+      }
+    ]
+  },
   {
     "version": "1.21.10",
     "date": "2026-09-05T09:28:38.523Z",