@blumintinc/eslint-plugin-blumint 1.20.90 → 1.20.91

package/lib/index.js

@@ -223,7 +223,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.20.90',
+        version: '1.20.91',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/prefer-use-deep-compare-memo.js

@@ -5,6 +5,7 @@ const utils_1 = require("@typescript-eslint/utils");
 const createRule_1 = require("../utils/createRule");
 const ASTHelpers_1 = require("../utils/ASTHelpers");
 const importInsertion_1 = require("../utils/importInsertion");
+const importRemoval_1 = require("../utils/importRemoval");
 const DEEP_COMPARE_MODULE = '@blumintinc/use-deep-compare';
 const DEEP_COMPARE_HOOK = 'useDeepCompareMemo';
 // Consider these as memoizing hooks producing stable references
@@ -218,49 +219,6 @@ function ensureDeepCompareImportFixes(context, fixer) {
         (0, importInsertion_1.insertAtImportAnchor)(sourceCode, fixer, (0, importInsertion_1.importAnchorLineStart)(sourceCode, anchor), importText),
     ];
 }
-function findVariableInScope(scope, name) {
-    if (!scope)
-        return null;
-    const found = scope.variables?.find((v) => v.name === name);
-    if (found)
-        return found;
-    if (Array.isArray(scope.childScopes)) {
-        for (const child of scope.childScopes) {
-            const v = findVariableInScope(child, name);
-            if (v)
-                return v;
-        }
-    }
-    return null;
-}
-function isIdentifierReferenced(sourceCode, name) {
-    const scope = sourceCode.scopeManager?.globalScope;
-    if (!scope)
-        return true;
-    const variable = findVariableInScope(scope, name);
-    if (!variable)
-        return false;
-    return variable.references.some((ref) => ref.identifier && ref.identifier.name === name);
-}
-function removeImportSpecifierFixes(sourceCode, fixer, importDecl, specifier) {
-    const fixes = [];
-    if (importDecl.specifiers.length === 1) {
-        fixes.push(fixer.remove(importDecl));
-        return fixes;
-    }
-    const tokenAfter = sourceCode.getTokenAfter(specifier);
-    const tokenBefore = sourceCode.getTokenBefore(specifier);
-    if (tokenAfter && tokenAfter.value === ',') {
-        fixes.push(fixer.removeRange([specifier.range[0], tokenAfter.range[1]]));
-    }
-    else if (tokenBefore && tokenBefore.value === ',') {
-        fixes.push(fixer.removeRange([tokenBefore.range[0], specifier.range[1]]));
-    }
-    else {
-        fixes.push(fixer.remove(specifier));
-    }
-    return fixes;
-}
 function isImportedIdentifier(context, name) {
     const sourceCode = context.sourceCode;
     const program = sourceCode.ast;
@@ -436,6 +394,28 @@ exports.preferUseDeepCompareMemo = (0, createRule_1.createRule)({
                             !bindsHookImport(existing, findDeepCompareMemoImport(context.sourceCode.ast))) {
                             return null;
                         }
+                        // The callee is the text this fix deletes, so it is also the text
+                        // whatever carried the hook stops being read from: `useMemo` for a
+                        // bare call, `React` for a member call. A binding left with no
+                        // reference at all is unbound here, in this same fix — stripping
+                        // its last use and keeping the declaration trades this rule's
+                        // report for an unused-import one, and nothing re-reports that debt
+                        // once the rewrite has resolved the original violation.
+                        //
+                        // Orphanhood is judged against this one callee's removal and the
+                        // file as it stands. A second `useMemo` call site keeps the
+                        // specifier, even one this rule also reports: that sibling may be
+                        // `eslint-disable`d (suppression is applied after a rule emits its
+                        // reports, so its fix never runs) or lose its fix to a conflict, and
+                        // either way the surviving call would spell a name nothing binds. A
+                        // later pass, reading a source where the sibling is already
+                        // converted, finds the specifier orphaned and removes it then.
+                        const importRemoval = (0, importRemoval_1.planOrphanedImportRemoval)(context.sourceCode, [node.callee.range]);
+                        // No plan means a binding is orphaned yet cannot be unbound safely,
+                        // so the rewrite stays too: the report without a fixer is the lesser
+                        // damage.
+                        if (!importRemoval)
+                            return null;
                         const fixes = [];
                         // Replace callee
                         if (node.callee.type === utils_1.AST_NODE_TYPES.Identifier) {
@@ -446,26 +426,7 @@ exports.preferUseDeepCompareMemo = (0, createRule_1.createRule)({
                         }
                         // Ensure import exists
                         fixes.push(...ensureDeepCompareImportFixes(context, fixer));
-                        // Clean up now-unused React/useMemo imports if safe
-                        const sourceCode = context.sourceCode;
-                        const program = sourceCode.ast;
-                        const reactImport = program.body.find((n) => n.type === utils_1.AST_NODE_TYPES.ImportDeclaration &&
-                            n.source.value === 'react');
-                        if (reactImport) {
-                            // remove named useMemo if unused
-                            const useMemoSpec = reactImport.specifiers.find((s) => s.type === utils_1.AST_NODE_TYPES.ImportSpecifier &&
-                                s.imported.type === utils_1.AST_NODE_TYPES.Identifier &&
-                                s.imported.name === 'useMemo');
-                            if (useMemoSpec &&
-                                !isIdentifierReferenced(sourceCode, useMemoSpec.local.name)) {
-                                fixes.push(...removeImportSpecifierFixes(sourceCode, fixer, reactImport, useMemoSpec));
-                            }
-                            const defaultSpec = reactImport.specifiers.find((s) => s.type === utils_1.AST_NODE_TYPES.ImportDefaultSpecifier);
-                            if (defaultSpec &&
-                                !isIdentifierReferenced(sourceCode, defaultSpec.local.name)) {
-                                fixes.push(...removeImportSpecifierFixes(sourceCode, fixer, reactImport, defaultSpec));
-                            }
-                        }
+                        fixes.push(...importRemoval.map((range) => fixer.removeRange([range[0], range[1]])));
                         return fixes;
                     },
                 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.20.90",
+  "version": "1.20.91",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,18 @@
 [
+  {
+    "version": "1.20.91",
+    "date": "2026-08-03T15:15:42.831Z",
+    "rules": [
+      {
+        "name": "prefer-use-deep-compare-memo",
+        "changeType": "fix",
+        "issues": [
+          1661
+        ],
+        "summary": "unbind the orphaned useMemo import (closes #1661)"
+      }
+    ]
+  },
   {
     "version": "1.20.90",
     "date": "2026-08-03T13:37:18.271Z",