@blumintinc/eslint-plugin-blumint 1.20.65 → 1.20.66

package/lib/index.js

@@ -223,7 +223,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.20.65',
+        version: '1.20.66',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/enforce-firestore-doc-ref-generic.js

@@ -655,10 +655,50 @@ exports.enforceFirestoreDocRefGeneric = (0, createRule_1.createRule)({
                     return tracesToRulesUnitTesting(node.expression, visited);
                 case utils_1.AST_NODE_TYPES.Identifier:
                     return identifierTracesToRulesUnitTesting(node, visited);
+                case utils_1.AST_NODE_TYPES.ArrowFunctionExpression:
+                case utils_1.AST_NODE_TYPES.FunctionExpression:
+                case utils_1.AST_NODE_TYPES.FunctionDeclaration:
+                    return functionReturnTracesToRulesUnitTesting(node, visited);
                 default:
                     return false;
             }
         }
+        /**
+         * Reached when a receiver is the result of calling a local helper, so what
+         * the helper hands back decides the surface. Only top-level returns are
+         * read; a return nested inside another function belongs to that one.
+         */
+        function functionReturnTracesToRulesUnitTesting(node, visited) {
+            if (node.body.type !== utils_1.AST_NODE_TYPES.BlockStatement) {
+                return tracesToRulesUnitTesting(node.body, visited);
+            }
+            return node.body.body.some((statement) => statement.type === utils_1.AST_NODE_TYPES.ReturnStatement &&
+                tracesToRulesUnitTesting(statement.argument, visited));
+        }
+        /**
+         * `withSecurityRulesDisabled` is the one API here that delivers a context
+         * through a callback rather than a return value, and the documented spelling
+         * leaves the parameter unannotated, so the call it belongs to is the only
+         * evidence of the surface.
+         */
+        const CONTEXT_CALLBACK_METHOD = 'withSecurityRulesDisabled';
+        function parameterTracesToRulesUnitTesting(name, owner, visited) {
+            if (name.type === utils_1.AST_NODE_TYPES.Identifier &&
+                name.typeAnnotation &&
+                isRulesUnitTestingType(name.typeAnnotation.typeAnnotation)) {
+                return true;
+            }
+            const call = owner.parent;
+            if (!call ||
+                call.type !== utils_1.AST_NODE_TYPES.CallExpression ||
+                !call.arguments.includes(owner) ||
+                call.callee.type !== utils_1.AST_NODE_TYPES.MemberExpression ||
+                call.callee.property.type !== utils_1.AST_NODE_TYPES.Identifier ||
+                call.callee.property.name !== CONTEXT_CALLBACK_METHOD) {
+                return false;
+            }
+            return tracesToRulesUnitTesting(call.callee.object, visited);
+        }
         function identifierTracesToRulesUnitTesting(node, visited) {
             const scope = ASTHelpers_1.ASTHelpers.getScope(context, node);
             const variable = ASTHelpers_1.ASTHelpers.findVariableInScope(scope, node.name);
@@ -670,24 +710,36 @@ exports.enforceFirestoreDocRefGeneric = (0, createRule_1.createRule)({
                 return (def.parent?.type === utils_1.AST_NODE_TYPES.ImportDeclaration &&
                     def.parent.source.value === RULES_UNIT_TESTING_MODULE);
             }
-            // Covers the `withSecurityRulesDisabled(async (ctx: RulesTestContext) =>
-            // ...)` callback, where the compat handle never appears as an initializer.
             if (def.type === 'Parameter') {
-                const annotation = def.name.typeAnnotation;
-                return (!!annotation && isRulesUnitTestingType(annotation.typeAnnotation));
+                return parameterTracesToRulesUnitTesting(def.name, def.node, visited);
+            }
+            // A hoisted declaration binds the helper the same way a `const` arrow
+            // does; an ambient `declare function` has no body and falls through.
+            if (def.type === 'FunctionName') {
+                return tracesToRulesUnitTesting(def.node, visited);
             }
             if (def.type !== 'Variable' ||
-                def.node.type !== utils_1.AST_NODE_TYPES.VariableDeclarator ||
-                def.parent?.type !== utils_1.AST_NODE_TYPES.VariableDeclaration ||
-                def.parent.kind !== 'const') {
+                def.node.type !== utils_1.AST_NODE_TYPES.VariableDeclarator) {
                 return false;
             }
             const declarator = def.node;
+            // An annotation constrains every assignment rather than just the
+            // initializer, so unlike an initializer it survives a `let`. The
+            // environment handle is created in `beforeAll` and so cannot be `const`;
+            // `let testEnv: RulesTestEnvironment` is the documented spelling, and
+            // TypeScript refuses to put another surface in it.
             if (declarator.id.type === utils_1.AST_NODE_TYPES.Identifier &&
                 declarator.id.typeAnnotation &&
                 isRulesUnitTestingType(declarator.id.typeAnnotation.typeAnnotation)) {
                 return true;
             }
+            // Without that guarantee only a `const` initializer is followed, mirroring
+            // `isTypedCollectionBinding`: an unannotated reassignable binding can hold
+            // an Admin SDK handle by the time it reaches `.doc()`.
+            if (def.parent?.type !== utils_1.AST_NODE_TYPES.VariableDeclaration ||
+                def.parent.kind !== 'const') {
+                return false;
+            }
             return tracesToRulesUnitTesting(declarator.init, visited);
         }
         return {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.20.65",
+  "version": "1.20.66",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,18 @@
 [
+  {
+    "version": "1.20.66",
+    "date": "2026-08-01T13:53:31.680Z",
+    "rules": [
+      {
+        "name": "enforce-firestore-doc-ref-generic",
+        "changeType": "fix",
+        "issues": [
+          1564
+        ],
+        "summary": "trace compat receivers through annotated lets and seeding callbacks (closes #1564)"
+      }
+    ]
+  },
   {
     "version": "1.20.65",
     "date": "2026-08-01T13:35:40.762Z",