@blumintinc/eslint-plugin-blumint 1.20.44 → 1.20.46

package/lib/index.js

@@ -223,7 +223,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.20.44',
+        version: '1.20.46',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/enforce-mui-rounded-icons.js

@@ -3,6 +3,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.enforceMuiRoundedIcons = void 0;
 const createRule_1 = require("../utils/createRule");
 const utils_1 = require("@typescript-eslint/utils");
+const MUI_ICONS_BARREL = '@mui/icons-material';
+const MUI_ICONS_DEEP_PREFIX = `${MUI_ICONS_BARREL}/`;
 /**
  * Non-Rounded MUI variant suffixes. An icon imported as one of these variants
  * (e.g. `AddReactionOutlined`) maps to the Rounded variant of its BASE name
@@ -31,11 +33,39 @@ const ICONS_WITHOUT_ROUNDED = new Set([
     'X',
     'YouTube',
 ]);
+/**
+ * Names the @mui/icons-material barrel exports that are not icons, so a
+ * `*Rounded` sibling never exists for them. `SvgIconComponent` is the icon
+ * component *type*, reached through the same barrel as the icons themselves.
+ */
+const NON_ICON_EXPORTS = new Set(['SvgIconComponent']);
 /** Strips a trailing non-Rounded variant suffix to recover the base icon name. */
 const toBaseIconName = (iconName) => {
     const suffix = VARIANT_SUFFIXES.find((variant) => iconName.endsWith(variant));
     return suffix ? iconName.slice(0, -suffix.length) : iconName;
 };
+/**
+ * Single source of truth for both import forms: maps the name an icon is
+ * imported under to the Rounded name that should replace it, or null when the
+ * name needs no change — it is already Rounded, it is not an icon, or MUI ships
+ * that icon without a Rounded variant.
+ */
+const toRoundedIconName = (iconName) => {
+    if (!iconName ||
+        iconName.endsWith('Rounded') ||
+        NON_ICON_EXPORTS.has(iconName)) {
+        return null;
+    }
+    // Map a non-Rounded variant to its base icon so the suggestion/fix targets a
+    // name that actually exists.
+    const baseIconName = toBaseIconName(iconName);
+    // Brand icons have no Rounded variant — demanding one is a false positive and
+    // the fix would point at a name that does not exist.
+    if (ICONS_WITHOUT_ROUNDED.has(baseIconName)) {
+        return null;
+    }
+    return `${baseIconName}Rounded`;
+};
 exports.enforceMuiRoundedIcons = (0, createRule_1.createRule)({
     name: 'enforce-mui-rounded-icons',
     meta: {
@@ -52,41 +82,68 @@ exports.enforceMuiRoundedIcons = (0, createRule_1.createRule)({
     },
     defaultOptions: [],
     create(context) {
+        /** `import LogoutIcon from '@mui/icons-material/Logout'` — the icon is named by the module path. */
+        const checkDeepImport = (node, iconPath) => {
+            const iconName = iconPath.split('/').pop();
+            const roundedVariant = iconName ? toRoundedIconName(iconName) : null;
+            if (!roundedVariant) {
+                return;
+            }
+            context.report({
+                node,
+                messageId: 'enforceRoundedVariant',
+                // The local binding is untouched: only the module the icon comes from
+                // changes.
+                fix: (fixer) => fixer.replaceText(node.source, `'${MUI_ICONS_DEEP_PREFIX}${roundedVariant}'`),
+            });
+        };
+        /** `import { Logout } from '@mui/icons-material'` — the icon is named by each specifier. */
+        const checkBarrelImport = (node) => {
+            // A type-only import names a type, and the barrel's type exports are not
+            // icons; nothing it introduces can be rendered.
+            if (node.importKind === 'type') {
+                return;
+            }
+            for (const specifier of node.specifiers) {
+                // Default and namespace imports name no individual icon.
+                if (specifier.type !== utils_1.AST_NODE_TYPES.ImportSpecifier ||
+                    specifier.importKind === 'type') {
+                    continue;
+                }
+                const importedName = specifier.imported.name;
+                const roundedVariant = toRoundedIconName(importedName);
+                if (!roundedVariant) {
+                    continue;
+                }
+                // An alias keeps the local binding independent of the imported name, so
+                // swapping the imported name is a self-contained edit. Without one, a
+                // fix would rename the binding and would have to rewrite every
+                // reference to it (shorthand properties, export specifiers, JSX) — so
+                // that form is reported without a fix rather than risking a corrupting
+                // edit.
+                const isAliased = specifier.local.name !== importedName;
+                context.report({
+                    node: specifier,
+                    messageId: 'enforceRoundedVariant',
+                    fix: isAliased
+                        ? (fixer) => fixer.replaceText(specifier.imported, roundedVariant)
+                        : null,
+                });
+            }
+        };
         return {
             ImportDeclaration(node) {
-                // Only check imports from @mui/icons-material
-                if (node.source.type === utils_1.AST_NODE_TYPES.Literal &&
-                    typeof node.source.value === 'string' &&
-                    node.source.value.startsWith('@mui/icons-material/')) {
-                    const iconPath = node.source.value;
-                    // Skip if already using -Rounded variant
-                    if (iconPath.endsWith('Rounded')) {
-                        return;
-                    }
-                    // Extract the icon name from the path
-                    const iconName = iconPath.split('/').pop();
-                    // Skip if the icon name is not a string (shouldn't happen)
-                    if (!iconName) {
-                        return;
-                    }
-                    // Map a non-Rounded variant import to its base icon so the Rounded
-                    // suggestion/fix targets a name that actually exists.
-                    const baseIconName = toBaseIconName(iconName);
-                    // Brand icons have no Rounded variant — demanding one is a false
-                    // positive and the fix would point at a non-existent module.
-                    if (ICONS_WITHOUT_ROUNDED.has(baseIconName)) {
-                        return;
-                    }
-                    // Create the rounded variant name
-                    const roundedVariant = `${baseIconName}Rounded`;
-                    context.report({
-                        node,
-                        messageId: 'enforceRoundedVariant',
-                        fix: (fixer) => {
-                            // Replace the import path with the rounded variant
-                            return fixer.replaceText(node.source, `'@mui/icons-material/${roundedVariant}'`);
-                        },
-                    });
+                if (node.source.type !== utils_1.AST_NODE_TYPES.Literal ||
+                    typeof node.source.value !== 'string') {
+                    return;
+                }
+                const source = node.source.value;
+                if (source.startsWith(MUI_ICONS_DEEP_PREFIX)) {
+                    checkDeepImport(node, source);
+                    return;
+                }
+                if (source === MUI_ICONS_BARREL) {
+                    checkBarrelImport(node);
                 }
             },
         };

package/lib/rules/enforce-object-literal-as-const.js

@@ -115,14 +115,23 @@ exports.enforceObjectLiteralAsConst = (0, createRule_1.createRule)({
                     node,
                     messageId: 'enforceAsConst',
                     fix(fixer) {
-                        const text = sourceCode.getText(argument);
-                        // If it's already a type assertion but not 'as const'
+                        // A literal already carrying an explicit assertion states a contract
+                        // the fix cannot preserve: `as const` produces a readonly,
+                        // literal-typed shape that is structurally different from the
+                        // asserted type, so rewriting `as SomeType` into `as const` silently
+                        // changes what the function returns and can break the signature the
+                        // assertion was written to satisfy. The diagnostic still holds — the
+                        // author may well want `as const` — but choosing between the two
+                        // types needs a human, so decline to fix (#1503).
+                        //
+                        // Any `TSAsExpression` reaching here is a non-`const` assertion; the
+                        // `as const` case returns before the report. The angle-bracket form
+                        // (`<SomeType>{...}`, a `TSTypeAssertion`) needs no branch here
+                        // because it is never detected above — tsc rejects testing for it.
                         if (argument.type === 'TSAsExpression') {
-                            // Get the expression part (before the 'as')
-                            const expressionText = sourceCode.getText(argument.expression);
-                            return fixer.replaceText(argument, `${expressionText} as const`);
+                            return null;
                         }
-                        return fixer.replaceText(argument, `${text} as const`);
+                        return fixer.replaceText(argument, `${sourceCode.getText(argument)} as const`);
                     },
                 });
             },

package/lib/rules/enforce-snapshot-state-narrowing.js

@@ -61,7 +61,7 @@ exports.enforceSnapshotStateNarrowing = (0, createRule_1.createRule)({
                     guardFunctions: {
                         type: 'array',
                         items: { type: 'string' },
-                        description: 'Canonical type guard function names',
+                        description: 'Type guard function names; the first is the one suggestions call and import',
                     },
                     excludeFiles: {
                         type: 'array',
@@ -70,23 +70,32 @@ exports.enforceSnapshotStateNarrowing = (0, createRule_1.createRule)({
                     },
                     guardImportSource: {
                         type: 'string',
-                        description: 'Module specifier the suggestion imports isSnapshotReady from',
+                        description: 'Module specifier the suggestion imports the guard from',
                     },
                 },
                 additionalProperties: false,
             },
         ],
         messages: {
-            noFalsyCheck: "Do not use boolean coercion on FirestoreSnapshotState<T>. All string states ('idle', 'loading', 'not-found') are truthy, so '{{expression}}' does not behave as intended. Use isSnapshotReady(state) to narrow to T, or compare explicitly (e.g., state === 'loading').",
-            noRawTypeof: "Do not use '{{expression}}' to narrow FirestoreSnapshotState<T> to data. Use isSnapshotReady(state) instead to maintain the abstraction boundary.",
+            // `guard` is the configured canonical guard name, so a consumer who
+            // renames it is not told to call a function their config says does not
+            // exist. Every report and suggestion supplies it.
+            noFalsyCheck: "Do not use boolean coercion on FirestoreSnapshotState<T>. All string states ('idle', 'loading', 'not-found') are truthy, so '{{expression}}' does not behave as intended. Use {{guard}}(state) to narrow to T, or compare explicitly (e.g., state === 'loading').",
+            noRawTypeof: "Do not use '{{expression}}' to narrow FirestoreSnapshotState<T> to data. Use {{guard}}(state) instead to maintain the abstraction boundary.",
         },
     },
     defaultOptions: [{}],
     create(context, [options]) {
         const snapshotHooks = new Set(options?.snapshotHooks ?? DEFAULT_SNAPSHOT_HOOKS);
-        // guardFunctions is accepted in config for documentation and future extensibility
-        // but detection is purely syntactic (by hook source), not by guard function name.
-        void (options?.guardFunctions ?? DEFAULT_GUARD_FUNCTIONS);
+        /**
+         * The name every suggestion calls, resolves in scope, and imports.
+         * `guardFunctions` may list several recognized guards; the first usable one
+         * is canonical. A list that names nothing callable — empty, or holding only
+         * blanks — falls back to the default rather than leaving the suggestion to
+         * emit `undefined(state)` or `(state)`.
+         */
+        const guardName = options?.guardFunctions?.find((name) => name.trim().length > 0) ??
+            DEFAULT_GUARD_FUNCTIONS[0];
         const excludeFiles = options?.excludeFiles ?? [
             'src/types/FirestoreSnapshotState.ts',
         ];
@@ -163,7 +172,7 @@ exports.enforceSnapshotStateNarrowing = (0, createRule_1.createRule)({
          * import, or would collide with an unrelated binding of the same name.
          */
         function resolveGuardBinding(scope) {
-            const variable = utils_1.ASTUtils.findVariable(scope, GUARD_NAME);
+            const variable = utils_1.ASTUtils.findVariable(scope, guardName);
             if (!variable) {
                 return 'missing';
             }
@@ -214,14 +223,14 @@ exports.enforceSnapshotStateNarrowing = (0, createRule_1.createRule)({
             if (reusable) {
                 const namedSpecifiers = reusable.specifiers.filter(isValueImportSpecifier);
                 const lastSpecifier = namedSpecifiers[namedSpecifiers.length - 1];
-                return fixer.insertTextAfter(lastSpecifier, `, ${GUARD_NAME}`);
+                return fixer.insertTextAfter(lastSpecifier, `, ${guardName}`);
             }
             // A namespace or type-only import of the module cannot take a named value
             // specifier, but its path is proof of how this file reaches the module.
             const source = guardDeclarations.length
                 ? String(guardDeclarations[0].source.value)
                 : guardImportSource;
-            const importText = `import { ${GUARD_NAME} } from '${source}';\n`;
+            const importText = `import { ${guardName} } from '${source}';\n`;
             const [firstImport] = declarations;
             if (firstImport) {
                 return fixer.insertTextBefore(firstImport, importText);
@@ -233,7 +242,7 @@ exports.enforceSnapshotStateNarrowing = (0, createRule_1.createRule)({
         }
         /**
          * Builds the single suggestion shared by every report: swap the flagged
-         * expression for its guard-based equivalent and bring `isSnapshotReady` into
+         * expression for its guard-based equivalent and bring the guard into
          * scope. Declines (no suggestion) when the name is already taken by
          * something that is not the guard.
          */
@@ -241,7 +250,7 @@ exports.enforceSnapshotStateNarrowing = (0, createRule_1.createRule)({
             return [
                 {
                     messageId,
-                    data: { expression: replacement },
+                    data: { expression: replacement, guard: guardName },
                     fix(fixer) {
                         const binding = resolveGuardBinding(scope);
                         if (binding === 'conflict') {
@@ -306,8 +315,8 @@ exports.enforceSnapshotStateNarrowing = (0, createRule_1.createRule)({
                         context.report({
                             node,
                             messageId: 'noRawTypeof',
-                            data: { expression: getText(node) },
-                            suggest: guardSuggestion('noRawTypeof', node, `${GUARD_NAME}(${operand.name})`, context.getScope()),
+                            data: { expression: getText(node), guard: guardName },
+                            suggest: guardSuggestion('noRawTypeof', node, `${guardName}(${operand.name})`, context.getScope()),
                         });
                     }
                     // typeof state === 'string' — allowed (narrows to non-data states)
@@ -327,7 +336,7 @@ exports.enforceSnapshotStateNarrowing = (0, createRule_1.createRule)({
             context.report({
                 node,
                 messageId: 'noFalsyCheck',
-                data: { expression },
+                data: { expression, guard: guardName },
                 suggest: guardSuggestion('noFalsyCheck', fixNode, replacement, context.getScope()),
             });
         }
@@ -372,7 +381,7 @@ exports.enforceSnapshotStateNarrowing = (0, createRule_1.createRule)({
                 // stay negated or the suggestion would reverse the control flow.
                 if (argument.type === utils_1.AST_NODE_TYPES.Identifier &&
                     isSnapshotVar(argument)) {
-                    reportFalsyCheck(node, `!${argument.name}`, `!${GUARD_NAME}(${argument.name})`);
+                    reportFalsyCheck(node, `!${argument.name}`, `!${guardName}(${argument.name})`);
                 }
                 // !!state — the argument is another `!` whose argument is the snapshot var.
                 // The double negation is a truthiness coercion, so the guard is positive.
@@ -381,7 +390,7 @@ exports.enforceSnapshotStateNarrowing = (0, createRule_1.createRule)({
                     argument.argument.type === utils_1.AST_NODE_TYPES.Identifier &&
                     isSnapshotVar(argument.argument)) {
                     const varName = argument.argument.name;
-                    reportFalsyCheck(node, `!!${varName}`, `${GUARD_NAME}(${varName})`);
+                    reportFalsyCheck(node, `!!${varName}`, `${guardName}(${varName})`);
                 }
             },
             // IfStatement: if (state) { ... } or if (!state) { ... }
@@ -389,14 +398,14 @@ exports.enforceSnapshotStateNarrowing = (0, createRule_1.createRule)({
             IfStatement(node) {
                 const test = node.test;
                 if (test.type === utils_1.AST_NODE_TYPES.Identifier && isSnapshotVar(test)) {
-                    reportFalsyCheck(test, test.name, `${GUARD_NAME}(${test.name})`);
+                    reportFalsyCheck(test, test.name, `${guardName}(${test.name})`);
                 }
             },
             // ConditionalExpression: state ? a : b
             ConditionalExpression(node) {
                 const test = node.test;
                 if (test.type === utils_1.AST_NODE_TYPES.Identifier && isSnapshotVar(test)) {
-                    reportFalsyCheck(test, test.name, `${GUARD_NAME}(${test.name})`);
+                    reportFalsyCheck(test, test.name, `${guardName}(${test.name})`);
                 }
             },
             // LogicalExpression: state && expr, state || expr
@@ -408,13 +417,13 @@ exports.enforceSnapshotStateNarrowing = (0, createRule_1.createRule)({
                     if (node.operator === '&&') {
                         // `state && expr` guards expr, so swapping the operand for the
                         // guard keeps both the polarity and the narrowing of `state`.
-                        reportFalsyCheck(left, left.name, `${GUARD_NAME}(${left.name})`);
+                        reportFalsyCheck(left, left.name, `${guardName}(${left.name})`);
                         return;
                     }
                     // `state || fallback` evaluates to the state itself when it is
                     // usable, so a bare operand swap would yield `true` instead of the
                     // data. Only the conditional form preserves that value.
-                    const guarded = `${GUARD_NAME}(${left.name}) ? ${left.name} : ${getText(node.right)}`;
+                    const guarded = `${guardName}(${left.name}) ? ${left.name} : ${getText(node.right)}`;
                     reportFalsyCheck(left, left.name, needsParentheses(node) ? `(${guarded})` : guarded, node);
                 }
             },
@@ -432,7 +441,7 @@ exports.enforceSnapshotStateNarrowing = (0, createRule_1.createRule)({
                     node.arguments[0].type === utils_1.AST_NODE_TYPES.Identifier &&
                     isSnapshotVar(node.arguments[0])) {
                     const varName = node.arguments[0].name;
-                    reportFalsyCheck(node, `Boolean(${varName})`, `${GUARD_NAME}(${varName})`);
+                    reportFalsyCheck(node, `Boolean(${varName})`, `${guardName}(${varName})`);
                 }
             },
         };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.20.44",
+  "version": "1.20.46",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,40 @@
 [
+  {
+    "version": "1.20.46",
+    "date": "2026-07-31T07:08:55.415Z",
+    "rules": [
+      {
+        "name": "enforce-snapshot-state-narrowing",
+        "changeType": "fix",
+        "issues": [
+          1505
+        ],
+        "summary": "make the guardFunctions option actually select the emitted guard name (closes #1505)"
+      }
+    ]
+  },
+  {
+    "version": "1.20.45",
+    "date": "2026-07-31T06:37:56.216Z",
+    "rules": [
+      {
+        "name": "enforce-mui-rounded-icons",
+        "changeType": "fix",
+        "issues": [
+          1502
+        ],
+        "summary": "examine barrel imports, not just deep ones (closes #1502)"
+      },
+      {
+        "name": "enforce-object-literal-as-const",
+        "changeType": "fix",
+        "issues": [
+          1503
+        ],
+        "summary": "stop the autofix destroying an existing type assertion (closes #1503)"
+      }
+    ]
+  },
   {
     "version": "1.20.44",
     "date": "2026-07-31T05:47:19.150Z",