@blumintinc/eslint-plugin-blumint 1.20.43 → 1.20.44

package/lib/index.js

@@ -223,7 +223,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.20.43',
+        version: '1.20.44',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/enforce-firestore-doc-ref-generic.js

@@ -10,6 +10,7 @@ exports.enforceFirestoreDocRefGeneric = void 0;
  */
 const utils_1 = require("@typescript-eslint/utils");
 const createRule_1 = require("../utils/createRule");
+const ASTHelpers_1 = require("../utils/ASTHelpers");
 /**
  * @type {import('eslint').Rule.RuleModule}
  */
@@ -305,8 +306,64 @@ exports.enforceFirestoreDocRefGeneric = (0, createRule_1.createRule)({
             if (findVariableDeclaration(node)) {
                 return true;
             }
+            // Resolve the binding through the scope chain so that a typed collection
+            // stored in a variable still supplies the document generic to .doc().
+            if (isTypedCollectionBinding(node)) {
+                return true;
+            }
             return false;
         }
+        /**
+         * Resolves an identifier to its declaration and reports whether that
+         * declaration provably yields a typed CollectionReference.
+         *
+         * Deliberately conservative: only immutable (`const`) bindings with a
+         * single definition are followed, and only for one hop. An alias such as
+         * `const b = a;` is not resolved because chasing arbitrary dataflow
+         * syntactically produces unsound exemptions; `let`/`var` are refused
+         * because a later assignment can replace the value with an untyped
+         * collection. Anything unresolvable (parameters, imports, destructuring)
+         * keeps reporting, since the rule cannot prove the reference is typed.
+         */
+        function isTypedCollectionBinding(node) {
+            const scope = ASTHelpers_1.ASTHelpers.getScope(context, node);
+            const variable = ASTHelpers_1.ASTHelpers.findVariableInScope(scope, node.name);
+            if (!variable || variable.defs.length !== 1) {
+                return false;
+            }
+            const def = variable.defs[0];
+            if (def.type !== 'Variable' ||
+                def.node.type !== utils_1.AST_NODE_TYPES.VariableDeclarator ||
+                def.parent?.type !== utils_1.AST_NODE_TYPES.VariableDeclaration ||
+                def.parent.kind !== 'const') {
+                return false;
+            }
+            const declarator = def.node;
+            if (declarator.id.type === utils_1.AST_NODE_TYPES.Identifier &&
+                declarator.id.typeAnnotation) {
+                return hasCollectionReferenceType(declarator.id.typeAnnotation.typeAnnotation);
+            }
+            return isTypedCollectionInitializer(declarator.init);
+        }
+        function isTypedCollectionInitializer(init) {
+            if (!init) {
+                return false;
+            }
+            // An explicit assertion states the schema just as an annotation does.
+            if (init.type === utils_1.AST_NODE_TYPES.TSAsExpression) {
+                return hasCollectionReferenceType(init.typeAnnotation);
+            }
+            // Mirrors the chained `db.collection<T>('x').doc('y')` detection: the
+            // presence of the type argument is what matters here. An `any`/`{}`
+            // argument is already reported on the collection call itself, so it is
+            // not reported a second time on the derived document reference.
+            return (init.type === utils_1.AST_NODE_TYPES.CallExpression &&
+                init.callee.type === utils_1.AST_NODE_TYPES.MemberExpression &&
+                init.callee.property.type === utils_1.AST_NODE_TYPES.Identifier &&
+                init.callee.property.name === 'collection' &&
+                !!init.typeParameters &&
+                init.typeParameters.params.length > 0);
+        }
         function checkCallExpressionForCollectionReference(node) {
             // Check if this is a method call that returns CollectionReference
             if (node.callee.type === utils_1.AST_NODE_TYPES.MemberExpression) {

package/lib/rules/enforce-transform-memoization.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.enforceTransformMemoization = void 0;
 const utils_1 = require("@typescript-eslint/utils");
 const createRule_1 = require("../utils/createRule");
+const ASTHelpers_1 = require("../utils/ASTHelpers");
 exports.enforceTransformMemoization = (0, createRule_1.createRule)({
     name: 'enforce-transform-memoization',
     meta: {
@@ -395,6 +396,14 @@ exports.enforceTransformMemoization = (0, createRule_1.createRule)({
                     !adaptValueNames.has(node.callee.name)) {
                     return;
                 }
+                // Every message this rule emits prescribes useMemo/useCallback, and a
+                // hook call is legal only inside a component or another hook. An
+                // adaptValue call at module scope, in a plain helper, or in a test body
+                // is not on a render path: nothing is "recreated on every render"
+                // there, and the prescribed fix would throw "Invalid hook call".
+                if (!ASTHelpers_1.ASTHelpers.isInsideComponentOrHook(node, context)) {
+                    return;
+                }
                 const optionsArg = node.arguments[0];
                 if (!optionsArg)
                     return;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.20.43",
+  "version": "1.20.44",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,26 @@
 [
+  {
+    "version": "1.20.44",
+    "date": "2026-07-31T05:47:19.150Z",
+    "rules": [
+      {
+        "name": "enforce-firestore-doc-ref-generic",
+        "changeType": "fix",
+        "issues": [
+          1498
+        ],
+        "summary": "honor a typed collection bound to a const (closes #1498)"
+      },
+      {
+        "name": "enforce-transform-memoization",
+        "changeType": "fix",
+        "issues": [
+          1497
+        ],
+        "summary": "only report inside a component or hook (closes #1497)"
+      }
+    ]
+  },
   {
     "version": "1.20.43",
     "date": "2026-07-31T04:38:54.532Z",