@blumintinc/eslint-plugin-blumint 1.20.34 → 1.20.36

package/lib/index.js

@@ -223,7 +223,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.20.34',
+        version: '1.20.36',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/no-margin-properties.d.ts

@@ -1,7 +1 @@
-type Options = [
-    {
-        autofix?: boolean;
-    }
-];
-export declare const noMarginProperties: import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleModule<"noMarginProperties", Options, import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleListener>;
-export {};
+export declare const noMarginProperties: import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleModule<"noMarginProperties", [], import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleListener>;

package/lib/rules/no-margin-properties.js

@@ -42,27 +42,14 @@ exports.noMarginProperties = (0, createRule_1.createRule)({
             description: 'Prevent margin properties (margin, marginLeft, marginRight, marginTop, marginBottom, mx, my, etc.) in MUI styling because margins fight container-controlled spacing, double gutters, and misaligned breakpoints; keep spacing centralized with padding, gap, or spacing props instead.',
             recommended: 'error',
         },
-        schema: [
-            {
-                type: 'object',
-                properties: {
-                    autofix: {
-                        type: 'boolean',
-                        default: false,
-                    },
-                },
-                additionalProperties: false,
-            },
-        ],
+        schema: [],
         messages: {
             noMarginProperties: 'Margin property "{{property}}" in MUI styling fights container-controlled spacing (Stack/Grid spacing, gap, responsive gutters) and produces double gutters, misalignment, and overflow as layouts shift. Keep spacing inside the component with padding or let the parent handle separation via gap/spacing so layout remains predictable.',
         },
     },
-    defaultOptions: [{ autofix: false }],
+    defaultOptions: [],
     create(context) {
         const seenNodes = new WeakSet();
-        // Note: autofix option is available but not currently implemented
-        // Future implementation can use: const { autofix = false } = _options;
         function checkProperty(propertyName) {
             const normalizedName = normalizePropertyName(propertyName);
             return MARGIN_PROPERTIES.has(normalizedName);

package/lib/rules/require-image-optimized.js

@@ -1,6 +1,7 @@
 "use strict";
 const utils_1 = require("@typescript-eslint/utils");
 const path_1 = require("path");
+const ASTHelpers_1 = require("../utils/ASTHelpers");
 const createRule_1 = require("../utils/createRule");
 const DEFAULT_COMPONENT_PATH = 'src/components/image/ImageOptimized';
 /** The JSX name the fixer writes, and the named export it comes from. */
@@ -82,6 +83,24 @@ const isBoundAsValue = (scope, name) => {
         variable.defs.length > 0 &&
         variable.defs.some((definition) => !isTypeOnlyImport(definition)));
 };
+/**
+ * Whether the name the fixer is about to emit still resolves, at the report
+ * site, to a declaration in the file's module scope — where the component's
+ * import, and any module-scope stand-in such as `const ImageOptimized =
+ * dynamic(...)`, live. A binding introduced by an enclosing inner scope (a
+ * local, a parameter, a block-scoped const) captures the emitted element
+ * instead: the name is bound, so no reference is stranded and TypeScript
+ * accepts the element, yet the fix silently renders that local value rather
+ * than the shared wrapper.
+ */
+const resolvesToModuleBinding = (scope, name) => {
+    const variable = ASTHelpers_1.ASTHelpers.findVariableInScope(scope, name);
+    // A variable with no definition is an ambient global, which is no component
+    // and cannot be the import the emitted element is meant to reach.
+    return (!!variable &&
+        variable.defs.length > 0 &&
+        variable.scope.block.type === utils_1.AST_NODE_TYPES.Program);
+};
 /**
  * Local name the component is imported under, when it is aliased away from
  * `ImageOptimized`. Reusing the alias keeps the fix bound to a real import
@@ -158,7 +177,7 @@ module.exports = (0, createRule_1.createRule)({
                     isInsideComponentMock(node, componentModule)) {
                     return;
                 }
-                const scope = context.getScope();
+                const scope = ASTHelpers_1.ASTHelpers.getScope(context, node);
                 const localName = isBoundAsValue(scope, COMPONENT_NAME)
                     ? COMPONENT_NAME
                     : aliasedLocalName(sourceCode.ast, componentModule);
@@ -176,6 +195,12 @@ module.exports = (0, createRule_1.createRule)({
                         if (!localName) {
                             return null;
                         }
+                        // A shadow of that name over the report site would make the swap
+                        // render the shadow's value; declining leaves the report for the
+                        // author to resolve the shadow by hand.
+                        if (!resolvesToModuleBinding(scope, localName)) {
+                            return null;
+                        }
                         const attributes = node.openingElement.attributes
                             .map((attribute) => sourceCode.getText(attribute))
                             .join(' ');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.20.34",
+  "version": "1.20.36",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,32 @@
 [
+  {
+    "version": "1.20.36",
+    "date": "2026-07-30T17:05:52.383Z",
+    "rules": [
+      {
+        "name": "no-margin-properties",
+        "changeType": "fix",
+        "issues": [
+          1460
+        ],
+        "summary": "remove the inert autofix option (closes #1460)"
+      }
+    ]
+  },
+  {
+    "version": "1.20.35",
+    "date": "2026-07-30T16:38:05.368Z",
+    "rules": [
+      {
+        "name": "require-image-optimized",
+        "changeType": "fix",
+        "issues": [
+          1457
+        ],
+        "summary": "decline the autofix when a shadow captures the reused import alias (closes #1457)"
+      }
+    ]
+  },
   {
     "version": "1.20.34",
     "date": "2026-07-30T16:15:43.598Z",