@blumintinc/eslint-plugin-blumint 1.20.2 → 1.20.4

package/lib/index.js

@@ -223,7 +223,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.20.2',
+        version: '1.20.4',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/no-unnecessary-verb-suffix.js

@@ -166,6 +166,28 @@ function isExported(node) {
     }
     return false;
 }
+/**
+ * Renames `identifier` to `newName` while leaving every other token inside the
+ * identifier's range intact.
+ *
+ * A TSESTree `Identifier` node's range spans the tokens that trail its name:
+ * a type annotation (`validateBy: Validator`), a definite-assignment assertion
+ * (`validateBy!: Validator`) and an optional marker (`cbBy?: Fn`). Replacing the
+ * whole node therefore deletes them, and dropping a contextual type turns
+ * inferred parameters into implicit `any` so the file no longer compiles — a
+ * silent corruption, since the rule reports nothing afterwards (#1351). The name
+ * is always the identifier's first token, so replacing that token's range alone
+ * renames the symbol and nothing else.
+ */
+function renameIdentifier(fixer, sourceCode, identifier, newName) {
+    const nameToken = sourceCode.getFirstToken(identifier);
+    // The token store yields the name for every real identifier; the arithmetic
+    // end keeps the range narrowed even if a token is somehow unavailable.
+    const nameEnd = nameToken
+        ? nameToken.range[1]
+        : identifier.range[0] + identifier.name.length;
+    return fixer.replaceTextRange([identifier.range[0], nameEnd], newName);
+}
 /**
  * Walks a scope chain upward from `scope` (inclusive) and reports whether
  * `targetName` is bound anywhere between `scope` and `stopScope` (inclusive).
@@ -561,16 +583,40 @@ exports.noUnnecessaryVerbSuffix = (0, createRule_1.createRule)({
                                 // Scope-tracked symbols (FunctionDeclaration, VariableDeclarator
                                 // arrows/functions, named FunctionExpression): rename the
                                 // declaration identifier and every in-file reference together so
-                                // no call site is left pointing at the old name.
+                                // no call site is left pointing at the old name. Every rewrite
+                                // goes through renameIdentifier, because an identifier's range
+                                // can carry trailing tokens that must survive a rename (#1351).
+                                const { sourceCode } = context;
                                 const fixes = [
-                                    fixer.replaceText(declarationIdNode, suggestion),
+                                    renameIdentifier(fixer, sourceCode, declarationIdNode, suggestion),
                                 ];
                                 if (targetVariable) {
                                     for (const ref of targetVariable.references) {
                                         // Skip the declaration identifier itself — already handled.
                                         if (ref.identifier === declarationIdNode)
                                             continue;
-                                        fixes.push(fixer.replaceText(ref.identifier, suggestion));
+                                        const refParent = ref.identifier.parent;
+                                        // An object-literal shorthand `{ fooBar }` desugars to
+                                        // `{ fooBar: fooBar }`: the one token is both the property
+                                        // key and its value. Renaming it would rename the KEY too,
+                                        // silently changing the object's shape so every
+                                        // `obj.fooBar` consumer reads undefined. Expand to
+                                        // `oldKey: newName` so only the value moves (#1352).
+                                        if (refParent?.type === utils_1.AST_NODE_TYPES.Property &&
+                                            refParent.shorthand &&
+                                            refParent.parent?.type === utils_1.AST_NODE_TYPES.ObjectExpression) {
+                                            fixes.push(fixer.replaceText(ref.identifier, `${name}: ${suggestion}`));
+                                            continue;
+                                        }
+                                        // A re-export specifier `export { fooBar }` binds the public
+                                        // export name to this identifier, a cross-file contract a
+                                        // single-file fixer cannot rewrite. The declaration-level
+                                        // export guard misses this form because the declaration
+                                        // itself carries no `export` keyword (#1352).
+                                        if (refParent?.type === utils_1.AST_NODE_TYPES.ExportSpecifier) {
+                                            return null;
+                                        }
+                                        fixes.push(renameIdentifier(fixer, sourceCode, ref.identifier, suggestion));
                                     }
                                 }
                                 return fixes;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.20.2",
+  "version": "1.20.4",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,32 @@
 [
+  {
+    "version": "1.20.4",
+    "date": "2026-07-25T03:08:45.043Z",
+    "rules": [
+      {
+        "name": "no-unnecessary-verb-suffix",
+        "changeType": "fix",
+        "issues": [
+          1352
+        ],
+        "summary": "stop the rename autofix from renaming shorthand keys and re-exported names (closes #1352)"
+      }
+    ]
+  },
+  {
+    "version": "1.20.3",
+    "date": "2026-07-25T02:54:46.197Z",
+    "rules": [
+      {
+        "name": "no-unnecessary-verb-suffix",
+        "changeType": "fix",
+        "issues": [
+          1351
+        ],
+        "summary": "preserve type annotations when the rename autofix renames an identifier (closes #1351)"
+      }
+    ]
+  },
   {
     "version": "1.20.2",
     "date": "2026-07-25T02:42:18.863Z",