@blumintinc/eslint-plugin-blumint 1.20.191 → 1.20.193

package/lib/index.js

@@ -223,7 +223,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.20.191',
+        version: '1.20.193',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/enforce-memoize-getters.js

@@ -423,6 +423,19 @@ exports.enforceMemoizeGetters = (0, createRule_1.createRule)({
                 // breakage.
                 if (node.key.type === utils_1.AST_NODE_TYPES.PrivateIdentifier)
                     return;
+                // The same unwritable-remedy shape, one key form over: `Memoize`
+                // declares its `propertyKey` parameter as `string`, so decorating a
+                // symbol-keyed getter — `get [Symbol.iterator]()` — is TS1241, and the
+                // `--fix` edit turns compiling code into code that does not compile.
+                // A computed key that IS a string literal (`get ['name']()`) is an
+                // ordinary string key and stays in scope; anything else cannot be shown
+                // to be a string without the checker, and a false negative is the
+                // cheaper error here.
+                if (node.computed &&
+                    !(node.key.type === utils_1.AST_NODE_TYPES.Literal &&
+                        typeof node.key.value === 'string')) {
+                    return;
+                }
                 const classBody = node.parent;
                 // The same reasoning, one level out: under `experimentalDecorators` a
                 // decorator is rejected on EVERY member of a class EXPRESSION — TS1206

package/lib/rules/enforce-typescript-markdown-code-blocks.js

@@ -2,32 +2,104 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.enforceTypescriptMarkdownCodeBlocks = void 0;
 const createRule_1 = require("../utils/createRule");
-const FENCE = '```';
-function isFenceLine(text, fenceIndex, indent) {
-    const lineEnd = text.indexOf('\n', fenceIndex);
-    const afterFence = lineEnd === -1
-        ? text.slice(fenceIndex + FENCE.length)
-        : text.slice(fenceIndex + FENCE.length, lineEnd);
-    return (afterFence.trim().length === 0 &&
-        text.slice(text.lastIndexOf('\n', fenceIndex - 1) + 1, fenceIndex) ===
-            indent);
+const BACKTICK = '`';
+const TILDE = '~';
+/** Only a run of exactly three backticks is labelable; longer runs are declined. */
+const LABELABLE_FENCE_LENGTH = 3;
+/** CommonMark opens a fenced block on a run of three or more of either marker. */
+const MIN_FENCE_LENGTH = 3;
+/**
+ * CommonMark allows a fence to be indented at most three columns. At four or
+ * more the line opens an indented code block, so its backticks are literal
+ * document content that must never be rewritten.
+ */
+const MAX_FENCE_INDENT_COLUMNS = 3;
+/** CommonMark advances a tab to the next multiple of four when measuring indent. */
+const TAB_STOP = 4;
+function splitLines(text) {
+    const lines = [];
+    let start = 0;
+    for (;;) {
+        const terminator = text.indexOf('\n', start);
+        const end = terminator === -1 ? text.length : terminator;
+        lines.push({ start, end, text: text.slice(start, end) });
+        if (terminator === -1) {
+            return lines;
+        }
+        start = terminator + 1;
+    }
 }
-function findClosingFence(text, startIndex, indent) {
-    let searchIndex = startIndex;
-    while (searchIndex < text.length) {
-        const candidate = text.indexOf(FENCE, searchIndex);
-        if (candidate === -1) {
-            return null;
+/**
+ * Reads the fence a line opens, or null when the line cannot open one.
+ * Indentation is measured in columns rather than characters so that a tab is
+ * treated as the four-column indent CommonMark says it is.
+ */
+function readFence(line) {
+    let indentColumns = 0;
+    let offset = 0;
+    while (offset < line.text.length) {
+        const char = line.text[offset];
+        if (char === ' ') {
+            indentColumns += 1;
         }
-        if (isFenceLine(text, candidate, indent)) {
-            return candidate;
+        else if (char === '\t') {
+            indentColumns += TAB_STOP - (indentColumns % TAB_STOP);
+        }
+        else {
+            break;
+        }
+        offset += 1;
+    }
+    if (indentColumns > MAX_FENCE_INDENT_COLUMNS) {
+        return null;
+    }
+    const marker = line.text[offset];
+    if (marker !== BACKTICK && marker !== TILDE) {
+        return null;
+    }
+    let runLength = 0;
+    while (line.text[offset + runLength] === marker) {
+        runLength += 1;
+    }
+    if (runLength < MIN_FENCE_LENGTH) {
+        return null;
+    }
+    return {
+        runStart: line.start + offset,
+        marker,
+        runLength,
+        indent: line.text.slice(0, offset),
+        infoString: line.text.slice(offset + runLength),
+    };
+}
+/**
+ * The line a block closes on, per CommonMark: a run of at least the opening
+ * length, of the SAME marker, at a fence indent, with nothing but whitespace
+ * after it. This locates the block's END, which is a separate question from
+ * whether the rule is willing to LABEL it.
+ */
+function findFenceCloser(lines, fromLine, opener) {
+    for (let index = fromLine; index < lines.length; index++) {
+        const fence = readFence(lines[index]);
+        if (fence !== null &&
+            fence.marker === opener.marker &&
+            fence.runLength >= opener.runLength &&
+            fence.infoString.trim().length === 0) {
+            return { line: index, fence };
         }
-        searchIndex = candidate + FENCE.length;
     }
     return null;
 }
-function isIndentOnly(value) {
-    return /^[\t ]*$/.test(value);
+/**
+ * The rule labels only a block it can delimit exactly: three backticks closed
+ * by three backticks at the same indent. A longer closing run or a differently
+ * indented one is left unlabeled by design — but the block is still SKIPPED
+ * whole, because a block the rule declines to label is a block it must not
+ * read.
+ */
+function isExactlyDelimited(opener, closer) {
+    return (closer.runLength === LABELABLE_FENCE_LENGTH &&
+        closer.indent === opener.indent);
 }
 exports.enforceTypescriptMarkdownCodeBlocks = (0, createRule_1.createRule)({
     name: 'enforce-typescript-markdown-code-blocks',
@@ -53,45 +125,51 @@ exports.enforceTypescriptMarkdownCodeBlocks = (0, createRule_1.createRule)({
             Program() {
                 const sourceCode = context.sourceCode;
                 const text = sourceCode.getText();
+                const lines = splitLines(text);
                 let index = 0;
-                while (index < text.length) {
-                    const openingFence = text.indexOf(FENCE, index);
-                    if (openingFence === -1) {
-                        break;
-                    }
-                    const lineStart = text.lastIndexOf('\n', openingFence - 1) + 1;
-                    const indent = text.slice(lineStart, openingFence);
-                    if (!isIndentOnly(indent)) {
-                        index = openingFence + FENCE.length;
+                while (index < lines.length) {
+                    const openingLine = lines[index];
+                    const fence = readFence(openingLine);
+                    if (fence === null) {
+                        index += 1;
                         continue;
                     }
-                    const lineEnd = text.indexOf('\n', openingFence + FENCE.length);
-                    if (lineEnd === -1) {
-                        break;
-                    }
-                    const infoString = text.slice(openingFence + FENCE.length, lineEnd);
-                    const closingFence = findClosingFence(text, lineEnd + 1, indent);
-                    if (closingFence === null) {
-                        index = lineEnd + 1;
-                        continue;
+                    const closing = findFenceCloser(lines, index + 1, fence);
+                    // An unclosed fence runs to the end of the file, so everything after
+                    // it is the block's literal content and there is nothing left to
+                    // scan. Resuming on the next line would read the block's interior.
+                    if (closing === null) {
+                        return;
                     }
-                    const content = text.slice(lineEnd + 1, closingFence);
-                    const hasContent = content.trim().length > 0;
-                    const hasLanguage = infoString.trim().length > 0;
-                    if (!hasLanguage && hasContent) {
-                        const locStart = sourceCode.getLocFromIndex(openingFence);
-                        const hasCarriageReturn = lineEnd > 0 && text[lineEnd - 1] === '\r';
-                        context.report({
-                            loc: {
-                                start: locStart,
-                                end: sourceCode.getLocFromIndex(lineEnd),
-                            },
-                            messageId: 'missingLanguageSpecifier',
-                            data: { line: locStart.line },
-                            fix: (fixer) => fixer.replaceTextRange([openingFence + FENCE.length, lineEnd], hasCarriageReturn ? 'typescript\r' : 'typescript'),
-                        });
+                    // A tilde fence and a run of four or more backticks are blocks this
+                    // rule declines to label, and declining to label a block means
+                    // declining to read it: its interior is literal text, triple
+                    // backticks included. So is the interior of a triple-backtick block
+                    // this rule cannot delimit exactly. Every one of them is skipped from
+                    // its opening line to past its closing line.
+                    const labelable = fence.marker === BACKTICK &&
+                        fence.runLength === LABELABLE_FENCE_LENGTH &&
+                        isExactlyDelimited(fence, closing.fence);
+                    if (labelable) {
+                        const content = text.slice(openingLine.end + 1, lines[closing.line].start);
+                        const hasContent = content.trim().length > 0;
+                        const hasLanguage = fence.infoString.trim().length > 0;
+                        if (!hasLanguage && hasContent) {
+                            const lineEnd = openingLine.end;
+                            const locStart = sourceCode.getLocFromIndex(fence.runStart);
+                            const hasCarriageReturn = lineEnd > 0 && text[lineEnd - 1] === '\r';
+                            context.report({
+                                loc: {
+                                    start: locStart,
+                                    end: sourceCode.getLocFromIndex(lineEnd),
+                                },
+                                messageId: 'missingLanguageSpecifier',
+                                data: { line: locStart.line },
+                                fix: (fixer) => fixer.replaceTextRange([fence.runStart + LABELABLE_FENCE_LENGTH, lineEnd], hasCarriageReturn ? 'typescript\r' : 'typescript'),
+                            });
+                        }
                     }
-                    index = closingFence + FENCE.length;
+                    index = closing.line + 1;
                 }
             },
         };

package/lib/rules/no-direct-function-state.d.ts

@@ -4,6 +4,6 @@ type Options = [
         functionPatterns?: string[];
     }
 ];
-type MessageIds = 'noDirectFunctionState' | 'noDirectFunctionStateAssertion';
+type MessageIds = 'noDirectFunctionState' | 'noDirectFunctionStateAssertion' | 'invalidFunctionPattern';
 export declare const noDirectFunctionState: TSESLint.RuleModule<MessageIds, Options, TSESLint.RuleListener>;
 export {};

package/lib/rules/no-direct-function-state.js

@@ -198,22 +198,33 @@ function isDefinitelySafeArg(argNode) {
     }
 }
 /**
- * Checks whether an identifier name matches any of the function-naming patterns
- * (e.g. onClose, handler, fn, callback).
+ * Compiles the configured function-naming patterns once, separating the ones
+ * that do not compile from the ones that do.
+ *
+ * Swallowing an uncompilable pattern makes the consumer's allowlist silently
+ * inert: the rule then reports the very code they wrote the pattern to exclude,
+ * with nothing anywhere saying why. Returning the rejects lets `create` report
+ * them, which is what the sibling pattern-compiling rules already do.
  */
-function matchesFunctionPattern(name, patterns) {
+function compileFunctionPatterns(patterns) {
+    const matchers = [];
+    const invalid = [];
     for (const pattern of patterns) {
         try {
-            const regex = new RegExp(`^${pattern}$`);
-            if (regex.test(name)) {
-                return true;
-            }
+            matchers.push(new RegExp(`^${pattern}$`));
         }
         catch {
-            // Ignore invalid regex patterns
+            invalid.push(pattern);
         }
     }
-    return false;
+    return { matchers, invalid };
+}
+/**
+ * Checks whether an identifier name matches any of the function-naming patterns
+ * (e.g. onClose, handler, fn, callback).
+ */
+function matchesFunctionPattern(name, matchers) {
+    return matchers.some((matcher) => matcher.test(name));
 }
 /**
  * Extracts the identifier name from an argument node for pattern matching.
@@ -296,12 +307,16 @@ exports.noDirectFunctionState = (0, createRule_1.createRule)({
                 'Why it matters: The function will be called with the previous state value and its return value stored — a silent bug with no error. ' +
                 'How to fix: Give the asserted value a name, then store that name through a thunk: const value = {{argText}}; {{setterName}}(() => value). ' +
                 'The assertion is hoisted out because a thunk that returned it would be an arrow returning a cast, which no-type-assertion-returns reports.',
+            invalidFunctionPattern: 'What\u2019s wrong: "{{pattern}}" in functionPatterns is not a valid regular expression, so it was dropped. ' +
+                'Why it matters: the rule silently stops honouring that entry, and reports the very code the pattern was written to exclude. ' +
+                'How to fix: correct the pattern in your ESLint configuration.',
         },
     },
     defaultOptions: [{ functionPatterns: DEFAULT_FUNCTION_PATTERNS }],
     create(context) {
         const options = context.options[0] ?? {};
         const functionPatterns = options.functionPatterns ?? DEFAULT_FUNCTION_PATTERNS;
+        const { matchers: functionPatternMatchers, invalid: invalidPatterns } = compileFunctionPatterns(functionPatterns);
         /**
          * Maps setter-variable names to whether the corresponding useState has
          * an explicit function type parameter. This is populated as we encounter
@@ -309,6 +324,15 @@ exports.noDirectFunctionState = (0, createRule_1.createRule)({
          */
         const setterFunctionTyped = new Map();
         return {
+            Program(node) {
+                for (const pattern of invalidPatterns) {
+                    context.report({
+                        node,
+                        messageId: 'invalidFunctionPattern',
+                        data: { pattern },
+                    });
+                }
+            },
             VariableDeclarator(node) {
                 // Look for `const [state, setter] = useState<T>(...)` or
                 // `const [state, setter] = React.useState<T>(...)`.
@@ -383,7 +407,8 @@ exports.noDirectFunctionState = (0, createRule_1.createRule)({
                 // No explicit function type. Fall back to heuristic: name pattern match
                 // or scope-level binding to a function.
                 const argName = getArgName(arg);
-                if (argName && matchesFunctionPattern(argName, functionPatterns)) {
+                if (argName &&
+                    matchesFunctionPattern(argName, functionPatternMatchers)) {
                     reportAndFix(node, arg, setterName, context);
                     return;
                 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.20.191",
+  "version": "1.20.193",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,40 @@
 [
+  {
+    "version": "1.20.193",
+    "date": "2026-08-30T05:32:04.963Z",
+    "rules": [
+      {
+        "name": "enforce-memoize-getters",
+        "changeType": "fix",
+        "issues": [
+          2215
+        ],
+        "summary": "decline a getter whose computed key is not a string literal"
+      },
+      {
+        "name": "no-direct-function-state",
+        "changeType": "fix",
+        "issues": [
+          2218
+        ],
+        "summary": "report an uncompilable functionPatterns entry instead of dropping it (closes #2218)"
+      }
+    ]
+  },
+  {
+    "version": "1.20.192",
+    "date": "2026-08-30T01:20:08.891Z",
+    "rules": [
+      {
+        "name": "enforce-typescript-markdown-code-blocks",
+        "changeType": "fix",
+        "issues": [
+          2213
+        ],
+        "summary": "never write inside a declined block (closes #2213)"
+      }
+    ]
+  },
   {
     "version": "1.20.191",
     "date": "2026-08-29T19:38:08.123Z",