@blumintinc/eslint-plugin-blumint 1.20.188 → 1.20.190

package/lib/index.js

@@ -223,7 +223,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.20.188',
+        version: '1.20.190',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/no-entire-object-hook-deps.d.ts

@@ -1,3 +1,4 @@
+import { TSESLint } from '@typescript-eslint/utils';
 type MessageIds = 'avoidEntireObject' | 'removeUnusedDependency';
-export declare const noEntireObjectHookDeps: import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleModule<MessageIds, [], import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleListener>;
+export declare const noEntireObjectHookDeps: TSESLint.RuleModule<MessageIds, [], TSESLint.RuleListener>;
 export {};

package/lib/rules/no-entire-object-hook-deps.js

@@ -1167,6 +1167,48 @@ function getObjectUsagesInHook(hookBody, objectName, typeInfo, bodyIsDeferred =
         notUsed,
     };
 }
+/** The run of spaces/tabs opening the line that `offset` sits on. */
+function indentAt(text, offset) {
+    const lineStart = text.lastIndexOf('\n', offset - 1) + 1;
+    return /^[ \t]*/.exec(text.slice(lineStart, offset))?.[0] ?? '';
+}
+/**
+ * Drop `span`, but re-emit any comment standing inside it.
+ *
+ * Removing a dependency means removing its separator too, so the span reaches
+ * to a NEIGHBOURING element and therefore covers the margin between the two.
+ * That margin is not the fixer's to delete: it can hold an
+ * `eslint-disable-next-line` protecting the dependency that survives, and
+ * dropping that directive silently re-enables another rule (#2208). Declining
+ * the fix instead would only trade the lost comment for a transform that a
+ * comment decides (#1877), so the comment is carried rather than obeyed.
+ *
+ * Each carried comment is re-emitted on a line of its own: a `//` comment
+ * swallows whatever follows it on the same line, so folding one inline would
+ * comment out the dependency that was meant to survive.
+ */
+function removeCarryingComments(fixer, sourceCode, span, anchor) {
+    const carried = sourceCode
+        .getAllComments()
+        .filter((comment) => comment.range[0] >= span[0] && comment.range[1] <= span[1]);
+    // With nothing to preserve the span is pure separator and whitespace, so the
+    // plain removal keeps the comment-free output exactly as it has always been.
+    if (carried.length === 0) {
+        return fixer.removeRange(span);
+    }
+    const text = sourceCode.getText();
+    // Anchor the indentation on the end the surviving code sits against.
+    const indent = indentAt(text, anchor === 'toNextElement' ? span[1] : carried[0].range[0]);
+    const body = carried
+        .map((comment) => text.slice(comment.range[0], comment.range[1]))
+        .join(`\n${indent}`);
+    // Both spellings close on a fresh line: whatever the span abutted — the next
+    // dependency, or the separator trailing the last one — would otherwise land
+    // on the final carried comment's line and be commented out.
+    return fixer.replaceTextRange(span, anchor === 'toNextElement'
+        ? `${body}\n${indent}`
+        : `\n${indent}${body}\n${indent}`);
+}
 exports.noEntireObjectHookDeps = (0, createRule_1.createRule)({
     name: 'no-entire-object-hook-deps',
     meta: {
@@ -1213,6 +1255,70 @@ exports.noEntireObjectHookDeps = (0, createRule_1.createRule)({
             return typeInfo;
         }
         const sourceCode = context.getSourceCode();
+        /**
+         * The variable each reference resolves to, keyed by the referencing
+         * identifier NODE rather than by name.
+         *
+         * why: identity keying is what makes the orphan check below immune to
+         * shadowing — a name lookup would resolve an inner `hydrated` against an
+         * outer binding of the same name and read its uses as survivors.
+         */
+        let variableByReference = null;
+        function resolveBinding(identifier) {
+            if (!variableByReference) {
+                variableByReference = new Map();
+                for (const scope of sourceCode.scopeManager?.scopes ?? []) {
+                    for (const variable of scope.variables) {
+                        for (const reference of variable.references) {
+                            variableByReference.set(reference.identifier, variable);
+                        }
+                    }
+                }
+            }
+            return variableByReference.get(identifier) ?? null;
+        }
+        /**
+         * Whether deleting `element` from the dependency array would leave its
+         * binding with no reader left in the file.
+         *
+         * why: a value declared and then read ONLY inside a dependency array is by
+         * construction load-bearing — the declaration would be pointless otherwise
+         * — so removing the entry both discards a deliberate recompute trigger and
+         * strands the declaration. The consumer runs `no-unused-vars` as an error
+         * and builds with `noUnusedLocals`, so the rewrite turns a green file red
+         * on their machine while staying green here. Every sibling instance of this
+         * class was fixed by deleting the stranded declaration too, but that remedy
+         * is unavailable here: the declaration is a hook CALL, and dropping it
+         * changes the component's hook order. Declining the edit is the only safe
+         * remedy, so the report stands and the autofix steps aside.
+         *
+         * Parameters are deliberately exempt. An unread parameter is not an unused
+         * BINDING to either instrument — `no-unused-vars` runs with `args: 'none'`
+         * and `noUnusedLocals` does not cover parameters — so declining there would
+         * withhold a fix without preventing any breakage, and it would silently
+         * settle the reporting question #1621 defers.
+         */
+        function wouldStrandBinding(element) {
+            const identifier = unwrapExpression(element);
+            if (identifier.type !== utils_1.AST_NODE_TYPES.Identifier)
+                return false;
+            const variable = resolveBinding(identifier);
+            if (!variable || variable.defs.length === 0)
+                return false;
+            if (variable.defs.some((def) => def.type === 'Parameter')) {
+                return false;
+            }
+            const [start, end] = element.range;
+            // why: a declarator's own initializer counts as a WRITE reference, so a
+            // survivor test that accepts any reference never fires for `const x = …`
+            // — the shape this check exists for (#1868 is the same trap).
+            return !variable.references.some((reference) => {
+                if (!reference.isRead())
+                    return false;
+                const [from, to] = reference.identifier.range;
+                return from < start || to > end;
+            });
+        }
         // why: scanning every comment once per file rather than once per hook call
         // keeps the check off the hot path of files with many hooks.
         let manuallyManagedLines = null;
@@ -1331,6 +1437,10 @@ exports.noEntireObjectHookDeps = (0, createRule_1.createRule)({
                                     const elementIndex = depsArg.elements.indexOf(element);
                                     if (elementIndex === -1)
                                         return null;
+                                    // The report stands either way; only the rewrite is withheld.
+                                    if (wouldStrandBinding(element)) {
+                                        return null;
+                                    }
                                     // If this is the only element, just remove it
                                     if (depsArg.elements.length === 1) {
                                         return fixer.remove(element);
@@ -1339,21 +1449,19 @@ exports.noEntireObjectHookDeps = (0, createRule_1.createRule)({
                                     if (elementIndex === depsArg.elements.length - 1) {
                                         const prevElement = depsArg.elements[elementIndex - 1];
                                         if (prevElement) {
-                                            const range = [
+                                            return removeCarryingComments(fixer, sourceCode, [
                                                 prevElement.range[1],
                                                 element.range[1],
-                                            ];
-                                            return fixer.removeRange(range);
+                                            ], 'fromPrevElement');
                                         }
                                     }
                                     // Otherwise, remove the element and the following comma
                                     const nextElement = depsArg.elements[elementIndex + 1];
                                     if (nextElement) {
-                                        const range = [
+                                        return removeCarryingComments(fixer, sourceCode, [
                                             element.range[0],
                                             nextElement.range[0],
-                                        ];
-                                        return fixer.removeRange(range);
+                                        ], 'toNextElement');
                                     }
                                     // Fallback to just removing the element
                                     return fixer.remove(element);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.20.188",
+  "version": "1.20.190",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,32 @@
 [
+  {
+    "version": "1.20.190",
+    "date": "2026-08-29T13:41:20.482Z",
+    "rules": [
+      {
+        "name": "no-entire-object-hook-deps",
+        "changeType": "fix",
+        "issues": [
+          2209
+        ],
+        "summary": "decline a removal that strands its binding (closes #2209)"
+      }
+    ]
+  },
+  {
+    "version": "1.20.189",
+    "date": "2026-08-29T11:57:05.586Z",
+    "rules": [
+      {
+        "name": "no-entire-object-hook-deps",
+        "changeType": "fix",
+        "issues": [
+          2208
+        ],
+        "summary": "carry comments in the removed dep's margin (closes #2208)"
+      }
+    ]
+  },
   {
     "version": "1.20.188",
     "date": "2026-08-29T07:11:55.294Z",