@blumintinc/eslint-plugin-blumint 1.20.159 → 1.20.161

package/lib/index.js

@@ -223,7 +223,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.20.159',
+        version: '1.20.161',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/enforce-react-type-naming.js

@@ -191,6 +191,68 @@ const isGlobalConstStyleGoverned = (declarator) => {
     }
     return (!isDynamicValue(init) && !isBindingAlias(init) && !isJestMockCast(init));
 };
+// `as const` is spelled as a `TSTypeReference` named `const`, so it reaches
+// `getTypeName` like any other type name and has to be excluded by name.
+const isAsConstAssertion = (typeAnnotation) => typeAnnotation.type === utils_1.AST_NODE_TYPES.TSTypeReference &&
+    typeAnnotation.typeName.type === utils_1.AST_NODE_TYPES.Identifier &&
+    typeAnnotation.typeName.name === 'const';
+/**
+ * The React type an `as`/`<T>` assertion pins on an initializer, or `undefined`.
+ *
+ * An assertion declares the binding's type exactly as bindingly as an
+ * annotation does — `tsc --emitDeclarationOnly` emits the same
+ * `export declare const config: FC;` for `const config: FC = {} as FC` and for
+ * `const config = {} as FC` — so it is a detection carrier, not decoration.
+ * Reading only the annotation made the shipped config's own `--fix` erase this
+ * rule's report: `no-redundant-annotation-assertion` deletes the redundant
+ * ANNOTATION and keeps the assertion (its fix direction is the type-safe one,
+ * since dropping the assertion instead leaves `const config: FC = {}`, TS2322),
+ * so a reported violation became an unreportable one (Issue #2029).
+ *
+ * Only the OUTERMOST assertion applied to the initializer answers. A nested one
+ * describes a sub-expression rather than the binding: in `(e as FC)()` the
+ * binding holds FC's RETURN value, and in `thing as unknown as FC` the
+ * intermediate `unknown` is discarded by the outer `as FC`. Parentheses need no
+ * handling because TSESTree does not model them, so `({} as FC)` IS the
+ * assertion node; `!` does, and is read through — non-nullability cannot change
+ * which React type names the value.
+ *
+ * `satisfies` is excluded because it leaves the expression's type alone
+ * (`{} satisfies FC` is still `{}`), and `as const` names no React type.
+ */
+const assertedTypeOf = (init) => {
+    let target = init ?? undefined;
+    while (target?.type === utils_1.AST_NODE_TYPES.TSNonNullExpression) {
+        target = target.expression;
+    }
+    if (target?.type !== utils_1.AST_NODE_TYPES.TSAsExpression &&
+        target?.type !== utils_1.AST_NODE_TYPES.TSTypeAssertion) {
+        return undefined;
+    }
+    return isAsConstAssertion(target.typeAnnotation)
+        ? undefined
+        : target.typeAnnotation;
+};
+/**
+ * Reports whether this identifier is the NAME of a JSX element (`<Content />`),
+ * as opposed to a value reference inside one (`{Content}`).
+ *
+ * A JSX element name resolves to a binding only while it starts uppercase: the
+ * scope analyzer models `<content />` as an intrinsic host element instead. So
+ * lowercasing such a name does not carry the reference across — it unbinds it,
+ * leaving the declaration orphaned and an unknown HTML tag rendered in its
+ * place. `JSXMemberExpression` is excluded on purpose: a dot always means value
+ * access, so `<ns.Thing />` keeps resolving whatever the case of `ns`.
+ */
+const isJsxElementName = (node) => {
+    const { parent } = node;
+    if (!parent) {
+        return false;
+    }
+    return ((parent.type === utils_1.AST_NODE_TYPES.JSXOpeningElement ||
+        parent.type === utils_1.AST_NODE_TYPES.JSXClosingElement) &&
+        parent.name === node);
+};
 exports.enforceReactTypeNaming = (0, createRule_1.createRule)({
     name: 'enforce-react-type-naming',
     meta: {
@@ -296,6 +358,28 @@ exports.enforceReactTypeNaming = (0, createRule_1.createRule)({
                 newName,
             });
         }
+        /**
+         * Reports whether lowercasing this variable's name would unbind a
+         * `<Name />` that resolves to it.
+         *
+         * The rename is withheld there and the report stands alone, on the same
+         * terms as a colliding rename: an incomplete rename is worse than none. The
+         * rewritten element would render an intrinsic host tag while the declaration
+         * it used to name sits unreferenced, which is dead code the fix itself
+         * created — and a consumer building with `noUnusedLocals` gets a red CI out
+         * of running `--fix`.
+         *
+         * Asked of variables only. An unused PARAMETER is an ordinary
+         * signature-driven shape rather than dead code, so the parameter rename
+         * stays as #1357 pinned it.
+         */
+        function renameUnbindsJsxElement(owner, declarationId) {
+            const variable = context
+                .getDeclaredVariables(owner)
+                .find((candidate) => candidate.defs.some((def) => def.name === declarationId));
+            return !!variable?.references.some((reference) => reference.identifier !== declarationId &&
+                isJsxElementName(reference.identifier));
+        }
         /**
          * Check variable declarations for React type naming conventions
          */
@@ -313,8 +397,11 @@ exports.enforceReactTypeNaming = (0, createRule_1.createRule)({
             if (isGlobalConstStyleGoverned(node))
                 return;
             const variableName = id.name;
-            // Get the type annotation
-            const typeAnnotation = id.typeAnnotation?.typeAnnotation;
+            // The declared type, from either carrier: the annotation when it is
+            // written, otherwise the assertion that stands in for it (#2029). The
+            // annotation wins when both are present — it is what the binding's type
+            // resolves to — so `const x: unknown = {} as FC` reads `unknown`.
+            const typeAnnotation = id.typeAnnotation?.typeAnnotation ?? assertedTypeOf(node.init);
             const typeName = getTypeName(typeAnnotation);
             if (!typeName)
                 return;
@@ -328,7 +415,9 @@ exports.enforceReactTypeNaming = (0, createRule_1.createRule)({
                         type: typeName,
                         suggestion,
                     },
-                    fix: (fixer) => buildRenameFixes(fixer, node, id, suggestion),
+                    fix: (fixer) => renameUnbindsJsxElement(node, id)
+                        ? null
+                        : buildRenameFixes(fixer, node, id, suggestion),
                 });
             }
             // Check if it's a ComponentType or FC (should be uppercase)
@@ -341,6 +430,8 @@ exports.enforceReactTypeNaming = (0, createRule_1.createRule)({
                         type: typeName,
                         suggestion,
                     },
+                    // Uppercasing cannot unbind a `<Name />`: the target starts uppercase,
+                    // which is exactly what a JSX element name needs to resolve at all.
                     fix: (fixer) => buildRenameFixes(fixer, node, id, suggestion),
                 });
             }

package/lib/rules/require-memo.js

@@ -323,6 +323,44 @@ function buildImportExtensionFix(fixer, program) {
  * that never renders. The report stands, the edit is withheld.
  */
 const isRewritableFunction = (node) => !node.async && !node.generator;
+/**
+ * Whether the call registers the one module factory jest hoists.
+ *
+ * `jest.mock` alone: `babel-plugin-jest-hoist` carries no case for `doMock` or
+ * `setMock`, which exist precisely to run in place, so a factory passed to
+ * either keeps its access to the module's bindings and needs no carve-out.
+ */
+function isHoistedMockCall(node) {
+    const { callee } = node;
+    if (callee.type !== utils_1.AST_NODE_TYPES.MemberExpression || callee.computed) {
+        return false;
+    }
+    const { object, property } = callee;
+    return (object.type === utils_1.AST_NODE_TYPES.Identifier &&
+        object.name === 'jest' &&
+        property.type === utils_1.AST_NODE_TYPES.Identifier &&
+        property.name === 'mock');
+}
+/**
+ * Whether the node sits inside the factory jest hoists — the second argument of
+ * the call. The module specifier that precedes it is evaluated in place and
+ * keeps its access to the file's imports, so only the factory subtree is out of
+ * reach.
+ */
+function isInsideMockFactory(node) {
+    let child = node;
+    let parent = node.parent;
+    while (parent) {
+        if (parent.type === utils_1.AST_NODE_TYPES.CallExpression &&
+            parent.arguments[1] === child &&
+            isHoistedMockCall(parent)) {
+            return true;
+        }
+        child = parent;
+        parent = parent.parent;
+    }
+    return false;
+}
 /**
  * Whether the emitted `memo(...)` call can reach the helper, and the import edit
  * that makes it so (null when the helper is already imported).
@@ -337,6 +375,15 @@ const isRewritableFunction = (node) => !node.async && !node.generator;
  * default import rather than a `memo` binding, so it never reaches this path.
  */
 function planMemoBinding(context, fixer, node) {
+    // Jest hoists a `jest.mock()` factory above the module's imports, so the
+    // helper is unbound when the factory runs and jest rejects the reference
+    // outright ("Invalid variable access: memo"). This holds whether the import
+    // is injected here or already present, so it is decided before the
+    // already-imported shortcut below. The report stands because legal spellings
+    // exist: `import { memo as mockMemo }`, or `jest.requireActual` in-factory.
+    if (isInsideMockFactory(node)) {
+        return { available: false, importFix: null };
+    }
     const existingMemo = ASTHelpers_1.ASTHelpers.findVariableInScope(ASTHelpers_1.ASTHelpers.getScope(context, node), MEMO_NAME);
     if (existingMemo && !bindsMemoHelper(existingMemo)) {
         return { available: false, importFix: null };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.20.159",
+  "version": "1.20.161",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,32 @@
 [
+  {
+    "version": "1.20.161",
+    "date": "2026-08-17T13:22:13.676Z",
+    "rules": [
+      {
+        "name": "enforce-react-type-naming",
+        "changeType": "fix",
+        "issues": [
+          2029
+        ],
+        "summary": "read the type from a type assertion (closes #2029)"
+      }
+    ]
+  },
+  {
+    "version": "1.20.160",
+    "date": "2026-08-17T02:55:06.538Z",
+    "rules": [
+      {
+        "name": "require-memo",
+        "changeType": "fix",
+        "issues": [
+          2028
+        ],
+        "summary": "decline the memo rewrite inside a jest.mock factory (closes #2028)"
+      }
+    ]
+  },
   {
     "version": "1.20.159",
     "date": "2026-08-17T02:05:07.694Z",