@blumintinc/eslint-plugin-blumint 1.20.15 → 1.20.17

package/lib/index.js

@@ -223,7 +223,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.20.15',
+        version: '1.20.17',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/no-mock-firebase-admin.js

@@ -1,14 +1,54 @@
 "use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.noMockFirebaseAdmin = void 0;
+const path_1 = __importDefault(require("path"));
 const utils_1 = require("@typescript-eslint/utils");
 const createRule_1 = require("../utils/createRule");
-const FIREBASE_ADMIN_PATHS = [
-    'firebaseAdmin',
-    'config/firebaseAdmin',
-    'src/config/firebaseAdmin',
-    'functions/src/config/firebaseAdmin',
-];
+const FIREBASE_ADMIN_MODULE = 'firebaseAdmin';
+const MODULE_EXTENSION = /\.(?:tsx?|jsx?|mjs|cjs)$/;
+/**
+ * Backend tier: `jest.setup.node.js` auto-mocks this module repo-wide, so a
+ * local `jest.mock()` bypasses the shared stub the rule exists to protect.
+ */
+const BACKEND_FIREBASE_ADMIN = 'functions/src/config/firebaseAdmin';
+/**
+ * Frontend tier: a distinct module with no shared mock (no `__mocks__` entry,
+ * no `jest.setup.node.js` registration), so nothing is bypassed by mocking it.
+ */
+const FRONTEND_FIREBASE_ADMIN = 'src/config/firebaseAdmin';
+const toPosix = (value) => value.replace(/\\/g, '/');
+const targetsFirebaseAdmin = (mockPath) => {
+    const basename = toPosix(mockPath).split('/').pop() ?? '';
+    return basename.replace(MODULE_EXTENSION, '') === FIREBASE_ADMIN_MODULE;
+};
+const comparisonPathOf = (mockPath, filename) => {
+    // Bare and aliased specifiers (`src/config/firebaseAdmin`,
+    // `@project/functions/src/config/firebaseAdmin`) are resolved by the module
+    // resolver against roots/aliases rather than the importing file, so joining
+    // them onto the file's directory would fabricate a path that never exists.
+    if (!mockPath.startsWith('.')) {
+        return toPosix(mockPath);
+    }
+    return toPosix(path_1.default.resolve(path_1.default.dirname(filename), mockPath));
+};
+const bypassesSharedMock = (comparisonPath) => {
+    // Backend is tested first because the backend path *contains* the frontend
+    // path as a substring; checking frontend first would exempt every backend
+    // mock and silently disable the rule.
+    if (comparisonPath.includes(BACKEND_FIREBASE_ADMIN)) {
+        return true;
+    }
+    if (comparisonPath.includes(FRONTEND_FIREBASE_ADMIN)) {
+        return false;
+    }
+    // A specifier attributable to neither tier keeps the rule's protection:
+    // prefer reporting over silently allowing an unknown layout to shadow a
+    // shared mock.
+    return true;
+};
 exports.noMockFirebaseAdmin = (0, createRule_1.createRule)({
     name: 'no-mock-firebase-admin',
     meta: {
@@ -43,26 +83,31 @@ exports.noMockFirebaseAdmin = (0, createRule_1.createRule)({
                         node.arguments[0].type === utils_1.AST_NODE_TYPES.TemplateLiteral)) {
                     let mockPath = '';
                     if (node.arguments[0].type === utils_1.AST_NODE_TYPES.TemplateLiteral) {
+                        // An interpolated specifier names a module only known at runtime:
+                        // `../../config/firebaseAdmin${env}` targets firebaseAdminStaging,
+                        // not firebaseAdmin. Reading the leading quasi alone would attribute
+                        // it to whichever module the static prefix happens to spell.
+                        if (node.arguments[0].expressions.length > 0) {
+                            return;
+                        }
                         mockPath = node.arguments[0].quasis[0].value.raw;
                     }
                     else if (node.arguments[0].type === utils_1.AST_NODE_TYPES.Literal) {
                         mockPath = String(node.arguments[0].value);
                     }
-                    const isFirebaseAdminMock = FIREBASE_ADMIN_PATHS.some((path) => mockPath.endsWith(path) &&
-                        !mockPath.endsWith('Helper') &&
-                        !mockPath.endsWith('utils') &&
-                        !mockPath.endsWith('test') &&
-                        !mockPath.endsWith('mock') &&
-                        !mockPath.endsWith('jest-mock'));
-                    if (isFirebaseAdminMock) {
-                        context.report({
-                            node,
-                            messageId: 'noMockFirebaseAdmin',
-                            data: {
-                                modulePath: mockPath,
-                            },
-                        });
+                    if (!targetsFirebaseAdmin(mockPath)) {
+                        return;
                     }
+                    if (!bypassesSharedMock(comparisonPathOf(mockPath, filename))) {
+                        return;
+                    }
+                    context.report({
+                        node,
+                        messageId: 'noMockFirebaseAdmin',
+                        data: {
+                            modulePath: mockPath,
+                        },
+                    });
                 }
             },
         };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.20.15",
+  "version": "1.20.17",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,32 @@
 [
+  {
+    "version": "1.20.17",
+    "date": "2026-07-29T10:47:56.581Z",
+    "rules": [
+      {
+        "name": "no-mock-firebase-admin",
+        "changeType": "fix",
+        "issues": [
+          1386
+        ],
+        "summary": "skip interpolated jest.mock specifiers (closes #1386)"
+      }
+    ]
+  },
+  {
+    "version": "1.20.16",
+    "date": "2026-07-29T10:30:50.111Z",
+    "rules": [
+      {
+        "name": "no-mock-firebase-admin",
+        "changeType": "fix",
+        "issues": [
+          1385
+        ],
+        "summary": "resolve specifier tier before flagging (closes #1385)"
+      }
+    ]
+  },
   {
     "version": "1.20.15",
     "date": "2026-07-29T08:50:35.880Z",