@blumintinc/eslint-plugin-blumint 1.20.149 → 1.20.150

package/lib/index.js

@@ -223,7 +223,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.20.149',
+        version: '1.20.150',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/enforce-exported-function-types.js

@@ -748,35 +748,6 @@ exports.enforceExportedFunctionTypes = (0, createRule_1.createRule)({
                     return;
                 checkComponentProps(component.fn);
             },
-            // Skip type checking for React components since we handle them separately
-            'FunctionDeclaration[id.name=/^[A-Z]/] > TSTypeAnnotation'() { },
-            'FunctionDeclaration[id.name=/^[A-Z]/] > TSTypeAnnotation > TSTypeReference'() { },
-            'VariableDeclarator[id.name=/^[A-Z]/] > ArrowFunctionExpression > TSTypeAnnotation'() { },
-            'VariableDeclarator[id.name=/^[A-Z]/] > ArrowFunctionExpression > TSTypeAnnotation > TSTypeReference'() { },
-            'FunctionDeclaration[id.name=/^[A-Z]/] > Identifier[typeAnnotation] > TSTypeAnnotation'() { },
-            'VariableDeclarator[id.name=/^[A-Z]/] > ArrowFunctionExpression > Identifier[typeAnnotation] > TSTypeAnnotation'() { },
-            'FunctionDeclaration[id.name=/^[A-Z]/] > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference'() { },
-            'VariableDeclarator[id.name=/^[A-Z]/] > ArrowFunctionExpression > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference'() { },
-            'FunctionDeclaration[id.name=/^[A-Z]/] > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > Identifier'() { },
-            'VariableDeclarator[id.name=/^[A-Z]/] > ArrowFunctionExpression > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > Identifier'() { },
-            'FunctionDeclaration[id.name=/^[A-Z]/] > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName'() { },
-            'VariableDeclarator[id.name=/^[A-Z]/] > ArrowFunctionExpression > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName'() { },
-            'FunctionDeclaration[id.name=/^[A-Z]/] > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName > Identifier'() { },
-            'VariableDeclarator[id.name=/^[A-Z]/] > ArrowFunctionExpression > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName > Identifier'() { },
-            'FunctionDeclaration[id.name=/^[A-Z]/] > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName > TSQualifiedName'() { },
-            'VariableDeclarator[id.name=/^[A-Z]/] > ArrowFunctionExpression > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName > TSQualifiedName'() { },
-            'FunctionDeclaration[id.name=/^[A-Z]/] > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName > TSQualifiedName > Identifier'() { },
-            'VariableDeclarator[id.name=/^[A-Z]/] > ArrowFunctionExpression > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName > TSQualifiedName > Identifier'() { },
-            'FunctionDeclaration[id.name=/^[A-Z]/] > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName > TSQualifiedName > TSQualifiedName'() { },
-            'VariableDeclarator[id.name=/^[A-Z]/] > ArrowFunctionExpression > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName > TSQualifiedName > TSQualifiedName'() { },
-            'FunctionDeclaration[id.name=/^[A-Z]/] > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName > TSQualifiedName > TSQualifiedName > Identifier'() { },
-            'VariableDeclarator[id.name=/^[A-Z]/] > ArrowFunctionExpression > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName > TSQualifiedName > TSQualifiedName > Identifier'() { },
-            'FunctionDeclaration[id.name=/^[A-Z]/] > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName > TSQualifiedName > TSQualifiedName > TSQualifiedName'() { },
-            'VariableDeclarator[id.name=/^[A-Z]/] > ArrowFunctionExpression > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName > TSQualifiedName > TSQualifiedName > TSQualifiedName'() { },
-            'FunctionDeclaration[id.name=/^[A-Z]/] > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName > TSQualifiedName > TSQualifiedName > TSQualifiedName > Identifier'() { },
-            'VariableDeclarator[id.name=/^[A-Z]/] > ArrowFunctionExpression > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName > TSQualifiedName > TSQualifiedName > TSQualifiedName > Identifier'() { },
-            'FunctionDeclaration[id.name=/^[A-Z]/] > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName > TSQualifiedName > TSQualifiedName > TSQualifiedName > TSQualifiedName'() { },
-            'VariableDeclarator[id.name=/^[A-Z]/] > ArrowFunctionExpression > Identifier[typeAnnotation] > TSTypeAnnotation > TSTypeReference > TSQualifiedName > TSQualifiedName > TSQualifiedName > TSQualifiedName > TSQualifiedName'() { },
         };
     },
 });

package/lib/rules/enforce-querykey-ts.js

@@ -385,6 +385,16 @@ exports.enforceQueryKeyTs = (0, createRule_1.createRule)({
          * Track variable assignments to detect variables derived from query key constants
          */
         const variableAssignments = new Map();
+        /**
+         * Names whose declaration leaves them holding `undefined` — `let key;` and
+         * `let key = undefined;` alike. Both falsy and nullish, which is what makes
+         * a later `||=`/`??=` onto one of them assign unconditionally.
+         */
+        const declaredUndefined = new Set();
+        /** Declarations and assignments seen per name, to bound the above to the provable case. */
+        const declarationCounts = new Map();
+        const assignmentCounts = new Map();
+        const isUndefinedIdentifier = (node) => node.type === utils_1.AST_NODE_TYPES.Identifier && node.name === 'undefined';
         /**
          * Check if a node represents a valid query key usage
          */
@@ -631,13 +641,45 @@ exports.enforceQueryKeyTs = (0, createRule_1.createRule)({
             },
             // Track variable declarations that might derive from query key constants
             VariableDeclarator(node) {
-                if (node.id.type === utils_1.AST_NODE_TYPES.Identifier && node.init) {
-                    variableAssignments.set(node.id.name, node.init);
+                if (node.id.type !== utils_1.AST_NODE_TYPES.Identifier)
+                    return;
+                const { name } = node.id;
+                declarationCounts.set(name, (declarationCounts.get(name) ?? 0) + 1);
+                if (node.init) {
+                    variableAssignments.set(name, node.init);
+                }
+                if (!node.init || isUndefinedIdentifier(node.init)) {
+                    declaredUndefined.add(name);
                 }
             },
             AssignmentExpression(node) {
-                if (node.left.type === utils_1.AST_NODE_TYPES.Identifier && node.right) {
-                    variableAssignments.set(node.left.name, node.right);
+                if (node.left.type !== utils_1.AST_NODE_TYPES.Identifier)
+                    return;
+                const { name } = node.left;
+                const assignmentCount = (assignmentCounts.get(name) ?? 0) + 1;
+                assignmentCounts.set(name, assignmentCount);
+                // Only a plain `=` makes the right-hand side the variable's value in
+                // general. A compound assignment leaves the prior value reachable
+                // (`key ||= K` is the old key OR K), so recording the operand would
+                // launder an unapproved key into an approved one.
+                if (node.operator === '=') {
+                    variableAssignments.set(name, node.right);
+                    return;
+                }
+                // The exception is a `||=`/`??=` onto a variable still holding
+                // `undefined`, which is both falsy and nullish: the assignment always
+                // happens, so the operand IS the value. A single declaration and a
+                // single assignment are what keep that provable — a second assignment
+                // anywhere puts a prior value back in play. `+=` is excluded because it
+                // concatenates onto `undefined` and yields neither operand.
+                //
+                // The operand is recorded rather than exempted, so it still has to be
+                // an approved constant to pass.
+                if ((node.operator === '||=' || node.operator === '??=') &&
+                    declaredUndefined.has(name) &&
+                    declarationCounts.get(name) === 1 &&
+                    assignmentCount === 1) {
+                    variableAssignments.set(name, node.right);
                 }
             },
             // Check useRouterState calls

package/lib/rules/no-type-assertion-returns.js

@@ -352,10 +352,6 @@ exports.noTypeAssertionReturns = (0, createRule_1.createRule)({
                     checkFunctionReturnType(node);
                 }
             },
-            // Check for array methods with type assertions
-            CallExpression() {
-                // Skip this check as we'll handle it in the TSAsExpression and TSTypeAssertion handlers
-            },
             // Check for type assertions in expressions
             TSAsExpression(node) {
                 // Allow 'as const' assertions if configured

package/lib/rules/prefer-global-router-state-key.js

@@ -122,6 +122,16 @@ exports.preferGlobalRouterStateKey = (0, createRule_1.createRule)({
         const defaultImports = new Map();
         // Track re-exports and variable assignments
         const variableAssignments = new Map();
+        /**
+         * Names whose declaration leaves them holding `undefined` — `let key;` and
+         * `let key = undefined;` alike. Both falsy and nullish, which is what makes
+         * a later `||=`/`??=` onto one of them assign unconditionally.
+         */
+        const declaredUndefined = new Set();
+        /** Declarations and assignments seen per name, to bound the above to the provable case. */
+        const declarationCounts = new Map();
+        const assignmentCounts = new Map();
+        const isUndefinedIdentifier = (node) => node.type === utils_1.AST_NODE_TYPES.Identifier && node.name === 'undefined';
         const validQueryKeySources = new Set([
             'util/routing/queryKeys',
             'constants',
@@ -444,15 +454,46 @@ exports.preferGlobalRouterStateKey = (0, createRule_1.createRule)({
             },
             // Track variable declarations that might derive from query key constants
             VariableDeclarator(node) {
-                if (node.id.type === utils_1.AST_NODE_TYPES.Identifier && node.init) {
-                    variableAssignments.set(node.id.name, node.init);
+                if (node.id.type !== utils_1.AST_NODE_TYPES.Identifier)
+                    return;
+                const { name } = node.id;
+                declarationCounts.set(name, (declarationCounts.get(name) ?? 0) + 1);
+                if (node.init) {
+                    variableAssignments.set(name, node.init);
+                }
+                if (!node.init || isUndefinedIdentifier(node.init)) {
+                    declaredUndefined.add(name);
                 }
             },
             // Track assignment expressions
             AssignmentExpression(node) {
-                if (node.left.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    node.operator === '=') {
-                    variableAssignments.set(node.left.name, node.right);
+                if (node.left.type !== utils_1.AST_NODE_TYPES.Identifier)
+                    return;
+                const { name } = node.left;
+                const assignmentCount = (assignmentCounts.get(name) ?? 0) + 1;
+                assignmentCounts.set(name, assignmentCount);
+                // Only a plain `=` makes the right-hand side the variable's value in
+                // general. A compound assignment leaves the prior value reachable
+                // (`key ||= K` is the old key OR K), so recording the operand would
+                // launder an unapproved key into an approved one.
+                if (node.operator === '=') {
+                    variableAssignments.set(name, node.right);
+                    return;
+                }
+                // The exception is a `||=`/`??=` onto a variable still holding
+                // `undefined`, which is both falsy and nullish: the assignment always
+                // happens, so the operand IS the value. A single declaration and a
+                // single assignment are what keep that provable — a second assignment
+                // anywhere puts a prior value back in play. `+=` is excluded because it
+                // concatenates onto `undefined` and yields neither operand.
+                //
+                // The operand is recorded rather than exempted, so it still has to be
+                // an approved constant to pass.
+                if ((node.operator === '||=' || node.operator === '??=') &&
+                    declaredUndefined.has(name) &&
+                    declarationCounts.get(name) === 1 &&
+                    assignmentCount === 1) {
+                    variableAssignments.set(name, node.right);
                 }
             },
             // Check useRouterState calls

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.20.149",
+  "version": "1.20.150",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,43 @@
 [
+  {
+    "version": "1.20.150",
+    "date": "2026-08-13T19:12:01.840Z",
+    "rules": [
+      {
+        "name": "enforce-exported-function-types",
+        "changeType": "fix",
+        "issues": [
+          2000
+        ],
+        "summary": "drop 28 inert empty-bodied selectors (closes #2000)"
+      },
+      {
+        "name": "enforce-querykey-ts",
+        "changeType": "fix",
+        "issues": [
+          1999,
+          2001
+        ],
+        "summary": "follow a `||=`/`??=` onto an undefined key (#2001); guard variable tracking on a plain `=` assignment (closes #1999)"
+      },
+      {
+        "name": "no-type-assertion-returns",
+        "changeType": "fix",
+        "issues": [
+          2002
+        ],
+        "summary": "drop the inert empty CallExpression handler (closes #2002)"
+      },
+      {
+        "name": "prefer-global-router-state-key",
+        "changeType": "fix",
+        "issues": [
+          2001
+        ],
+        "summary": "follow a `||=`/`??=` onto an undefined key (closes #2001)"
+      }
+    ]
+  },
   {
     "version": "1.20.149",
     "date": "2026-08-13T16:22:27.196Z",