@blumintinc/eslint-plugin-blumint 1.19.4 → 1.19.6

package/lib/index.js

@@ -222,7 +222,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.19.4',
+        version: '1.19.6',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/no-redundant-this-params.js

@@ -77,8 +77,45 @@ exports.noRedundantThisParams = (0, createRule_1.createRule)({
             }
             return [];
         }
+        function isExportedClass(node) {
+            const parent = node.parent;
+            if (!parent) {
+                return false;
+            }
+            if (parent.type === utils_1.AST_NODE_TYPES.ExportNamedDeclaration ||
+                parent.type === utils_1.AST_NODE_TYPES.ExportDefaultDeclaration) {
+                return true;
+            }
+            // `export const Foo = class { ... }` exposes the class expression to other
+            // files just as an exported declaration does.
+            if (node.type === utils_1.AST_NODE_TYPES.ClassExpression &&
+                parent.type === utils_1.AST_NODE_TYPES.VariableDeclarator) {
+                const declaration = parent.parent;
+                const exportNode = declaration?.parent;
+                return (exportNode?.type === utils_1.AST_NODE_TYPES.ExportNamedDeclaration ||
+                    exportNode?.type === utils_1.AST_NODE_TYPES.ExportDefaultDeclaration);
+            }
+            return false;
+        }
         function collectClassInfo(node) {
             const methods = new Map();
+            // A method's `this.method(...)` call sites are confined to this file only
+            // when the class cannot be extended from another file. An `abstract` class
+            // exists to be subclassed, and an exported class can be subclassed
+            // anywhere; either way subclasses may call an inherited non-private method
+            // with a different `this.<member>`, so those methods are externally
+            // reachable and must not be reported. See issue #1309.
+            const classIsExtensible = Boolean(node.abstract) ||
+                isExportedClass(node);
+            function computeExternallyReachable(methodName, accessibility) {
+                if (!classIsExtensible) {
+                    return false;
+                }
+                // `private` (TS) and `#name` (ECMAScript) methods are never inherited,
+                // so all of their call sites live in the declaring class body.
+                const isPrivate = accessibility === 'private' || methodName.startsWith('#');
+                return !isPrivate;
+            }
             function setMethod(methodName, meta) {
                 /**
                  * Prefer instance methods over static methods when names collide.
@@ -102,7 +139,14 @@ exports.noRedundantThisParams = (0, createRule_1.createRule)({
             for (const member of node.body.body) {
                 if (member.type === utils_1.AST_NODE_TYPES.MethodDefinition ||
                     member.type === utils_1.AST_NODE_TYPES.TSAbstractMethodDefinition) {
-                    if (member.kind === 'constructor') {
+                    // Only genuine methods (`kind: 'method'`) are invoked directly as
+                    // `this.x(args)`. A `get`/`set` accessor is also a MethodDefinition,
+                    // but `this.accessor(args)` evaluates the accessor with zero arguments
+                    // and then calls its RETURN VALUE — so when that value is an
+                    // externally-supplied function it legitimately needs instance state
+                    // threaded in, and flagging it is a false positive (issue #1308). The
+                    // constructor is likewise never called as `this.constructor(...)`.
+                    if (member.kind !== 'method') {
                         continue;
                     }
                     const methodName = getNameFromPropertyName(member.key);
@@ -113,6 +157,7 @@ exports.noRedundantThisParams = (0, createRule_1.createRule)({
                         params: getMethodParams(member),
                         isStatic: Boolean(member.static),
                         isAbstract: member.type === utils_1.AST_NODE_TYPES.TSAbstractMethodDefinition,
+                        externallyReachable: computeExternallyReachable(methodName, member.accessibility),
                     });
                 }
                 else if (member.type === utils_1.AST_NODE_TYPES.PropertyDefinition) {
@@ -130,6 +175,7 @@ exports.noRedundantThisParams = (0, createRule_1.createRule)({
                         params,
                         isStatic: false,
                         isAbstract: false,
+                        externallyReachable: computeExternallyReachable(methodName, member.accessibility),
                     });
                 }
             }
@@ -425,6 +471,12 @@ exports.noRedundantThisParams = (0, createRule_1.createRule)({
                         for (const [, propStats] of argProperties) {
                             if (propStats.callsWithProperty === methodStats.totalCalls) {
                                 for (const violation of propStats.violations) {
+                                    // Skip methods whose call sites are not provably confined to
+                                    // this file: a subclass elsewhere may thread a different
+                                    // `this.<member>` through the same parameter (issue #1309).
+                                    if (violation.methodMeta.externallyReachable) {
+                                        continue;
+                                    }
                                     reportAccess(methodName, violation.methodMeta, argIndex, violation.access);
                                 }
                             }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.19.4",
+  "version": "1.19.6",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,32 @@
 [
+  {
+    "version": "1.19.6",
+    "date": "2026-07-16T01:27:07.130Z",
+    "rules": [
+      {
+        "name": "no-redundant-this-params",
+        "changeType": "fix",
+        "issues": [
+          1309
+        ],
+        "summary": "skip externally-reachable methods (closes #1309)"
+      }
+    ]
+  },
+  {
+    "version": "1.19.5",
+    "date": "2026-07-15T15:24:16.132Z",
+    "rules": [
+      {
+        "name": "no-redundant-this-params",
+        "changeType": "fix",
+        "issues": [
+          1308
+        ],
+        "summary": "skip get/set accessors when resolving callees (closes #1308)"
+      }
+    ]
+  },
   {
     "version": "1.19.4",
     "date": "2026-07-14T18:24:36.895Z",