@blumintinc/eslint-plugin-blumint 1.19.32 → 1.20.1

package/README.md

@@ -196,6 +196,7 @@ full closed loop is documented in agora's `.claude/skills/eslint-autonomy/SKILL.
 | [no-redundant-param-types](docs/rules/no-redundant-param-types.md)                                           | Disallow redundant parameter type annotations                                                                                                                                                                                                                                                                                                                                                    | ✅  |    |    | 🔧 |    |    |
 | [no-redundant-this-params](docs/rules/no-redundant-this-params.md)                                           | Disallow passing class instance members (this.foo) into class instance methods; access the member from this inside the method instead.                                                                                                                                                                                                                                                           | ✅  |    |    |    |    |    |
 | [no-redundant-usecallback-wrapper](docs/rules/no-redundant-usecallback-wrapper.md)                           | Prevent wrapping already memoized/stable callbacks from hooks/contexts in an extra useCallback()                                                                                                                                                                                                                                                                                                 | ✅  |    |    | 🔧 |    |    |
+| [no-render-function-components](docs/rules/no-render-function-components.md)                                 | Disallow declaring a local `render*` function that returns JSX and consuming it as a plain function (direct call or array-iteration callback); author it as a real component rendered with JSX instead                                                                                                                                                                                           | ✅  |    |    |    |    |    |
 | [no-res-error-status-in-onrequest](docs/rules/no-res-error-status-in-onrequest.md)                           | Forbid sending 4xx/5xx Express responses inside onRequest handlers; throw structured HttpsError instances instead so the wrapper can format, log, and map errors consistently.                                                                                                                                                                                                                   | ✅  |    |    |    |    |    |
 | [no-restricted-properties-fix](docs/rules/no-restricted-properties-fix.md)                                   | Disallow certain properties on certain objects, with special handling for Object.keys() and Object.values()                                                                                                                                                                                                                                                                                      |    |    |    | 🔧 |    |    |
 | [no-satisfies-in-frontend-bundle](docs/rules/no-satisfies-in-frontend-bundle.md)                             | Disallow the `satisfies` operator in files that reach the frontend webpack bundle (Next.js 12 SWC cannot parse it)                                                                                                                                                                                                                                                                               | ✅  |    |    |    |    |    |

package/lib/index.js

@@ -196,6 +196,7 @@ const no_single_dismiss_dialog_button_1 = require("./rules/no-single-dismiss-dia
 const no_portal_inside_tooltip_1 = require("./rules/no-portal-inside-tooltip");
 const no_satisfies_in_frontend_bundle_1 = require("./rules/no-satisfies-in-frontend-bundle");
 const prefer_utility_function_own_file_1 = require("./rules/prefer-utility-function-own-file");
+const no_render_function_components_1 = require("./rules/no-render-function-components");
 const NO_FRONTEND_IMPORTS_FROM_FUNCTIONS_MESSAGE = 'Backend Cloud Functions (.f.ts under functions/) must not import frontend modules from the repo root src/**. Frontend code can depend on browser-only APIs and bundling it into Cloud Functions breaks server execution; move shared logic into functions/src or a shared package.';
 function noFrontendImportsFromFunctionsPatterns(pattern) {
     return [
@@ -222,7 +223,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.19.32',
+        version: '1.20.1',
     },
     parseOptions: {
         ecmaVersion: 2020,
@@ -424,6 +425,7 @@ module.exports = {
                 '@blumintinc/blumint/no-portal-inside-tooltip': 'error',
                 '@blumintinc/blumint/no-satisfies-in-frontend-bundle': 'error',
                 '@blumintinc/blumint/prefer-utility-function-own-file': 'error',
+                '@blumintinc/blumint/no-render-function-components': 'error',
             },
             /**
              * Depth-specific overrides block only import strings that traverse to the
@@ -700,6 +702,7 @@ module.exports = {
         'no-portal-inside-tooltip': no_portal_inside_tooltip_1.noPortalInsideTooltip,
         'no-satisfies-in-frontend-bundle': no_satisfies_in_frontend_bundle_1.noSatisfiesInFrontendBundle,
         'prefer-utility-function-own-file': prefer_utility_function_own_file_1.preferUtilityFunctionOwnFile,
+        'no-render-function-components': no_render_function_components_1.noRenderFunctionComponents,
     },
 };
 //# sourceMappingURL=index.js.map

package/lib/rules/enforce-boolean-naming-prefixes.js

@@ -296,7 +296,7 @@ exports.enforceBooleanNamingPrefixes = (0, createRule_1.createRule)({
                         if (lowerCallee.startsWith('assert')) {
                             return identifierReturnsBoolean(calleeName);
                         }
-                        return isPrefixedByBooleanKeyword(calleeName, approvedPrefixesWithoutAsserts);
+                        return calleeNameImpliesBoolean(calleeName, approvedPrefixesWithoutAsserts);
                     }
                     // Default to false for other cases with || to avoid false positives
                     return false;
@@ -316,7 +316,7 @@ exports.enforceBooleanNamingPrefixes = (0, createRule_1.createRule)({
                         return identifierReturnsBoolean(calleeName);
                     }
                     // Check if the function name suggests it returns a boolean
-                    return isPrefixedByBooleanKeyword(calleeName, approvedPrefixes.filter((p) => p !== 'asserts'));
+                    return calleeNameImpliesBoolean(calleeName, approvedPrefixesWithoutAsserts);
                 }
             }
             return false;
@@ -418,7 +418,12 @@ exports.enforceBooleanNamingPrefixes = (0, createRule_1.createRule)({
                 ];
                 const matchesPrefix = isPrefixedByBooleanKeyword(calleeName, calleeBooleanPrefixes);
                 if (matchesPrefix) {
-                    return 'boolean';
+                    // The callee's declaration outranks its name: a resolvable predicate
+                    // that demonstrably returns a verdict object, a string or a Promise
+                    // yields a non-boolean value no matter how it is named.
+                    return calleeReturnEvaluation(calleeName) === 'nonBoolean'
+                        ? 'nonBoolean'
+                        : 'boolean';
                 }
                 if (lowerCallee.startsWith('get') ||
                     lowerCallee.startsWith('fetch') ||
@@ -565,6 +570,238 @@ exports.enforceBooleanNamingPrefixes = (0, createRule_1.createRule)({
             }
             return false;
         }
+        // Predicates that call themselves (or each other) would otherwise recurse
+        // forever while their returns are classified.
+        const calleesUnderEvaluation = new Set();
+        const NON_BOOLEAN_TYPE_KEYWORDS = new Set([
+            utils_1.AST_NODE_TYPES.TSStringKeyword,
+            utils_1.AST_NODE_TYPES.TSNumberKeyword,
+            utils_1.AST_NODE_TYPES.TSBigIntKeyword,
+            utils_1.AST_NODE_TYPES.TSSymbolKeyword,
+            utils_1.AST_NODE_TYPES.TSObjectKeyword,
+            utils_1.AST_NODE_TYPES.TSVoidKeyword,
+            utils_1.AST_NODE_TYPES.TSNullKeyword,
+            utils_1.AST_NODE_TYPES.TSUndefinedKeyword,
+            utils_1.AST_NODE_TYPES.TSTypeLiteral,
+            utils_1.AST_NODE_TYPES.TSArrayType,
+            utils_1.AST_NODE_TYPES.TSTupleType,
+            utils_1.AST_NODE_TYPES.TSFunctionType,
+            utils_1.AST_NODE_TYPES.TSConstructorType,
+            utils_1.AST_NODE_TYPES.TSIntersectionType,
+            utils_1.AST_NODE_TYPES.TSTemplateLiteralType,
+            utils_1.AST_NODE_TYPES.TSMappedType,
+        ]);
+        const NON_BOOLEAN_EXPRESSION_TYPES = new Set([
+            utils_1.AST_NODE_TYPES.ObjectExpression,
+            utils_1.AST_NODE_TYPES.ArrayExpression,
+            utils_1.AST_NODE_TYPES.TemplateLiteral,
+            utils_1.AST_NODE_TYPES.TaggedTemplateExpression,
+            utils_1.AST_NODE_TYPES.ArrowFunctionExpression,
+            utils_1.AST_NODE_TYPES.FunctionExpression,
+            utils_1.AST_NODE_TYPES.ClassExpression,
+            utils_1.AST_NODE_TYPES.NewExpression,
+            utils_1.AST_NODE_TYPES.UpdateExpression,
+            utils_1.AST_NODE_TYPES.JSXElement,
+            utils_1.AST_NODE_TYPES.JSXFragment,
+        ]);
+        // `as const` preserves the operand's shape, so the assertion says nothing
+        // about booleanness and the operand must be classified instead.
+        function isConstAssertion(typeNode) {
+            return (typeNode.type === utils_1.AST_NODE_TYPES.TSTypeReference &&
+                typeNode.typeName.type === utils_1.AST_NODE_TYPES.Identifier &&
+                typeNode.typeName.name === 'const');
+        }
+        function classifyTypeAnnotation(typeNode) {
+            if (typeNode.type === utils_1.AST_NODE_TYPES.TSBooleanKeyword ||
+                typeNode.type === utils_1.AST_NODE_TYPES.TSTypePredicate) {
+                return 'boolean';
+            }
+            if (typeNode.type === utils_1.AST_NODE_TYPES.TSLiteralType) {
+                const literal = typeNode.literal;
+                return literal.type === utils_1.AST_NODE_TYPES.Literal &&
+                    typeof literal.value === 'boolean'
+                    ? 'boolean'
+                    : 'nonBoolean';
+            }
+            if (typeNode.type === utils_1.AST_NODE_TYPES.TSUnionType) {
+                const members = typeNode.types.map(classifyTypeAnnotation);
+                if (members.every((member) => member === 'boolean')) {
+                    return 'boolean';
+                }
+                // A union that mixes boolean with anything else cannot be trusted to
+                // hold a boolean; the repository prefers false negatives here.
+                return members.some((member) => member === 'nonBoolean')
+                    ? 'nonBoolean'
+                    : 'indeterminate';
+            }
+            if (typeNode.type === utils_1.AST_NODE_TYPES.TSTypeReference) {
+                if (typeNode.typeName.type === utils_1.AST_NODE_TYPES.Identifier &&
+                    typeNode.typeName.name === 'Boolean') {
+                    return 'boolean';
+                }
+                // Named types (including `Promise<boolean>`, whose call site yields a
+                // promise rather than a boolean) are treated as non-boolean values.
+                return 'nonBoolean';
+            }
+            if (NON_BOOLEAN_TYPE_KEYWORDS.has(typeNode.type)) {
+                return 'nonBoolean';
+            }
+            // `any`, `unknown`, generics, conditional and indexed-access types carry
+            // no reliable syntactic verdict.
+            return 'indeterminate';
+        }
+        function classifyReturnExpression(expression) {
+            // A bare `return;` (or a fall-through) produces undefined.
+            if (!expression)
+                return 'nonBoolean';
+            if (expression.type === utils_1.AST_NODE_TYPES.TSAsExpression ||
+                expression.type === utils_1.AST_NODE_TYPES.TSSatisfiesExpression ||
+                expression.type === utils_1.AST_NODE_TYPES.TSTypeAssertion) {
+                const annotation = expression.typeAnnotation;
+                if (annotation && !isConstAssertion(annotation)) {
+                    const classified = classifyTypeAnnotation(annotation);
+                    if (classified !== 'indeterminate') {
+                        return classified;
+                    }
+                }
+                return classifyReturnExpression(expression.expression);
+            }
+            if (expression.type === utils_1.AST_NODE_TYPES.ChainExpression ||
+                expression.type === utils_1.AST_NODE_TYPES.TSNonNullExpression) {
+                return classifyReturnExpression(expression.expression);
+            }
+            if (expression.type === utils_1.AST_NODE_TYPES.SequenceExpression) {
+                return classifyReturnExpression(expression.expressions[expression.expressions.length - 1]);
+            }
+            if (NON_BOOLEAN_EXPRESSION_TYPES.has(expression.type)) {
+                return 'nonBoolean';
+            }
+            if (expression.type === utils_1.AST_NODE_TYPES.Literal) {
+                return typeof expression.value === 'boolean' ? 'boolean' : 'nonBoolean';
+            }
+            if (expression.type === utils_1.AST_NODE_TYPES.Identifier &&
+                expression.name === 'undefined') {
+                return 'nonBoolean';
+            }
+            if (expression.type === utils_1.AST_NODE_TYPES.UnaryExpression) {
+                if (expression.operator === '!' || expression.operator === 'delete') {
+                    return 'boolean';
+                }
+                return 'nonBoolean';
+            }
+            if (expression.type === utils_1.AST_NODE_TYPES.BinaryExpression &&
+                !BOOLEANISH_BINARY_OPERATORS.has(expression.operator)) {
+                return 'nonBoolean';
+            }
+            // Branching expressions are classified from their branches so a mix of a
+            // boolean and an object (or two objects) is recognized as non-boolean.
+            if (expression.type === utils_1.AST_NODE_TYPES.ConditionalExpression) {
+                return combineClassifications([
+                    classifyReturnExpression(expression.consequent),
+                    classifyReturnExpression(expression.alternate),
+                ]);
+            }
+            if (expression.type === utils_1.AST_NODE_TYPES.LogicalExpression) {
+                return combineClassifications([
+                    classifyReturnExpression(expression.left),
+                    classifyReturnExpression(expression.right),
+                ]);
+            }
+            const evaluation = evaluateBooleanishExpression(expression);
+            if (evaluation === 'boolean')
+                return 'boolean';
+            if (evaluation === 'nonBoolean')
+                return 'nonBoolean';
+            return 'indeterminate';
+        }
+        function combineClassifications(classifications) {
+            if (classifications.length === 0)
+                return 'indeterminate';
+            if (classifications.every((entry) => entry === 'boolean')) {
+                return 'boolean';
+            }
+            return classifications.some((entry) => entry === 'nonBoolean')
+                ? 'nonBoolean'
+                : 'indeterminate';
+        }
+        function classifyFunctionReturn(functionLike) {
+            const annotation = functionLike.returnType?.typeAnnotation;
+            if (annotation) {
+                const classified = classifyTypeAnnotation(annotation);
+                if (classified !== 'indeterminate') {
+                    return classified;
+                }
+            }
+            // Calling an async or generator function hands back a promise or an
+            // iterator, never the boolean produced inside the body.
+            if (functionLike.async || functionLike.generator) {
+                return 'nonBoolean';
+            }
+            if (functionLike.type === utils_1.AST_NODE_TYPES.ArrowFunctionExpression &&
+                functionLike.expression) {
+                return classifyReturnExpression(functionLike.body);
+            }
+            // Overload signatures and ambient declarations expose no body to inspect.
+            if (functionLike.body?.type !== utils_1.AST_NODE_TYPES.BlockStatement) {
+                return 'indeterminate';
+            }
+            const returnArguments = collectReturnArguments(functionLike.body);
+            if (returnArguments.length === 0) {
+                return 'nonBoolean';
+            }
+            return combineClassifications(returnArguments.map(classifyReturnExpression));
+        }
+        function functionOfDefinition(definition) {
+            if (definition.type === 'FunctionName') {
+                return definition.node;
+            }
+            if (definition.type === 'Variable') {
+                const init = definition.node
+                    .init;
+                if (init?.type === utils_1.AST_NODE_TYPES.ArrowFunctionExpression ||
+                    init?.type === utils_1.AST_NODE_TYPES.FunctionExpression) {
+                    return init;
+                }
+            }
+            return undefined;
+        }
+        /**
+         * Resolve a callee identifier through the scope chain and classify the value
+         * its calls produce, without a type checker.
+         */
+        function calleeReturnEvaluation(name) {
+            if (calleesUnderEvaluation.has(name))
+                return 'indeterminate';
+            const variable = findVariableInScopes(name);
+            if (!variable || variable.defs.length === 0)
+                return 'indeterminate';
+            calleesUnderEvaluation.add(name);
+            try {
+                const classifications = [];
+                for (const definition of variable.defs) {
+                    const functionLike = functionOfDefinition(definition);
+                    // Imports, parameters and aliases hide the implementation, so the
+                    // name heuristic must keep its reach across module boundaries.
+                    if (!functionLike)
+                        return 'indeterminate';
+                    classifications.push(classifyFunctionReturn(functionLike));
+                }
+                return combineClassifications(classifications);
+            }
+            finally {
+                calleesUnderEvaluation.delete(name);
+            }
+        }
+        /**
+         * Decide whether a call to `calleeName` yields a boolean, giving the callee's
+         * resolvable declaration the final say over its name.
+         */
+        function calleeNameImpliesBoolean(calleeName, prefixes) {
+            if (!isPrefixedByBooleanKeyword(calleeName, prefixes)) {
+                return false;
+            }
+            return calleeReturnEvaluation(calleeName) !== 'nonBoolean';
+        }
         /**
          * Check if a variable is used in a while loop condition and is likely a DOM element or tree node
          * This helps identify variables like 'parent', 'element', 'node', etc. that are used

package/lib/rules/enforce-firestore-facade.js

@@ -6,6 +6,23 @@ const createRule_1 = require("../utils/createRule");
 const FIRESTORE_METHODS = new Set(['get', 'set', 'update', 'delete']);
 const COLLECTION_CONSTRUCTORS = new Set(['Set', 'Map', 'WeakSet', 'WeakMap']);
 const KNOWN_FIRESTORE_ROOTS = new Set(['db', 'firestore']);
+// The modular client SDK. DocSetter/DocSetterTransaction wrap
+// firebase-admin/firestore and cannot be imported from frontend code, so a
+// client-SDK batch or transaction has no facade to route through and must not
+// be reported.
+const CLIENT_SDK_MODULES = new Set([
+    'firebase/firestore',
+    '@firebase/firestore',
+    'firebase/firestore/lite',
+]);
+// firebase-admin/firestore exposes no `writeBatch` export at all (the admin
+// API is `db.batch()`), so this spelling identifies the client SDK with
+// certainty even when the binding's origin cannot be traced.
+const CLIENT_BATCH_FACTORY = 'writeBatch';
+// Shared spelling: the client SDK exports a free `runTransaction(db, cb)`
+// while the admin SDK only exposes the `db.runTransaction(cb)` method, so the
+// callee shape, not the name, decides which SDK a transaction belongs to.
+const TRANSACTION_RUNNER = 'runTransaction';
 const isMemberExpression = (node) => node.type === utils_1.AST_NODE_TYPES.MemberExpression;
 const isCallExpression = (node) => node.type === utils_1.AST_NODE_TYPES.CallExpression;
 const isIdentifier = (node) => node.type === utils_1.AST_NODE_TYPES.Identifier;
@@ -94,6 +111,16 @@ exports.enforceFirestoreFacade = (0, createRule_1.createRule)({
         const firestoreTransactionVariables = new Set();
         const docSetterVariables = new Set();
         const batchManagerVariables = new Set();
+        // local name -> imported name, for bindings that come from the modular
+        // client SDK (covers `import { writeBatch as wb }` aliases).
+        const clientSdkImportedLocals = new Map();
+        // Namespace bindings for the client SDK (`import * as fs`).
+        const clientSdkNamespaceLocals = new Set();
+        // Bindings that demonstrably come from some other module, so a local
+        // helper named `writeBatch` is not mistaken for the SDK export.
+        const nonClientImportedLocals = new Set();
+        // Batches/transactions proven to originate from the client SDK.
+        const clientFirestoreVariables = new Set();
         const sourceCode = context.sourceCode;
         const clearFirestoreTrackingFor = (name) => {
             firestoreDocRefVariables.delete(name);
@@ -102,7 +129,36 @@ exports.enforceFirestoreFacade = (0, createRule_1.createRule)({
             firestoreTransactionVariables.delete(name);
             docSetterVariables.delete(name);
             batchManagerVariables.delete(name);
+            clientFirestoreVariables.delete(name);
         };
+        const isClientSdkExportReference = (node, exportName, allowUntracedSpelling) => {
+            const callee = unwrapTSAsExpression(node);
+            if (isIdentifier(callee)) {
+                if (clientSdkImportedLocals.get(callee.name) === exportName) {
+                    return true;
+                }
+                return (allowUntracedSpelling &&
+                    callee.name === exportName &&
+                    !nonClientImportedLocals.has(callee.name));
+            }
+            if (isMemberExpression(callee) &&
+                isIdentifier(callee.property) &&
+                callee.property.name === exportName) {
+                const base = getLeftmostIdentifier(callee.object);
+                return !!base && clientSdkNamespaceLocals.has(base.name);
+            }
+            return false;
+        };
+        // `writeBatch(firestore)` / `fs.writeBatch(firestore)` — client SDK only.
+        const isClientBatchFactoryCall = (node) => {
+            const candidate = unwrapTSAsExpression(node);
+            return (isCallExpression(candidate) &&
+                isClientSdkExportReference(candidate.callee, CLIENT_BATCH_FACTORY, true));
+        };
+        // `runTransaction(firestore, cb)` — the free-function form only exists in
+        // the client SDK. The name alone is not enough, because a project helper
+        // could share it, so the binding must be traced back to the SDK.
+        const isClientTransactionRunnerCall = (node) => isClientSdkExportReference(node.callee, TRANSACTION_RUNNER, false);
         const recordFirestoreVariable = (varName, expression) => {
             const target = unwrapTSAsExpression(expression);
             if (target.type === utils_1.AST_NODE_TYPES.ConditionalExpression) {
@@ -131,6 +187,10 @@ exports.enforceFirestoreFacade = (0, createRule_1.createRule)({
                 batchManagerVariables.add(varName);
                 return true;
             }
+            if (isClientBatchFactoryCall(target)) {
+                clientFirestoreVariables.add(varName);
+                return true;
+            }
             if (isFirestoreDocumentReference(target)) {
                 firestoreDocRefVariables.add(varName);
                 return true;
@@ -143,8 +203,7 @@ exports.enforceFirestoreFacade = (0, createRule_1.createRule)({
                 isMemberExpression(target.callee) &&
                 isIdentifier(target.callee.property) &&
                 target.callee.property.name === 'batch' &&
-                isIdentifier(target.callee.object) &&
-                target.callee.object.name === 'db') {
+                isFirestoreRoot(target.callee.object, firestoreCollectionVariables, firestoreDocRefVariables)) {
                 firestoreBatchVariables.add(varName);
                 return true;
             }
@@ -214,6 +273,110 @@ exports.enforceFirestoreFacade = (0, createRule_1.createRule)({
             clearFirestoreTrackingFor(varName);
             recordFirestoreVariable(varName, right);
         };
+        const recordImportBinding = (localName, importedName, isClientSource) => {
+            if (!isClientSource) {
+                nonClientImportedLocals.add(localName);
+                return;
+            }
+            if (importedName === null) {
+                clientSdkNamespaceLocals.add(localName);
+                return;
+            }
+            clientSdkImportedLocals.set(localName, importedName);
+        };
+        const recordImportPattern = (pattern, source) => {
+            const isClientSource = CLIENT_SDK_MODULES.has(source);
+            if (pattern.type === utils_1.AST_NODE_TYPES.ObjectPattern) {
+                for (const property of pattern.properties) {
+                    if (property.type !== utils_1.AST_NODE_TYPES.Property)
+                        continue;
+                    if (!isIdentifier(property.key) || !isIdentifier(property.value)) {
+                        continue;
+                    }
+                    recordImportBinding(property.value.name, property.key.name, isClientSource);
+                }
+                return;
+            }
+            if (isIdentifier(pattern)) {
+                recordImportBinding(pattern.name, null, isClientSource);
+            }
+        };
+        const getImportExpressionSource = (node) => {
+            const expression = unwrapTSAsExpression(node);
+            if (expression.type !== utils_1.AST_NODE_TYPES.ImportExpression)
+                return null;
+            const source = expression.source;
+            return source.type === utils_1.AST_NODE_TYPES.Literal &&
+                typeof source.value === 'string'
+                ? source.value
+                : null;
+        };
+        const isPromiseAllCall = (node) => isCallExpression(node) &&
+            isMemberExpression(node.callee) &&
+            isIdentifier(node.callee.object) &&
+            node.callee.object.name === 'Promise' &&
+            isIdentifier(node.callee.property) &&
+            node.callee.property.name === 'all';
+        // Frontend Firebase access is required to be dynamically imported, so
+        // `await import(...)` — including the correlated `Promise.all` array form —
+        // is the ordinary client-SDK call site rather than an edge case.
+        const recordDynamicImportBindings = (node) => {
+            const init = node.init;
+            if (!init || init.type !== utils_1.AST_NODE_TYPES.AwaitExpression)
+                return;
+            const awaited = unwrapTSAsExpression(init.argument);
+            const directSource = getImportExpressionSource(awaited);
+            if (directSource !== null) {
+                recordImportPattern(node.id, directSource);
+                return;
+            }
+            if (!isPromiseAllCall(awaited) ||
+                node.id.type !== utils_1.AST_NODE_TYPES.ArrayPattern) {
+                return;
+            }
+            const promises = awaited.arguments[0];
+            if (!promises || promises.type !== utils_1.AST_NODE_TYPES.ArrayExpression)
+                return;
+            node.id.elements.forEach((element, index) => {
+                const promise = promises.elements[index];
+                if (!element || !promise)
+                    return;
+                const source = getImportExpressionSource(promise);
+                if (source === null)
+                    return;
+                recordImportPattern(element, source);
+            });
+        };
+        const getCallbackFirstParam = (node) => {
+            const callback = node.arguments.find((argument) => argument.type === utils_1.AST_NODE_TYPES.ArrowFunctionExpression ||
+                argument.type === utils_1.AST_NODE_TYPES.FunctionExpression);
+            const param = callback?.params[0];
+            return param && isIdentifier(param) ? param : null;
+        };
+        // Binds the transaction callback parameter to the SDK that produced it, so
+        // classification rests on origin rather than on the parameter being
+        // spelled `transaction`.
+        const recordTransactionCallback = (node) => {
+            if (isClientTransactionRunnerCall(node)) {
+                const param = getCallbackFirstParam(node);
+                if (param) {
+                    clearFirestoreTrackingFor(param.name);
+                    clientFirestoreVariables.add(param.name);
+                }
+                return;
+            }
+            const callee = node.callee;
+            if (!isMemberExpression(callee) ||
+                !isIdentifier(callee.property) ||
+                callee.property.name !== TRANSACTION_RUNNER ||
+                !isFirestoreRoot(callee.object, firestoreCollectionVariables, firestoreDocRefVariables)) {
+                return;
+            }
+            const param = getCallbackFirstParam(node);
+            if (param && !clientFirestoreVariables.has(param.name)) {
+                firestoreTransactionVariables.add(param.name);
+            }
+        };
         const isRealtimeDbRefAssignment = (node) => {
             if (node.type !== utils_1.AST_NODE_TYPES.VariableDeclarator)
                 return false;
@@ -282,7 +445,8 @@ exports.enforceFirestoreFacade = (0, createRule_1.createRule)({
             const object = node.callee.object;
             if (isIdentifier(object)) {
                 const name = object.name;
-                if (docSetterVariables.has(name) ||
+                if (clientFirestoreVariables.has(name) ||
+                    docSetterVariables.has(name) ||
                     batchManagerVariables.has(name) ||
                     realtimeDbRefVariables.has(name) ||
                     realtimeDbChildVariables.has(name) ||
@@ -304,7 +468,7 @@ exports.enforceFirestoreFacade = (0, createRule_1.createRule)({
                 }
                 return false;
             }
-            if (isRealtimeDbReference(object)) {
+            if (isRealtimeDbReference(object) || isClientBatchFactoryCall(object)) {
                 return false;
             }
             if (isFirestoreDocumentReference(object)) {
@@ -374,7 +538,19 @@ exports.enforceFirestoreFacade = (0, createRule_1.createRule)({
             });
         };
         return {
+            ImportDeclaration(node) {
+                const source = node.source.value;
+                const isClientSource = typeof source === 'string' && CLIENT_SDK_MODULES.has(source);
+                for (const specifier of node.specifiers) {
+                    if (specifier.type === utils_1.AST_NODE_TYPES.ImportSpecifier) {
+                        recordImportBinding(specifier.local.name, specifier.imported.name, isClientSource);
+                        continue;
+                    }
+                    recordImportBinding(specifier.local.name, null, isClientSource);
+                }
+            },
             VariableDeclarator(node) {
+                recordDynamicImportBindings(node);
                 isRealtimeDbRefAssignment(node);
                 isCollectionObjectAssignment(node);
                 isFirestoreAssignment(node);
@@ -383,6 +559,7 @@ exports.enforceFirestoreFacade = (0, createRule_1.createRule)({
                 handleAssignmentExpression(node);
             },
             CallExpression(node) {
+                recordTransactionCallback(node);
                 if (!isFirestoreMethodCall(node))
                     return;
                 const callee = node.callee;

package/lib/rules/no-render-function-components.d.ts

@@ -0,0 +1,8 @@
+import { TSESLint } from '@typescript-eslint/utils';
+type RuleOptions = {
+    renderPropNames?: string[];
+    allowNames?: string[];
+};
+type Options = [RuleOptions?];
+export declare const noRenderFunctionComponents: TSESLint.RuleModule<"renderFunctionComponent", Options, TSESLint.RuleListener>;
+export {};