@blumintinc/eslint-plugin-blumint 1.19.3 → 1.19.5

package/lib/index.js

@@ -222,7 +222,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.19.3',
+        version: '1.19.5',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/no-redundant-this-params.js

@@ -102,7 +102,14 @@ exports.noRedundantThisParams = (0, createRule_1.createRule)({
             for (const member of node.body.body) {
                 if (member.type === utils_1.AST_NODE_TYPES.MethodDefinition ||
                     member.type === utils_1.AST_NODE_TYPES.TSAbstractMethodDefinition) {
-                    if (member.kind === 'constructor') {
+                    // Only genuine methods (`kind: 'method'`) are invoked directly as
+                    // `this.x(args)`. A `get`/`set` accessor is also a MethodDefinition,
+                    // but `this.accessor(args)` evaluates the accessor with zero arguments
+                    // and then calls its RETURN VALUE — so when that value is an
+                    // externally-supplied function it legitimately needs instance state
+                    // threaded in, and flagging it is a false positive (issue #1308). The
+                    // constructor is likewise never called as `this.constructor(...)`.
+                    if (member.kind !== 'method') {
                         continue;
                     }
                     const methodName = getNameFromPropertyName(member.key);

package/lib/rules/require-props-composition.js

@@ -46,6 +46,18 @@ const DEFAULT_EXCLUDED_COMPONENTS = new Set([
     'React.StrictMode',
 ]);
 const DEFAULT_TARGET_PATHS = ['src/components/**/*.tsx'];
+/**
+ * Icon components (e.g. CheckIcon, RefreshIcon from @mui/icons-material) are
+ * decorative leaf elements — the same category as the layout/decorative
+ * primitives in DEFAULT_EXCLUDED_COMPONENTS. They expose no composable
+ * customization surface a parent should re-expose, so rendering one is never a
+ * composition dependency. Matched by the conventional `*Icon` suffix, which
+ * excludes CheckIcon/LinkIcon/RefreshIcon without touching interactive
+ * components like IconButton (issue #1307).
+ */
+function isDecorativeIcon(name) {
+    return /Icon$/.test(name);
+}
 /**
  * Derives the expected Props type name for a JSX element name.
  * e.g. "LoadingButton" → "LoadingButtonProps"
@@ -432,7 +444,9 @@ exports.requirePropsComposition = (0, createRule_1.createRule)({
             const body = funcNode.body ?? funcNode;
             const allJsxNames = collectJsxElementNames(body);
             // Filter to non-excluded custom components
-            const depComponents = Array.from(allJsxNames).filter((name) => !excludeComponents.has(name) && name !== componentName);
+            const depComponents = Array.from(allJsxNames).filter((name) => !excludeComponents.has(name) &&
+                !isDecorativeIcon(name) &&
+                name !== componentName);
             if (depComponents.length < minDependencyCount) {
                 return;
             }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.19.3",
+  "version": "1.19.5",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,32 @@
 [
+  {
+    "version": "1.19.5",
+    "date": "2026-07-15T15:24:16.132Z",
+    "rules": [
+      {
+        "name": "no-redundant-this-params",
+        "changeType": "fix",
+        "issues": [
+          1308
+        ],
+        "summary": "skip get/set accessors when resolving callees (closes #1308)"
+      }
+    ]
+  },
+  {
+    "version": "1.19.4",
+    "date": "2026-07-14T18:24:36.895Z",
+    "rules": [
+      {
+        "name": "require-props-composition",
+        "changeType": "fix",
+        "issues": [
+          1307
+        ],
+        "summary": "exclude decorative *Icon leaf components (closes #1307)"
+      }
+    ]
+  },
   {
     "version": "1.19.3",
     "date": "2026-07-14T11:28:07.708Z",